From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D483AC7EE2D for ; Fri, 3 Mar 2023 18:37:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F06F6B0071; Fri, 3 Mar 2023 13:37:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A0376B0072; Fri, 3 Mar 2023 13:37:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B4F16B0073; Fri, 3 Mar 2023 13:37:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2C6F36B0071 for ; Fri, 3 Mar 2023 13:37:29 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E7BC61C60BF for ; Fri, 3 Mar 2023 18:37:28 +0000 (UTC) X-FDA: 80528444976.19.6DFADB6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 4DDD01C000D for ; Fri, 3 Mar 2023 18:37:26 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iDsxeXbE; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677868646; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DnnDDOtg9arnIH/GYWZvqJdEorDl3//e9CYhvYSBbjE=; b=18RjLXQeJ85ZW4F5Ht0ZJAEC3NQ52QNaeDc4OKTqGwyCwBXcqHipPlGwISF/7D18Ofgoio MgYZMeWOg6E9Lw1dqnvldyDAn7G0Ypk/Hs6mkEgv59PXAsDw5vEJq2KTqwqRrRUFiB6BQp 0/IpOAfvgLP2P3T2U6XxSJNWu6NXs+8= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=iDsxeXbE; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677868646; a=rsa-sha256; cv=none; b=Br3vxm3q4pJVYpGBYQn72UgbiQ+LENjSWA/fUZJWwPPJvtI+TdgXJKCmsmhEFkXszFxyrr X2o9CRMP7jksugrLZRD31A82HCUst7WiqLuga8mNm3jmakEKqDyCVBpus0pAIc3W3F0SBH JMofSydczny+6QlA8WsBdnxMMU7mA6o= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2906F6186E; Fri, 3 Mar 2023 18:37:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1375EC433EF; Fri, 3 Mar 2023 18:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677868644; bh=5VS5XD3aopCKWM9JTeZDCTyMBWVPcB+DkyyfJ8MlSXI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iDsxeXbEpmzOFkAE0D7aQfG+IpmIJt9cqHZzJYXvK54CZ80JIipc9IeCzA618Cxeo 1Vl0LGnSiOFgTK1FlzNZKSXTsbztN3MBX0NYE+OQmC4ZeiLI7EQGfK/8Ek8hjTMAW/ KjqE64xMvoE8pv91cvzPPURq0d7TEQG1vRXoUn2je/m5scx+X+JpOf7HQoKp4IKJSg rbIMtjW1XAtGQwgGqneY0zsjBdEaaec8m0fxM3Bb5z4ezKOPSeqKuWzSj6ZzY+tjiH aU3Svqc1nFwitx7jHTGaC3bdkM4aXzhanrP1OnjCh5u/BG6dg1FejcPBRLwiNRVwXI SwQQvGAIYh5Rg== From: SeongJae Park To: SeongJae Park Cc: Kefeng Wang , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH v2 3/3] mm/damon/paddr: minor refactor of damon_pa_mark_accessed_or_deactivate() Date: Fri, 3 Mar 2023 18:37:22 +0000 Message-Id: <20230303183722.113464-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230303182633.113353-1-sj@kernel.org> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4DDD01C000D X-Stat-Signature: nhm7uq4xck46dbip7nx5j8a579inzwas X-Rspam-User: X-HE-Tag: 1677868646-383225 X-HE-Meta: U2FsdGVkX1+/J2m98rvWpuynF8DFEUZDP8QMgJvJWFTxOliihNsVL2puUpTg20OiZf2kg99Nbyiaqg3+g7h0VrWWgMxQ3+O6UPiBba8MTGV/Kjwc1FbykL6u/ZbbJ72GOWEkQwBd6cJrnZW34nyOEWY1cMmCMbucybpg8ztIEBK30EXWr0/gLLbjAUjFo37Yjoa+gNSY+gB2WbBcLxGIUtyfYVaEAHl937dMsXfXhVCZdYjs7Fn27vyBT5t9tgNspVkTIEV94rDySn5pYkbhuVmg3NmDRm7MiKsQhxCwaUAdrEJ9q7/K+jtAye+4yKmKWglcgzrSJeyXAjX7qNOdUOMXyRG0H9K8MmnkXTGclrQPsaGXAQvqo5+R1o7b4VpVRQkClFGt+8O2qsQij+7Ue+DPXEEYlCQprJZ9lcPRDSSbPrJwqaua67DtxNAnSSufKDh1VrAg4kE9WiuuPsxouZm48mTAvcLOO3GawB0c8a4fwq+61pT14TLJwmV6ewx3D8ahREoPql8KRsbc56gqLTUs+0uTbLRLAxvRf/7E3UevoMc4KwxbhN/sVKBZeFbLIaOX/8NUUJNXxN83cPfSTwfH0ilb1fxmEyLBCCzzorsWgQQuQ8w7HHLXaDDv61rYWfwoJKSZSL6ulopvjQh1YqZKPBbxijvp4BrccSv04cwLDrYu4d2+lCBcNwAGjUgYjauiulNRMBRZJaAPdj+r0rcXc3ALwGEVSlIbRuFbMDMGBrivZRxj8lpdn9ZEU+U/pcEsvr82gNk7iCKeWZQ0aordaX83Vfly/oOao3li5tsPT6n2XgCwrOIo4Ja6DGbIDXj3zpHZU12D2WRbsnHkD8C2KWs+i0Oj7xOrMky8TcOpiWSVeyIqjw/jnfCt6bP5oMvI1AcNs9mTBcZ34mxAEFl0sqHZftfMd2H6EoXhI0RbRhNLT0zv1bliJRs9+fhKJVM4QxRNeEuCjOe7iE7 BVorARPO 3sQ2gqZlvL3ALiQh3idfQYc3dsnPo62LsqT/WQJaBFWY6fv1/d/0BeMxn6NGgVSF0KHxZXkB326brTie916m/dE+rBErWOxX5a2ShCqmm9Gt6mzdfqSlMOtKsYdYFzRWYhwtz4DN5KHHQ+ru8qa4knL2dVXEzJaMgdQcOolBdVky7QXLV8wN51PpPujcUhhxc9STjI8ijAIBu4fuF76VPhQvvkNgxVEAUF2d/e5mqAMA3UJ5xm91UaTsgTsMcfviEY94kei7VCLZVU50dDMJmitETPMfvs1H5JF0XApjHvNsGD+Rv6QrE7Cm/GHqPiHZ6ZhL9rB5c/MyeYzUv+NbFKev5FYYtgCJrAX0g58CjryuMLi6baWgSDbFwPritQCIasAB+bwjZ3/QQzmwkBmoT2HsTqNomnZLWigCle8TpcrZsBIc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Mar 2023 18:26:33 +0000 SeongJae Park wrote: > On Fri, 3 Mar 2023 16:43:43 +0800 Kefeng Wang wrote: > > > Omit one line by unified folio_put(), and make code more clear. > > > > Signed-off-by: Kefeng Wang > > --- > > mm/damon/paddr.c | 9 ++++----- > > 1 file changed, 4 insertions(+), 5 deletions(-) > > > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > > index 2ef9db0189ca..6930ebf3667c 100644 > > --- a/mm/damon/paddr.c > > +++ b/mm/damon/paddr.c > > @@ -266,17 +266,16 @@ static inline unsigned long damon_pa_mark_accessed_or_deactivate( > > if (!folio) > > continue; > > > > - if (damos_pa_filter_out(s, folio)) { > > - folio_put(folio); > > - continue; > > - } > > + if (damos_pa_filter_out(s, folio)) > > + goto put_folio; > > > > if (mark_accessed) > > folio_mark_accessed(folio); > > else > > folio_deactivate(folio); > > - folio_put(folio); > > applied += folio_nr_pages(folio); > > +put_folio: > > + folio_put(folio); > > I think this change is ok, but shouldn't the 'folio_put()' have called before s/before/after/ > 'folio_nr_pages()' anyway? If so, could we make the change as a separate fix > first, and then make this change, so that it can be easily applied to relevant > stable kernels? > > > Thanks, > SJ > > > } > > return applied * PAGE_SIZE; > > } > > -- > > 2.35.3 > > > >