From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Bert Karwatzki <spasswolf@web.de>,
Andrew Morton <akpm@linux-foundation.org>,
bugzilla-daemon@kernel.org, Nadav Amit <nadav.amit@gmail.com>,
linux-mm@kvack.org
Subject: Re: [Bug 217061] commit 2286a6914c776ec34cd97e4573b1466d055cb9de breaks do_mprotect_pkey
Date: Fri, 3 Mar 2023 13:29:58 -0500 [thread overview]
Message-ID: <20230303182958.h7ttvfnkc4xexy4o@revolver> (raw)
In-Reply-To: <20230223220228.bf2ob472wxwtqk75@revolver>
...
>
> Just for clarity, tmp is used to ensure there isn't a hole in the range
> we are iterating over. I don't particularly like how this was done, but
> I tried (unsuccessfully) not to break it.
>
> It looks like I've missed the case where a merge succeeds and so tmp is
> now out of sync with the iterator.
>
> I would change this tmp = prev->vm_end idea slightly and use the vma
> iterator end location:
>
> tmp = vma_iter_end(&vmi);
>
> I'll send out a patch once I test this.
The patch has been sent out and I've submitted my testing to LTP:
https://github.com/linux-test-project/ltp/commit/3cbaaddf6f785d91aeb370beb75d0623f8c48624
The testcase is mprotect05
Thanks,
Liam
prev parent reply other threads:[~2023-03-03 18:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-217061-27@https.bugzilla.kernel.org/>
[not found] ` <bug-217061-27-Nl8xiZT9yu@https.bugzilla.kernel.org/>
2023-02-23 20:04 ` Andrew Morton
2023-02-23 20:36 ` Bert Karwatzki
2023-02-23 22:02 ` Liam R. Howlett
2023-03-03 18:29 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303182958.h7ttvfnkc4xexy4o@revolver \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=bugzilla-daemon@kernel.org \
--cc=linux-mm@kvack.org \
--cc=nadav.amit@gmail.com \
--cc=spasswolf@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox