From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC1E1C7EE2D for ; Fri, 3 Mar 2023 18:26:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E77C6B0071; Fri, 3 Mar 2023 13:26:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 196A86B0072; Fri, 3 Mar 2023 13:26:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 05F7E6B0073; Fri, 3 Mar 2023 13:26:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E9B316B0071 for ; Fri, 3 Mar 2023 13:26:40 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BBF9441274 for ; Fri, 3 Mar 2023 18:26:40 +0000 (UTC) X-FDA: 80528417760.17.90C9A32 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf30.hostedemail.com (Postfix) with ESMTP id E8B888000D for ; Fri, 3 Mar 2023 18:26:38 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BuvFWYIu; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677867999; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BS/bfG5ASiUCEspQ4y/0GdjuWtBIgFzCKp4wP2RMXbw=; b=L5d/2xU6P5o0XAwFhfjVfYWftyJbA6ZRKalh+9scMAVn50gEMYmpdTDD5qN8rt4wqFzKdF 6INODviQbF7c0QDNkaUpKTB4DYHylhDzxHUxJ7a+92dVJYG9CjcaL1p87uixj+lCVuyc7M jVCDNrDZwdfXp0wEhV0WsQZqGLGPWMU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BuvFWYIu; spf=pass (imf30.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677867999; a=rsa-sha256; cv=none; b=GsEn56X+ED+fSA2A3dTIS2+TAL5IsL8vSHpVJRmZjCF0Iz8q2LcJHElM6VU+OtVhsNgRGp TVT24Dk2HmY7lK8AYrDCpgfrxxmnpGDxu93/3jqmHR6SjRpOC4dXYf4HWyNseZ5fMdEEWT g/Ieuq+s5S0BrtbQNU77Pvgcj2kvHao= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 37573B819B4; Fri, 3 Mar 2023 18:26:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4991CC433D2; Fri, 3 Mar 2023 18:26:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677867995; bh=DSkurpKxMx8y54UF4lVb+7A5OkUioceZ/RbRt1Z30bI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BuvFWYIu/HVI0EgnY69jn3dhqrWhQZcsbdv59Lq8Ni3QTqOYiVwaOcqyjKaq3Zyu9 dFFJYaLBgJs6zF1/r5EWCPBcioqqGG70dP432wtlzyLgvaJmWsVXkDxBQceqi/MDvd 7B6pdzmLaP8E1XoL2be19YkR+K5mRacFGADciNjpFdbAIPY950D8uIYvAz7C4HyTET 9TxwKEJr0mf2J3upDZ4BN+MeopBYcTCzUN1MYbx++E8i9bxrrJq0+ULvre0HBpQz3Y z1mBI7VF5ssOoENzPzeVddx+Qvn6xHMbOJ/vRCInZboL78YfU/ojigMWYdL/KEcd0u miGlX47ifhiTQ== From: SeongJae Park To: Kefeng Wang Cc: SeongJae Park , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH v2 3/3] mm/damon/paddr: minor refactor of damon_pa_mark_accessed_or_deactivate() Date: Fri, 3 Mar 2023 18:26:33 +0000 Message-Id: <20230303182633.113353-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230303084343.171958-4-wangkefeng.wang@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: p4dtn6kp9igwupewf5uggok6uh8monh4 X-Rspam-User: X-Rspamd-Queue-Id: E8B888000D X-Rspamd-Server: rspam06 X-HE-Tag: 1677867998-894398 X-HE-Meta: U2FsdGVkX1/WA+1mcLi3IrciFe5n50fou4k/j6YHQlpRnmBK+riM7FDUEPEcAkT37rxropHOqan+hQTqVJYxLYSw0uDJSJ6XckCygiw0Nk0kfThDoFEs9LGA9nrlYssnByR5mvoOI4ZbLZ71gl/dz68mkGk5S0EphxGYyO8kuJBtUnSZ8FdJ/MiBG5DfEAZUjeEamDqgcn2fC8IfUIzOQYjKYzfo66unzEMPtKIXAdxEmsM4PpiESWUQAksI06S9jWFAjR7fnoQq2w2VoY0NSaQOqAIXMXQto8DNojkGsV/wuC6bCl6GIDEOOpjwiE5e4O0acwP3W1vQ0CtXL1ml4HXng1tUnwylsy6wiw7i6roLuHiI4Evut4KeA+B3A+XgrATl9R9VjGWT+ljtmWqxey3x/LhQNZtekoRc63R5YQSPqt45OUFAmv6Wu7UImxopjFQugG2vTeF+l9Fwp/1D68kFZtfvWQcxk4YMP7ojRsq+dOjtO2jFI+sR5jg2tQf5mNtFtJbSlHLbTXjiilHXSKuwEbi8guq4tnVavLL40W6WchcMoZjpBoM84FQoVgXDh2sHHkUH1iYjeI6k7UbP0Yrq4Fq7Tkci1NDAicHQaaWK8asMoSxDGQ6J5o4DsU9fTelng/f3uAJ5nz5qPoMECy/Y3QQ2KSTtrSQy31v1U/KpgIq+6NQt4XYTGVOHYGjzChkUSBTOxRk16fwXaRvViS16wsu4dyLBN2G4Elm35H6dQMep4bEKEM/6EZYT6W5To5RJHitKYAq6TLfTUsj6Pd1ARZab+XFGfOmG0u8VIQDcJCv4z2HU2aE80dtPpSRL0hsa3wC1KUX7jdol9WSbCmoYHNprKyoVa/2LRo6JYhWxo9lPaS9X5VMH7e/cFo3UhbSTci0021fT6M2cVBJ4dd+e4CIUmrDwEEO1Bp9025ZLgGkSixJLAY5XAogrq6TkVQWL3p2XUwQUw7v0O1+ 1eYRj/5N 4SfceJSRf+/sxMfPA9zlIjttQSdUwTXVs9cg8ij79+8e8XUzWLUyY1274O9egaw5fNJJIJjGt4L7jROlbbJHJKGxcIEJVHcfnIBENUrBkzSKdJ1GL2LZY3IwbR7zB66eIoBbwsun4Io+cSEEglxXW9XYG6am6O4vFa/lhU1+L2JBki4zeROZ+ty4yGII04sCJVsgNixFGwHlKhI0NydWzoShqLH4NW/UPOFGy1/S7yaA23dVFk14NkQ+Tmj0yAA/c33faM3ZdUs/nlylqlRMfM4L2VBz0B7ROU62pgbI/5v760E9CBbTIX3ne7tnbQwYgyxFS/Z0cdgWiP20V538aWLo9ctMLjtHJIJ9ANqKKlPTLE2Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Mar 2023 16:43:43 +0800 Kefeng Wang wrote: > Omit one line by unified folio_put(), and make code more clear. > > Signed-off-by: Kefeng Wang > --- > mm/damon/paddr.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index 2ef9db0189ca..6930ebf3667c 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -266,17 +266,16 @@ static inline unsigned long damon_pa_mark_accessed_or_deactivate( > if (!folio) > continue; > > - if (damos_pa_filter_out(s, folio)) { > - folio_put(folio); > - continue; > - } > + if (damos_pa_filter_out(s, folio)) > + goto put_folio; > > if (mark_accessed) > folio_mark_accessed(folio); > else > folio_deactivate(folio); > - folio_put(folio); > applied += folio_nr_pages(folio); > +put_folio: > + folio_put(folio); I think this change is ok, but shouldn't the 'folio_put()' have called before 'folio_nr_pages()' anyway? If so, could we make the change as a separate fix first, and then make this change, so that it can be easily applied to relevant stable kernels? Thanks, SJ > } > return applied * PAGE_SIZE; > } > -- > 2.35.3 > >