From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FB0C7EE2D for ; Fri, 3 Mar 2023 15:45:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62F216B0074; Fri, 3 Mar 2023 10:45:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DF0D6B0075; Fri, 3 Mar 2023 10:45:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 47F046B0078; Fri, 3 Mar 2023 10:45:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 346436B0074 for ; Fri, 3 Mar 2023 10:45:58 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 012EA1401EA for ; Fri, 3 Mar 2023 15:45:57 +0000 (UTC) X-FDA: 80528012796.25.F9FD78E Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf04.hostedemail.com (Postfix) with ESMTP id A489F40023 for ; Fri, 3 Mar 2023 15:45:54 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZwNAWntD; spf=pass (imf04.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677858354; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XUrdf6MZd4Bc/cJvmEdQo3H49BiVbJ8IWrHGSAtocn8=; b=2qNLmqcqMngN+CpACNacG23xjG955qoPSRx4hw/VUQ5BYsOds9U2UmWzDNmrsQWxsm1dy4 6/pcXD/Zab66COtKOHrK0hmqEdOadbefZCYXmK1RRxvtpPLQB1WHw25vVEVbbrG9thGiEC s+Fxon2/nHGncbZ0ZoA1cAdLcG9GXVE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ZwNAWntD; spf=pass (imf04.hostedemail.com: domain of zokeefe@google.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=zokeefe@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677858354; a=rsa-sha256; cv=none; b=6Wy0r1tUoBcsw8v1SHwM41wOprSj63V0QzOmHz8VboujX/2RcmYox0u9KGuO46M/GxQWS5 dzHcr5WDPvSR+leqj/OLGQ87TD65cvfHV/Jsa8WFE1aAGvEHspR6gaiZSTOH8aM+VZ7gi2 LadylD22HpXxJs3tX2yF8MR/l+2dbtU= Received: by mail-pj1-f48.google.com with SMTP id bo22so2922572pjb.4 for ; Fri, 03 Mar 2023 07:45:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1677858353; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=XUrdf6MZd4Bc/cJvmEdQo3H49BiVbJ8IWrHGSAtocn8=; b=ZwNAWntDzIXhLpXm+UxGbCquSggabPxjiWTdH07AOEr2F/iKVKFTnQETKg0BevqA7k bThNxmZSXw5veuOs9BBu0bNR+fD13muhVrsY9qEcj+vvkpDEugyTR0eHDsEyNXXc0/iM i/NyOkzs+qrjRIZAf5Lj34GQjUHJpkQhW+Hzb4jMVwD4mbnjpUX7ge4gbuczgAPKYQLU js8zL4+S8HFrEp8PxUt7DHo5q16dMqY4n9Bm04hcpibrN2uee+D1sv9U41OFUItVtcyV OrAQYZCc4Y+JL1iG2FFgP9z5AsIexOSQVzorweoXbYM6IgV9RQXdW1XjnVp0S4sLlSpQ CzBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677858353; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XUrdf6MZd4Bc/cJvmEdQo3H49BiVbJ8IWrHGSAtocn8=; b=7fDmj0Oy+Ba0uCjcGIEIJ0QGxYIBHfrQpMFHweAVwmY3jyyn3EmckfTxiON2UNPAb6 yFakK0wBP2hT5+skBv25OBx4Pt0DxxuRjvQbf6P3pmSZBaFrctBie+NpOh0tMQlMQM6F +lqSr2Bye766/XWEIFEyDaWYWItO4s83ZkVJ/9pl4dvjZ7KOZjjiCZo5d6RMWZZnOLTM H9uIWVtl55wN4X8hYlpzrMjJzk1jtDGyShASQu+bqj/0fIP8UuYyPBqZEwDPS0DTiAP5 dIui1CzDWhqQUHg3VGj+5KFfb5YqXZPqmnuOMf//z/m6tat3CJjz8qg1dVXYOw4xFMv0 g33w== X-Gm-Message-State: AO0yUKUxqq6HFeSl/nvk2jVNba3vJ1khMhqha4AnqEXEEJPukAMQ8/+c LZf0HTEq+Joh9pjNexZ5r3S45Q== X-Google-Smtp-Source: AK7set+lCN5F5Cbsep/m67mKpIsN4i0zksZlRs9Hv1GK95z3lis7CUT7+0vY4dJrr8BGtovepGn68A== X-Received: by 2002:a17:903:42cc:b0:199:3909:eaee with SMTP id jy12-20020a17090342cc00b001993909eaeemr279241plb.6.1677858353255; Fri, 03 Mar 2023 07:45:53 -0800 (PST) Received: from google.com (33.5.83.34.bc.googleusercontent.com. [34.83.5.33]) by smtp.gmail.com with ESMTPSA id b21-20020a170902d31500b0019a7d6a9a76sm1689767plc.111.2023.03.03.07.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Mar 2023 07:45:52 -0800 (PST) Date: Fri, 3 Mar 2023 07:45:49 -0800 From: Zach O'Keefe To: Peter Xu Cc: David Stevens , linux-mm@kvack.org, Matthew Wilcox , Andrew Morton , "Kirill A . Shutemov" , Yang Shi , David Hildenbrand , Hugh Dickins , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/3] mm/khugepaged: fix khugepaged+shmem races Message-ID: <20230303154549.xli4knfliv4c7gc4@google.com> References: <20230217085439.2826375-1-stevensd@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A489F40023 X-Rspam-User: X-Stat-Signature: mdiiawirnfa3stormx6zppynoq1hrrkz X-HE-Tag: 1677858354-424700 X-HE-Meta: U2FsdGVkX18Sb8C+0Y5FpZTh1Q3UJAICJZtPk1jbgbFKyy17uuLE7BO8QxM0anIARbA/gyccJcs7PfpJTmvxbOqSQzyrmkAtT6Zd16oSLzd6zA5CaXGUQPDq6tS7z9jf/63mNgJvfAOBX54/6gZfxaV757Xo9o7hLGuSautCXm4eP2pcNNFn+IFA7JD6pD7oi2Au5GcNHDmvBy2bmLL0yVanZtohLM9ACLYmnTOCnp3d0QBByNBeY7SIU/pbQa8YGz4Oce+Zm0yNPI3fsFYg2lfbkz5xSIVJNTMSAVhb7A5M37dLMbJ3vAniwUyl0S49BIFafJTES3RcMwkAH3cMTBgXGLJo8MuixsKKI2/O9XIjD9+x5H/moudOC1Y1Ilw2fyvAs50Kt4nOFxGgff3KGimw/pWPAAM2ITLY+yFrNyc9UKarNsqsWnMPPopk26fXl4BipHjRQyvknWwXIw5UlmQQsE7JfXiNmRkEjkcBVKExLOLM31flxYyvDffwKhOoJpl/dI7rnqUh9vlE2lwLuT2ziBoh0/H4BQgYpZmBN/5eBPWGYWfikyeC5rrHnnz/djSmTOkSiSwzHKsiuZgHw/f7xcFBrds2oJXBdDS+tKv0tpxiorHJayFdf/fOsOHw5RJbOJaQrCxHcorq8/RW13U0oO++ets8sr2tFIV4/2SL710963NEQFe2khU8tE/AGIRFgzWUQHwWZNhGf7eFIUIJESeDcRPKR3n/tRmIYaPGln6AS9aBKGpgf2qdL6QfG7EtQjvzzL69l9yh0a7oAfhR4Lqot2TiO6R4lghBizU66rcD3CeFisi5UcrWLnNh+mbx3KiuXBYY3h9wKRUpDtADJpXxV8zLVh2vAexc9ttuVJ2j5X7c1XJB6xS1nRP60Uc2cBz8B5spx4YfA4Ib7BmgQGtTMxXHDqnI7Mb6nHaY3gdtnfcnI/xcOJeFU/nWl1PKjz9fUBqhmwcqiyF jLFnRKgb //EckLsR1ejDcpwXSTLCjmvNnDWqI41FmImKzG+HY/TNa5y2UND6PgSrf2Zx0elnl9doEqFT3jXv0kH0LP3MUfcn2T+IgMiLpgPed5RXddc9HIOVCQPH7a+wBbg9bAyTNI+aIwQPfXZb3wwMO2MeeCofJjmt+QaOYC/0xAR1BaxaYg6fj71vRJ+Htc+Lm4G9pf/wOmF/N6fPcqhYHaSi7wogfMZqRqMeWOVME5KZfzuE9bQqH0NOpGiEmkPpCExdKfrkvNn+yH0C0r4wxvAFfHk/bz9NA+tcb9JIn2feHm84QNTh88UU3C/8lcjoFfwUUiAm/Z4erkTpb3OMEIOeV+DgR0/yUL8Bn6c3FhGOMTi2bkFHNs0BOSPgTtqzl/fBf2ZUvz8KXwyJ6y0j4/0FIRMPcfzPbxfaUMIStM13UcAbIJIB/aiy6t4I7hp/rjLhe7h4KzSxouuEt+WKkZO47S5ZffQcWXhaqjIjQncG6yWXAxigG/fwdJA0h9mNt/x5oAkwrFaHlXcW/VK0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mar 03 10:35, Peter Xu wrote: > On Fri, Feb 17, 2023 at 05:54:36PM +0900, David Stevens wrote: > > From: David Stevens > > > > Fix two races in khugepaged+shmem that cause issues with userfaultfd and > > lseek, respectively. > > > > v3 -> v4: > > - Base changes on mm-everything (fba720cb4dc0) > > - Add patch to refactor error handling control flow in collapse_file > > - Rebase userfaultfd patch with no significant logic changes > > - Different approach for fixing lseek race > > I just noticed this one hasn't landed unstable, so I guess I just posted a > trivial cleanup that can conflict with this so it won't apply cleanly.. > > https://lore.kernel.org/r/20230303151218.311015-1-peterx@redhat.com > > The resolution will be fairly straightforward though, and I'm happy to > rebase that one to this since this targets a real bug so should have higher > priority. > > I guess it's possible Andrew thought the series has unsettled comment so > Andrew could just have ignored that whole set in the mark ups. A repost > could possibly clarify that. > > Again, it'll always great to get another eye on this slightly involved > series. Matthew / Yang were already on the list, also copying Zach for his > recent works on khugepaged just in case he spots anything wrong. Thanks Peter. My email filters need some tinkering, since I missed this until yesterday when I came across it by chance. Thanks for Cc'ing me. I'm taking a look now, and likewise will if reposted. Best, Zach > > Thanks, > > -- > Peter Xu >