From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50729C61DA4 for ; Fri, 3 Mar 2023 23:28:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 656F06B0072; Fri, 3 Mar 2023 18:28:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6065A6B0073; Fri, 3 Mar 2023 18:28:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F5146B0074; Fri, 3 Mar 2023 18:28:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3BF976B0072 for ; Fri, 3 Mar 2023 18:28:39 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 09321A1217 for ; Fri, 3 Mar 2023 23:28:39 +0000 (UTC) X-FDA: 80529178758.03.A6A737B Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id 3CA5020016 for ; Fri, 3 Mar 2023 23:28:36 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xz+hEPzI; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677886117; a=rsa-sha256; cv=none; b=H0FN0Ch4BTwHYUqhj50pzswze+swCg5QxXwX8FKNm2zsW+kq7imempzCRmD/gbm0tsfPWX ygwsyfS+vCMN+pXITUbfGei40dwFgTy6hkyby6BUzEAHxZDerbTmvoW7SjIG1GqgU4TTPN 9rmNSQgsucFpKhUvhQoDjQH7a/Hnw+U= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=xz+hEPzI; spf=pass (imf03.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677886117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UY+Cq1nDwGIIWNOQQ05RVKXEIEk9Acg99XSQzlfgnDc=; b=ax1eA9HBs/QDjSCn6Jo6HahHTYokurBEivHvdFlikzujkRvUAOnKBy5mUPiY1+TqtyAihZ 35L+JZP9cpOiVX5SDBOQ4TzXOiVSRPzEhC5eVS9ZtuIM3wYK6ad5TcN/KVbfmKkZUbRMnV OJIxSAnEyqPW32cJIeVXwltAXuqAqJE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 54851B819F0; Fri, 3 Mar 2023 23:28:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1082C433D2; Fri, 3 Mar 2023 23:28:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1677886114; bh=ZTKHiA7szHOvOhjA3ud+/tRtXeXi1U4d2tB3FjcWrLE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=xz+hEPzI6vAGTikNV2NSPsJ4d5THUdQvR2muRqIwfTD9Uwrj+tgBf//RwUieK4SAm /kQMDv8eB1/RrOq8dSLpN9vpHETS1lzDu0vt8jIXQBXtjdFO05sDg8TsShTIwOJI+w lf9n2gLk3sMoL1bZcm5Wf0xAqfSYq+H8WG/htIH0= Date: Fri, 3 Mar 2023 15:28:33 -0800 From: Andrew Morton To: Yosry Ahmed Cc: Sergey Senozhatsky , Minchan Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv3 2/4] zsmalloc: fine-grained inuse ratio based fullness grouping Message-Id: <20230303152833.24d7a42102bd712e09f95cd5@linux-foundation.org> In-Reply-To: References: <20230303073130.1950714-1-senozhatsky@chromium.org> <20230303073130.1950714-3-senozhatsky@chromium.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 3CA5020016 X-Rspamd-Server: rspam01 X-Stat-Signature: ekmo7zpw7ezbsjetdfdhm3czgpx6jfz1 X-HE-Tag: 1677886116-398042 X-HE-Meta: U2FsdGVkX1/CpkfCfgt5aAxYDOD1pjThg9j/35g130frOwFCBrsNufEEJGJtcF/cJZmN2TZ/9f5nwQ6FY/8flAMYza7KkrtXL47sRvbAjJoIRLg4dVaHnStKEA1/dYwSZnN13znNlv9pemuP9OHONhKr/BNjfCoajiV0gzsd+Iv+sL+Rm+IYIKy+vemk7UtyF1Licg/uEVKCMiWx+Iy6Icnb4Ol//uikP3Xr8w+YpCdUCxEqUHMGfseha1F2PxrM2Jnwu+zlmRhGgIEd8EXys9pEHCDS+PNXlwQqkuaPfS3fipebjB8hHd0lMcqt3tistXo2EJHvjYmm6rIsTdr9zG1kutHl499sFZrdBwMkXKJ3To922KNKdmjupHSvF4r7JBMnf1rjhau1/6r1u7zCIsUTxIM4Z/Buqrnkt2nRMaKvb+P/7/nhwjcTY/y4MkWoQQeAH/sXcPKqNUSaKB3j/pq9wAgcDYxq3i91ru5w0FG+r3/8QypU1B4J7t4CbrplstCBO8G2kKc3qB54Xt7dSzkMgOh0JIb+as684kmH/2mP8UZ9Nz7O0YgN7Qa4c/5PnSM7B5/pYOn0adwadcB35IQpyyvGbAtKjPAXCjFVcZ8PTSGxkO8u9ZaI7Vvvjy76hOv/m6y8RKzpvJGF5AoNoZ4ha0FBB0Bo3mllwhzNhG3EqEJt840qssywnyZwknR4m253D8j0NhbvjDnt/noHof7Pf7fgwN06e7oWpYbBRi8NHH0R43fC6en0VtyiBJvgCm4mwZpVsCPtVv+1A0Y8WX8y/zceDopIZr1z5fWo7Tx7dp4m/2wdg3JK9pQEiYPTvHNv8+hEDH/Drwo+JnDWz43BH8bXyOB4IcWwOXrwgPM2a/47ajtyxVTC+tkv6GI3tgvZUFas27fjMWeIM/gltZgKggWh6FBhgDk/5j/keFY4bxB7YBVFpyO/Tn4UxNHpnUpuxDmEI6gKa2i2Wi/ pEH1+Rmy cKHNtDqDU19Bo/bUNAu7oEvI6a0UyfRaHMo3kbP7s0fM3+rM+nglSnaCSY7+CFmfVZgw77I377LVkx0VKJ0xd6yW1cwz1DPNuTOip60gUV2O35lZkm6z12QIDLa+TluZvic7L1tS7tLLoLnyH3+pF4F/H68Av5zp2+AQwsuRlWsjYO79bxQIeY35eK/pPSfd3PP//agRorW1UFhJLj2ai5TH6+d+iw0eQhEJr7mmYxoezjW6e1pczfKVWumfMwEAOGw+Un7e7fvdaNyZRBA0zJQlkv625sXwpnl/ZlF3zda4yf3sZnVln8wOlBxXkWj/uU+JIC8+415+AWBjpVeQP89dYLG62e6RTa4SZisQ8nC1Meo2PP/P4sc95Ug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Mar 2023 08:58:55 -0800 Yosry Ahmed wrote: > > > + for (fg = ZS_INUSE_RATIO_70; fg <= ZS_INUSE_RATIO_99; fg++) > > > + class_almost_full = zs_stat_get(class, fg); > > > + for (fg = ZS_INUSE_RATIO_10; fg < ZS_INUSE_RATIO_70; fg++) > > > + class_almost_empty = zs_stat_get(class, fg); > > > > Aren't these supposed to be += ? > > Looks like they are removed by a following patch anyway. I'll fix that up anyway, to avoid a bisection hole. And in case [patch 4/4] gets dropped from the series or is later reverted or whatever.