From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F3FC61DA3 for ; Fri, 3 Mar 2023 22:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BC4B6B0072; Fri, 3 Mar 2023 17:53:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86C496B0073; Fri, 3 Mar 2023 17:53:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 734D56B0074; Fri, 3 Mar 2023 17:53:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 566FF6B0072 for ; Fri, 3 Mar 2023 17:53:03 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BE585C07F2 for ; Fri, 3 Mar 2023 22:53:02 +0000 (UTC) X-FDA: 80529089004.13.B4FF9E7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id B14181C000C for ; Fri, 3 Mar 2023 22:53:00 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wMOpck3M; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677883980; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dQIBV2eWUqk6o3Z54yNiICRzgQsJTGO3YrhByk5BdIY=; b=SgsoBZT83QPMOPX8MU/1O5oG71WB9/TnDA7FoJYh3aS0N3vKVJMHPz/xj/JvbhOZHp1J6l kujHbXv6rvr+++R6LEZiY+CS16q3QkFhXd53cWnllSiLTA7CbRFwX5frZPS+Ux3KfbmqgF HQDijRLAcAAiohg7DqAwwuD2LNgzlzw= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=wMOpck3M; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677883980; a=rsa-sha256; cv=none; b=o1hG74i0TKtjv8YWZWZ5Iz8//IZIVICbd9/G2kuUbVB8Ima036y4yiJ/PMGCSrzk/HR6nF gXEAb+EhJHj0KmjxhIPvoRfRLUygPbiFOJHA4/nnMxpgqAX6BxluUQogxlGHea5i6qDBys 7LcSjJW5CyOLaNfUQi8TATwSDeu5FcQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BEA2F61939; Fri, 3 Mar 2023 22:52:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D071CC433D2; Fri, 3 Mar 2023 22:52:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1677883979; bh=MaBBLQHFLpcwWDV9KeH/SPbJ3duagmQxqkkADuevkSw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=wMOpck3M+IldQq9RC0s8DweCBKhwjBcQh3A3LTHWGvMAel9o2UxQVdzCjiQP8CLyy nEXMKTW8YkpfEm4DFrXkRKPg6r3mo6GXVD7Eb3uzseyAADZT5oPbJkyvKg5xmNMErC ccRabcn/xohdH4FMPkYkTuuTRhGwVgRiD1PasIdk= Date: Fri, 3 Mar 2023 14:52:58 -0800 From: Andrew Morton To: Peter Xu Cc: David Stevens , linux-mm@kvack.org, Matthew Wilcox , "Kirill A . Shutemov" , Yang Shi , David Hildenbrand , Hugh Dickins , linux-kernel@vger.kernel.org, Zach O'Keefe Subject: Re: [PATCH v4 0/3] mm/khugepaged: fix khugepaged+shmem races Message-Id: <20230303145258.866b985b21b3ccd9bc41bc4b@linux-foundation.org> In-Reply-To: References: <20230217085439.2826375-1-stevensd@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: B14181C000C X-Stat-Signature: sjg58wcaqujjqa9mftg319bcfkdm85yz X-Rspam-User: X-HE-Tag: 1677883980-816432 X-HE-Meta: U2FsdGVkX19lAsRjjYm1T1HARxNXIVDTytRFSQEjRIOF7/zUAV0h3BeLn0L0w2TAtC0DJq5QslmN2lnyIbDgVC7FZXhPL30mzrX12X+/RVhpXxgDXkXM5KJws+Qw3YEtokHV02ve/G1Cg4q/ZH2p6sCbjuRoo4df4D5A6Y8b5FYvrCsRtOQ2NLV1IfLdZI5lQS5kWch09cNR8MIsVgsxdAoHCC2A69QzWfcJ4PEDNLXELMfZJuNEK7cHeaAjWJGHS8PwvPMO4nGAbbH1aOOQkyZEidxSqqoXSeesxMEuwSCzSuerZzpfOiyh9XqPcZp3g/8Tb5GDSoh/gdIzHfkfgtROjYaFi4+cUXMA4qJb0TVMX8N6BtpYRRL20nTLX15fF4xhrm56HmoTApigQv5qy4fjExgiR81q3kyujEOH1TDQYZI3ctE8EhUBHgIWRGSMIIwJYwEXcOGMtsfGUabs5+GESfCGP6SH+m1+Jy11W2sx/6/9fqDoNND2vev7EneAB921XCxHmraTo9J4b016wpP/ZArJuQ5lkeQE1W9Ynxfny95WmwWp0/J31k1+RzAn3ejlMpBj29/q1mi5A0AC3tDGDj2RJmZ9AKys7q92SQxowMiiSvUCc8mngbRujX+VSJ5gIiZBwqX3Hu3Zvbud6DXNWemQWtTn9s/La2I7OAozSVq4sgFi/ZSiyusnd62wDqtm7JTpejvijYm0iTvk+8p6DqXkDXfAuz05OqcO/NVaAajg59KOHgbes19X7k2mETVZOj1Ptx0bwhzVLYcSWqfMhkoVXcvt1dD+zr+7DjupuQW+sbpaSgPJYsmReyyBRbvsgoEk/McMCi1jGltZYjqkNU+pfzWaxwQnVYb5LyVku/2WivjnEXQKCCRuiQ5+5WHZqxtj02wPQhZl/ooVOgh/B5Y7m+LW8U/hKw/u4CAI2Xp687ycF9nEg35/wS/KDx7CMpgJnM7fChNaOoZ zoeyd/Uq UZUFHyHAgGZHl3puGQvMOBh2JcBOryLbquK/I8bpITJl3c4buiBdDdLWOQqS5IHH9Se2pTrIRdVwNqz49IowflUzb5bd/3v0/tzPQ08npI/TvN9++iCPk9JTf/17f089JqokHlRPx5O3Zcipv9nUTUEIwxv8bc+4NG/NOynFgTORo87XmsmnyQCIyxpM+y6zCAjq+IwfaxK6/KSm6Ea2Ht1S2HC3rZgDM25zuPTUkCsTt/Gi4OFZVKsXztUrXqthIBRDnEbtFVlkbiq32ns9TC/unIaoTovmQn+4Hps1ilMeRLpq5s54yp5EYee8v9Is/cXhzZqGpvjk1N4Cq+6YDTTEc8Pupz4goOMSpjj+kIKOb035wTf5GeZZCnBMyWHsPqH6oIdGB8Qu2Tx9neou+AuK9aJXl+iGUhRmX74ImQwoBDIr8V4iJIj3UhMNaE915l+doc6VB4Ac2nqO8ltWZUC4E1iR9z34NrFfrjNFRm3VBzJQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 3 Mar 2023 10:35:53 -0500 Peter Xu wrote: > On Fri, Feb 17, 2023 at 05:54:36PM +0900, David Stevens wrote: > > From: David Stevens > > > > Fix two races in khugepaged+shmem that cause issues with userfaultfd and > > lseek, respectively. > > > > v3 -> v4: > > - Base changes on mm-everything (fba720cb4dc0) > > - Add patch to refactor error handling control flow in collapse_file > > - Rebase userfaultfd patch with no significant logic changes > > - Different approach for fixing lseek race > > I just noticed this one hasn't landed unstable, so I guess I just posted a > trivial cleanup that can conflict with this so it won't apply cleanly.. > > https://lore.kernel.org/r/20230303151218.311015-1-peterx@redhat.com > > The resolution will be fairly straightforward though, and I'm happy to > rebase that one to this since this targets a real bug so should have higher > priority. Even without the above patch ("mm/khugepaged: Cleanup memcg uncharge for failure path") I'm seeing a big reject in khugepaged.c. Might be easily fixed, didn't look. > I guess it's possible Andrew thought the series has unsettled comment so > Andrew could just have ignored that whole set in the mark ups. A repost > could possibly clarify that. Yes please. Lets gather the acks thus far, rebase on git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm's mm-unstable branch and resend? > Again, it'll always great to get another eye on this slightly involved > series. Matthew / Yang were already on the list, also copying Zach for his > recent works on khugepaged just in case he spots anything wrong.