From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 320F0C678D4 for ; Fri, 3 Mar 2023 01:57:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BF2E26B0072; Thu, 2 Mar 2023 20:57:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA46A6B0073; Thu, 2 Mar 2023 20:57:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A458F6B0075; Thu, 2 Mar 2023 20:57:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 92E186B0072 for ; Thu, 2 Mar 2023 20:57:46 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 63B30AB89C for ; Fri, 3 Mar 2023 01:57:46 +0000 (UTC) X-FDA: 80525925732.01.5F2F2D2 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf13.hostedemail.com (Postfix) with ESMTP id 7C3D420009 for ; Fri, 3 Mar 2023 01:57:44 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XfgMeJU2; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677808664; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X1JY9qAQaVPtwW8pbTi193xRy3To8OgGxPisxr9W/+Q=; b=0HQ8eFe5QpWR96p/U4sL5sMsOa6XcmslRwi9RUd8gEsmOx8aSQ3t800zN5l6Y16dh933PI /C8HrL4bKe5klVKVLMK+cNQf09+3lc/fD148UrgKdPNIQepPwvnq7X0OtBxyC8uaMMPPzR tiDn0VCDYOdpb8r5OG/6q1rWvhWRDrY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=XfgMeJU2; spf=pass (imf13.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.171 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677808664; a=rsa-sha256; cv=none; b=lt1M3TSpiITiZ8Y2p2LkfiwS5bVUSkIjJkYsIqmNEm5OprmM72bpGyRIg+qRQINano3gGI h4gY1IqZyykUbzguZ6dfvF/3JH+oRlBXgw55cvVqJ19MivhcBROPHjh1rBt3nezIhwT79S 2EddraoxNqx0RHXTukF+R37P4s/fzqU= Received: by mail-pl1-f171.google.com with SMTP id i5so1253812pla.2 for ; Thu, 02 Mar 2023 17:57:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X1JY9qAQaVPtwW8pbTi193xRy3To8OgGxPisxr9W/+Q=; b=XfgMeJU2499eB7h4inb3tPyBLMSEri3RDc/Y1tCyRvdVwLrqssnUhp82FJzJQTjDrT G/qkZjurQdkL7CQ9eJSqhmOFLLXOn6Ioqn/gUw/Ilnf/aka67SO/LXI+F3UVbJPHLJW7 /piwT5e34DTdkYHDcVNtJZ7SoDL3X2vTshLAo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X1JY9qAQaVPtwW8pbTi193xRy3To8OgGxPisxr9W/+Q=; b=en+0Upnevs1gnwUrW1ifAJL1RATnfjDNQXSkPeqUQkU3whC5OvFqEJMzdhJAtj+mK9 EjpgOvGPP2NTY+ECB3of7A9IZHM95olqOtMTW2CHmVNUHg7urT07CQr8JO+z8wU+0zq4 KxmddC662iT7Eqsvw0kABU4/lfU8ESqIARdOSe7UsVFGhNJLoDSotxcP5JNKrpIQhFpJ Dtt9CVWlRw7VnhA+iJULLjRGISqwke9YEmS6XvjVFwr5ZaTIkXrWANJjUf8/f0QU0N7w fEbcsjd5zcCf8XBKryqecqyaknhKPQv+Z8AQRdqwn1xZfj7qxEGIi46xasAhlxpReQQK 3M5Q== X-Gm-Message-State: AO0yUKXy4IpWQh85s1lghnNK1sXmU543vyYQf+qHkM44Ibi7amo1FI8V Jq8qyDij4lghyxKqf7hx2/ohOueIziYu8mf8 X-Google-Smtp-Source: AK7set84d7+Pv9ZbBDJRsmxLnTvKT9/3OI5J587MlSNWV12F04oQRLoXViDlM5tKVb2tantx0/IEUg== X-Received: by 2002:a05:6a20:1585:b0:cc:32aa:8570 with SMTP id h5-20020a056a20158500b000cc32aa8570mr640098pzj.14.1677808663408; Thu, 02 Mar 2023 17:57:43 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id e16-20020a62ee10000000b005d791692727sm320573pfi.191.2023.03.02.17.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 17:57:42 -0800 (PST) Date: Fri, 3 Mar 2023 10:57:39 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 5/6] zsmalloc: extend compaction statistics Message-ID: <20230303015739.GC4022757@google.com> References: <20230223030451.543162-1-senozhatsky@chromium.org> <20230223030451.543162-6-senozhatsky@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7C3D420009 X-Rspam-User: X-Stat-Signature: us4g1ff4oy18ap1upbb96egerapwst9r X-HE-Tag: 1677808664-144311 X-HE-Meta: U2FsdGVkX1/ry9Wy+kSAQmd/bUEEtDN1S1oB36/ZDPxFqivdA3+zgM4xZ2JCy6y21qLyup9l37FLQ3pgKdwnt8EtNobVELUJkxp8KWqryoEExuL9wFbzjRBjOq4DZQxZtzou208f3Lwqh4tsJxIlAaknuMUlaSevkgp7+L2yBqwGsrOMBRlhsheWvK8DG+lLRICAWcDR+RSUdku3EBT6XMqBCf/g00da03XWe5a1RorftwLy5BUWpYtB8s2PZQgBZ5BVUKjUODaYqMuj8Xei2RMLiRYPlotFxL2AE3A2MLpOgDIxtyjf80H9Mz5zUw8nMkdPMh9ndkRpXRafPF+wgSqhKue46zMcmPOOgVGtF+QITLPc0EovwYxMlPMud7U5hQcXI6nSIxfwTpiBk2IZZRMsTYaHVFVpza/olEJTUL7bgJcp+xNdgrJx+Kx+olXz2uohTizwRJRa+JYuH0qyd9+0e8NNVxaPPjtwBX/tVl2LeV84wucA3UEyHzsZoXDCHNlfP5aRqd7qlL5DIPFayCeZYLcyYiS1/RfQmLWtF2Tm/Vmb2Gc3j1LngCu1qJ8TaZXiLnnkyt6EvUTlcgloX4C6jgJkp9+/J+WpxcfYrIDvORGSefnyC71VzsDf5nju2SOkHpuwZEVpSRguvFNxAXmWq2uFFGCBEzrfPL9OwGQqwYRkdHrYOLxR6JlTtCn9IuDkfOEPo+x8QW5GptHrceV1UvUQiHxxfhzZpbPSDsd+pwH+uAGZAJXTnhGHWW/hRv6W4BrT5HM5Zd8rstsy3hyn79YPiE2hOQ4MIed3svZ6BzfG9/RfKcpkI5FRwrnAwLSorsNKCDeaq37ZHehc6SaTwS0X3S2elBtd+c9iMxtvS/KyCGg991ydNGvHtCjODc6X0zQsDBGtsfxkdX0LjLuZedrh2J0lqMtZn0i8krM5GS8I8WwO2G88Z92bd1Q9HhTcc6+s+owhf+X47fj Gkn7t/n8 oRNPD41mSoxCwFhLU1DLaOF1yZTufGIiA0Y2Z2NvMilm33QWsLD2oT1HGCa+jUeorbiHeXHa6O/FOWp3/j+zX3ndnv3G5kW0NU7/o1M2Q2jkRBiRxoFGOAC4fhJ+Su6S+rh3gH/Cn58a59MJ3YmjWkqXezBJFkkobWyCeqLGPxye4fOCoKzLQ4ZNpIrEOHtbIf4VxhiuY3E/22zOWEt4IKkZaHt02Dfc4h2xkZfhLKbQfDOYK81RFtxeLv7loZnW1/RtVTmVZf1+KwLIaizWh0GC9e7LLgWT19KwyNDbO+etTMyGA3Ek5TIhLG9XZslHMf1TYgNwqPb/iyPc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.157323, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/03/01 15:48), Minchan Kim wrote: > > in general does not have to do comapction, since the kernel will > > handle it. > > > > Just an idea. It feels like "pages compacted" on its own tells very > > little, but I don't insist on exporting that new stat. > > I don't mind adding the simple metric but I want to add metric if > we have real usecase with handful of comments how they uses it > in real world. I'll drop it from the series for now.