From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3C77C6FA8E for ; Fri, 3 Mar 2023 01:44:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 410CB6B0071; Thu, 2 Mar 2023 20:44:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C0C66B0072; Thu, 2 Mar 2023 20:44:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 288DC6B0073; Thu, 2 Mar 2023 20:44:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 173646B0071 for ; Thu, 2 Mar 2023 20:44:07 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id D2BC21C6478 for ; Fri, 3 Mar 2023 01:44:06 +0000 (UTC) X-FDA: 80525891292.02.E560136 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by imf02.hostedemail.com (Postfix) with ESMTP id EF7918000C for ; Fri, 3 Mar 2023 01:44:04 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=QDru2ShG; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf02.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677807845; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5Z4Izmtpe6A+FGHNDtYVCOvZY6ttPq+HHyaZSIEyjLo=; b=o8Li1v+6HNwkZ2FRt/D/SgQHbPZ17/crh/RRLs+5XLIW/FeDlK82vpYWiQ370W7WWxLtz6 GRjCohROn9YnWwDJiyb4E2qxMhDy78uEP8e5UOKOyKrNGIpqKPM1342QghdSxLiadzyGgw aBXsdsE98cayjzCIMc91eA9Qy7zblmU= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=QDru2ShG; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf02.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.214.170 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677807845; a=rsa-sha256; cv=none; b=uW+9OP1JWbHIUwXrQC4rEab37FyAhOCQdMkVaxL0YtwHLtTIoCAaTll17Yi1dwYFnlwbdR bU/itTOVpSSViz4UzI2y8uGce9WAnO0Jvz6N4SI71BWxK5su+BRUdT0xX0v23PKyut9DoV FnH2klJFuzVKXYfxEzgiAnsdmlhd/zg= Received: by mail-pl1-f170.google.com with SMTP id u5so1196956plq.7 for ; Thu, 02 Mar 2023 17:44:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=5Z4Izmtpe6A+FGHNDtYVCOvZY6ttPq+HHyaZSIEyjLo=; b=QDru2ShGrea6ivFoLgZOKi1RJNIuylB/St40a2BcpngvqQA+l/eLrSftj0tYuShEdu mE+3s9/mSLT2HYcnv/lecH32NOIDEaldbZU2AVqICf7W3F1eocuU5j+RFpUwehukLYur KPMhIyA6BzCrb5+tTrqYz5F0vNW5OybEMBo00= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5Z4Izmtpe6A+FGHNDtYVCOvZY6ttPq+HHyaZSIEyjLo=; b=DrLVXtHZ6jN2qVjHttU/i8wjq7vZk46v299NxIPWTFU0giYCjefSD3WdhScg8GtvZn eiNB8wqEPGYCeR/fTzjtU3IF3nZMeVKbwTWteD16oiyit4sTwgoybfcEwUgQ6yTItrh/ Pu2h0KcfaLnE2Wlg8GE+/jTg+KtJOHO2yvmcZe4L0MJGGHGrpZXKqeRSCai3t7NPYZVH UMAbTwOg0OB+UmKHJR86YfZSXCJzwQ4vK89bhdrO/B4JNP4JC0Em7OXKqJ1MwdT05zgc Om6IF797oLOcxGjBHDe1wudoB3SunCuFDmpA50yoA13xAx3DUP0bNfyvJwGWuqzLo1tv m8Pw== X-Gm-Message-State: AO0yUKUXWERmztoFzDzRw/esvsTGNqiDrhmw7SdM7kwnthKoktJOpDbV MnYyd6NbWkCrEagqfiHIU9RCUw== X-Google-Smtp-Source: AK7set+LPAioHoytU7+vjU+ulqwj/OLfubh8KprN1MMUfBqzKhgW1xyr77d2yrv458tVX97CEFChEQ== X-Received: by 2002:a17:90b:1b4c:b0:23a:333c:6bab with SMTP id nv12-20020a17090b1b4c00b0023a333c6babmr5336237pjb.23.1677807843699; Thu, 02 Mar 2023 17:44:03 -0800 (PST) Received: from google.com (KD124209188001.ppp-bb.dion.ne.jp. [124.209.188.1]) by smtp.gmail.com with ESMTPSA id bt9-20020a17090af00900b00230dc295651sm395624pjb.8.2023.03.02.17.44.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Mar 2023 17:44:03 -0800 (PST) Date: Fri, 3 Mar 2023 10:43:59 +0900 From: Sergey Senozhatsky To: Minchan Kim Cc: Sergey Senozhatsky , Andrew Morton , Yosry Ahmed , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv2 3/6] zsmalloc: fine-grained inuse ratio based fullness grouping Message-ID: <20230303014359.GB4022757@google.com> References: <20230223030451.543162-4-senozhatsky@chromium.org> <20230303010643.GA4022757@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EF7918000C X-Stat-Signature: o89793gfbzaiqp8ch5jq1wyghy5h3kka X-HE-Tag: 1677807844-60136 X-HE-Meta: U2FsdGVkX19lq+q/OBHKzasp7nSV/s0jozS4Ckfgl4kWD9QzOA3flvtxpA8qWhwoOIHB7yc1nU6+0VO5HX1S7r/Q3FrwK7pUyovaLV7CtK4UkraO151wRCevqo5odSXO3jJtWUp5F4tP6i4MOGuVgXJY5l+rwkENIzRzDomua4TbPDbUh6m5Qz+vx5aOu2uW4VAc5h+8S98YrUVNimxg2q3cDTEbrMq7R2BJ30Q9chm2ahNLFI9HEq4AhY+jaK9zcsAwTmGQY1t1wsrHUAOoPDw0LlMhEJH1JUds26ImPN4H2A9Uv8uVxBf39aH52P7c5JVH7+ENJARAjJaFMUdNcHZr4D8+gqnNeNFflUVB/A5GHxEXmi9O7YRSmgkeASg7/ZrdD5kuYLhte0zEW+dmoPAVg4fpTkMfCih0cDcwZLQv47l5F9p6t3Iw5sPnq0PmqZV76fKuWxNHNeMUyE3RHIyvReUet99X2wOV8uUOt7FregQT1FjQNs+TZLSe5cbFTXl4RHR6K3ypod+l6YIqLN4wSgWiIYU1jrdk5bE5osBudUfvPw82xHloj+bSbXgQsOc6p1NadiBxoGyCHVT4mNUUXNu4pi5CZWdq2s4Yz1Mj5kMA2lQeerBv2pJOQ/14EHnJk1d93oJNBkC6Y7+KZ9WHiPDD13LnGlfP3hVRUlX1BDcOaX6W9IJBUZm1H/fa2FP0z8GlCN/Tlr7F6VDUQOyvswLl18BVkKsjbLwzF19/qzYHb/6NnVzWIqguVxacN3VbzkiyiiUy7vT7C6ZHwHW+BBqoljzBwKP6MDbNrWGkL9XBbLGfC4f2qwOOVOy7uWo2tqolNn90nYdYe2tl0dGWHLVKhh4NvlwEZAr3sCWGog4DyWJkcvoKmmfNfrqwNb/YrNU5Pl5csGIsRBV545cbGo3LbB3QZGFhqIIUfA/m5xP5dMTeBJYQd1QOrxz/Qx0+Hae2xR7452gZFAS SgvRLvTg vQ/deYKA6iBgJltQZNLhrR2qH/5fHKKHkvcY8F5Xz8tH4UgiJ2GjmN1LATw1iwiANqwl9PMvR8B3jz3WF4TcDyItccor9DRSoLpkncPziUaZA0naGPEETKBQIvJNCZvMlLOPW1+Dzzr+fc02pQEbNNb/V2P99gfxkwBVvBcYYLBaYj0Ge0mNwA8cm8hIWrpo7R3n7FOgnM1nrGl3nGtRYR7FRV9Yo4LvLVdfpJn3NMlQDEC0GUWwzHg+Mi3rB6VAo8c5c3XS11zbBwxvHMTptyxmSOedKtbbqiLwb612ZG32p+w5GeHDz08wee+ypl8XmxpAnhJGmcOTsUd4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.410546, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On (23/03/02 17:38), Minchan Kim wrote: > > Otherwise I can create two big enums for fullness and stats. > > Let's go with two enums at this moment since your great work is not > tied into the problem. If that becomes really maintaince hole, > we could tidy it up at that time. OK. > > > What's your preference on inuse_0 and inuse_100 naming? Do we > > keep unified naming or should it be INUSE_MIN/INUSE_MAX or > > EMPTY/FULL? > > I don't have strong opinion about it. I will follow your choice. ;-) OK :) > prologue - seq_printf > for (ratio = min, ratio < max; ratio++ ) > seq_printf(s, "%lu", get_stat(ratio) > epilogue - seq_printf > seq_puts(s, "\n"); Let me try a loop.