From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D56E6C678D4 for ; Fri, 3 Mar 2023 01:50:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 409C46B0071; Thu, 2 Mar 2023 20:50:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3B97F6B0072; Thu, 2 Mar 2023 20:50:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2A7D36B0073; Thu, 2 Mar 2023 20:50:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1B3D56B0071 for ; Thu, 2 Mar 2023 20:50:09 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id EA2EF1A02EE for ; Fri, 3 Mar 2023 01:50:08 +0000 (UTC) X-FDA: 80525906496.24.83C43B3 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf06.hostedemail.com (Postfix) with ESMTP id 1FFBC180005 for ; Fri, 3 Mar 2023 01:50:06 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KFFPaCK3; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677808207; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vYsfDrrIFqKT586niYD+p8i6jvcEkX5KGy9Xmm2V1ks=; b=WYjl4FMRoJbsyoRPQUUNcn42TZ14MEIdVnYrOVhNgXNWFy+SAaLrIPw3dNt9zaZdmWuzFy w0DRVTuUKODj4C3yd9UdCLdU45ruoRVGS7xPhpMMKX6WUv1IeyZIgs2kc6L7Grz5oPaZgs quA8EmnSOY5Lq9hJ5FF6ZnFRo1S1YpM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KFFPaCK3; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677808207; a=rsa-sha256; cv=none; b=AtIMEOoPWEr9nVLOWTC0XfGIvRlkcZo9sogofJIeJnU+uvZjt6UdKjORItbiGKc5r8m0iW PPkLq9ZBS8JeaLQBW3WTeXA683ugfjCgdDw+j3d+fQK1VzDmKwbczGFJTuQtp4gp4u3qKd hY3iR88l+sspcTGAjJEFUHKrIaRbx08= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5728DB81620; Fri, 3 Mar 2023 01:50:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D412BC433D2; Fri, 3 Mar 2023 01:50:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1677808204; bh=ygNSzvL6CMybipvv1iTEmj2Hxqh5QV3leQ3C6IQ16qE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KFFPaCK3QbMh9lbtukWaKEZyx1kp1ha+avhNuGQEPfrx2rI+l1eyjhW5bJYCF4QSi 0TMEke89VdeDX6Ow6BtBiIZrBsAneDoqJDzaIfX4tc6rom0bGjTREGxm+qL2YWBrvO td+LqAWNMchOxk+bh0cDSoDmrGbckgO5DFfIQ56Y= Date: Thu, 2 Mar 2023 17:50:03 -0800 From: Andrew Morton To: Peter Xu Cc: James Houghton , David Hildenbrand , Axel Rasmussen , Anish Moorthy , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: teach mincore_hugetlb about pte markers Message-Id: <20230302175003.7772edcfc28cf0bd67f45e72@linux-foundation.org> In-Reply-To: References: <20230302222404.175303-1-jthoughton@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1FFBC180005 X-Stat-Signature: 3fw8pn88jg9uf7665offfw1r4f4fue8u X-HE-Tag: 1677808206-200372 X-HE-Meta: U2FsdGVkX19wyr1R0mqTTSc+ftWCqBeDhdCzAtW8xqiUTawjKvrxupAg/T6/yRDWIAb1LDl4eNXQ2uqkzlxn4rpDDYWvdNgq8qTb6KJ8fsJ3OAA11FIBKNfcEfXvkg52cv0eukCR3aqKHmsWkGi/3NT4AfPMYIyFsmswwd7BHdWEqUAakm8Ca8VLiBTHJsfKXixLIJPbyiN08wrnH33/DdGw/o23iNhTD0FI6PqsczzYzvli8RG44fCgLW+0NEdUC+gQKu3COqhmnPUQIv5Pncuo3r+aOGR7Rz37W/WO3oQePMwIGOQQ2VhWv5RBtRDCgBgjyu84lnUpm+nKbS7tbZT5gFhGOqqP82Ym0yfkvrn9OgipN/+Pc75Nqda1ISSu4LrlswxDLw5dOzc2GmlHL9/WwhfNPnlpwpB52bxp/MvaI7K5AyVo/AV8gkFN3EQH9ksau7wKdTZN8ZXY/7yjt7smEF/at91Cuy4VPky82QeeP1ueDKgfLle58pcjm4rvkevwnOOGIfoYgF36VZASa1SpktRiwUB1FV/QM4bqpddEzqnQX77U/3uAXqecCfORlDKuUQA8xdrZEQPcq4aLEi5uRWqy8XyCWtJVUDemVotATxMMqZ8RfSC9oHPAV0tEdUfGziBJ30iZH3CzFk81f5wT91GH18Cd+97njbzxmS6tF7enm96HMZwpUYX9H/lY9tHES/K7z6VyALJZlNpNWrSc6Kp8FPPS61Fl7HpsrBmaE86OEy8EbRJCFvxX+HXrQRkw1KgDYrCRUJqMBJc+S6h5qIUNhga7J++lv/3uYekAvrjkPQ7hGXXOjWZMRNcDskzsjK0MhEM/FNRSd64I0ppb2+WLcDvF8G3pOmA1ZJJpjTqz6IUuUjsFpQLsUZboMIssTn6RIFJ5jEFu0JVwqRDOXjPcMpTahIK5ZEeRiy/xE9Twv9XyHPbLnSTlQhnYDjZ5Szaj7Quzu9/DC46 SpRKyMTo XsCorMSOTzKCDl8s25lDec3Y/MkAmgcZL1W3PsrJgfSv5LX1R1AienM8eN+KzekNnDvwXawEMTsGn787XY1wCti9tzy7uCAKEx810az2MjMyThuVNZqAlxu10eTmaYNfF3Un5ENnJgxdIfuYQ2sALYXK69IOwBQY5j5uqG/gzQ2mmTOn4F6Gi8py8CBxYHB9mu9+ssTK/erswmBTkmZBXkNkOaOWuSgUPzQKT6BS+FCIWK2HWyXDLKxAgfmeNcvIsWSOW7OPy1yebWfN/eJErbvHOP6MRZDi0ed1i7FkxneExlDSRkY0zjAapkRMmSoHsTTylrTmIVzOMJGRhlpy2C8uRJNaCn+oXylwFzoaXNlGS+McsDKZhiceNg4R40vTsR0I6calW1IAshltycPyYv7AknS0ueF4D3R+/fz1vTa+AjwnKB42+Cyxffg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000010, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2 Mar 2023 17:32:48 -0500 Peter Xu wrote: > On Thu, Mar 02, 2023 at 10:24:04PM +0000, James Houghton wrote: > > By checking huge_pte_none(), we incorrectly classify PTE markers as > > "present". Instead, check huge_pte_none_mostly(), classifying PTE > > markers the same as if the PTE were completely blank. > > > > PTE markers, unlike other kinds of swap entries, don't reference any > > physical page and don't indicate that a physical page was mapped > > previously. As such, treat them as non-present for the sake of > > mincore(). > > > > Fixes: 5c041f5d1f23 ("mm: teach core mm about pte markers") > > Signed-off-by: James Houghton > > Acked-by: Peter Xu > I think I'll add cc:stable to this.