From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 660F0C7EE2F for ; Thu, 2 Mar 2023 16:47:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C8376B0071; Thu, 2 Mar 2023 11:47:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 978AC6B0073; Thu, 2 Mar 2023 11:47:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8401C6B0074; Thu, 2 Mar 2023 11:47:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 718106B0071 for ; Thu, 2 Mar 2023 11:47:12 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 44A6D1407EA for ; Thu, 2 Mar 2023 16:47:12 +0000 (UTC) X-FDA: 80524538304.27.016259E Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf25.hostedemail.com (Postfix) with ESMTP id 7750AA0028 for ; Thu, 2 Mar 2023 16:47:10 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uGmuCBI3; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677775630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3faSJ9q6B40BaV9n7HNpRrLhFu8opMwkIRE+14xsV/s=; b=Yrz4649DLhrU96nrNaB+Q3L57UcvvUeDrMYybtfx9QSw7cxxwaMaPPmXxODdHH+N5W9W1x 6iMfOXbVKp/13OE6BwNcNHZeqDMBnU2II6h0HHA3yJTblfKvq9XC+p4eDba2PO17n4BV5D L/smBRvXqgOB8kg002n24z+CjN0iAkw= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=uGmuCBI3; spf=pass (imf25.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677775630; a=rsa-sha256; cv=none; b=oHuqQbuLZR2aIEh2NlWkZgmruDKHdbefB0XkI+luomEuSJE7YCfm8oJhUviwAOQ0sZcmbV ULffZB2No1uGMYaEMiFeSMTdWsyDDyQq0oEYN4edQMx/rPBrEJLxAlc5OTw/ZdmhuHwUl/ 39hXfzWMT9aqsfW7maFVKS0lPEuQ0Ww= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 48363615C7; Thu, 2 Mar 2023 16:47:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 32C19C433EF; Thu, 2 Mar 2023 16:47:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677775628; bh=Bfaxg0viKwM69JDI9XacTFnWsfSPRHkmBeTe0jCJjhU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uGmuCBI35YMYdj1qVKjiffrckevG0q4jBIGfhm3EB5st05tld1r7r/+8Ufq0To4Vb HnvW2i0wvozPC7dbaBrgO+RLpdgSIaVGLOcrXnrY/sB5ONOar5qnpu3XNZHGz4SugF kxxzQJEePbcEFKG53xu2/J03kt8cXBkzT/RJRSxsgT7eW3dPipwKFHNoMwWvEcHlt/ qmugQgBHieDf/EBVSfDaFKK+GU/QlD1u/QPxlf1drG5mu9noMM5aatTh1cbx0xvpHJ wyKCidm72tG42CB+y/k/m04q9B6PyE7XeLdj3dD4SuXl3uLZfBF9r1tZwPGluZ+n1y j7fDEjh+dmxCg== From: SeongJae Park To: Kefeng Wang Cc: SeongJae Park , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH -next] mm/damon/paddr: minor refactor of damon_pa_pageout() Date: Thu, 2 Mar 2023 16:47:06 +0000 Message-Id: <20230302164706.85999-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230302144926.40012-1-wangkefeng.wang@huawei.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: mkcya7ugeokd9o64qibk77pj5yksr8n6 X-Rspamd-Queue-Id: 7750AA0028 X-HE-Tag: 1677775630-461857 X-HE-Meta: U2FsdGVkX19Bp5tVuWUXrDUVK9f1ZkXVYjobYdnywWdU08jBPT87D+Z6FRBlraBJ1XtaJ+RRW5GSe59S309OZR8Zr6g4Ay2O7P7arTYKSNij8r+/QnHXywH818jTPsj+r49H5lVZ6yaY2YFLEzSbKrd0++VZa0nIBO/04dRGlnNW30KY2TvVa6+WcMpq4M9XSNue86b9gFWLzoTQwV4V1IK63P9fJmUHLdOUoayGRvCOH7wjJn+N72T+9njtPCJqbOLCmVyPEM/B8FA8BFkzS/gXGskxKVzAfS3vUrDuL/dIEDI8xYvo99to+4val45vp45z2eaBvaXL9IhnuUvZyD/15P3TU4OEByzkBv0Irac4PMIyhCAK0wgekSXdX9s1kKbD/Ahit9Ca7PTz2oD+YnzoucJCC3GlGXl+cukEqyA4wiTH1MgJjnAxWBkRJ9VjkYLxQoxqefkTaLv3J93oL0rMDeOm00sUTWppibP/EjK+aoo6OopIViccHaQ7jkM0dQykL0sVu5TDcMsJLOBSKvyboSctFrz63rYIUfGNpGQQR8RXXoqTGLPwwNhf0K2cLUZC/ZHXcjOalyQbcEV2eI82YSDVClzKmdyr/xOQnStnPOnZ03mqb2U4g3c/nsJBhkH/ClyfG9iZaSsln5kQ0yyL7BXHkPoSfs8TOPx2TE9P4IGDZwAFFpD5XxNBrOBgJGmHh56KcX1dw4JVs8mbJUlq8EeYcc9aqkSjTg9f9qilbxOJ7gZHLA4ckkvy1X7K/nXkrifAXDWdtBc6haBG7XgotgSEH8gWjN1zBy7orqeFkGkhPDFvw09Ld4WaWH7LMWl9d4PuyFiLfYjDN8jEv1C4UvGLajYiRb77qFTxVVMVuKwxS+92tUwQTBiB1qqoA6cVnew4QtAi8RENQr0Wk3Nb/uhSqRzcO3Y6qkif9Q7coJzkM5fhl+L/TMMg7jOseU1WCgnhuseq/Ik28M2 LYDu4uaL Q7hN0eGbBgzDPzgQbxd/sjsM7GZVfbYzRpemTPLWIH82PkspLvkFGuIs7E3k2smq2vB/lw4QK6bC7yai8+zus1ZU2SGDyZ/X/YscNOUbk1mENLMxmSWbxxx/AFpfaJSEcbjhnyOs4tBaWrZ0wIimwEcOCTvlMkVyHqaj9y+y/61ymmXREUJlSLAm9vI21x5knA1YT15uY1SyQ1qCTM8XIfDQBPt1ybJPVCwPr0ZetCCo517x/o7mQERzXuH/p/lh/l+ZgyyBBlJUwsxa4DvpfGB7WXY1p2aAGA6izRGGzglQTyiV64/32F/XU93Jx2/B8i1f5MVbiyIDDmjqvwe2OKmfw0izGYpw0Uu53d+hBPbjSYM8Fm2smheUjonIcth0yZbtSxdnpdJzRca6/8SUqA1AnXXAQZnUPyzte+BELrtcJe0eyFyZ7oHTZiSaZc5NysoF6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Kefeng, On Thu, 2 Mar 2023 22:49:26 +0800 Kefeng Wang wrote: > Omit two lines by converting if(!folio_isolate_lru()) to > if(folio_isolate_lru()). > > Signed-off-by: Kefeng Wang > --- > mm/damon/paddr.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index 6c655d9b5639..a557f3c9300f 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -246,14 +246,12 @@ static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s) > > folio_clear_referenced(folio); > folio_test_clear_young(folio); > - if (!folio_isolate_lru(folio)) { > - folio_put(folio); > - continue; > + if (folio_isolate_lru(folio)) { > + if (folio_test_unevictable(folio)) > + folio_putback_lru(folio); > + else > + list_add(&folio->lru, &folio_list); > } > - if (folio_test_unevictable(folio)) > - folio_putback_lru(folio); > - else > - list_add(&folio->lru, &folio_list); > folio_put(folio); > } This looks ok to me, thank you for your effort! Nevertheless, I don't like increasing depth as much as number of lines. The more-than-3-levels-of-indentation[1] warning is not always right, but this 4 levels of indentation is not making me so exciting. What do you think about adding put_continue label and using it, not only here, but also above part? For example: --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -239,21 +239,18 @@ static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s) if (!folio) continue; - if (damos_pa_filter_out(s, folio)) { - folio_put(folio); - continue; - } + if (damos_pa_filter_out(s, folio)) + goto put_continue; folio_clear_referenced(folio); folio_test_clear_young(folio); - if (!folio_isolate_lru(folio)) { - folio_put(folio); - continue; - } + if (!folio_isolate_lru(folio)) + goto put_continue; if (folio_test_unevictable(folio)) folio_putback_lru(folio); else list_add(&folio->lru, &folio_list); +put_continue: folio_put(folio); } applied = reclaim_pages(&folio_list); It omits three lines. $ git diff --stat mm/damon/paddr.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) [1] https://docs.kernel.org/process/coding-style.html#indentation Thanks, SJ > applied = reclaim_pages(&folio_list); > -- > 2.35.3 > >