From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85559C678D4 for ; Thu, 2 Mar 2023 13:32:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AED9C6B0071; Thu, 2 Mar 2023 08:32:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9D096B0073; Thu, 2 Mar 2023 08:32:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 964E96B0074; Thu, 2 Mar 2023 08:32:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 875676B0071 for ; Thu, 2 Mar 2023 08:32:18 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 575FAAB26E for ; Thu, 2 Mar 2023 13:32:18 +0000 (UTC) X-FDA: 80524047156.19.47DC494 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf04.hostedemail.com (Postfix) with ESMTP id F35AE4001F for ; Thu, 2 Mar 2023 13:32:15 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rnzVAew6; spf=pass (imf04.hostedemail.com: domain of gerald.schaefer@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=gerald.schaefer@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677763936; a=rsa-sha256; cv=none; b=0o2Rf/pAOdX4f9UQWvw28o/77pNeBVnB6klgza8h8AAnJpCnj7P9FYhEYPGrPU1XTjqWr3 NG40ncJcFm8Q+Uu8o/uND/NyCjPbYJiJzJ52tO12CY49RRddfv85Wg9e7tZ4QxMa7Gy45O 6iSxLV3f04qNVZ2YlLj7+mflkEyxSSU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rnzVAew6; spf=pass (imf04.hostedemail.com: domain of gerald.schaefer@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=gerald.schaefer@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677763936; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ba61TMgbgtq2qCLloS89YKVV6TrsoEUxqPkJmjoGD+Q=; b=hVkRRPfhrQ1bBTVc316nrN3epLieCVtdvP4O5Pnfg5kcMFyV64VLgormdLtEn334RqDw3m jE6x/6wPIZQy8iTnsBoNL381GX9XOQfw5jxGtqOH3ypgR3lWY0ofNxWOP7MNKAVNBKB3BA I59thvZAe5buVk7bfH61dY3Tu8G2G/E= Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 322DFZvZ010455; Thu, 2 Mar 2023 13:32:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=pp1; bh=Ba61TMgbgtq2qCLloS89YKVV6TrsoEUxqPkJmjoGD+Q=; b=rnzVAew6rlusCElG0+c9Ft8GCJZwxOCj9pEbrQJH+tbt377GnwnW5K7LZNsm7LkH6h7D 3FMv95yDnAFSaN+R+B/pqQnEyh7H/PgW64tPAo+aMa0WViiNSm+uPom4zsUS2QdW+y1H ll1DU3Q2g91JJ9xAMaFuxpWI5Vbb7IWg1PVFK80T2xE7NLG3KmSB5KvHvjYcWd5ud6VY XUXBJ2GRH270NMAN3ZY6qxpD80fpT3CZfsH2LkFTLPYY587jtpGRMpSod+cvVnzmLr89 M3VahycIScDLF7CY0xRfMBBjiYK5cge1YedI9OPgkfY1Gz2xFCk/ubdGygBh82tU6miC hQ== Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3p2vhcrfbw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Mar 2023 13:32:03 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 32264nRo013030; Thu, 2 Mar 2023 13:32:00 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3nybcq5uj8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 02 Mar 2023 13:32:00 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 322DVv9a64094476 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 2 Mar 2023 13:31:57 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id F284920043; Thu, 2 Mar 2023 13:31:56 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 81DE520040; Thu, 2 Mar 2023 13:31:56 +0000 (GMT) Received: from thinkpad-T15 (unknown [9.152.212.238]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 2 Mar 2023 13:31:56 +0000 (GMT) Date: Thu, 2 Mar 2023 14:31:54 +0100 From: Gerald Schaefer To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: Re: [PATCH v3 21/34] s390: Implement the new page table range API Message-ID: <20230302143154.1886c213@thinkpad-T15> In-Reply-To: <20230228213738.272178-22-willy@infradead.org> References: <20230228213738.272178-1-willy@infradead.org> <20230228213738.272178-22-willy@infradead.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: aAeGP5EBVBGILPMKK7Fm47tHFTlZ37R7 X-Proofpoint-GUID: aAeGP5EBVBGILPMKK7Fm47tHFTlZ37R7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-03-02_07,2023-03-02_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1011 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 priorityscore=1501 mlxlogscore=640 mlxscore=0 adultscore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2303020113 X-Rspam-User: X-Rspamd-Queue-Id: F35AE4001F X-Rspamd-Server: rspam01 X-Stat-Signature: e5ore61uh5j94anij5juy4gfrszitesa X-HE-Tag: 1677763935-142864 X-HE-Meta: U2FsdGVkX1+KUP5WQgKJYvxsxWEFSMp+6scbTgwXcsMJc5542vVO0kNJRFmKz/kBBX8ZxNi/GvqvJXBngW1PT8cJdX75LUxGtvo6TRD34hvxsv2nXoycVpIXcqOYVI66kfBKSXX6ANGNeoWojNUAKUeNvw24aABGctPUtHqz4tU4MeXO8+p6SvuXHmK+0LjQMWU9eKAbHnlQpAsUt7b/YIW16uxD4arIz4E0YD3KE6Y24gdmIcsILkGzYI0fxmjOMxTVRUgiOW4wOboBbzQg8B9WsTWPNpq/lABoNUBe4rwP0zZG4q2ZIfqwWtSEtTPz7rsk1DgANH6T53QTmavTBpIxFTBLhGim13htHYyVU9aZY9NGMxMX4Bth2Wmo1IVf6CqjtZo+F5z+sp9pAR2urtLcndlcEhkmblWLFs9f4tEwAAxlPtbAbTN7KYwDIkQgiGU4tcMDYK1lSRLfSCwvXrdvYCy47Q7bigKKHp7SnP1G9MiYAp+DeGrZJw7m3oM46+e2MTjcg+tabHw37KeSOkHtTNJw9+gdyg+T2kUU7hFfdK02XPztUtlges1/7vqw0CcPPORlAY5YACWHTw2uorfe77S3covBrWxZUSg86pxa/DBVv2J5qKc05yXPZfpFme4EIsX6MVKSDUdN/JfNdYSY72Isd+oTIaX9aUoI2Zciy8lbSWWaf3nPn34aAuNZ5gI0UG86fG9aBRo9vUEnQ28jbV0IRbfw/2ciV9LsXj2MIVYx3s/PHB+Rk0LPy189g5R1doVez0HgJzhIUaYGXBsjxnXmc/dTOy9Yu6L07kmb/LcoNBUnmdEhH01sXgdv3rlMRADz01/588MwNtFa/5fidkSLZ40bGk6ByD0kxIx56axmuPoGHHJHqX/aFvZIHznt7FIc+gVTb3xolMC6R7P+mom1Pfrpj4BtqHNuwq8OPw8qWhftgrcBtoGlVsS7HWyYjmqlefxgqEZHFhM qR7Dkwil cmQv57woikOqO7NNh7lC/Pq9G+3E7b6D3ODv5tysqQ8x7lBYiOR916unIFF1IMBdXxKR8Xc1Eaf24e5Q+dbSl3wWP6bPCvm0gqN2FwE4KQnAC2gJjqSe4znNV2iRyCQEa5j9121T5OPHNHKa5jaEx8BslzJNebHxkvMPKYF0jx8DylMjzz8sTBUFWCSG+MZP3PsHhuh0TYI1uQcjk2oVFUeKTVLkpEA3E7G2SKdBqrgSuSkWmjY5SHhfvLInSI6EMLmTnPV/NgnLcIx2Y17xv43zCoDkeap+nP60/s8p73cNWoYDTTwvKE21ztXsiPWh7uE8c8DxnuJJme9A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 28 Feb 2023 21:37:24 +0000 "Matthew Wilcox (Oracle)" wrote: > Add set_ptes() and update_mmu_cache_range(). > > Signed-off-by: Matthew Wilcox (Oracle) > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Alexander Gordeev > Cc: Christian Borntraeger > Cc: Sven Schnelle > Cc: linux-s390@vger.kernel.org > --- > arch/s390/include/asm/pgtable.h | 34 ++++++++++++++++++++++++--------- > 1 file changed, 25 insertions(+), 9 deletions(-) > > diff --git a/arch/s390/include/asm/pgtable.h b/arch/s390/include/asm/pgtable.h > index 2c70b4d1263d..46bf475116f1 100644 > --- a/arch/s390/include/asm/pgtable.h > +++ b/arch/s390/include/asm/pgtable.h > @@ -50,6 +50,7 @@ void arch_report_meminfo(struct seq_file *m); > * tables contain all the necessary information. > */ > #define update_mmu_cache(vma, address, ptep) do { } while (0) > +#define update_mmu_cache_range(vma, addr, ptep, nr) do { } while (0) > #define update_mmu_cache_pmd(vma, address, ptep) do { } while (0) > > /* > @@ -1317,21 +1318,36 @@ pgprot_t pgprot_writecombine(pgprot_t prot); > pgprot_t pgprot_writethrough(pgprot_t prot); > > /* > - * Certain architectures need to do special things when PTEs > - * within a page table are directly modified. Thus, the following > - * hook is made available. > + * Set multiple PTEs to consecutive pages with a single call. All PTEs > + * are within the same folio, PMD and VMA. > */ > -static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > - pte_t *ptep, pte_t entry) > +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t entry, unsigned int nr) > { > if (pte_present(entry)) > entry = clear_pte_bit(entry, __pgprot(_PAGE_UNUSED)); > - if (mm_has_pgste(mm)) > - ptep_set_pte_at(mm, addr, ptep, entry); > - else > - set_pte(ptep, entry); > + if (mm_has_pgste(mm)) { > + for (;;) { > + ptep_set_pte_at(mm, addr, ptep, entry); There might be room for additional optimization here, regarding the preempt_disable/enable() in ptep_set_pte_at(), i.e. move it out of ptep_set_pte_at() and do it only once in this loop. We could add that later with an add-on patch, but for this series it all looks good. Reviewed-by: Gerald Schaefer