From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6651C6FA9D for ; Wed, 1 Mar 2023 15:41:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 527AF6B007E; Wed, 1 Mar 2023 10:41:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D7816B0080; Wed, 1 Mar 2023 10:41:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 378C96B0081; Wed, 1 Mar 2023 10:41:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2B6836B007E for ; Wed, 1 Mar 2023 10:41:40 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id C8F521C625E for ; Wed, 1 Mar 2023 15:41:39 +0000 (UTC) X-FDA: 80520744318.25.B18D5DD Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf08.hostedemail.com (Postfix) with ESMTP id EFAC5160013 for ; Wed, 1 Mar 2023 15:41:36 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=RacUjtkK; spf=pass (imf08.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677685297; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=T04RMfKzSUFRrZ3CYc3+bErGU8vpxkP2QVI3mwlpG78=; b=TkwIjIif42jztlUy5MId7q/DiiOGB26aC3RFa+r2KOQstesb6qBPPIxMjpTSjRARnFOr6n S72oujWKJ8S0lCLa0WyKOmjwTLrUmoq/2cGnF3PgJuNYniQxG6OR2ZcE8HcvWTZaYfcx7R tg8NwDgojU+bn/OvKwiMmN0CT/xWB7c= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=rivosinc-com.20210112.gappssmtp.com header.s=20210112 header.b=RacUjtkK; spf=pass (imf08.hostedemail.com: domain of debug@rivosinc.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=debug@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677685297; a=rsa-sha256; cv=none; b=eOyAiS88nSUrOHD0jPeqAfWTYZJ4PXvH9mb+IvKINGQZKG9Hb1PujlDwdoc80m9NGN8tD2 KYQiVa91pPhwvnFBC2wrIqrPTOFitjh3XbUbaSPAmVHxPS+ynFzWQQ47tBurR4dASxyU/W v2ne18skM+b40Y69yCf6grAMAgBTpeI= Received: by mail-pl1-f174.google.com with SMTP id p6so13567317plf.0 for ; Wed, 01 Mar 2023 07:41:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; t=1677685296; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=T04RMfKzSUFRrZ3CYc3+bErGU8vpxkP2QVI3mwlpG78=; b=RacUjtkKVhkSdFUBywOGho+8dt8NsK+GHdxWXdQ69WX2yCf/yYWl7r6icMXBWT/ShM KzbzJEeKqlnWntlEh4Hu5sno9Ak81pDzhFum2pY94j4Sv2hldxTUvXOesOtDXjR8r6gc qTgIZDS9fRsSDLNbTTTqAFsgPsTJ/DQ+0jjGE9ek1g+5UBhUcmjFAxCNoVki1FxJorhz 1mqoDsTuoBLwUNz+cTKmWUvmBN0WlvjuL/8NCCPe/UsZ69pgJ+6lNteW1mdicJGes/KY sz2TvcyHAjAaMaJRH5/VJiCFama3PVa+Xs98E38Ow6CsZfQ4ni3p2/e/LUrMvV5jGCLw yEmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677685296; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T04RMfKzSUFRrZ3CYc3+bErGU8vpxkP2QVI3mwlpG78=; b=ZDFV58wa/84mcggk0IF72fA7nD6fHaWBtNdJ48IBISOD0BCqCgIjA3vn73lHE73Qep 7B3lpFTFxXPhc+XGkmF6q5LN9zBhNBiYN2flkvBVEOjbFLt/hGYEJCxRMfHYCKzzXwQ7 xQDDw/kCyhVKeXK8wFlWk2Gewm0LH5qCBgdjJcqnkOKZpEBVsipRmlawj11727Oa74x/ 1lLjbeEze61Tiv6GKNMB9HNlWGlECqhp6klWt9P2yogxR7NwR0AXNjpTenU7IMXyf3qH 0zfWfpa2rYcDngNDjq6hsY37dPkrmdIS3+7TCsdPds0rGSKX+wa/FKWfPgoZ5obtFsoz mh1Q== X-Gm-Message-State: AO0yUKXUuTrhCLzgSWtu5EDJukDw+h+s5IEYv+r8MXKNrHvX6jtCs6oi EfReMOHZGStACBwIMu8F1UBsHg== X-Google-Smtp-Source: AK7set89u8u7K351sr+Ck6r7PKKsfq0NxjZus48TDBYC9SmTqwP5jGqb0tSf18Db2RC/D0Tp3KOSQg== X-Received: by 2002:a05:6a20:2444:b0:cc:ac05:88f7 with SMTP id t4-20020a056a20244400b000ccac0588f7mr8304959pzc.34.1677685295782; Wed, 01 Mar 2023 07:41:35 -0800 (PST) Received: from debug.ba.rivosinc.com ([66.220.2.162]) by smtp.gmail.com with ESMTPSA id l12-20020a62be0c000000b005821c109cebsm8058970pff.199.2023.03.01.07.41.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Mar 2023 07:41:35 -0800 (PST) Date: Wed, 1 Mar 2023 07:41:30 -0800 From: Deepak Gupta To: Rick Edgecombe Cc: x86@kernel.org, "H . Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H . J . Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , Weijiang Yang , "Kirill A . Shutemov" , John Allen , kcc@google.com, eranian@google.com, rppt@kernel.org, jamorris@linux.microsoft.com, dethoma@microsoft.com, akpm@linux-foundation.org, Andrew.Cooper3@citrix.com, christina.schimpe@intel.com, david@redhat.com, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, Michal Simek , Dinh Nguyen , linux-mips@vger.kernel.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, xen-devel@lists.xenproject.org Subject: Re: [PATCH v6 13/41] mm: Make pte_mkwrite() take a VMA Message-ID: <20230301154130.GB3505369@debug.ba.rivosinc.com> References: <20230218211433.26859-1-rick.p.edgecombe@intel.com> <20230218211433.26859-14-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20230218211433.26859-14-rick.p.edgecombe@intel.com> X-Stat-Signature: 4s9ykfu9ampwi6y7qowo444yezshyxrf X-Rspam-User: X-Rspamd-Queue-Id: EFAC5160013 X-Rspamd-Server: rspam06 X-HE-Tag: 1677685296-977415 X-HE-Meta: U2FsdGVkX1//zLEOTV9Ips2ZSiCyY/Q+oJXq4ZwzM3n+DZrbVZ1yF7eDA8/Sv6NtUchLFA/KniWUjoL3ENkJd8XKW0FeD8GA3F5N01IMJ9+Ad8ri76QjsfxYNPeOu68igP/mxZfADAWdL6W4ImRNT51plbkus4pJVehRtQaRd1tRuVxY0goyISmR3igQ7bo+1iMfbLaoCYuj1b2AoZg05cHSzVsp0jqJoVsAaIu0ZMFJlcbkDBFCwrn6+3Q1gLXTU7hvgEs8bRuEaHL+OR818y2qeAUFkDBYrYb1vpLbCgRIBuJNWxyrxCGJvpehwkPVPtElwdMCUkx6rg/yB4c/ZuGW6HLnSpVNmATlZ1mtM0y3FJRaic+FdoSfsBvIS2KluQ0eHY3Txo4SgQmenlWND8Xqh10u2OyCZpx667sxSMgsT7kSg6gqp0vPFK9Evg6n+lrsJqCBR3reQR5y36I9RGGLJ4voja6SgXYLJE1eaHCUGJMH4Qa7opMA5oKqS4VU8tkfEXaEZrLga3UEWLfp418rLweJEd9cUAkxZ3Rd0vXgUoQ9TuC9wIybcJQrtyZhqRYO+VTybKd3OSMT+0q3IlptoeW1rdVVbmlKCFpI2Lt7XrRbDfJVusP4qMIWhFS7iKzNbdlq1C8OHF3OIvXouUXBY9vkAbb2+ChiJw7Fm9EnRQ0AiUVUltnyofjHtsHO72ERFDIKC9LaJNbhILLeK7s/lFW2w8w+TXvPICxzDvhs0ZHu2HMIZoU4VQCO5UDH20VPmh1M87PndpDcPv7+vuBl9BNX1aW9FjItrI4NqSaPO5ebhkhI8M0ifttrUFdF/+d7vBDZMSu9iyEmeVIJGW3O4bECnbrW6UvdL4CsHcCt6wLPrn8u+BVY/30OcjfbNxDi/zAL2IZBcCEiymtAUliUDCa936T3tURJGCXoXYY4zqmV1crQP88ljohkJ3cAHGkOqzUrMbCmnDZQFue EZkoVfvB Pjg31W2iDYDG7k1a+Ot/PqNpVJjtBXakXB9VXGF8kk60EAhlvSvA2oSzuohxzVvm+3I5imT7OB7/Sm4CA3dfOjvZDA8t4LOmhFA97omtUCTXYX9Y6QawI0ji1/9eD+sLX192VJkU8OdKt/fFm9Ul6dTbKBjvAWAD5zzdQU4hl7dVnmXltudMzi1wUaS9Vl7tLHnQcWXz1nENbbJUsB7VmS9rYPK3ViZL6nSCgvEFeYCTId7ojyzcXwhZ8XT/YToGf07gGzwjMCVDUQdleG9ZY2cAezyGLxvisJxpL+tNp/7fjTXVZ8NPPATpBOGU82YorjpR9k99zeMyvuTBKgEYsLqNx0m9K04cr2J9v5jSCe18LBEOOs+1BeoaA0AUilNOG9PqJDsUHAqKYP/2QL8Jhh5artMr+mBBMNB3UJkS0Nypkb8zQ42BW1uR7gVNPUxO6F9DFvcEDoCjt77vb9o8hw1yTTGtgRkpQZ+0d9VkUlMuZMka646uGESrqnJblcFPn3/cSuLx7b72vSIPoSgnwePYnHQE7QzpqPf71PSVaZYvSPVcPLhGGyXmoaNznZ96674LgUr9IAm5BXl+Jkpk5Tb6ggVmkqmTlu36tJfiShjg85fR8rbWE+AmGPU/hOx59cHkdaQB4OujMrz58bec+EiE5BO1ibsAwvT35FepQ6TBO9sY80vMgw+K7UjwDNI8JFRXG+etqXf02oLk70BIpTMMDYGerOnC1Ur1aJS6Rr6lvNzd1t9XzKD9tEMX0zEwPpPjFuKYB7VfrRVpAJJco31TetipWo5/tNvtRLGWQFM9PN6pUnf4mppLk33Ng4r1Xyxztg7EVyblXD944EOCWtmDFHWbPOoJN598LaiibKr4eap8hueJIYshSDNvPa7KaEssMSdMA2TzyIOIU+l3dXLNouUlPF3QTFtQ4jgIHJAZoToGNmkb5mXw65Ysire3zf/DsJCBsE5oKzu4K0/o0sP6PKtsu MtWk413x S5tT1dJ9XNv1Cx4Bm5eR28IjqZZ/m8po1oruSC23l9nOCdi3fPGYR6P+Os6sV9q87CIILdqIl8SvjDlfVafOMg+eJ6E/NKi/DULwGjwb+c2e86niSbCa/SC2ENG0iwnysTT37gzaGNM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Feb 18, 2023 at 01:14:05PM -0800, Rick Edgecombe wrote: >The x86 Control-flow Enforcement Technology (CET) feature includes a new >type of memory called shadow stack. This shadow stack memory has some >unusual properties, which requires some core mm changes to function >properly. > >One of these unusual properties is that shadow stack memory is writable, >but only in limited ways. These limits are applied via a specific PTE >bit combination. Nevertheless, the memory is writable, and core mm code >will need to apply the writable permissions in the typical paths that >call pte_mkwrite(). > >In addition to VM_WRITE, the shadow stack VMA's will have a flag denoting >that they are special shadow stack flavor of writable memory. So make >pte_mkwrite() take a VMA, so that the x86 implementation of it can know to >create regular writable memory or shadow stack memory. > >Apply the same changes for pmd_mkwrite() and huge_pte_mkwrite(). > >No functional change. > >Cc: linux-doc@vger.kernel.org >Cc: linux-kernel@vger.kernel.org >Cc: linux-alpha@vger.kernel.org >Cc: linux-snps-arc@lists.infradead.org >Cc: linux-arm-kernel@lists.infradead.org >Cc: linux-csky@vger.kernel.org >Cc: linux-hexagon@vger.kernel.org >Cc: linux-ia64@vger.kernel.org >Cc: loongarch@lists.linux.dev >Cc: linux-m68k@lists.linux-m68k.org >Cc: Michal Simek >Cc: Dinh Nguyen >Cc: linux-mips@vger.kernel.org >Cc: openrisc@lists.librecores.org >Cc: linux-parisc@vger.kernel.org >Cc: linuxppc-dev@lists.ozlabs.org >Cc: linux-riscv@lists.infradead.org >Cc: linux-s390@vger.kernel.org >Cc: linux-sh@vger.kernel.org >Cc: sparclinux@vger.kernel.org >Cc: linux-um@lists.infradead.org >Cc: xen-devel@lists.xenproject.org >Cc: linux-arch@vger.kernel.org >Cc: linux-mm@kvack.org >Tested-by: Pengfei Xu >Suggested-by: David Hildenbrand >Signed-off-by: Rick Edgecombe > Acked-by: Deepak Gupta