From: Alexander Potapenko <glider@google.com>
To: glider@google.com
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
x86@kernel.org, dave.hansen@linux.intel.com, hpa@zytor.com,
akpm@linux-foundation.org, elver@google.com, dvyukov@google.com,
nathan@kernel.org, ndesaulniers@google.com,
kasan-dev@googlegroups.com,
Geert Uytterhoeven <geert@linux-m68k.org>,
Daniel Vetter <daniel@ffwll.ch>, Helge Deller <deller@gmx.de>,
Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Subject: [PATCH 3/4] x86: kmsan: use C versions of memset16/memset32/memset64
Date: Wed, 1 Mar 2023 15:39:32 +0100 [thread overview]
Message-ID: <20230301143933.2374658-3-glider@google.com> (raw)
In-Reply-To: <20230301143933.2374658-1-glider@google.com>
KMSAN must see as many memory accesses as possible to prevent false
positive reports. Fall back to versions of
memset16()/memset32()/memset64() implemented in lib/string.c instead of
those written in assembly.
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Helge Deller <deller@gmx.de>
Suggested-by: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Signed-off-by: Alexander Potapenko <glider@google.com>
---
arch/x86/include/asm/string_64.h | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/arch/x86/include/asm/string_64.h b/arch/x86/include/asm/string_64.h
index 9be401d971a99..e9c736f4686f5 100644
--- a/arch/x86/include/asm/string_64.h
+++ b/arch/x86/include/asm/string_64.h
@@ -22,6 +22,11 @@ extern void *__memcpy(void *to, const void *from, size_t len);
void *memset(void *s, int c, size_t n);
void *__memset(void *s, int c, size_t n);
+/*
+ * KMSAN needs to instrument as much code as possible. Use C versions of
+ * memsetXX() from lib/string.c under KMSAN.
+ */
+#if !defined(CONFIG_KMSAN)
#define __HAVE_ARCH_MEMSET16
static inline void *memset16(uint16_t *s, uint16_t v, size_t n)
{
@@ -57,6 +62,7 @@ static inline void *memset64(uint64_t *s, uint64_t v, size_t n)
: "memory");
return s;
}
+#endif
#define __HAVE_ARCH_MEMMOVE
void *memmove(void *dest, const void *src, size_t count);
--
2.39.2.722.g9855ee24e9-goog
next prev parent reply other threads:[~2023-03-01 14:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 14:39 [PATCH 1/4] x86: kmsan: Don't rename memintrinsics in uninstrumented files Alexander Potapenko
2023-03-01 14:39 ` [PATCH 2/4] kmsan: another take at fixing memcpy tests Alexander Potapenko
2023-03-02 11:18 ` Marco Elver
2023-03-02 14:48 ` Alexander Potapenko
2023-03-01 14:39 ` Alexander Potapenko [this message]
2023-03-02 11:18 ` [PATCH 3/4] x86: kmsan: use C versions of memset16/memset32/memset64 Marco Elver
2023-03-01 14:39 ` [PATCH 4/4] kmsan: add memsetXX tests Alexander Potapenko
2023-03-02 11:22 ` Marco Elver
2023-03-02 14:14 ` Alexander Potapenko
2023-03-02 11:13 ` [PATCH 1/4] x86: kmsan: Don't rename memintrinsics in uninstrumented files Marco Elver
2023-03-02 14:27 ` Alexander Potapenko
2023-03-02 15:13 ` Marco Elver
2023-03-02 15:17 ` Alexander Potapenko
2023-03-03 14:14 Alexander Potapenko
2023-03-03 14:14 ` [PATCH 3/4] x86: kmsan: use C versions of memset16/memset32/memset64 Alexander Potapenko
2023-03-03 14:17 ` Alexander Potapenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301143933.2374658-3-glider@google.com \
--to=glider@google.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=daniel@ffwll.ch \
--cc=dave.hansen@linux.intel.com \
--cc=deller@gmx.de \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=geert@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox