From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36527C64EC7 for ; Tue, 28 Feb 2023 11:45:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9FC86B0071; Tue, 28 Feb 2023 06:45:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B4F946B0072; Tue, 28 Feb 2023 06:45:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A180D6B0073; Tue, 28 Feb 2023 06:45:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 921156B0071 for ; Tue, 28 Feb 2023 06:45:42 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 4E9C6121334 for ; Tue, 28 Feb 2023 11:45:42 +0000 (UTC) X-FDA: 80516520924.22.F8D6123 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf22.hostedemail.com (Postfix) with ESMTP id 209CBC0005 for ; Tue, 28 Feb 2023 11:45:38 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZaRF8wl6; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677584739; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=H5JSzEqI0/+afD06RNG2Om4rCq2fsM2EzEdhgaq5IcA=; b=IN3nZzKGuuGB8B+45vutquKV2vfRN0IJd1R9Js15rnt8GAZxbvEHscpnMmai36aBzEHw39 uyg/nM2Rds4TkUFxERcrzeEtne1B5/CsiM1za6lIrZNegWEFJ5cpsI1BHqgJEBmHhsCqGL CZlCwqFEn342QfyDPlvxyLGVGtXtf2I= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ZaRF8wl6; spf=pass (imf22.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677584739; a=rsa-sha256; cv=none; b=7jtf7mbaXGO7c333W3zMOP+ltIXo4oGWFO2sJ/NQKNVzM29YHc+utUMEMLsmFvVA59JEDs dIQUdSdLoVDRZgH/FVfTwddgYtzWOr+8969CZB2B5CkQKsy+Ns98j9Wet5c1rGroeNkR73 r3/6hkprHAUBwqKj7usLIJPfdBORVUA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677584739; x=1709120739; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=LVg3sGlt00QgG3sEB9rSq0uJyw0mKZJvOIL+heEjZDw=; b=ZaRF8wl67lFgz3O+mPM3gr6urllNSsdRiwuBroVgcLCuupFyhiOqAeKn EgRmCtUXVnFZwpyPyHzDWUs3i570rdv2/HVwkMILcZwmJLrY1FWm/I4kb Bl5XWRkJWVaOh+KxSfN7eyZvXrVmPshFzlX9+lqQCg+bNThbrDDNE/3pT wA10YG6mtNbgBD0azyMDJhk7lHw6RoFsbPjnzuA41mD/pLhRUYss3KUNa RAuNubKo3ue2j9lB1CI01/keDcCzdmJL9wnTRnJKoNh7ObRv6xZrrVGbd orMtOxjSIwU85wO58x5Zb7NWd+CLCtAnFUwL6ngljR08GHzBWXZ4c+qfN w==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="332841398" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="332841398" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:45:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="783805950" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="783805950" Received: from lkp-server01.sh.intel.com (HELO 3895f5c55ead) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 28 Feb 2023 03:45:31 -0800 Received: from kbuild by 3895f5c55ead with local (Exim 4.96) (envelope-from ) id 1pWyQE-0005Mt-2S; Tue, 28 Feb 2023 11:45:30 +0000 Date: Tue, 28 Feb 2023 19:45:25 +0800 From: kernel test robot To: Yosry Ahmed , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko Cc: oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, Yosry Ahmed Subject: Re: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim Message-ID: <202302281959.EmOJaeae-lkp@intel.com> References: <20230228085002.2592473-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230228085002.2592473-3-yosryahmed@google.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 209CBC0005 X-Stat-Signature: w3yxck8i77rtwso84rofktkgqhp9xjht X-HE-Tag: 1677584738-299715 X-HE-Meta: U2FsdGVkX1+ttxi/A/FHolu+Yl58LYWydSWBBLu7xkC6Dpy9zDkhvRIg9ahZTmuRwhALw/I+tU5wx4bn480aoOSAmMLfeRjewcg40zEqt6ln12ZrS7+6DiLglK3W5haDHODXTyBeyQFyCcpWY1cks8lzbZCq/U1CjP9sKXFhX/FI65ma8iAP2Zj/EYpnZ8i3O8kE/3U4OJt+Og676vDKn5gOKZlugj2quUzNDRZxsE3eaCGqvTcPNCi2wYCf76zgmbBv7fO2M8yIsqquIT+JZR96vgIzxITcLmsibM0FhHzaXhrjHBt0NnDS/jtXFtOw/QmIp1tLWfiFZg6yVQG8ZJT36c52ejpMhxiS906lTVmiTEDDZAiUbSi75s2MdHZsUvPbk4YFxdbBm+YBII91wJ4VVDA5w7Hnz3fyxncXcYQO37wRBc6UTOhzvYH/ABzv4bkWJivQcZwZxHt9zLj1SnY/dUiSgVitw/1AvRc3vlP7k2lQB7mr5PPmyfsRxHPyOcs2hciMmEEgxhfLdjW1xml6lHwFj+1AAFg/vHhGzE1dqsI/XzIDhE6Ziswis9aBW4FFVzUuPNSkr59cnj73ysV96HCXb7VVTc7X6wWpnkXlU7VxGwPTvJDk2qdX8iPXHPV7kZH0tNuMTqTmL54Yz+/4x4xELJvmM2BIGLI3luLAGoXPWp9DM7Cl3VmkCtVEfW9sh+t0OBOBlrvyQQhcCPJByfkMYCApzi656xs08sctEiYBR5MMS8n5BhK860F3MXx1p0RiQ3PVe74fgZf233/rfP6MFmPLHhCbuDJktRKA6X9KzewiEARtGoxri/2VcuI0kaC12ux1b+jLsiIiAxKDDOCO89lKc6X9yo9oD8j4DjGzi/gTJlFYpe4yb3IsF+LOoVjqtELktOvc3Alr3fwGQApjQNfOwjpmocvfFwJ+Q5j2Uz8oSLwfT4uk7vSvMLH7YM2kaAc4ZSs0+pj OLYfZqo8 Ky8rUIkLpePw+tN8/5nxmNVA+HsC+M1Cf8dMG4qUJuiBw+ctn+54bYJasaaPO2ki6+dCKWi+vSWj5Mp4W7TQPSaBhbCDX7DYnsceOjtUhXWFUYGT8v7Y0XPdwx2B+hoNbgEcebcY1h/IWTZNLrwwwW9TOZEoye5PZf9e4z/P37bRRIRr2ktAbSrqhnvUuJZnNqP2PtgbPct3cBUVK33OJ7zzAGXBOAskphHGr2VJk5HWp2NsVwCt7PO6B+r0eZbY+GinN+5TP0glphgdGrL9mLVc0I17l4lKqSYXjW5ZIeoGCtvOoEzBWEJ3GYSxmNmPGqkXDIbGe1Fh8pEPeVBxJpxj2Vr6gXaZaiq+KfV1IISbn+KwPpcdBoWXg+TNA0xguV2tEGGKihHOXypV/GOcjVTrq0HmBOP08Gtc/n2rXHBCSg3nHKK+4BXKPFvfM7YFuyRF0QNl0G4HtagTE5xMJqE/IpfGalzfE7jwRDsrJYMpJxLg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yosry, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] [cannot apply to vbabka-slab/for-next xfs-linux/for-next v6.2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230228085002.2592473-3-yosryahmed%40google.com patch subject: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim config: x86_64-randconfig-a014-20230227 (https://download.01.org/0day-ci/archive/20230228/202302281959.EmOJaeae-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/f6d2b849f186a927925a29e289d60895048550f5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 git checkout f6d2b849f186a927925a29e289d60895048550f5 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202302281959.EmOJaeae-lkp@intel.com/ All errors (new ones prefixed by >>): >> mm/vmscan.c:549:13: error: redefinition of 'cgroup_reclaim' 549 | static bool cgroup_reclaim(struct scan_control *sc) | ^~~~~~~~~~~~~~ mm/vmscan.c:191:13: note: previous definition of 'cgroup_reclaim' with type 'bool(struct scan_control *)' {aka '_Bool(struct scan_control *)'} 191 | static bool cgroup_reclaim(struct scan_control *sc) | ^~~~~~~~~~~~~~ >> mm/vmscan.c:554:13: error: redefinition of 'global_reclaim' 554 | static bool global_reclaim(struct scan_control *sc) | ^~~~~~~~~~~~~~ mm/vmscan.c:196:13: note: previous definition of 'global_reclaim' with type 'bool(struct scan_control *)' {aka '_Bool(struct scan_control *)'} 196 | static bool global_reclaim(struct scan_control *sc) | ^~~~~~~~~~~~~~ mm/vmscan.c:196:13: warning: 'global_reclaim' defined but not used [-Wunused-function] vim +/cgroup_reclaim +549 mm/vmscan.c 86750830468506 Yang Shi 2021-05-04 548 b5ead35e7e1d34 Johannes Weiner 2019-11-30 @549 static bool cgroup_reclaim(struct scan_control *sc) 89b5fae5368f6a Johannes Weiner 2012-01-12 550 { b5ead35e7e1d34 Johannes Weiner 2019-11-30 551 return false; 89b5fae5368f6a Johannes Weiner 2012-01-12 552 } 97c9341f727105 Tejun Heo 2015-05-22 553 a579086c99ed70 Yu Zhao 2022-12-21 @554 static bool global_reclaim(struct scan_control *sc) a579086c99ed70 Yu Zhao 2022-12-21 555 { a579086c99ed70 Yu Zhao 2022-12-21 556 return true; a579086c99ed70 Yu Zhao 2022-12-21 557 } a579086c99ed70 Yu Zhao 2022-12-21 558 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests