From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16B03C64EC7 for ; Tue, 28 Feb 2023 11:56:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7A0186B0071; Tue, 28 Feb 2023 06:56:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74F8A6B0072; Tue, 28 Feb 2023 06:56:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 617616B0073; Tue, 28 Feb 2023 06:56:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5364F6B0071 for ; Tue, 28 Feb 2023 06:56:41 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 2F51BA13AD for ; Tue, 28 Feb 2023 11:56:41 +0000 (UTC) X-FDA: 80516548602.11.25DE52F Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by imf24.hostedemail.com (Postfix) with ESMTP id 434B5180006 for ; Tue, 28 Feb 2023 11:56:38 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=H3P5vdUz; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677585399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OfrdSrcCi+pPUbdWTdV7t6yad+vlldndtLGZIOBbtjQ=; b=C4HSdju30K7pU94z0bEmPy2n/zfpxoOdUV+cUniITNsaG59ogMzUabnDJsNDfSCCOk7JQD XTjKiw9i15+9SXzetHD6SoyaAGAO/d3s2i0d4Vyhtb6LECdADHS6cVHtAJKNuLehu2gF/l fCeeTPDuqURksQ8xLE8zb0Y0S2BNLpk= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=H3P5vdUz; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf24.hostedemail.com: domain of lkp@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677585399; a=rsa-sha256; cv=none; b=Ena+rTJLR6LT++DmQQrXCf9ItSZQEWoD0b5DQTCqSKhaSm5m4zirTzpVnz0k2DX4/M/2Ft 79seiFDw3cK//ftBGtXCWeetf3jiBJTmlIO+22au4cOQi+QicFmnmtPlIHCmNJXjUJzKXQ cjxoY+CAVjPlCszUZio8gOohYGxcYKo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1677585398; x=1709121398; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8KXKh05zvvXmBiBlla6UAU9gMBZihB631H77fNyc5ms=; b=H3P5vdUzX8xV5XDmW86ijLgdLhRCMPqGhxnKYWWPPgQ4OwOHTJXFx/Wj Z4n29Wey9pFJ/iGY9LK9jiU7UBuLvI6uQw9llzq0pPQleJIO6DMvAB/FR /OqvVft96P0NP6Q78asaWLBB3nhYQUaXMxk1af8VsThMqo3JyXLujlcTk tPeFws7onYBP1+kSch9qkzvHk6Ql56K6wkSxZJQveebn/H73zsJpIldmf wFGgXXDk1ZLY/juBltm/OuplWtPVThnbvyj/pgf6AwXC5rGyboO9bT8+I OjbEiOdfyHVlgKhUc/SkYNSb9TwEeh6sdHvXf/dZGHZZU8nxMun0OPxnh Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="314540203" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="314540203" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Feb 2023 03:56:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10634"; a="676272332" X-IronPort-AV: E=Sophos;i="5.98,221,1673942400"; d="scan'208";a="676272332" Received: from lkp-server01.sh.intel.com (HELO 3895f5c55ead) ([10.239.97.150]) by fmsmga007.fm.intel.com with ESMTP; 28 Feb 2023 03:56:31 -0800 Received: from kbuild by 3895f5c55ead with local (Exim 4.96) (envelope-from ) id 1pWyat-0005N9-0F; Tue, 28 Feb 2023 11:56:31 +0000 Date: Tue, 28 Feb 2023 19:55:36 +0800 From: kernel test robot To: Yosry Ahmed , Alexander Viro , "Darrick J. Wong" , Christoph Lameter , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, "Matthew Wilcox (Oracle)" , Miaohe Lin , David Hildenbrand , Johannes Weiner , Peter Xu , NeilBrown , Shakeel Butt , Michal Hocko Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, Yosry Ahmed Subject: Re: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim Message-ID: <202302281933.vU1PHuZr-lkp@intel.com> References: <20230228085002.2592473-3-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230228085002.2592473-3-yosryahmed@google.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 434B5180006 X-Stat-Signature: q9hbjchbk4k5dcnb9zy8de8prbfabhks X-HE-Tag: 1677585398-446872 X-HE-Meta: U2FsdGVkX19C6HK14rNL0v1CzAkjjxCmk+nit2YXH2cQqi4hdtmF6P5yQaLc8TFyH7rzZu+mI5vz6REpixT/PoBDk0RlsKmDbRqXf3fIUPe3fy2fk+eCin34h0W07TYZxgJm0g9xMuvfYX5p2y5npjauD47DHfi1csV71yaVRv/xyMiSb3E/J1PSEDRxewf3PVuZ/slz4MJHF2SM6lW6XHZSvvfTrENPoeUc4/PyRGv59M92V3YiEjX/Puo16nW52sYFU99SzJkHRC9vpZMEihlr2wYaMJLwhU0B5ACEJwvu0v5rNzMrF5+z9oOcHtnkgfX3SVmoYMHRoKo0trsRiEMFrZoJXexnmuqc/dh7N9pNIg7v3HDBEDTxV2Q4OIyrjBQuBRxfCUDHSs6/B4PQpjXmHOMXVBjSUZkxWdiMZkT2Lxm7hc38MC5Zzktiy6pY5v2fvLGVYiSVwpp4zRHcngybnWJseJ3PoQeXpa2w2HWFwoUBPzVtmh0obvlvacnf8oUKJrqWB6Hvdrw6HVyEbefNcADdHZgYswemDYYmjQCxXUL6T5kLqp2aYbT1Jqa8K2Z5Y3n7bion2FFgq8+ankfB1DXtl6P5eeUQNHulc4YGtr53CociTME7iGpe+b4FY3SmRfUMrgakXwDti9lnBC4Y6m2OS2vV3JYXCMQ7mf86RwMKjNe2TM1tFqtHNmwJ2dS4f9cWKqoFg57ilzFPWL+wmJaa9fme3aG5m/dAZyAOdliShfEJ2GFiXqXS/YqfqW1z7X9Don1XkNTf94qVe0+lZnE5uDT0Ts9GVKFPsdaNHzKHsibJN6VRoNAXgU7uw205IGSEpSAc/HVePSY1eSyGziMzI6xA7fa6E5Z6L57Pugs/PvapIGkcvBemAoFD/ood55Hr8ZWuDuc4ymi1Gtdyv2E77YN94deQmc5HCwdF12/pEtxoYLqD6+JtyoDkpzpvKhILx55VXV0FIoD thoF8jed 62kjSIs/fTeFStnB+u/ZxlRpzhh+U+DN6oK75MAuLxwCCVJRYZ8Jp+jPw2+3mwlmKLs7kol0NpkrG15sIDiJpeXC2mmgtRa1tkkAjvpAv64ijtMYtvZxztXk3Ig7sZfq5G1153nBLC3GsPup9eeo9X1uNt+3dlceDlmFBEssizE/pma30qROp5UzM+4nHZAfu4faj6Xw/Iw8j/anIOjlzu+HzKDNXiQf9m2h+d1Xe0IhPEqpVyrxTZ+ekJJMgApZkaNpuiSNAsXo4pxgVnGf+PM66yv65s6Fi7/c5d6RX9PBCrx0HN2JwI+JyknQYOw9k+QEv4oVsBXm1HklDlmztfsUU9Ud7d9jb7vT4mBUIX1okplDGDAKC8AcffqncwdmcU3PwommNHlrBfUT0aI3S3d7JE6iB6SUcmIv1qBKHvwcPgk0QtSiY/U/SSPAXM4miK802hmEFvRaR3578YHvMC9X913bKlz9EeM54Z3o8daEuT2EelR/gILbudzqpOYHjlyS4gdYthUdqbH5A8/A9S29eWiUbXAwVO52W X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Yosry, Thank you for the patch! Yet something to improve: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master next-20230228] [cannot apply to vbabka-slab/for-next xfs-linux/for-next v6.2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20230228085002.2592473-3-yosryahmed%40google.com patch subject: [PATCH v1 2/2] mm: vmscan: ignore non-LRU-based reclaim in memcg reclaim config: i386-randconfig-a002-20230227 (https://download.01.org/0day-ci/archive/20230228/202302281933.vU1PHuZr-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/f6d2b849f186a927925a29e289d60895048550f5 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Yosry-Ahmed/mm-vmscan-refactor-updating-reclaimed-pages-in-reclaim_state/20230228-165214 git checkout f6d2b849f186a927925a29e289d60895048550f5 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Link: https://lore.kernel.org/oe-kbuild-all/202302281933.vU1PHuZr-lkp@intel.com/ All errors (new ones prefixed by >>): >> mm/vmscan.c:549:13: error: redefinition of 'cgroup_reclaim' static bool cgroup_reclaim(struct scan_control *sc) ^ mm/vmscan.c:191:13: note: previous definition is here static bool cgroup_reclaim(struct scan_control *sc) ^ >> mm/vmscan.c:554:13: error: redefinition of 'global_reclaim' static bool global_reclaim(struct scan_control *sc) ^ mm/vmscan.c:196:13: note: previous definition is here static bool global_reclaim(struct scan_control *sc) ^ 2 errors generated. vim +/cgroup_reclaim +549 mm/vmscan.c 86750830468506 Yang Shi 2021-05-04 548 b5ead35e7e1d34 Johannes Weiner 2019-11-30 @549 static bool cgroup_reclaim(struct scan_control *sc) 89b5fae5368f6a Johannes Weiner 2012-01-12 550 { b5ead35e7e1d34 Johannes Weiner 2019-11-30 551 return false; 89b5fae5368f6a Johannes Weiner 2012-01-12 552 } 97c9341f727105 Tejun Heo 2015-05-22 553 a579086c99ed70 Yu Zhao 2022-12-21 @554 static bool global_reclaim(struct scan_control *sc) a579086c99ed70 Yu Zhao 2022-12-21 555 { a579086c99ed70 Yu Zhao 2022-12-21 556 return true; a579086c99ed70 Yu Zhao 2022-12-21 557 } a579086c99ed70 Yu Zhao 2022-12-21 558 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests