From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2661C64ED6 for ; Tue, 28 Feb 2023 14:24:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0048F6B0071; Tue, 28 Feb 2023 09:24:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF6DB6B0072; Tue, 28 Feb 2023 09:24:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DBED66B0073; Tue, 28 Feb 2023 09:24:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CBBEE6B0071 for ; Tue, 28 Feb 2023 09:24:28 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 884D1408D0 for ; Tue, 28 Feb 2023 14:24:28 +0000 (UTC) X-FDA: 80516921016.24.2FAC14E Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by imf23.hostedemail.com (Postfix) with ESMTP id B3715140007 for ; Tue, 28 Feb 2023 14:24:26 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QDTuqN8j; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of error27@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=error27@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677594266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=hlBi5awhCP+gPf2l9TBqOitrum6hLos29GmQuuua0y4=; b=JQz9A5AyeHOX9Ye8RTOn5C4qzruhPvs6EA+eh4fDcyjl9TIKdqX2bPDwf8Hcrpne5dUx3O IjKAGdg+e5lRoACUm+1JiZdztvIqEQvCp5p0AEYYZ/hJAkVGam2T1On4p9+JupkF4GVQK6 H7IbVBdAgMSu0AeLUGoWWVkh5Ixlihc= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=QDTuqN8j; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf23.hostedemail.com: domain of error27@gmail.com designates 209.85.208.50 as permitted sender) smtp.mailfrom=error27@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677594266; a=rsa-sha256; cv=none; b=XqERSE3JvFqWGdBZUCO2UGYk8koYBYKUZ0JhryiF/cDup0p2CoCCjQiTnK1LVRDIOSzo1i 4HMjgjIkQ5lKzeT9aoFmWsCAXmExiSyBxCPMJ9euiMGDMn3xpifPtEI4kcZyBqO1vbfKjv Z6uZ4/Gn8mdSukvNC2MvM2eD27/Al30= Received: by mail-ed1-f50.google.com with SMTP id o15so38230795edr.13 for ; Tue, 28 Feb 2023 06:24:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=hlBi5awhCP+gPf2l9TBqOitrum6hLos29GmQuuua0y4=; b=QDTuqN8jQtLj7eXjOQvRvymlcpQCPFZnoFc+FvqSxJhPBt+IOVLf15r8t+NryZAPdE tBdM7B+6cQori5/oFKo/1ZP3ax+WrcMY9XGsvaiBtCLriqsOZMv6jRqeE0kQZNQsCNMq ZDXqJh/9OyHjmxvQke3tz9EftAF29MWM5NLx2FE9Ag7XEyUcW8GnIcpNxuPMawJJtZgB cRquCfyEYa6d1FM/FdSSc64um1P3M0mvlutKmo/a6f3NIQfdUyG7R4IDtsp+bTpZRZFt b58Jk6b+yKxKTOBSUSUK3hp2kwJ7Kq7wslceW882ezAjsiDT10KnFYOoky1wl7YE5s5Y bZ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hlBi5awhCP+gPf2l9TBqOitrum6hLos29GmQuuua0y4=; b=wVxGJEXpJ2vDNaE4YZXRskeHQWIPkIg3yYtWg8F6pEftOfuzyMVU5xBPEurHbyNnJE Bt8rDV3TE16oIoT3m/NQ3OGWzOPx9Ck/YZoIXXEqXAVPt9ZRs5D6AGiQ9p+Pd30hj76R PA61pDqal170eGfMWSnROrW58gq8ROJ2oH2xJDFtHcvDdoBhWCB5D1xEJfhi50VJoq85 iKZUpFHpmVIwgbEwLh7kYl/yTuLveUiutWYXXziftqHY9MqkFq+dPYIGwADJ88MhuD4y ckUyZ3+T43yq/URVGx+dM6iS3oCwgDx67v78H0lPy3qWXlpgxY4+WHZKJLm4ok87TxhD Fl1A== X-Gm-Message-State: AO0yUKXhis40K3VlmwwyPunMdHmmL9nvW7ubbQnF/v1ldBR6kx1TqhKf 3If1Pw3dQZJWDZ8BhGM8OGo= X-Google-Smtp-Source: AK7set+oyXFS60VGC3QQYJGcFF7II1bH1tG77O89utRLWZE9PGBZhepGqowGtnrIVK39Zr8o8f+qwQ== X-Received: by 2002:a17:907:2163:b0:8b2:7534:265e with SMTP id rl3-20020a170907216300b008b27534265emr2664161ejb.58.1677594265103; Tue, 28 Feb 2023 06:24:25 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id d15-20020a170906544f00b008f89953b761sm4482402ejp.3.2023.02.28.06.24.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 28 Feb 2023 06:24:24 -0800 (PST) Date: Tue, 28 Feb 2023 17:24:20 +0300 From: Dan Carpenter To: oe-kbuild@lists.linux.dev, Suren Baghdasaryan Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev, Ammar Faizi , GNU/Weeb Mailing List , Andrew Morton , Linux Memory Management List Subject: [ammarfaizi2-block:akpm/mm/mm-unstable 82/99] mm/mmap.c:516 vma_prepare() error: we previously assumed 'vp->vma' could be null (see line 505) Message-ID: <202302281802.J93Nma7q-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: B3715140007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: z7eg7ht18m58k714dtjdhrdzwpazne68 X-HE-Tag: 1677594266-467972 X-HE-Meta: U2FsdGVkX1+VgLDNP8UqQNhm3wxCO3ClvN8qPgtNEuVFj317r/S2L7DLCaZEb+S3pBdLzdp1uzwTxBVPSijPQO21aFV/VG3d19wGaJyFxfrWUlFmrp3Z0/jgfJO3/Z69rP1fSfQKEgcfsOj6qhVtnqBp6LEmdMQbNZbu9xkJTatSf3Do+odpbTdiaS2eeCNWNvYEqzi5zTdzOHfmwKSGOxgnGbtZbsPODF0ILCE8dQyPfAtvVor5qH35VIUK3t9+bCNmpz3rt0Wo2lx9+eiSJWs/lJ4EVuV81o8ZtjPYUuhl2rvjYw+G7NBbjuPqi8DJusBIWC7lpX5ivXJHrNtFBEQnz9XCytzuPHNcynrRuHnl9/BI5WXAKy4TbUhr3fSiXIfgBXSXUSHTVy9AJKJYKRl2vuGHmJsCyATJuiK88CGYsb1TkiEg/D3cc7bV+bgU1OO+DC4kLvVkTniGz/O/0JKyweeiIKDNIo/wad59TeDCOuN4yJdeuyScUv5n+wgOAj5C789jQgdOyXOlRAKCVjoZ1IvVhDFQlIVkHZwpQxsTT6Cdy7CgZJbqYvEheCTFSj9QoAA4NWVUiDQO41bcl1mUeenTRx1QRuNDWMC2M55jCafvSZyKlfvngEPj15blzJWmBp2smK4BoRR5JzLf4fByjwcR3I2bXMeb/aU8s4EwHqZFEg+oEUZLXfrn/UZlqeyR/NerTJbb6RfRyQRZHtAfIMPVVX3XXAuXqO4MzP5fcKPLcZ5yR/zsq6Y3p5XGFB8m2uYYP3zxY7gblGzLo0eYA3mVUN3ThWSDo/ihwAxrFeUPn+4e+XUbNXM1g2tj3P4tvQRX+SOD7KW9l0XUu0iqiLrsHKClIZ1DMTyJd1ovn+VlA2SL00AQ2GtBgtOW9s9bt+YvA7PYT4TsG4pC6L+Rq1SpoTRCNutMYGgn/8r5UzRH83OM9CvdeNYXNG0eEXNA2B4OYk/Cdiq8I6x 9aOW/sYm ab1pGZ+wYFT+4+5aN3/cpj+ryhcioGTW8Su+f5xwfHauXv3fvWKuyxWDqXjKfhINYwkUFeA2cdmA0cOps6FZyL67j4AehHcsRagIXWo+7RXY+YtsdcAakteXy4ZnHVvUrUxBW4ErChwFhQgTfiOC2MDOZ6luX/HGIBIjhIJytBcP7/cGrSJm72s73PDZ9+XwN4hHsLn2Q66XHrSOq7hPzgvyvh3wGS0SRch2G7w5wA4+oZECztU9F3VTm7h/Yl1xRrLxUG4Q4e+R1V2WGhC2nY0SsHeRTRjOu44FW7V7WT1BQinHXBlmq8RKsfXRbsCnXoGcanB0IXYNokobm0iWIPgAax8uKbikS1EK1tL1WuCllSW+TEeYG8MXvniJ7SO+WGKha4WZALmETtgcqXspBzIFucCeQEMFtczpfyWt2ZnNlbdJ+WIESl8uZaCX2RJfIyiLyrikn+kA4YFMuZCTmOOFXqNJSvMmh3C6/6eJYQlKcfONezr2LtxZha7/AsWo4hReibaCBNcOBJ/L6jdLDVDcvbd3L5Im0vHL0LNUmg1O3I2C5A4pL2GUAw69JbsA7yV5TuwXXiyYbpOSdHk1TbA+X3gZOiZXoO4QM3Tzc3F3BArT3tWCPSw33eJDPZSbf4i4GZOhF/JoflKE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://github.com/ammarfaizi2/linux-block akpm/mm/mm-unstable head: 61edd3b68c3185673c9b05dfe48038692964c73b commit: f517f7ae341d933856cdf4d9d773027681ed5dff [82/99] mm/mmap: write-lock VMAs in vma_prepare before modifying them config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20230228/202302281802.J93Nma7q-lkp@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Link: https://lore.kernel.org/r/202302281802.J93Nma7q-lkp@intel.com/ smatch warnings: mm/mmap.c:516 vma_prepare() error: we previously assumed 'vp->vma' could be null (see line 505) vim +516 mm/mmap.c 440703e082b9c7 Liam R. Howlett 2023-01-20 503 static inline void vma_prepare(struct vma_prepare *vp) 440703e082b9c7 Liam R. Howlett 2023-01-20 504 { f517f7ae341d93 Suren Baghdasaryan 2023-02-27 @505 if (vp->vma) Check presumes that vp->vma can be NULL. On my other system (with yesterday's linux-next code) vp->vma can never be NULL. f517f7ae341d93 Suren Baghdasaryan 2023-02-27 506 vma_start_write(vp->vma); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 507 if (vp->adj_next) f517f7ae341d93 Suren Baghdasaryan 2023-02-27 508 vma_start_write(vp->adj_next); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 509 /* vp->insert is always a newly created VMA, no need for locking */ f517f7ae341d93 Suren Baghdasaryan 2023-02-27 510 if (vp->remove) f517f7ae341d93 Suren Baghdasaryan 2023-02-27 511 vma_start_write(vp->remove); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 512 if (vp->remove2) f517f7ae341d93 Suren Baghdasaryan 2023-02-27 513 vma_start_write(vp->remove2); f517f7ae341d93 Suren Baghdasaryan 2023-02-27 514 440703e082b9c7 Liam R. Howlett 2023-01-20 515 if (vp->file) { 440703e082b9c7 Liam R. Howlett 2023-01-20 @516 uprobe_munmap(vp->vma, vp->vma->vm_start, vp->vma->vm_end); ^^^^^^^ Uncheck dereference. 440703e082b9c7 Liam R. Howlett 2023-01-20 517 440703e082b9c7 Liam R. Howlett 2023-01-20 518 if (vp->adj_next) 440703e082b9c7 Liam R. Howlett 2023-01-20 519 uprobe_munmap(vp->adj_next, vp->adj_next->vm_start, 440703e082b9c7 Liam R. Howlett 2023-01-20 520 vp->adj_next->vm_end); 440703e082b9c7 Liam R. Howlett 2023-01-20 521 440703e082b9c7 Liam R. Howlett 2023-01-20 522 i_mmap_lock_write(vp->mapping); 440703e082b9c7 Liam R. Howlett 2023-01-20 523 if (vp->insert && vp->insert->vm_file) { 440703e082b9c7 Liam R. Howlett 2023-01-20 524 /* 440703e082b9c7 Liam R. Howlett 2023-01-20 525 * Put into interval tree now, so instantiated pages 440703e082b9c7 Liam R. Howlett 2023-01-20 526 * are visible to arm/parisc __flush_dcache_page 440703e082b9c7 Liam R. Howlett 2023-01-20 527 * throughout; but we cannot insert into address 440703e082b9c7 Liam R. Howlett 2023-01-20 528 * space until vma start or end is updated. 440703e082b9c7 Liam R. Howlett 2023-01-20 529 */ 440703e082b9c7 Liam R. Howlett 2023-01-20 530 __vma_link_file(vp->insert, 440703e082b9c7 Liam R. Howlett 2023-01-20 531 vp->insert->vm_file->f_mapping); 440703e082b9c7 Liam R. Howlett 2023-01-20 532 } 440703e082b9c7 Liam R. Howlett 2023-01-20 533 } 440703e082b9c7 Liam R. Howlett 2023-01-20 534 440703e082b9c7 Liam R. Howlett 2023-01-20 535 if (vp->anon_vma) { 440703e082b9c7 Liam R. Howlett 2023-01-20 536 anon_vma_lock_write(vp->anon_vma); 440703e082b9c7 Liam R. Howlett 2023-01-20 537 anon_vma_interval_tree_pre_update_vma(vp->vma); More unchecked dereferences. 440703e082b9c7 Liam R. Howlett 2023-01-20 538 if (vp->adj_next) 440703e082b9c7 Liam R. Howlett 2023-01-20 539 anon_vma_interval_tree_pre_update_vma(vp->adj_next); 440703e082b9c7 Liam R. Howlett 2023-01-20 540 } 440703e082b9c7 Liam R. Howlett 2023-01-20 541 440703e082b9c7 Liam R. Howlett 2023-01-20 542 if (vp->file) { 440703e082b9c7 Liam R. Howlett 2023-01-20 543 flush_dcache_mmap_lock(vp->mapping); 440703e082b9c7 Liam R. Howlett 2023-01-20 544 vma_interval_tree_remove(vp->vma, &vp->mapping->i_mmap); 440703e082b9c7 Liam R. Howlett 2023-01-20 545 if (vp->adj_next) 440703e082b9c7 Liam R. Howlett 2023-01-20 546 vma_interval_tree_remove(vp->adj_next, 440703e082b9c7 Liam R. Howlett 2023-01-20 547 &vp->mapping->i_mmap); 440703e082b9c7 Liam R. Howlett 2023-01-20 548 } -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests