From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B163AC64ED6 for ; Tue, 28 Feb 2023 09:34:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FD636B0072; Tue, 28 Feb 2023 04:34:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AD3E6B0075; Tue, 28 Feb 2023 04:34:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39BFC6B007B; Tue, 28 Feb 2023 04:34:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2B5D46B0072 for ; Tue, 28 Feb 2023 04:34:13 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 021CD4138F for ; Tue, 28 Feb 2023 09:34:12 +0000 (UTC) X-FDA: 80516189544.26.2CFB7BC Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf03.hostedemail.com (Postfix) with ESMTP id 2EA9920017 for ; Tue, 28 Feb 2023 09:34:10 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="kUEbZG/k"; spf=pass (imf03.hostedemail.com: domain of jolsa@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jolsa@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677576851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kIiOhB5XFH9ASOjhyNBa5Jjx1HYWCL1nsx7TAIeuG+s=; b=NNa1TRbTFxl5VyLz9Y2bnfxqEFEE2nJoHZC8DpXyEUIJ7H1cK8t3eHhWCFRQ+wKQlhQGO3 xXooH1oCgMZib8uQ6h8OMV1/GrAHTJ5g8lU2B5N4YKr86PtRAxUkpEt1wn6InDBkcFuuYW E2F6tF8AYtGRFcvPXxpSgq10IPl1JQI= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="kUEbZG/k"; spf=pass (imf03.hostedemail.com: domain of jolsa@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jolsa@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677576851; a=rsa-sha256; cv=none; b=vFFJTKciEhNhypSlNoswjumi6DAH+fHgSFUCGu/fk5gPj9MR31i+tBY8uEfwgz+OoKjtdz MFONSij4yPjN0/TZhx7vfnZ2Y0bT+pOEiKI+NBZA0V53JoYcGxm+Qob8zEIHREqn34uNLv JDzETXhuJuN2MhNFBG5oFO9UdgeKVDQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B2330B80E19; Tue, 28 Feb 2023 09:34:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 555D7C433EF; Tue, 28 Feb 2023 09:34:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677576849; bh=GuLnU0d3k2V6ZdWnoPW82USn52Mxiiw398+O8RnbxjY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=kUEbZG/k7LV/1mLXHeWWy8ByEFwfH8vr4ZFgj6lyjUX85YnoF9O+2SNLVfQ+BFZCK /C8zbSyBs0+Fgcg9S3mJ2CLktdsdjmUgSUhzqdyNcv7ycvIZ0OCbJwonyDI4shyNV5 ftTQF6r5HRAVPTY6qSwaMbTC+jiQDAFlvQxjT/tlM2rrxAwhsV4dC4XBD980wAL+mb tJpPPKnthTlBdWX5SGZewGddSsBTsAMcdvfZrdMbLb3WEcdYd1omjU9JoHFl2ZgqeI OJuG5BHYKrQ+D9+Yy/tYafMvA1FOw/NB91C6UneYdz+M7WN7WxroH3DaZIK9AeKVf7 ICF2YvbB5G38w== From: Jiri Olsa To: Alexei Starovoitov , Andrii Nakryiko , Hao Luo , Andrew Morton , Alexander Viro , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Matthew Wilcox Cc: bpf@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Daniel Borkmann , Namhyung Kim Subject: [PATCH RFC v2 bpf-next 9/9] selftests/bpf: Add iter_task_vma_buildid test Date: Tue, 28 Feb 2023 10:32:06 +0100 Message-Id: <20230228093206.821563-10-jolsa@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230228093206.821563-1-jolsa@kernel.org> References: <20230228093206.821563-1-jolsa@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 2EA9920017 X-Rspam-User: X-Stat-Signature: kpqcbhxcdb5zrf5uy6399sxot77g63ae X-HE-Tag: 1677576850-751112 X-HE-Meta: U2FsdGVkX1/ZKlZ8XQ55WlivuWhwXuZM5hZx5qqh+8y1peHzGReoLodd1wKlNBsc91kxDw1v3W9f4CwYqzdTDqZVJD7UBbRm//gAEReURg6M3GxC8ZtbOmbTLcTXxVVqXr/hoFJ4Eb96D3xpd6n7XjAHyPnLg3tE0YtWX+0fzjDEws5pG5W1wLpKsVSlt/U3FKuVra0nsqMtTBjGUGQlYrSV6khPwcsVAIe9LeEB9c6vk9MYUnoja4Z9rdbSqpxeOnsplcmDA3JrUqaGdhi/H/tnE/mX2rZWyTyCu4KLPdp/MGugAAm3gqcTogJWAajDvCq0eb00efz4cfolnM5xmwJrg6e7cZdaqOeILQ0DkmD+V3i34un1Yz0meD7YR31vSZ92wz15z0mFo9bYWZpWecVuhz1QgkGzG8GTm1Fc+jNkD8SiZGgN0nDnvqDweAOyrcmZ1tzj/v4qO/t8OzKeQ/90WuSlSe6iOxILWqtD9QZJYrWBw5V/gGFLem3ukurSsPStSpAQnzOqRUucpGzYqJ27ru0p4ZtoIUpCiAd1I8lhsF4Opq7uY2oBm51hhwuqjmqCMOvAYA3+AwDGDvbj+Q+wXn+DgIwpk44e1WKhRh7SKT5Yo+tTq3DwlFRZWxnX6Z5jdyYQI5mRrpbctEH2r2HfOFZAt791a+IcLJ9eSqi5yNayhAGvyPJjVPHoIfcpXpFS0oz3LHZwTe+/CLzxXbDlWrnXEaQHx+1PA9wMoyRNA3aNCwSo2imWKSC1vW3XyzVhWNDv6G7PmsFLdvnHUaJP+7oQPtMBeI58T/4TEe64BMuLfR38LaWxl5hQDSrgO0h67niCnCeG+CFfd0Mf9dcAy/TnqOmsqaM6CoOAejtvlpaCkLfjWhJ0WXf7TydHd9LB/gR5CgNjS64OvjWrLVhsZbwS+f8lMzAwYhJ5ehIprS12vf/DHIFBiXTRgV1yarLO7413uXe6W1qRDK+ oncvRRM+ 3SRbXqRH0hMJrAbJJQsXSTWwFHcZaeFCQS3zKvpWjCeV3Oi586rVBgjk5B2PlZOJXD9fos0eWWDIOqZIfxeR+U6Vzrxox/OjcneHPzrJPQ1igsyDVoTdZtLOZ3ek06WqVOKoUE+mN9BuqwIkHwCjAmXEGqVP7j/7Dqd13K8o5kj11YqCxDGjnQZEf6RVVgasJ2uLxUragejlaW0FWbJAcbAuSN3YJaeTAh3DLhqGOnC0x95ArPA+TM5unncrq2eVcBUpsTRvG5VQ83vNqbkzqi8XCxQ5E/3C0JfT7BRhuAkEU1b8Lwo0PCeSrnGSLEmFdSw0keBXZtQRToZPtboKcuAKMWwc6JF0lytjCXNUjlMGfBJS5zaJexzpHD9y6ndNIY9ueKPQHi6urfvM2xdY0+mKDZuOoch179BxNBDn838gEgizATVO5cN4zBXIb/g1reKXMHnFJfgLi4zSdMmGYvczMLtye5zDp9El2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Testing iterator access to build id in vma->vm_file->f_inode object by storing each binary with buildid into map and checking it against buildid retrieved in user space. Signed-off-by: Jiri Olsa --- .../selftests/bpf/prog_tests/bpf_iter.c | 78 +++++++++++++++++++ .../bpf/progs/bpf_iter_task_vma_buildid.c | 60 ++++++++++++++ 2 files changed, 138 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c index 1f02168103dd..c7dd89e7cad0 100644 --- a/tools/testing/selftests/bpf/prog_tests/bpf_iter.c +++ b/tools/testing/selftests/bpf/prog_tests/bpf_iter.c @@ -33,6 +33,7 @@ #include "bpf_iter_bpf_link.skel.h" #include "bpf_iter_ksym.skel.h" #include "bpf_iter_sockmap.skel.h" +#include "bpf_iter_task_vma_buildid.skel.h" static int duration; @@ -1536,6 +1537,81 @@ static void test_task_vma_dead_task(void) bpf_iter_task_vma__destroy(skel); } +#define D_PATH_BUF_SIZE 1024 + +struct build_id { + u32 sz; + char data[BPF_BUILD_ID_SIZE]; +}; + +static void test_task_vma_buildid(void) +{ + int err, iter_fd = -1, proc_maps_fd = -1, sz; + struct bpf_iter_task_vma_buildid *skel; + char key[D_PATH_BUF_SIZE], *prev_key; + char build_id[BPF_BUILD_ID_SIZE]; + int len, files_fd, cnt = 0; + struct build_id val; + char c; + + skel = bpf_iter_task_vma_buildid__open_and_load(); + if (!ASSERT_OK_PTR(skel, "bpf_iter_task_vma_buildid__open_and_load")) + return; + + skel->links.proc_maps = bpf_program__attach_iter( + skel->progs.proc_maps, NULL); + + if (!ASSERT_OK_PTR(skel->links.proc_maps, "bpf_program__attach_iter")) { + skel->links.proc_maps = NULL; + goto out; + } + + iter_fd = bpf_iter_create(bpf_link__fd(skel->links.proc_maps)); + if (!ASSERT_GE(iter_fd, 0, "create_iter")) + goto out; + + /* trigger the iterator, there's no output, just map */ + len = read(iter_fd, &c, 1); + ASSERT_EQ(len, 0, "len_check"); + + files_fd = bpf_map__fd(skel->maps.files); + + prev_key = NULL; + + while (true) { + err = bpf_map_get_next_key(files_fd, prev_key, &key); + if (err) { + if (errno == ENOENT) + err = 0; + break; + } + if (bpf_map_lookup_elem(files_fd, key, &val)) + break; + if (!ASSERT_LE(val.sz, BPF_BUILD_ID_SIZE, "buildid_size")) + break; + + sz = read_build_id(key, build_id); + /* If there's an error, the build id is not present or malformed, kernel + * should see the same result and bpf program pushed zero build id. + */ + if (sz < 0) { + memset(build_id, 0x0, BPF_BUILD_ID_SIZE); + sz = BPF_BUILD_ID_SIZE; + } + ASSERT_EQ(val.sz, sz, "build_id_size"); + ASSERT_MEMEQ(val.data, build_id, sz, "build_id_data"); + + prev_key = key; + cnt++; + } + + printf("checked %d files\n", cnt); +out: + close(proc_maps_fd); + close(iter_fd); + bpf_iter_task_vma_buildid__destroy(skel); +} + void test_bpf_sockmap_map_iter_fd(void) { struct bpf_iter_sockmap *skel; @@ -1659,6 +1735,8 @@ void test_bpf_iter(void) test_task_vma(); if (test__start_subtest("task_vma_dead_task")) test_task_vma_dead_task(); + if (test__start_subtest("task_vma_buildid")) + test_task_vma_buildid(); if (test__start_subtest("task_btf")) test_task_btf(); if (test__start_subtest("tcp4")) diff --git a/tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c b/tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c new file mode 100644 index 000000000000..dc528a4783ec --- /dev/null +++ b/tools/testing/selftests/bpf/progs/bpf_iter_task_vma_buildid.c @@ -0,0 +1,60 @@ +// SPDX-License-Identifier: GPL-2.0 + +#include "bpf_iter.h" +#include "err.h" +#include +#include + +char _license[] SEC("license") = "GPL"; + +#define VM_EXEC 0x00000004 +#define D_PATH_BUF_SIZE 1024 + +struct { + __uint(type, BPF_MAP_TYPE_HASH); + __uint(max_entries, 10000); + __type(key, char[D_PATH_BUF_SIZE]); + __type(value, struct build_id); +} files SEC(".maps"); + +static char path[D_PATH_BUF_SIZE]; +static struct build_id build_id; + +SEC("iter/task_vma") +int proc_maps(struct bpf_iter__task_vma *ctx) +{ + struct vm_area_struct *vma = ctx->vma; + struct seq_file *seq = ctx->meta->seq; + struct task_struct *task = ctx->task; + unsigned long file_key; + struct inode *inode; + struct file *file; + + if (task == (void *)0 || vma == (void *)0) + return 0; + + if (!(vma->vm_flags & VM_EXEC)) + return 0; + + file = vma->vm_file; + if (!file) + return 0; + + __builtin_memset(path, 0x0, D_PATH_BUF_SIZE); + bpf_d_path(&file->f_path, (char *) &path, D_PATH_BUF_SIZE); + + if (bpf_map_lookup_elem(&files, &path)) + return 0; + + inode = file->f_inode; + if (IS_ERR_OR_NULL(inode->i_build_id)) { + /* On error return empty build id. */ + __builtin_memset(&build_id.data, 0x0, sizeof(build_id.data)); + build_id.sz = 20; + } else { + __builtin_memcpy(&build_id, inode->i_build_id, sizeof(*inode->i_build_id)); + } + + bpf_map_update_elem(&files, &path, &build_id, 0); + return 0; +} -- 2.39.2