From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D591C7EE2E for ; Mon, 27 Feb 2023 11:39:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79BE96B0072; Mon, 27 Feb 2023 06:39:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74B0B6B0073; Mon, 27 Feb 2023 06:39:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 612826B0074; Mon, 27 Feb 2023 06:39:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 523576B0072 for ; Mon, 27 Feb 2023 06:39:30 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 213301207A7 for ; Mon, 27 Feb 2023 11:39:30 +0000 (UTC) X-FDA: 80512876500.01.909C003 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf30.hostedemail.com (Postfix) with ESMTP id 3C3E180006 for ; Mon, 27 Feb 2023 11:39:27 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=n9aLASAR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iIiM1+yC; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677497968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YVS14n0GDTqfvhRA+DP8X9hCVpdLZuTQ0R/ZHuFyhHk=; b=QtHxB7YyABwYFQpQZv1/k5zZUcN48opQIRT78wi+85WK5F9p1iagxI1qPtlHjsum2mKXZH OmDGywZqLVJ4idubY22xN2YWQ+7HFrGVbJwvT2W2jKSniwA7KbjwEIfST+5oWF2gBJChwW jD1f+F6Jkl42zwo+RwYgB9PX2LIy7Oo= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=n9aLASAR; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=iIiM1+yC; spf=pass (imf30.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677497968; a=rsa-sha256; cv=none; b=l4lOkVlwwiQ9me/QEHXanOO7oF3Ge6uXbDSdZEn55l61t/D6FSOkIFpQPeLyDTIEAScBFa SEwnNuLUOoeoCya/NaqtBPfLR1xcUpLHi4ACctc+1ZhZfAMuoL3pleLVrBQX/IrUwUx/4O fo+VT2ocptOyMf+J6Vc5QqYwdFAkRq8= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 99A0A1FD66; Mon, 27 Feb 2023 11:39:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1677497966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YVS14n0GDTqfvhRA+DP8X9hCVpdLZuTQ0R/ZHuFyhHk=; b=n9aLASAR6XYYsnsQl4uCk6uFdI2Poqw6c2vZmNpT94ZZ3Ln0hMBldkdmHWMF1J7/1FVso0 g+w1W0l0C5YNVkU4T1Z6ee8e/rW50WLsvIhGHOHMgEzKRkjyNM/IRzer+GSEaHvBz+wfGA tRViFUZE+/1DuVDjvx4JOriqVmg4XyY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1677497966; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YVS14n0GDTqfvhRA+DP8X9hCVpdLZuTQ0R/ZHuFyhHk=; b=iIiM1+yCY3dv21mDMtCWRBzWY2xBiCqOKRsOmmehFtO2idcscrGzhzOISjySgjDwXpNrwd J6xeyFSdtAiw7NCQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8AFEF13912; Mon, 27 Feb 2023 11:39:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TezkIW6W/GM4IQAAMHmgww (envelope-from ); Mon, 27 Feb 2023 11:39:26 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 178C0A06F2; Mon, 27 Feb 2023 12:39:26 +0100 (CET) Date: Mon, 27 Feb 2023 12:39:26 +0100 From: Jan Kara To: Christoph Hellwig Cc: Jan Kara , Dave Chinner , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, John Hubbard , David Howells , David Hildenbrand Subject: Re: [PATCH 4/5] block: Add support for bouncing pinned pages Message-ID: <20230227113926.jr7wuhmiul7346as@quack3> References: <20230209121046.25360-1-jack@suse.cz> <20230209123206.3548-4-jack@suse.cz> <20230214135604.s5bygnthq7an5eoo@quack3> <20230215045952.GF2825702@dread.disaster.area> <20230216123316.vkmtucazg33vidzg@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 4antetcp8r8xzpmejzf7etxa3nw87mn4 X-Rspam-User: X-Rspamd-Queue-Id: 3C3E180006 X-Rspamd-Server: rspam06 X-HE-Tag: 1677497967-642833 X-HE-Meta: U2FsdGVkX193t6UDdo3Y4Hs7HdlgQ1i618TaDHh4bxiX4KqLS38FbosjlnWxBvFGcRhfEIlU7S2VVzTb8OFSm4PTcC6D7cQFgf1UoaT1jUWEfl9WQBhLv+Pqd1EMVOl9ABRXq3Dh+OrH74r4wUQ6aG1y0PsLlKYXCSsAaHx/er0/xWSfUnZAnNjEBbpMoaYxsGTPFuvrZxQuzt+UaDvyy9dl6cmCH1tqF95gqqv3/k3UOzErDFAY/++uuDvAxilPkoCzzzoIUMlXvAYpeTsdB5+P9qM3alHho8h8ETiUdQgbU/U4xD8fe7LplD1RggndC/s8tQnu/O6NONju7oMowbMh0JoAE4b5c4kWeppv42OU33u0hvwd5Azc17fzr6DTY/cXPzzqumyG4fLPiRiBSoOiGwTmG2NA3HpMujLx2lfocfwBUz6DOdbbnGGaoPMPgTCip+B0+B9qRPouMpy5sW8wvvnCPNsbjvCP9d7Vrx0DLfJ/3TZQ2cq0fG77O7ihQpYNtSqsf+z2IcwifC2OE8sniWA6I7PCZOWXEv5F8fytwiNec76cx2imFsYlErqCxK+FE41oQxJYfQioVNoyg9rAm8EXLVLXXMLXq7TOy8X/+tQatxDVspejWNHDPRz+gdrOUMwrRXtmWre6RR8ZLUnPmc2x2iyrmcUds4I7+vqVJ0fzdYUauTs6ip676iR5mOnGlUQcAFWieiAcfNm3eLkoedBXEpzprjwetga54hA+t1ZBXarz5fOt/aRVxAjKK79LehWEFPdhSYsZ3AnCRP3VlOqdBwxcyr+AIWFhD1Eeq5wViDqGEoam9jtwwjGOJnHqtmj4YX+lcJIdwcoa/XuJlIGqruRdyLPYFYxRgxDMtKAMPLZwruF3l8Vpf7doIk7qDeuE8H2fpsZv4NhmhclZR6Pwp3mkBpSaGp6hB7WVtwqt2eithuliH1m3Ku21bUtMcymo+mqi1h5IHgo zReXgeJz vU606STIbSrb8Zp6S9mrai5iVVjGHBcz7ppq87ms07uGnrF8m7FfuKPJrJUPxs+snAoP2Nfxowv5oXxVTFRENI0CqlJBEyCBwQ5JJ+KIQJ+zSWdpX+iCdr9v52WIIfjyqfgFNWIASzGo3mlLAeq7qln9p5Zf2y0rh6ibAhYykLm2I6XS8WTYdFUG1zzqrbQdfCymzKHbZvQppAWIOeccxiRgdRrGivgBWTUbhDh/xStz6HWgMmLsMpAChfEDZ1Fvc3LWi1a5fi0Fw3nI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 19-02-23 22:22:32, Christoph Hellwig wrote: > On Thu, Feb 16, 2023 at 01:33:16PM +0100, Jan Kara wrote: > > I'm a bit skeptical we can reasonably assess that (as much as I would love > > to just not write these pages and be done with it) because a lot of > > FOLL_LONGTERM users just pin passed userspace address range, then allow > > userspace to manipulate it with other operations, and finally unpin it with > > another call. Who knows whether shared pagecache pages are passed in and > > what userspace is doing with them while they are pinned? > > True. > > So what other sensible thing could we do at a higher level? > > Treat MAP_SHARED buffers that are long term registered as MAP_PRIVATE > while registered, and just do writeback using in-kernel O_DIRECT on > fsync? Do you mean to copy these pages on fsync(2) to newly allocated buffer and then submit it via direct IO? That looks sensible to me. We could then make writeback path just completely ignore these long term pinned pages and just add this copying logic into filemap_fdatawrite() or something like that. Honza -- Jan Kara SUSE Labs, CR