From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AB2BC64ED6 for ; Sun, 26 Feb 2023 23:56:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A155E6B0072; Sun, 26 Feb 2023 18:56:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C49C6B0073; Sun, 26 Feb 2023 18:56:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 847A76B0074; Sun, 26 Feb 2023 18:56:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 71A4C6B0072 for ; Sun, 26 Feb 2023 18:56:22 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 373D3A00FB for ; Sun, 26 Feb 2023 23:56:22 +0000 (UTC) X-FDA: 80511104604.04.10A50BE Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf06.hostedemail.com (Postfix) with ESMTP id 4841318000E for ; Sun, 26 Feb 2023 23:56:20 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=Mk9tRRfW; spf=pass (imf06.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677455780; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZRz1s/KRyO2Uxle7inVvqWM+4+Zegth9BIYrB8VHgJo=; b=5Ho3y5AXphy3ZK0muP+en9ktPgAw1ry+ltShE44Ixb8+YRUDTdc1iW+327pYdLV6WFNrRW diPpHmU/d5XH5Ufn7/R61KpcmHjRNaQmyl0BdFvxO0cWKG0EUEbqu0rk3BJirOs+Md6okl IOrSBpJnysgB7Urq7m6A+mayo7QX6Ks= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=Mk9tRRfW; spf=pass (imf06.hostedemail.com: domain of david@fromorbit.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677455780; a=rsa-sha256; cv=none; b=2kogWOdDgXOdzyYNOVGeAMZkke9GboTA4oFXwSYn3Z5zXCc+GL+NGAucuZZTF013e06EPQ SSHZR2PyLxUxi5+smHCIhxsN6UNnYQgSY6lPA3I9mzS+1+n3TJueQRhTW+bVNh3+APxvKd ys/phvLLUUnUZbIFEINtJ4YKjeTj3Rs= Received: by mail-pf1-f182.google.com with SMTP id u20so2492852pfm.7 for ; Sun, 26 Feb 2023 15:56:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ZRz1s/KRyO2Uxle7inVvqWM+4+Zegth9BIYrB8VHgJo=; b=Mk9tRRfW308oYU3sLQ9yDdi2b3JL5istzYA1UAT00A3pKm3FAvG/xGqJ5/miW1RysM /CqsMcjdybw8Bo9iiRVpNU4Umt6d5Gt9dh5zmiVrlCp7366v3Ujk/vxERazGT2EObXDs E2ROzMGJwFWIVc/swERCL/ssQ2fhO90sCYWSVt1gUFeIUCyhCIHM4BDpaJn9PMlH+CTW Upx+Na8pZmYuq4FwymuNcI8m2JTDaJmk4E8oui+2O4xDj3fWiLc1QFoWfPpoYniyuSoI qsEGgGD9WGutpkTiQ3JcoO3/2xVfqOozEew6jMBI54emEqIMDlChsH8cQpY7QSG4Os5Z lG2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZRz1s/KRyO2Uxle7inVvqWM+4+Zegth9BIYrB8VHgJo=; b=UUsBue1BiAmDkCgR/x+hBM0PLORRHWVy9hU5S07EHi6QiabSQFNY9dhQ3sk9e5U+4c 19VTlAH4QceUgHOU/fjdg/RIKW7hgVcNkYTs4clJ1D+lH4yMfNoaFZJ+L1J4S342jamm ZOMyRFA6iepwJ7pst0vwcRLXh9raBdjL/Qy75cf2GiB10fbe5cmMWuuPR6Fmk/KcbWZe RpGbn3Ns8DHqWjRAjGOqXsfBSeQLT7B+fBbWYgw0cXpu1dB7Jb3FTvO+bQN8pFREbugW ENTj6oHExjsUVspaaGHxdHtAM3rvGCRTbn7lqZOOUJgJcHTOy+UINDcTVF0L0diiCuaz y7ww== X-Gm-Message-State: AO0yUKXMjNIV9iQbQ0OCYp42/Ei5ZbMO3n9x0HsChZ3yh2grgQpp9NWV dYxLV9roty6bcOhKVlfYoFXUWKmxfdwE7jdm X-Google-Smtp-Source: AK7set9nFy4/f6XcyXZVPqFl639UstSp++qbIKME5kqRCmc5ElckiPp+IUv8d1xCQl78ZiAXr5MTlg== X-Received: by 2002:a17:902:eccc:b0:19c:387c:bd65 with SMTP id a12-20020a170902eccc00b0019c387cbd65mr28220861plh.10.1677455460789; Sun, 26 Feb 2023 15:51:00 -0800 (PST) Received: from dread.disaster.area (pa49-186-4-237.pa.vic.optusnet.com.au. [49.186.4.237]) by smtp.gmail.com with ESMTPSA id d13-20020a170902aa8d00b00198d7b52eefsm3129186plr.257.2023.02.26.15.51.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 15:51:00 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pWQnB-002WaD-LN; Mon, 27 Feb 2023 10:50:57 +1100 Date: Mon, 27 Feb 2023 10:50:57 +1100 From: Dave Chinner To: Shiyang Ruan Cc: linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, djwong@kernel.org, dan.j.williams@intel.com, hch@infradead.org, jane.chu@oracle.com, akpm@linux-foundation.org, willy@infradead.org Subject: Re: [PATCH v10 2/3] fs: introduce super_drop_pagecache() Message-ID: <20230226235057.GY360264@dread.disaster.area> References: <1676645312-13-1-git-send-email-ruansy.fnst@fujitsu.com> <1676645312-13-3-git-send-email-ruansy.fnst@fujitsu.com> <20230220212506.GS360264@dread.disaster.area> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: snxesiofg4xm8gebzpkoete94kjm6djo X-Rspamd-Queue-Id: 4841318000E X-HE-Tag: 1677455780-208503 X-HE-Meta: U2FsdGVkX19FSnImh/IqVOAn2F0qrNzXhCmzkejHJgNxQp/SV+8o3iWVGbSa0gM2c3SZ+FVkXIrjlGmpqWzxarC23p8TkGntjoL1gf10B3ikA2AYu6UY3P12zlVer6MM6IlEt2fl+ldkc/4cZGNLTJcCvasNwI3BciKvVA2ZF1W4IAQQ4uz+aYExn7Td3PH0R83cP1uBlLN4Sch/cj/PDYM2BJmg1ssLUSExKTOohejTLoNXjQbDgOxF2g9+ZjqoJnN5OrwRXY2KtSC/5R1PnNA+Wwgajlajfep4NRzXnh1T8bEowdSO4sBSX210XmBDfsuGS0dSIOivd2UN+ypvwZQjJ3TZJHjiYEZSDIr361SmSGLoUJLsNlR1VViH9bc0LwinQu6FX3SHhviWcAiUJOuOSIvmOmrXOQxGYjE3kvYZx+9i9Hv0vO4Nc67l8B2G4/4+nlsSh4J/QCpxUhTY5kdPO9+DsjJgqZ0uG7ZGV2D4z0WpUHi9Cn3YOTZ7LzcZeZ2MqNvYydH0rKivpxebFexGEFhWscYJ4SNgvuEiP4hLci+oNdYq5at40jwMDYwIpwbfKanHAuen7D37VKJEVEF3Il8Cs6zIB+A27hp9m9cM5S31tXyuMpikt+KW4f+lH8RCD6KbAqioHV/mEny+02u4wFbRjaO4XteC3RCNt8f9YgcFZ60pK1EPGvcLsGsjyHN9w5xSK6p9OBK4kg2SySOptbhTVVpFt+td+z+jE/ye6dfDu/KKlRxMmRxM0dIlI7gLPIytwGlj0narQWVq8vrdiutBB6QdWnhHd5nXnARuHo43cNwXLyxFs8/BCj98DYfe15Bw+024DRMgXhQxNpdWd8eGdFkOcVMDQf8IysETQItNskue4adDf85qLithqVVNy+tGcYRJi285xCBdklNp6NHBrPd7B3LcX8+ZnBcDy7zpadyMu93BPgoXdG6C/pDvBdmh19Q59PIFHwW VNleSr+j PqDb8CLb+rHXWKJV9p2T2eKhv5x/AK+7i7130bbJKH8eseQbUKoR04g+vF5KmXiq1fZyHa231BTVXwBJb0EpVPZ8/fMl5H5VmsazJ+g/2EbUEyC46DawSrtQUIO5cfm2fvDN9ofesjNJzWRk2atfm4WsqGn8QTWxXnbZa2cphnBbH0F5f2ofOBNH0KhSwHHsddwwcTVmMgkBowmWp7KMBpUIVp9UhZlPG0snow8ZNp6hqlUNbIWrJ36U5D+mrqAC4pSZO5XT4e1JcKMY8aE1bZmfb5ZdMyKwTBp+VQP8rFhAqWugFuvPqZdtbMYKUnqP5Lg1NvF2nZJct77jelIdWuQHWyRZU1fnzbtmdLRwWYRfsj6YxjOWtftXCQhVCgMjFc0Cwkkew7FlfuWo6Y7dIz5+GO9A+uX5UM16SL2CuMLy4v8LG+myEfB2OLcBgWRE8vVcEb7soHS7SrufbXA8AMOUUbj1hE8EePH93QH9mnitFaSAXKQrsvtwy94YkUWO5Yjay49yHxoHIxwIEL5IVJ9IRWfE4cH2Pl8RRX9OTX9MNdvsIisbABcfU3VBrVQEQL8u7SAL+nxn6Oz0dKqaBd/QFCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000398, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 21, 2023 at 09:57:52AM +0800, Shiyang Ruan wrote: > > > 在 2023/2/21 5:25, Dave Chinner 写道: > > On Fri, Feb 17, 2023 at 02:48:31PM +0000, Shiyang Ruan wrote: > > > xfs_notify_failure.c requires a method to invalidate all dax mappings. > > > drop_pagecache_sb() can do this but it is a static function and only > > > build with CONFIG_SYSCTL. Now, move its implementation into super.c and > > > call it super_drop_pagecache(). Use its second argument as invalidator > > > so that we can choose which invalidate method to use. > > > > > > Signed-off-by: Shiyang Ruan > > > > I got no repsonse last time, so I'll just post a link to the > > concerns I stated about this: > > > > https://lore.kernel.org/linux-xfs/20230205215000.GT360264@dread.disaster.area/ > > Please see patch 3. I changed the code: freeze the fs, then drop its > caches. Neither the patch nor the cover letter have a changelog in them that mention you changed anything. Please, at least, keep a change log in the cover letter so that people know what has changed from version to version without having to look at every patch and line of code again. -Dave. -- Dave Chinner david@fromorbit.com