From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C9ACC7EE23 for ; Sun, 26 Feb 2023 13:17:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B13B76B0072; Sun, 26 Feb 2023 08:17:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9BC56B0073; Sun, 26 Feb 2023 08:17:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9151A6B0074; Sun, 26 Feb 2023 08:17:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 7EBEF6B0072 for ; Sun, 26 Feb 2023 08:17:04 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1C2B21A02DB for ; Sun, 26 Feb 2023 13:17:04 +0000 (UTC) X-FDA: 80509493568.30.05A9808 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by imf04.hostedemail.com (Postfix) with ESMTP id 56FB140006 for ; Sun, 26 Feb 2023 13:17:02 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Cw96/L1R"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of ivan.orlov0322@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=ivan.orlov0322@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677417422; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=4MQkzTFY7oFLk7HS5mTlDP6H3MWtlVl305nioGoqUIs=; b=TP9CJ+9gWsecsGB7o+BS2Va/0zm5kUYetYwyLyW2rOZzJfk9JgBObu9Wn+RqXeoh5RWL+B zNEBdauwKAatOAiz5Tt80srkTESL/JUY8Vj5Uwe3dWY/0gixkNGzuOQ82C4ZzhN4b3YBJU wZ1gSxuH80S+zKUafBNkcinEUQhiQmQ= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Cw96/L1R"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of ivan.orlov0322@gmail.com designates 209.85.208.45 as permitted sender) smtp.mailfrom=ivan.orlov0322@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677417422; a=rsa-sha256; cv=none; b=1IEh6HvcCF7w0Kx1sj8bi2TuLCdqQ9uqURUNcGY2v7cW3wuD2cL7AU8fX6nvDVgfNhio5c am+93R388oyUe+0kmPFGTXFBa31N68qquDkCEdYNfyjOMIBbPNjuIc8184Hcf+inhjhtn1 J0vVXAbB84t4kaEaeKTyEZ1rTR1ksXM= Received: by mail-ed1-f45.google.com with SMTP id h16so15226471edz.10 for ; Sun, 26 Feb 2023 05:17:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677417420; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4MQkzTFY7oFLk7HS5mTlDP6H3MWtlVl305nioGoqUIs=; b=Cw96/L1RHzMm7Iwoev/iq9NQQD4j4GnUH9LI9hf0FsI7wpXOyF7SPk8t4sj26swyzx NoiuVoyttuLYzz6AkKaKAxzFsgN9YUejX+v/ekVf8Lt3h7MJYwNVH1SqG2XSo8NYCdlg OtUI1WZf2hD8ndAhpOM+BAOjCp10hXvhXrVmiwWsI7LnC3kwhrcVfsTa/u9vbkTGukNL Htl/vGkWLNa/aPzZOaw1WBlsiOeVy5wJ9T0+Tr+uWMisrEBBZ5Wqwfr6tsnjga9Los6O x4PJoNWIOeFMjvXEP+/GvphKdLQcqlNsifDVayI5uePvFO70xyMmJC2L/mb0Wagx6bHh vIBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677417420; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4MQkzTFY7oFLk7HS5mTlDP6H3MWtlVl305nioGoqUIs=; b=MjyV0DsSUHOkeiQO0Wocc6Ig2d3PgTqCnaTlrSH2Vd8wzboNsbazb5R6NmMsfFfP97 U4cOWf4QxssJiYWrByuSIoSPnGTmER00fras7OIKLmobEGc6n8CGslzYlNM9rzxSS3cy 9ZTJx6O+UtFIJbNUKFI5G5rkXUl+KVU++OMljnleE+/cumyJV8lZM78Oz8hquaUbuWY1 RNjpAD+B1U70QVc/5IS+ur/Gz93yZKyw2nJZH7HHkZHdg83FZNDVfarMu/NPdcZmSPtB NhIuJfMa9avRLJ3I9oCKSX5IL9nMZmdx4PC7ntsDtU76Tcyjn3vpeXJ9wZERgkSqFEuV ubjA== X-Gm-Message-State: AO0yUKUUgZQcYDwEmAeitBXrrOGo0jkjNWZ9OwTgwNZlveFIeOUAfcLD 90q2LY9dU1hUmZ35XhF1T60= X-Google-Smtp-Source: AK7set+eUagH/xey6K9nUkb+yayfzAZAtxqqWU//2CxFZ/bP4zU9yXjY1lC0f4dAaOA0Pe2LN2C+/A== X-Received: by 2002:a17:906:256:b0:882:bffc:f2d2 with SMTP id 22-20020a170906025600b00882bffcf2d2mr30458808ejl.2.1677417420590; Sun, 26 Feb 2023 05:17:00 -0800 (PST) Received: from mineorpe-virtual-machine.localdomain ([37.252.81.68]) by smtp.gmail.com with ESMTPSA id bq7-20020a170906d0c700b008c5075f5331sm1957965ejb.165.2023.02.26.05.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 26 Feb 2023 05:17:00 -0800 (PST) From: Ivan Orlov To: hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, tj@kernel.org, lizefan.x@bytedance.com, shuah@kernel.org Cc: Ivan Orlov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org Subject: [PATCH] selftests: cgroup: Add 'malloc' failures checks in test_memcontrol Date: Sun, 26 Feb 2023 16:16:33 +0300 Message-Id: <20230226131634.34366-1-ivan.orlov0322@gmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 56FB140006 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: k17ptgkezkduxw7biwn9m7a3sk5mxcxo X-HE-Tag: 1677417422-610846 X-HE-Meta: U2FsdGVkX19WwcQt+vnQpP1ME0EcIgQ66pr2kpnocA8YpQziurOaZZ+wI2MMQTQl+NKTseJYJItmR77yf2L4zu2HQ4MFBA645FayrtvssTDZ9f6Z6U52qxAS/06RaHqtQCkcFndnvF6Kr7sDvpPUS3/oDFbljBNToG88C8G5cxzYxLCVtdEiA1Q+xHEBxnP/ct+wkRSn4uTdLrD0en8h7T6WtB6CHdRCtZuin/Q2JcR1R3QWWWIIYk9wVhMv9FWVL8n5vRdQvZEILRhhaFHZIbKT/Tt0IpN5CXLL62R7eHvuZB/yiQ6lZhNBLd3Z2WeLCOikC7WnK68m27HgYpV9K63nQv1XlhFlwuaahwxS++IpqmdnI0ln8hVVFp1Ynd7Tt1rzVANAIv+90U/vBTC6KAtuR5CBx5E7m5scIoUi8cG7bIgzoF5EQ5p4ness85LEZT0wzC0MpfaSyC9U1yb0VR8vveEKd0A7iUvy9FRKtIS1KrP217hTnnaLa/i3ycZ2f2gdyyV3/v+cCMEkF0GFEeyxw7LE4WB6hYeUd1OcgH+/eeYG+NsqDNq/4Iztvap6xgmF+u7y45n9atWJjsH0x51CaKAVLwL9cPpyhZug8PlADY4lHchwIFD9gD8Fva7f7iYorpMHpGXmLyWObCV3jaEemW21zLXPqe/eQeTDUBgeyNFrp7MtgAcjcxePvEfuwS/keECjJrvxJVCE5CpEbyYKfHGYXwJPSrH1gm1evFsIVhXzEP8wBUxkebiUvGet5vW5oMkcKK+xYJ1JxFflnpWw2RSQI8d2/28UuK4oTY3GQ3j1y+eTdmDXqKHUtnYAXdmvqP1FFJtf+L0GHW8BvW/hQp4xrbCbKgwsQa98tMocuTNbgz5Cylmdi3rm9nI/1dLc8n3a/3C37z5bCuQlxjXYPA+ppqQsvAKK68PkTS4zxbQ7vB0IRmnUhT5rbOCeV5JUFR5p+NQgP6pBnoK K7F1fCrg tCYx8eD9liSMAL6/dnc9PeSFGq9RIJN+XSq10a2xDB0XMBEdes0kV9/LMyn+ZNQl7AR2uNQjTJQ9pbFnhzomS9qmFBWp0E7ugtXz9v7Zr8QApA7Z/F2490J3Z4//ifdrchnj8vcdvDjMgaLSli7qd0K2MFjPk8dQEWq2XSelCROf12Y09ZPVXm1ReX06OH7BLYwlH+E0dSrMbOCRVfcVKKFBktxlfyCURGc7WoyKdBPb5rAi3WT+RWxHqeh+LRwsbue+uHrsRS3jrdy8822GNXE1o75yFJTTwdFLo49zT5pcIJp1r7wsRPSUTobERT87YtdlsyXLrvTKsVtKVQRO2rSsKlrOG6kJ0USr1nifrnIXJRM1WXgOpIuhr0HFVvrTLlvav1fqVXNi8l0DefdN6Yo69jH7K90ZTVlrXVn7A2FMpLD/8aAch/zYTNuWmyBQv4VPh2M8hzsgIR6XVLy7RbqzdPxiome0RKL65ShtL5IqlMuQlRBwMOIRRhhtut6xl+kDPzAN6dwybpOmQGp9/0c1loskQsl7jbhvkHTrZDnFZOX4Mo8T40m+jrywiJN3rJznR1TGS0o/aG5Lo1Y3E005rRZWIaQQ+fz109qQxsXhGPcA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There are several 'malloc' calls in test_memcontrol, which can be unsuccessful. This patch will add 'malloc' failures checking to give more details about test's fail reasons and avoid possible undefined behavior during the future null dereference (like the one in alloc_anon_50M_check_swap function). Signed-off-by: Ivan Orlov --- tools/testing/selftests/cgroup/test_memcontrol.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/tools/testing/selftests/cgroup/test_memcontrol.c b/tools/testing/selftests/cgroup/test_memcontrol.c index 1e616a8c6a9c..f4f7c0aef702 100644 --- a/tools/testing/selftests/cgroup/test_memcontrol.c +++ b/tools/testing/selftests/cgroup/test_memcontrol.c @@ -98,6 +98,11 @@ static int alloc_anon_50M_check(const char *cgroup, void *arg) int ret = -1; buf = malloc(size); + if (buf == NULL) { + fprintf(stderr, "malloc() failed\n"); + return -1; + } + for (ptr = buf; ptr < buf + size; ptr += PAGE_SIZE) *ptr = 0; @@ -211,6 +216,11 @@ static int alloc_anon_noexit(const char *cgroup, void *arg) char *buf, *ptr; buf = malloc(size); + if (buf == NULL) { + fprintf(stderr, "malloc() failed\n"); + return -1; + } + for (ptr = buf; ptr < buf + size; ptr += PAGE_SIZE) *ptr = 0; @@ -778,6 +788,11 @@ static int alloc_anon_50M_check_swap(const char *cgroup, void *arg) int ret = -1; buf = malloc(size); + if (buf == NULL) { + fprintf(stderr, "malloc() failed\n"); + return -1; + } + for (ptr = buf; ptr < buf + size; ptr += PAGE_SIZE) *ptr = 0; -- 2.34.1