From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 317CAC64ED6 for ; Sun, 26 Feb 2023 20:38:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92D476B0072; Sun, 26 Feb 2023 15:38:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DCF76B0073; Sun, 26 Feb 2023 15:38:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F3236B0074; Sun, 26 Feb 2023 15:38:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 7092E6B0072 for ; Sun, 26 Feb 2023 15:38:19 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3426440149 for ; Sun, 26 Feb 2023 20:38:19 +0000 (UTC) X-FDA: 80510605518.09.3A5FBFF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id 3EE1518000F for ; Sun, 26 Feb 2023 20:38:17 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YWEJ8gUm; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677443897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hF0fGv6nI/itSoRvw1K2LcHCkJ9qqTX6e5Lj2hSQpac=; b=1Xf/yGgstad2ToEvDsqg/Oh+ArAQT39asiIq2G1okxhnDCYKhbFMSE9MOW0nSw3gsGasRT 8GrYNRBjXoe7imhSQ8TZcjr0Fk4X3mLKn4N0KWAjNJ1AsHgOP068qePM2MIHH6cSdHMxY5 ASuuR/xTY5Jn7fz+i8EgMG36O6vSvUE= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=YWEJ8gUm; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677443897; a=rsa-sha256; cv=none; b=58JCco3gbngOGQuNp1GqYCODah3XV4QAFCZLVIuKqoDEfAQmccyPRlen3ZM+JgWeEs4LN/ hQNZTfyux7k6A77V7da9O7LlxU21zWkyi7tPNGSz/Bpw+wEtOcmSYq34aO4greOLT9hUI0 Us4n0sRsCmRZfTFG1oBB10dSCbwxtgk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E91960BDE; Sun, 26 Feb 2023 20:38:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 418A9C433D2; Sun, 26 Feb 2023 20:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1677443895; bh=FqOwZ1KiLarzLNaFojBpikgn+mbiZr/mALVgv4DFdxg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=YWEJ8gUmujjdLDytk9zdHMjmjeElCaeHmxsa12Koi3PGWUd2pB3DTQqVapa0ss+rQ h1p412xVL07fLn/3Hcm3vLAX+7psysGjtNt9ABHd7ZUKGBLPykcXskslx3GP/gIwCN y4g1uH+SD8bOvR1QkjuQntUt06Y94C/t2+72WYvY= Date: Sun, 26 Feb 2023 12:38:14 -0800 From: Andrew Morton To: syzbot Cc: glider@google.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, willy@infradead.org, Nicolas Pitre Subject: Re: [syzbot] [fs?] [mm?] KMSAN: uninit-value in ondemand_readahead Message-Id: <20230226123814.1d9afb8c3de438155593c378@linux-foundation.org> In-Reply-To: <0000000000008f74e905f56df987@google.com> References: <0000000000007dcc0b05e91943c2@google.com> <0000000000008f74e905f56df987@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3EE1518000F X-Stat-Signature: q1dr8w9p6fzqb6miinad95bkcsgcpxdr X-HE-Tag: 1677443897-471961 X-HE-Meta: U2FsdGVkX184qNSVnkR/VGXFwmaTlkFsWaxaWAuyeWosUe/Qzx+qjFDM79l09dSo/vjAm7JbrvZ8MfSqVkMYDjbrruqXMLkPqlzvYRHizg9AGhG6mYp5+DJyWEAX9MYHCgjLiVTVA9TxIUvNA0mXer2S1rB1GIIrPuzyyV4jssuGacIAusgzobh8vFUkbBYjreXdeAiLZ5Eu6XKU4S3BCI/9Eiyvd9BpC6EP61l6unW/6hVcsC53DSlyufI78Zq3Ade4pNVq1mUWaOqVSfspTZcbnY7nT4u4zL07KjrxKkgCY7plqk1PSWUILoPC+ukkcc4Zfdj/8N8HCdsSBM3tlZNwAj/2C7gBkQrCGm28O5NYMeJ5q3cDQfsFSkGVaPUVLL4VJzHLJ6ghaiqZhOacgUmejWWZsCAODF/VW5y8PEhh5WsBOqw/uA3tzXzsQT7IqPZIqDnm2SjNBzz/8N5ScLS8PQGLbfI/1Wnb6zROFFfZC7QS/ezGLH19uSxEaC4OEg/29OZ2ZGs7Xu7VOQt/q/HzmOeWTOg92Lb1p2lZjZsiXtg/Nr6H/wHj0zWm+huPjYZqCag5FIGb3WbEeAPjD83EJ1dU/zXfjFQD8bkKCclv9jUO+eYpNMtL15zwSzAgnarspLSiUymEelgMD+zUpiek3jH6dbz6A7DydBkf0q3hRQ1Cm50J58e/1SiAjuuHrAenPo14yatHJYHBjDq7QdV03LG+ZH0WaSyqRW3mNO4XuymP/aBVw3dT/iWDTdhiQBGGdpXX66AQNNmgUgy6JBaXLuMVroyWTqxYNZgw4wz8MnMpi9n5B9/mQfgAgZdGAAk6RQtm2IDOVrT/tD3T3Xcaxjh2vuaEb/DSHcHRZLXK+YzC/qgQHbbowDlfGZH/JtdmvldgRmggBglKKjVU7jYvR5ftlP8BDGyYQCx/v7dNt/zGZHzPykxRdbPAKjD4JrhJBdTIGGAba7mSvLr aZi+hJ+C ZuFU/nY0NJko1S7Ws2aUfhck5RqjQwG4xjqELbWXzZPj1/M1v6/NjbalxlFGfIpmijI5q8DwVLbgXC3rE95QOxdxWskQVHxgUIfIRU3GdOwl8REa/xRyYNgmZbslEroCDh5b94z2MSr48I/f+83KEZqHZYG3t9lH329Hf6Cy9l/LHeEYd+20x+wa+pHdiz30ogoFy0EY/kY2F4WkPi8ycZqXybdvIJUKQXOI6DX2c0T68h9+Md7EtiESLjIVxkFvv0hdm6EaJustoGHMJdNf9bY7b8OjHYAqURpVhmiKGi7Ke0vHux8N4gcBbxlty8XMLGcuq0Po3VeJ5lq4goF0sl6c8XOO5R/sBIHFuQJMasIbHyF5E64wH6LQecQETq5pbFtLKiXdXTmJ/J8afcU9qH3PMuCcIXyfwYsrnM48I2LmE737ba0IrBJa8YFzvD1PxA/J1ZR6buQkgDziyfhXvB6M/E35rjQDzWBTsyyPHiiWCqOCDLKQhA6EnzVvdlGP4zSQ2elk8avTzA3bPJWbO/0Jg3j9yN9yVp4AFqpGCPuXe4Kg96Fr28EOy7m7yEE2H8OXsbALXv2S/BVcAGmYH0gZ4b9eEUahrhhShrcgYZqLhGLr7Oo0x+tPfzOcoqAqEdcBx8wIlRoRRGLg860jKlN145/z2OvD9pjzUBEi+kGVAPEDEzV0C3bg/a2dLpwRJUKLqbTJSrcWqDj2OqaOAnDSrdEMQsMjEzDkfug6pC7bsROz4otHh1wxqczHYfLl5KEf9M7GxwbSypRBODWKAJir+je0H8h+bE+tpicQ+JXAkdm7sUML1Yio6nNZI6nJ0ItW/OkE6yeJ/eem+zThhEzE4Ke96Q2+1FNlDE7Y5z00rtkx1yeTYMhS6xrk4RE7vpvw9kSiQiiJbi2QTULCl7vzxcrne6bNBFzTU8POUAYUgKYhEkItGM9Rk+ax/gi+txalMM6/su7Sj8Vit5IfW50ro4zcB Z5kicUJ9 uHpIG7/91L1+V+FQ45IEY0FEdfvno1p3X3kgQWOkz/e2dMHRXTbqDVuql/rC2lrtSiAX1/viSkH8du++d+1BgeMKjiODUplKfqGY3s7/CC+1wVGwc1FmhWCsd8sfZVpAyMxJkq1fVoey10tozToLyKRcWpeWrQBSeLgaWDdg4QMCf8ACaEKxwA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 24 Feb 2023 00:32:50 -0800 syzbot wrote: > syzbot has found a reproducer for the following issue on: > > HEAD commit: 97e36f4aa06f Revert "sched/core: kmsan: do not instrument .. > git tree: https://github.com/google/kmsan.git master > console output: https://syzkaller.appspot.com/x/log.txt?x=10e46944c80000 > kernel config: https://syzkaller.appspot.com/x/.config?x=46c642641b9ef616 > dashboard link: https://syzkaller.appspot.com/bug?extid=8ce7f8308d91e6b8bbe2 > compiler: Debian clang version 15.0.7, GNU ld (GNU Binutils for Debian) 2.35.2 > userspace arch: i386 > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=143b8650c80000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=15a22f2cc80000 > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/9931a9627dc6/disk-97e36f4a.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/1aafdb2fd6dc/vmlinux-97e36f4a.xz > kernel image: https://storage.googleapis.com/syzbot-assets/90df5872c7ff/bzImage-97e36f4a.xz > mounted in repro: https://storage.googleapis.com/syzbot-assets/ea75a01297dd/mount_0.gz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+8ce7f8308d91e6b8bbe2@syzkaller.appspotmail.com > > loop0: detected capacity change from 0 to 16 > ===================================================== > BUG: KMSAN: uninit-value in ondemand_readahead+0xddf/0x1720 mm/readahead.c:596 > ondemand_readahead+0xddf/0x1720 mm/readahead.c:596 > page_cache_sync_ra+0x72b/0x760 mm/readahead.c:709 > page_cache_sync_readahead include/linux/pagemap.h:1210 [inline] > cramfs_blkdev_read fs/cramfs/inode.c:217 [inline] > cramfs_read+0x611/0x1280 fs/cramfs/inode.c:278 > cramfs_lookup+0x1b8/0x870 fs/cramfs/inode.c:767 Thanks. file_ra_state_init() says "Assumes that the caller has memset *ra to zero". This should fix: From: Andrew Morton Subject: fs/cramfs/inode.c: initialize file_ra_state Date: Sun Feb 26 12:31:11 PM PST 2023 file_ra_state_init() assumes that the file_ra_state has been zeroed out. Fixes a KMSAN used-unintialized issue (at least). Fixes: cf948cbc35e80 ("cramfs: read_mapping_page() is synchronous") Reported-by: syzbot Link: https://lkml.kernel.org/r/0000000000008f74e905f56df987@google.com Cc: Matthew Wilcox Cc: Nicolas Pitre Cc: Signed-off-by: Andrew Morton --- --- a/fs/cramfs/inode.c~a +++ b/fs/cramfs/inode.c @@ -183,7 +183,7 @@ static void *cramfs_blkdev_read(struct super_block *sb, unsigned int offset, unsigned int len) { struct address_space *mapping = sb->s_bdev->bd_inode->i_mapping; - struct file_ra_state ra; + struct file_ra_state ra = {}; struct page *pages[BLKS_PER_BUF]; unsigned i, blocknr, buffer; unsigned long devsize; _