From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8B99C64ED8 for ; Thu, 23 Feb 2023 22:02:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 69FA16B0073; Thu, 23 Feb 2023 17:02:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 62F776B0074; Thu, 23 Feb 2023 17:02:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4869D6B0075; Thu, 23 Feb 2023 17:02:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 331016B0073 for ; Thu, 23 Feb 2023 17:02:45 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 00D28AB5FE for ; Thu, 23 Feb 2023 22:02:44 +0000 (UTC) X-FDA: 80499931890.26.25FFE4A Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by imf05.hostedemail.com (Postfix) with ESMTP id 02924100010 for ; Thu, 23 Feb 2023 22:02:38 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=VDH8Rbhf; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Vosq1QTo; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf05.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677189759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/HrKDQ0j9TCoz7DErfVeNXtnYDOsQNCDvxt8EstlRVU=; b=bpr4ESkHPZ3uxHZ9VJu3tDkx+WkJElZ6Q3AyHxDHC98dwe+NvuIXmKvWSoGZNgynG96hMD 8t1U/9JpxWziA8Q61u7AG4TLuPgkxLlBjQyKAgot+28k3HMH47B9fPebkfoiJ45JsbrB8j sLgxwF7709vmrBtfSs7ZRB+gCWOHojo= ARC-Authentication-Results: i=2; imf05.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2022-7-12 header.b=VDH8Rbhf; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Vosq1QTo; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf05.hostedemail.com: domain of liam.howlett@oracle.com designates 205.220.177.32 as permitted sender) smtp.mailfrom=liam.howlett@oracle.com; dmarc=pass (policy=none) header.from=oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1677189759; a=rsa-sha256; cv=pass; b=lxRxqFjAVxQ96dsl8K1Pj+YsVkWXESHYBAubXyklAEMgo8gqEg6A/OcKZRN7oAgD3IF2yU 2S4cFHDhNoCRPziHMM2E+MGV+Uv0f/S24VriOsaEfGn/KdlSJREzXQYfK6sdWpUK17Lmhf eg1h78ovWyTufYySDhdnZgYl8SvnH/c= Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31NGwi2C003635; Thu, 23 Feb 2023 22:02:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : content-transfer-encoding : in-reply-to : mime-version; s=corp-2022-7-12; bh=/HrKDQ0j9TCoz7DErfVeNXtnYDOsQNCDvxt8EstlRVU=; b=VDH8RbhfhNx8kMVKU1HcKWZ/c5oJpyH8XXZSCfj7mMzi4hTiQiXfcibXlCaC3wz1aY3D bPPZWpIO7WpT88ONup7ueIOKRpCZJjt6u47rg+9FQuCTQHPpbK8Fiw25ExAKOSNBOy+f mmoYxukYesKrGz8rUy1t+IKMfZGVx22ZeGF3ASr1YjyXwl/j/eDbnjgmRG2j2uA+6QXg 2uLCLsr8wPz+LPu9Y3PsjSG4FtOgtPcPX6xuxUpAeIh7PYOPFsHWgJZ7FbxidQdDJVwM DOWENRkdit8tX2M1Pi6+d1AWrihjwZLUCFErfGLhknaa8gOBQ6d3g6ykMSgJpuRsXDdG mA== Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3ntn3dus83-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Feb 2023 22:02:34 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 31NKDMZr018057; Thu, 23 Feb 2023 22:02:33 GMT Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11lp2169.outbound.protection.outlook.com [104.47.58.169]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3ntn48wygn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 23 Feb 2023 22:02:33 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oXy2v41KNLkFjrDwxzNdgt7HRUgwGS/XgQ5a7v0Vf/FbJV+mgVHvMBsn/DZW8kMuff72RsMgFN9pmyVs1mRztDBNqiD7sPVcMQ4EjppsUUewq97Qer9jUSyrTt33fvPLS9EGwimTV5i1+X+eflLyuG3+MaeX93owueKYjyWblvDHVvWstMdusAq1/luIbuUrEUcCKHrRN+7qx5DxD8gZ1kIDl3FCoGrkZMua6GyQ4qt6xstK7y4+W/Zye5Lh8RWAg2ZW9EE/RWImJL8AnVZj4BPRdldQSWFBnabpxArV+ssLPlIlSTzrHxha1gczsOofrCIlIgUaG2mc0qu+OtF47g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/HrKDQ0j9TCoz7DErfVeNXtnYDOsQNCDvxt8EstlRVU=; b=agU10MqEacviQUgj5opTDdkjuqxnM9qchjY7YdWCbKpshAkI8Yj+CY3OJ8JpI1vAgIjKSCvNZfkuvdzQV0LYhfKRiPLmioQBumhtgwz6fhgi431gWnE1tbpHiy77ZjcX9lsK9HaQ9l4RAu7kaqfXH7XDnhh3oChGUfwwroeCzbXjcA2OtqxonQ6eb/R6/o5xPzf2TQ5sdz9HC5HuNhFQdBjX0FDAyR3bhG3NfaotCDncxbt1+WoX7VGUe4OuytvsCI8rhtecsz3J1W3unxoNwrkODZJTCd0dh00KJ/6nUQd6vJlIWole4WQXC6OV5gWfhEef/gQYkgy2t9cuny9meQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/HrKDQ0j9TCoz7DErfVeNXtnYDOsQNCDvxt8EstlRVU=; b=Vosq1QTonS/r6zs8lkGFHPXIKcgXvgkfph1fzDOMhS95mzm9TLNvIHLNI4pcxrv76x2AuslKzd8QnqN6n3r7h/CB+BLOBeVEIXD4d8G4/04v8fpTFJVzoQRM2BRk7q33MWpvmq/xP/kVCG00V438yjiusGbtHLMe971JwMN91uo= Received: from SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) by IA0PR10MB7328.namprd10.prod.outlook.com (2603:10b6:208:3dd::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6134.19; Thu, 23 Feb 2023 22:02:31 +0000 Received: from SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::93c9:c99e:5ab:4319]) by SN6PR10MB3022.namprd10.prod.outlook.com ([fe80::93c9:c99e:5ab:4319%7]) with mapi id 15.20.6134.017; Thu, 23 Feb 2023 22:02:31 +0000 Date: Thu, 23 Feb 2023 17:02:28 -0500 From: "Liam R. Howlett" To: Bert Karwatzki Cc: Andrew Morton , bugzilla-daemon@kernel.org, Nadav Amit , linux-mm@kvack.org Subject: Re: [Bug 217061] commit 2286a6914c776ec34cd97e4573b1466d055cb9de breaks do_mprotect_pkey Message-ID: <20230223220228.bf2ob472wxwtqk75@revolver> Mail-Followup-To: "Liam R. Howlett" , Bert Karwatzki , Andrew Morton , bugzilla-daemon@kernel.org, Nadav Amit , linux-mm@kvack.org References: <20230223120407.729110a6ecd1416ac59d9cb0@linux-foundation.org> <7d6b7f52cde12390980b906983500576b20b33c0.camel@web.de> Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <7d6b7f52cde12390980b906983500576b20b33c0.camel@web.de> User-Agent: NeoMutt/20220429 X-ClientProxiedBy: YT4PR01CA0083.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:ff::10) To SN6PR10MB3022.namprd10.prod.outlook.com (2603:10b6:805:d8::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN6PR10MB3022:EE_|IA0PR10MB7328:EE_ X-MS-Office365-Filtering-Correlation-Id: 4d7c5596-2313-4721-5658-08db15e9a930 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BQT5j60SgoqTT5RqhQaUxsbaOH+tScJQrXbQyyAolLzuU1ffYYD1idizF6Qapo6QHjw5tHc0mN7wW2v3Q5TWIZkeA54s42aonXJmgq4P1cV3GhW4YsP1WXJvGWZo50hybIdzhRp8hb3K1YGWTT3gmcyqjCzV7fKlkgGr3APSkVZ5QeAqhllSDaMio2IN36VfOz0WIASc2n1sU1CWoKR2qzxDkLARxcaguBDdVmcflwvNM3diCAgJAotf//2P5fUHrBnumi7IQHHP/z6pU8cmCw4VnNqdktGu/VvUWyNXe6Ul90MgsGptqs/LbuVf4U0+E4kg5hUW6AFgjc72Y4GWzyPDTaUVie8zuFLrIr4yF8tgGyL/ud2OokM3diLCQYwitpP8SwZJFwZ2sHiZLc8ClKrC5YKBjzOG3Y8+gUvqUgmlB9cfCh1c6Kg7L5znevgQNYiF00hs7MGOcf7ZHSa3CKAAcngzt3G+Wxqoe+aK2DZ6t8oCIBbLqWxN2BnAwr82D62HsOpBvpxt4v/Fn7mV4LvnjRKjvLsNlV/4V/0e+B83PwL9kIIZ6EjJRO0jNMpTvdtMly3ykAscnzs9ozhniy+IX4BWPFFVN83UvDPZuFZZ+95ezn1nilq6peyNBbyP X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR10MB3022.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(7916004)(39860400002)(376002)(136003)(396003)(366004)(346002)(451199018)(38100700002)(33716001)(8676002)(1076003)(186003)(2906002)(6506007)(6512007)(9686003)(6666004)(316002)(54906003)(5660300002)(26005)(41300700001)(66476007)(4326008)(66946007)(6916009)(66556008)(966005)(6486002)(86362001)(478600001)(8936002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?Yye5RS1OxVZYLJWflvGfDyFei4qrfa1C56hXIBRZHESZuOA9vbBR9OmqeI?= =?iso-8859-1?Q?0KSV4HZ5f23XuNOrwfwTX6RmOBcpOabv5NNL+qj4qVEYe4CZ+wRjW8i7Fj?= =?iso-8859-1?Q?KzAexkzreyoK+L2A7p542wa/GohQr3YB1DYPwmcVS57vQRvEG2zhi2PKI0?= =?iso-8859-1?Q?xgwASB12NQcmPLmRpiuk3GIvI+0Xf3Du8k4p3kui5E3ozwV9GOn9TM8nAK?= =?iso-8859-1?Q?ma4Kkp3wRc9QpS6qm1CZn+gPuJ2CbjdYen8Nwp12sYfrUCGMh+dMJ1Xx4C?= =?iso-8859-1?Q?/vDUFfzwaeegArMORAxJM7ZA0lftsjTiov58K7ue4tm31ad9EUrGGmXZXE?= =?iso-8859-1?Q?b9APPy2tzVh8LUFrvqX3QW2Gk1QeMYtZRrH6CyF5sjgOx207M6BMfaxYo4?= =?iso-8859-1?Q?nORVEh/6hP86i1GRdP0AmBCnCIo822jCnS+GUYAX0brhj6JUb53Fovii89?= =?iso-8859-1?Q?2deN1PMHQq2vUXB+IlJSei0SUSLc1YP9TnIlZnxxZD6mvKOqK6JvnNcPCQ?= =?iso-8859-1?Q?7ILEfRyGkqiUv4J5yNNXVjrY1oiEZBSc9MWXDS02KCsBMAh2wBDX96gpWc?= =?iso-8859-1?Q?TUQq7kj0nrGKh0sxeyfHeMSduS//eH/TKgNVOmGMfkrAm8jVhtpPHWTkkI?= =?iso-8859-1?Q?g0PDb3kk8ViZ2yx+KgaVvmpQnSU0XKVgwRmKR6M5ifb9jAz2vrO8TWsFEk?= =?iso-8859-1?Q?SkEtjNUBIcmIrKc7EvaL73vmLBlUuKMb5frciOYhXvGriFaUxd3j6W4HNF?= =?iso-8859-1?Q?6npiewTGme0Mj20o364oQ24v1P5SdyUbo/Hwr0yF4U7LDFXPPg5h2HKmFv?= =?iso-8859-1?Q?/+aEVNB9FnM+b7S4KH/Xv62sGfMa1D+cx9+teaM1EjFoBmWG0TuaeX96sx?= =?iso-8859-1?Q?iFfLlciJFijxEx4gWkhVOUNiWkV6Y7sTjfLqIs4L9jARGIBX/ZLrwW6+HZ?= =?iso-8859-1?Q?HuxBX3bez7Q9zJyzD7PuzoDCO/xQiw7yOrfBR7vdJ/GgGUzTzpdWMxHdbZ?= =?iso-8859-1?Q?KRQWxfPWKOB6yv/4b0VGIubhc6x3L0ml2A7/kC8XEG5UAWenoZFvYiw2Kr?= =?iso-8859-1?Q?5seWX3nLxLdE0uOaqW62+MS+NjrXVKXXOa1ncYySoJbwwEf7me6PDEnPP+?= =?iso-8859-1?Q?zjR/y9DtiLe64LeJa/edKVFbLgkJ1zerd5iOsoyMzXbvJGPmFdCrBIgbD7?= =?iso-8859-1?Q?sU37V82j3pImBawbXEe+oocfyJQbsl7abCq9csub42BivSz9BItMmvaB7z?= =?iso-8859-1?Q?eeaULyn/GkYmd32mDYZ3i5YgCjbjt/aaovx26+m2fsBVRuC0o6HEBDr94P?= =?iso-8859-1?Q?D91sle1eg1uhah3UDL3FU5SywMIzmka0WBEDoa3PBDRu0DpxfZbuebMNTi?= =?iso-8859-1?Q?Dj5iqzhicTS4a5r3IHmtnXzTqpQuqLsB2IpmhsGNMWH/Tm30xsXVCWP3Sl?= =?iso-8859-1?Q?iOElIiGdzUMHNcqjaypbbwBPiinWk63XdV7hogyumhjW4kWvLFkrnbmH25?= =?iso-8859-1?Q?brDSrPT01Y8hsJwE6NQj7hjU5AtC42dk3x2UnXIeIuBcorDtfV0h4nijns?= =?iso-8859-1?Q?QErh7h73ytiQgogpYIx34os2itS0H00vtoaR6nGUXBD3WJuK0mUygELejY?= =?iso-8859-1?Q?nibZKSDJb8S+qHrKm12pnsC0kHYaV6D/YKRr0OTVRy9l287C+w2gPTWA?= =?iso-8859-1?Q?=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: x/iD+OgMnQqIutQ/jyyMBBbCa4Ga5wYdpsyQIbXIiO/7BlVbAqnkLFu1oNBmTkaEOJsqTU4hLo3IudqNmSvX4wkz81ewubSKaDvlDRsOq1ecMFgzvPobDepqeMGHJLCLca8qnuqB+ah4uQj4eWAMEQAHN1zXjgSfqamRZQK8SbLlG6PndMit9tc3/qLGOqTDCM1HeZTU6qdqO5/cGD7KD2Q3ctxRjV4Bv1Li3f5F09l/KexRMIclpYJgbhU3QCO9gEJFF46rd6lU93Swvbuj7ZjmTH3fjNAdD+9EhvqkUn46Rk0lLGsuETceWQwQDEXjZRiRdAReCSjonmMKqTty11P/+lr2Xdjr66Gd8EaL/RlgbwJht3LJw3gs5fDo83yxvN+uXDZDuyJKIR8zystjNQAGKiIdB0xWQXjSK1J35AubHZQ6EMzG1PkMxM+lMkF5D8F91G1anKIGHCQX0GNlrzkxnllDcVTK/Cw07ySfkcaPevt4Tb6GNisSlU3g3JDrsGzPFC804/uo7yKXjkvMOKhERem+HL5jBAL1LcVFvyzKnO3Zs6FBqE5MwutjjQDVUWO31nqY3jWchPPsuLTdV0lvd8QT9xqkZ73DNkWirM7FmtM1QqEscv/wThJ2tL8jGdxjIDwU/NSy8NkgQl3dOeBpdlGmnWNpinoeUpbWHwLJUT6pHt5G84QzFv0ZBeriwEP80RWmXoMiePkkoOo8/4m7bra3tmJbYiv28bAzuv8vWPwSYQQ/iQiPLTwimoPPGVHESAUMgVWKJfmOF8pEF25Snwq5PrZ1kdWKixCTgbec2M0KS80xDS2Bzgz58AILbagKMAcQofwwEuGVUzFYbFhvfQAWIAZFtpFvwIizbixI4NcyEtLHn14W/+O+fZZD X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4d7c5596-2313-4721-5658-08db15e9a930 X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2023 22:02:31.4387 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V9xs9Qgx6sMPEApu6gK6RV+uTqb6FsgyYs2oiGDNSdLifE3G7J/rRWPmkt0K9WuzZqoO4LCydjiGSZvCHh+1kA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR10MB7328 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-23_13,2023-02-23_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxlogscore=999 bulkscore=0 suspectscore=0 mlxscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302230181 X-Proofpoint-GUID: kAMKQTNrtdFWB7UNDeqUeLiqN1W7xWhX X-Proofpoint-ORIG-GUID: kAMKQTNrtdFWB7UNDeqUeLiqN1W7xWhX X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 02924100010 X-Stat-Signature: s3ujgzsmr599baq18towkfa89nuupqj3 X-Rspam-User: X-HE-Tag: 1677189758-907572 X-HE-Meta: U2FsdGVkX18DgCHt462YdCcsAM9mfpm+KM21EgbsZ2qNHeY4KPkphr61zcS0n17W2ALC8LSzPn019VgwlXeNtsfyeQsCFH551lO+KM4tgNa4NLYrFhrJRYi2nMHCZXKnrHyHg6h3PhHwu8q9igYlmBHvNvGhL6PsfVJUDdnhgkHnV7z2ZHDW50UHt3mJJb3j9MOkYpULVMTeljkbvbEVOe9gx3/Rn2nMDVkXldWkJNRfBVQaO6aLfWEh6oRYOgv5xElLlrKh4J4OYH8KUtF0zeO1lUKD0dUQTi7KixtBBUC/QhHL3xaIJC+4lXWzMvuE+0LOB6Dnu7whQbsibE7QasFIx0P+qjBQ1NEkD6WugzfwNh6TgrrrfdwWOZGJWHrsD22ih8IsAvCiRClD75IodI9Jr1iXxHoXJ5uMEgUaj1NCNlPH9rZydZID8h3CVMe+MB7u2IpKnXFnK/zvt3wThudVXolNhhhnxsiydqYTYfaRPSz7gg/b247xpkiIEo4iaQkBNxIeK9bFLJUNdaDp6QmN6v/5wTmlZTsJZMDeT18J9eXTvdAf/5O+PUe8tcqR80dqhTrWWVMVR+FDsY4SUJGLuJy9/FO8zZfHewBW8bRNswXDrS+lAqrdtOMynEQ9i6wiA0sTDWfeB6509oOTxE+JnE3bdk1RZeJHLi/lJ8Ve4P3WHw7zV2cObN+C65i+x7l1RcaAjWZ1d6OJ8pkqaAOSLYVPvyP606FHksfTJarBfxGNoacJGlKHEHDQ5in8ciekX7W+3NbtWEuqzgou/3/+2EygFkxEBaMuedwSX2R3f18c8tsKJxNiuRoTzIbrcLVjg+MDGgnIgjJjfYp/Gyzc1jpomZfyuJYFiZU3vbHFcpqfbV2Mx74RUorHwAWH8t2Y9gatpvegF1Z6ynOAFdwmDmtRQtzKzxqeRcIymcJwnJ9Y7RI9qrdauLDNWCtET1RGyD60hqeisW5Fdq7 xpPZrg1/ UPMi2TggSX2LYv0GhGPURntrhNwIVPr4evvaX0tjjDMC2tQ9RH7nl6V8INm1wIi5tk95ldfhw2D4QrdpaTv8YLMS8y29EwXGn4bson20T0X6ISE4v0pdiCmgufAuX3YRtZItiKEo2hb8yJlgQ7OPiE2Eu+KzhQ5OdefqeTZJBPcK207B7OPgXWzysLWzS+zkcteLAScBQBMnPyOZcuTBGNClpF+iDxOadiL5NYxXRVrScrLUK11IVo57NyyyMIT7kqBi0J5SKDmDk7v04HVFpU7Cd/DqnwImUz7uw7ayExxVbJin5RHGWlTFlHcH0Z5pozrB/AYwPRDzhICVECCUDlePmgKZNR//SfNjel14LYNfdvKO/vq6pP0YkL4oZebwP6Am8839yxKVUYJT8QAy2vMJA4Ei55yGXkmT1XqoLE900kjJ8QS3M+N48Aw2xJbtkVMXiLJ1hfIzkZAyP3Igga37eIsMHJ/ZR066lA9PFxsrkzh+x3wHsRsW8ouKzSEcxOUQ7Zgr6kfGu8lHUafPfTb5rvpGeSIseUUJWOEzaLzoCzGA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: * Bert Karwatzki [230223 15:36]: > Am Donnerstag, dem 23.02.2023 um 12:04 -0800 schrieb Andrew Morton: > > (switched to email.=A0 Please respond via emailed reply-to-all, not via > > the > > bugzilla web interface). > >=20 > > On Wed, 22 Feb 2023 18:27:37 +0000 bugzilla-daemon@kernel.org=A0wrote: > >=20 > > > https://bugzilla.kernel.org/show_bug.cgi?id=3D217061 > > >=20 > > > --- Comment #5 from spasswolf@web.de=A0--- > > > This fixes the problem for me in next-20230220 > > >=20 > > > diff --git a/mm/mprotect.c b/mm/mprotect.c > > > index 1d4843c97c2a..f70f9a7b545e 100644 > > > --- a/mm/mprotect.c > > > +++ b/mm/mprotect.c > > > @@ -832,6 +832,7 @@ static int do_mprotect_pkey(unsigned long > > > start, size_t > > > len, > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 if (error) > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= break; > > >=20 > > > +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 tmp =3D prev->vm_end; > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 nstart =3D tmp; > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 prot =3D reqprot; > > > =A0=A0=A0=A0=A0=A0=A0 } > > >=20 > > > Next I'll try to construct a simpler testcase without steam and > > > stellaris. > >=20 > > Thanks for figuring this out. > >=20 > > Liam, this has been bisected to 2286a6914c776e ("mm: change > > mprotect_fixup to vma iterator").=A0 Please take a look? > >=20 > While a still don't have a simple example for this bug I can at least > explain what it takes to trigger it: > The memory area for which mprotect is called must have (at least) 3 > vm_area_struct of which the first to must be mergeable. Then the > following happens in the for_each_vma_range loop inside > do_mprotect_pkey: > At the beggining of the loop vma points to the first vm_area_struct. > Then mprotect_fixup is called and merges our first two vm_area_structs > but tmp still points to the beginning of the second vm_area_struct. At > the beginning of the next iteration vma already points to the third > vm_area_struct and so the check vma->vm_start !=3D tmp gives a false > error. > Setting tmp=3Dprev->vm_end after mprotect fixup sets tmp to the > beginning of the next unprocessed vma and fixes this error. =20 >=20 Thank you for the analysis. Just for clarity, tmp is used to ensure there isn't a hole in the range we are iterating over. I don't particularly like how this was done, but I tried (unsuccessfully) not to break it. It looks like I've missed the case where a merge succeeds and so tmp is now out of sync with the iterator. I would change this tmp =3D prev->vm_end idea slightly and use the vma iterator end location: tmp =3D vma_iter_end(&vmi); I'll send out a patch once I test this. Thanks, Liam