From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 222FBC61DA4 for ; Thu, 23 Feb 2023 21:48:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 71CCD6B0073; Thu, 23 Feb 2023 16:48:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6CD6C6B0074; Thu, 23 Feb 2023 16:48:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5954A6B0075; Thu, 23 Feb 2023 16:48:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4A7816B0073 for ; Thu, 23 Feb 2023 16:48:22 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 0D3AB160302 for ; Thu, 23 Feb 2023 21:48:22 +0000 (UTC) X-FDA: 80499895644.07.2096FEA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 26A9410000C for ; Thu, 23 Feb 2023 21:48:19 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RHcaiN3J; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677188900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=elf57BbkaYLylEf6//UAX79sMSg+jFaUVI3L63l7GSk=; b=g5GjpEwH3BAUp9FWuHW0KZGZ61ybgj/xHeK057IkbQluPLPPfi5yUgWnGt4forTf5MwCpN gbQVj5D0chun8sIL/sl5Ku0xhIy3UOmTdedH0VQuBxPcmwEK9PrHR5KW+MBFm00gbWYR4+ zc0NqHxRBzmCNMn+XN3A590YBsUYHzg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=RHcaiN3J; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677188900; a=rsa-sha256; cv=none; b=vprw4Uznv3ymxlbKO7V2DHiKCdWeqr5ahYsBY1ICPdLNb3TD2VGo5VO+nlBSKJsAvmlp/k VXXS1LzLyGu5kiEyrA3uwBA2OwrLhzLeVfJgnhdVES1P4qsb2mH04A2IAlc3rkFsD9cQFJ PX/dv35HB7BaKEy3pXDt5Tj0hTW68Qc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2F4546178E; Thu, 23 Feb 2023 21:48:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DDD0C4339B; Thu, 23 Feb 2023 21:48:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1677188898; bh=1uH85J31wjCE9rL1eHDJcDdPRwd1mAfcvOY7PpzaXhA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RHcaiN3JsUZSzsIP2ayAeBgme88GgyvBlUvl0ZbYCuBbNuIma5h2ZOQVGyqgbXC1j IYyIsvoRtTWiULtvg282Daxu5yXOzQxCJ2sAwv4dLHb1LJ33BHjm2XoHtaQTdWcnPs IEhKjJiSWByyqKinXGpBZ23XhK/ikeg6phmKoFgo= Date: Thu, 23 Feb 2023 13:48:17 -0800 From: Andrew Morton To: Vlastimil Babka Cc: Alexander Halbuer , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm, page_alloc: batch cma update on pcp buffer refill Message-Id: <20230223134817.dc1669b51a9c39850a6f86cb@linux-foundation.org> In-Reply-To: <89778da7-74a3-2f2a-1668-afe7b15487dc@suse.cz> References: <20230217120504.87043-1-halbuer@sra.uni-hannover.de> <89778da7-74a3-2f2a-1668-afe7b15487dc@suse.cz> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 26A9410000C X-Stat-Signature: p9m4rdmaryukyaf4ewxzatbk4zwf7z7z X-Rspam-User: X-HE-Tag: 1677188899-81934 X-HE-Meta: U2FsdGVkX1+tIS4Clx0zPcr+edkIOSk1oyx0ew9/co/qYo76BowfUPsY93CY42oAwNDOwnwLkodbf0rzn3WYz/LWHah/NiKyluUToLBhoZpy+ESTJWtNyAppVfPxo8x0ugW+mXCbNRoAEf6bLXH1rUDB37ukHm7C2ynbEQC2roG+E8teasxWeridbddir8pz9y43e4mj6kP6pQcf/3CCKUq69LCWrIs1TTSz/ys96wHMwap7jTYqVNWwROXXVxCdlxOnl+vi6KLFrYq7TwzdzuZXTAoRTTg78ntlwXq/ii/Yr6TepVnKPR8HFnDoCqyNs8ZpJkPjsT7g8jahNR52G5RzuHyh5kWMS8LjAscUNKStGHoGnMiQZEH2CcgtfjGUHnKnJ+VZQ0eZ0d5rLeFTJv1++1Kwd/cLrC0Ijsmn+5ZFBaA58YLzQXbER2E4IC0SQY/kDKE7nEvekwVFpEKG4glxdQdB7MR6KE+DP16TxZqggk25MTMcDEFo9JpX5hwTlHkvVLNRM0rDquyj3UFjWUytI82dhuif032HZ54nYHZTklRqDGZ7HbhqfEEPoJ3vgj2TX1ZnD8hl4Lhhua49BJ2DXKRxKFExOJI9b60bTGrSCltUuS2pmNyNDdHSD0Mn/KjD7I39s9mL5FlRSfBhR00lXijpN0Ch+NLvy6ySyOOevOsxO5U76KXGan4JEfSXEIq7BFy3tDyH5nIjtcyLBFedCr/3/rJzihqs3YlFnxe50iRiKvAU33FcqFJgM6DkyVytZ950KkWpwjNXgYTQRma/uvsjE5ho7fyMBZ2N+qphxH6d75X3IBYvBQf4C+x/s4bVGgWWLHwxCgqWXVLgG0w262fSvDbVrFJHI/y8V45lP34HEgLCdCELRohM4vXxbHLL3/JLUHTxkXrIvC1hOO/fYDKR/zMLH4J5/rXAvKHQx8UMTt4e82Tr9mL7b4Fn/scDnY+XbocIHWEUzBC EuwU9BYj f8neL4QKJyRCY1dGBgG4fKe2WwzdRWpBXWIJcKEiESX+2tA2JQCoOyhpJQ9aN26cmXNO6tJUv9Hm6YS+qqN3FmI0PJ8++WhXbsO1c3u0wWBl5g39vWA4yaLzHl0/pI3FHI65Nhj6uAe7E2Gk28sR6QtEIpCGLvNdYkhceC9W/803vpm6hHGgOnsNkauzIK33rGPmCfgRyBXB17vRaCF9p7PBDnBMS5UYGfSICgLU0b4naDykVMokA3lYDbi1TwSuEI0b4rjq0jPn3efYKUFCeCReq0MNyZ8Qc4C9U4H1c4+5F0XIvJ+hixX1y49yoeLzXSjkr7iZxAUWdybKtIObLBdzjX8KHAKLImskJeLNbj2VjAQGMCkv6zTck1ZC3Ad8Oi3B2WUtvmGJLANlnBsDGaxyGJ7BmbE9uYMflCaj1c2s3GCi/x1mMnSFCvb2QnDiXOGxV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 21 Feb 2023 11:27:14 +0100 Vlastimil Babka wrote: > > > The tables below compare this patch with the initial one using a > > parallel allocation benchmark. The used kernel config is based on the default > > debian config but with CONFIG_INIT_ON_ALLOC_DEFAULT_ON=FALSE and > > CONFIG_CMA=TRUE. The benchmarks have been performed with the default sanity > > checks enabled as the patch "mm, page_alloc: reduce page alloc/free sanity > > checks" [2] was not enabled on my test branch. > > The given times are average allocation times. The improvement is not > > significant, but the general trend is visible. > > Yeah there's some improvement, but if [2] is accepted, then keeping two > loops there just for the cma update (as there will be no more checking in > the second loop) will almost certainly stop being a win. And with the risk > of inaccuracy you pointed out, on top. > > ... > > > [2] https://lore.kernel.org/linux-mm/20230216095131.17336-1-vbabka@suse.cz/ I've just added "mm, page_alloc: reduce page alloc/free sanity checks" to mm-unstable.