From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7D45C64ED8 for ; Thu, 23 Feb 2023 20:04:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 128466B0071; Thu, 23 Feb 2023 15:04:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0D7F36B0072; Thu, 23 Feb 2023 15:04:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F09736B0073; Thu, 23 Feb 2023 15:04:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E323F6B0071 for ; Thu, 23 Feb 2023 15:04:13 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BBB1C40372 for ; Thu, 23 Feb 2023 20:04:13 +0000 (UTC) X-FDA: 80499633186.20.E093C91 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id EA779100012 for ; Thu, 23 Feb 2023 20:04:10 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T5jZg8DJ; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677182651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JedPpx7ujhog15eTN1GyDU7QkuG4hk6p1COcP8h25Kc=; b=57gjPX2taJcTDftrNMJ4plLhCDLRILdavCXJ9UJDS+C4EKlw3CDQEuG7gqyoKdbODLlfz/ RRocJbe+mBp7GYNtnalxI4zb+D2nq3mjkqRUAgjObGjcMnTMuKdLfna44uP+iJpOko5m3w n5pzmFi/9EoJbNtShVyUl0qiMhr7CbA= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=T5jZg8DJ; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677182651; a=rsa-sha256; cv=none; b=26prvAdztd93ENc8BdZ7sPz6ku75Br9MXuKHrvI7y0k8Fbkq7aBkXLzlDIPYX33PksG9fg WZz/BkMVJXlKGuQl8lbh9dkvcVBiTFsoDQAsgb0ZTUDW0ilcafpH7DKGI4VFQfSkqKdqyJ OgCZzGFHwV3jZOm0Esh+0DnhDhDy1lw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 1DE7FB81A28; Thu, 23 Feb 2023 20:04:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A634EC433D2; Thu, 23 Feb 2023 20:04:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1677182647; bh=KxptXKjcM6nM+K9Cob4zKCOXsickZvzhV4dCRlGokH0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=T5jZg8DJ8EqekQxwN2dx63/HBmRN3a1Zu1eleYoU4MhiG2/EPif8hOV5H8WbpLgj5 nC03ciZ7EuUNQRWZqTPNYf7ISn55xpQnKRLBx3pdO4NfisGI/vd5448NdawSpLD2Kh Hn0mrXp+41dDjpG9eRgBwWhHyIgzdJDnL75gu2O8= Date: Thu, 23 Feb 2023 12:04:07 -0800 From: Andrew Morton To: spasswolf@web.de Cc: bugzilla-daemon@kernel.org, Liam Howlett , Nadav Amit , linux-mm@kvack.org Subject: Re: [Bug 217061] commit 2286a6914c776ec34cd97e4573b1466d055cb9de breaks do_mprotect_pkey Message-Id: <20230223120407.729110a6ecd1416ac59d9cb0@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: EA779100012 X-Stat-Signature: n6a46339szdzs1ypgo9kqhoyefhj5a65 X-HE-Tag: 1677182650-766949 X-HE-Meta: U2FsdGVkX1/c2iD+4TpkUm5gYh/MnUjdAY/IYKjC3TfxwUOh/beQf/2KjLFxjrDK0O16MAp+XSswxwE01ErT/u+8OvPaJq6nC5rSox918f5O0/dc3sEmoHUvPgNxL5l8jn8OZMM31FunvXMWdHAFtdHJQolbpeL7LZ9lJ1O+lubrvSyziUH1k0u1i2jd4JdHvGZwlpO+YwJVv804RAnwDnXFP3TQU6KHBcAfZvXj4TkaC1gm/5XQEfwBP00k6+mDGUZxEKf4w55dxeqyjTBHcdxLO3YD0Q50cII+W0uGcTbhil7KSvKFfH0OJXxvUU+6nvgIQvtQRzwTPpzabpsVO0DiJ1T3WXrp0BoDIvMfDhdv5R0+eXudz00gDhEyI6jrnuizVhYULFrUqUvk2fm/6+ILn6bX0dLDD3mpxbn0O8038V4VVP7PWWu3hXf1Aj4PbJ67gQ1fnNoh7Af1NbEXt9DFCrytUAD8paHs+DJTf7ZGSfzBIfYwhxN2szYttH+B1urrTrLee9ZJqIwHSt4oQRHJo3FSZN56QBLydN3dkL6Ic+w756SzUd8HupPNCGCkiccvgQZpbAJDO5oTp8P4IpvkumgmzOF8fNkOL7VJAlMuOv2MUQvk6EknPdxbBIJJYzFiDAUCcDGhwZ8ngtbFyi1VeiXrUe9qu0AgKzdSTNpI3anNsmO+/QE/lPSvLvLs+4DzYoCyIuv7dBo6uS3Cr+w0XzbfagjqRtsL5RoVKP0XcbQotm38b7eRFXNI8MCQvbuxwbipw20RbzYkNFP+oNYqgjqbI/lFxAzOIPAVAtCLxNUatkSPBXrvfaz3X3WvA2IKhuivYo6PXrEB9DJAZ376Gib7Tm7uIUavX06aZvjTKml7Fp14Zw+g5Wf5BT8+PLvgzKbLHfW4N+AIOJMD+/n3gVU4mejacJ4b1ODPMjU6m9wYtDK2YB5e7GpbY8Rbli/44CUupEfBsR6aSEU SYC0HwKk xFPJ4ashdrCGug9lWk3EGUBt4TElHbbQqnjNNpB34A5spRROAQDW+t59YE3UXAH0pBitg3BrryuIsitLzYuBdWQqBPkosUCK+PbIo+e/6goc4UMX5bHRiGlCQQvEbiuLxRF8ARKz0II3rSFAFfSXyz4qVUsTWKAV2bEhW7v6WaugmTGFrGCl6YYg37KJTazjPYUd7enZU5C4DYZ4UxQ+ZVCbf3y2RCJm+5QGDw7Lfa5yFqmUhigKqpyWwrw/OA4OhR7IW5Z/oT0x2RwrkpjaJWFGGFgX6hst63wnyGkrAKFqLHzHEdmvZO22gPSbLhOqX8LNJPgB0CjPmb8s1RLPh3FfF9S4oxzqMXEQyhzO7wvPDECsS3VvcAgUHmL5OKQPgHlifky2KjAvtAGQdTUmqpZ5VfN7oQRh4fkJLJmYMbBE4EZSb+MYd9PlSbDiF+FVXi9lgUc1P1AqtPnmL9/9W3ltaZt6wN73WWOQXdV+GDikSG3wgmdhQrXzq1V3t27DWtSDrBduwvF8oOow= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Wed, 22 Feb 2023 18:27:37 +0000 bugzilla-daemon@kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=217061 > > --- Comment #5 from spasswolf@web.de --- > This fixes the problem for me in next-20230220 > > diff --git a/mm/mprotect.c b/mm/mprotect.c > index 1d4843c97c2a..f70f9a7b545e 100644 > --- a/mm/mprotect.c > +++ b/mm/mprotect.c > @@ -832,6 +832,7 @@ static int do_mprotect_pkey(unsigned long start, size_t > len, > if (error) > break; > > + tmp = prev->vm_end; > nstart = tmp; > prot = reqprot; > } > > Next I'll try to construct a simpler testcase without steam and stellaris. Thanks for figuring this out. Liam, this has been bisected to 2286a6914c776e ("mm: change mprotect_fixup to vma iterator"). Please take a look?