From: Andrew Morton <akpm@linux-foundation.org>
To: spasswolf@web.de
Cc: bugzilla-daemon@kernel.org,
Liam Howlett <liam.howlett@oracle.com>,
Nadav Amit <nadav.amit@gmail.com>,
linux-mm@kvack.org
Subject: Re: [Bug 217061] commit 2286a6914c776ec34cd97e4573b1466d055cb9de breaks do_mprotect_pkey
Date: Thu, 23 Feb 2023 12:04:07 -0800 [thread overview]
Message-ID: <20230223120407.729110a6ecd1416ac59d9cb0@linux-foundation.org> (raw)
In-Reply-To: <bug-217061-27-Nl8xiZT9yu@https.bugzilla.kernel.org/>
(switched to email. Please respond via emailed reply-to-all, not via the
bugzilla web interface).
On Wed, 22 Feb 2023 18:27:37 +0000 bugzilla-daemon@kernel.org wrote:
> https://bugzilla.kernel.org/show_bug.cgi?id=217061
>
> --- Comment #5 from spasswolf@web.de ---
> This fixes the problem for me in next-20230220
>
> diff --git a/mm/mprotect.c b/mm/mprotect.c
> index 1d4843c97c2a..f70f9a7b545e 100644
> --- a/mm/mprotect.c
> +++ b/mm/mprotect.c
> @@ -832,6 +832,7 @@ static int do_mprotect_pkey(unsigned long start, size_t
> len,
> if (error)
> break;
>
> + tmp = prev->vm_end;
> nstart = tmp;
> prot = reqprot;
> }
>
> Next I'll try to construct a simpler testcase without steam and stellaris.
Thanks for figuring this out.
Liam, this has been bisected to 2286a6914c776e ("mm: change
mprotect_fixup to vma iterator"). Please take a look?
next parent reply other threads:[~2023-02-23 20:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-217061-27@https.bugzilla.kernel.org/>
[not found] ` <bug-217061-27-Nl8xiZT9yu@https.bugzilla.kernel.org/>
2023-02-23 20:04 ` Andrew Morton [this message]
2023-02-23 20:36 ` Bert Karwatzki
2023-02-23 22:02 ` Liam R. Howlett
2023-03-03 18:29 ` Liam R. Howlett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223120407.729110a6ecd1416ac59d9cb0@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bugzilla-daemon@kernel.org \
--cc=liam.howlett@oracle.com \
--cc=linux-mm@kvack.org \
--cc=nadav.amit@gmail.com \
--cc=spasswolf@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox