From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6898C61DA4 for ; Thu, 23 Feb 2023 07:13:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4D11E6B0074; Thu, 23 Feb 2023 02:13:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 481546B0075; Thu, 23 Feb 2023 02:13:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 348AA6B0078; Thu, 23 Feb 2023 02:13:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 220F36B0074 for ; Thu, 23 Feb 2023 02:13:04 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E46B71611A9 for ; Thu, 23 Feb 2023 07:13:03 +0000 (UTC) X-FDA: 80497689846.07.D76094F Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf16.hostedemail.com (Postfix) with ESMTP id 4B87F180002 for ; Thu, 23 Feb 2023 07:13:01 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=qw6kU8IO; spf=pass (imf16.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677136382; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=A6QTGm81phs1BDTIrGmL3AE+q+u9INzAv0b8ooL163Q=; b=0y8etc3AsabxZJeUZOpuPGzKwsJtLJIZthshwg3DZUWH9VNlX/Op/XNpvfEvXig+Tp4Tdv UNH8v5Ftpb5SjNxOT7occ3jQceaN3+nXCwkuV3h4icEBcEFwzgdokQ6zqaEnjm8BKY9pRL h8laFyqzzx5m4NxYw7CyaIC4wcu3I8U= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=bytedance-com.20210112.gappssmtp.com header.s=20210112 header.b=qw6kU8IO; spf=pass (imf16.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677136382; a=rsa-sha256; cv=none; b=cd4WFwiCOSF2xGL4yYBfZytC4c1NEchLbCXJvbKzdWPbQ5SyNNqm5uRV1MK+5ktJFe1OKF kVdQ0pnfgG/QaeU1o9eIyyjdMrFDqp7vDE6NdVU+Z4IGru+5z4dfSN37JKeCCFE9ylPTbM NGN0ydqnPwRDujI+zJaznohTe5iIYpE= Received: by mail-pj1-f49.google.com with SMTP id q31-20020a17090a17a200b0023750b69614so3279773pja.5 for ; Wed, 22 Feb 2023 23:13:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=A6QTGm81phs1BDTIrGmL3AE+q+u9INzAv0b8ooL163Q=; b=qw6kU8IOs9YLnPcnx7k3brP0v/xsrbYbyyTADSWojaS3kGHoqpazneINsSl1LpCiF4 z8kAT7JDnA7fI2KCP1/J0AhohtooNBj144mMfJIN0LogYQ7FN/e5P0ls0Gly6PuYCuAW cateNSima5wp7fKbcBQex/Lkk+KA6WjbzQVI1DeoRlN54tI7p8BSqmi1xXAMAzCnz9+/ kk6g2RSEfyJVHutk26XlLurkGhUiBGgm7d6PVJ1EZQr0cJAsxzrjSqSsyyiWUG3uDCg5 TuzwG8I0EmDlGc590Zg9IWhjwRK15xzOpOMIZTOE1kC2eBLscO4/VHdoc494DXQZbpD5 KUiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=A6QTGm81phs1BDTIrGmL3AE+q+u9INzAv0b8ooL163Q=; b=v0dpiT8UxwUQ+Eeu0xouinYN8H95eTpAAVWLt9ObpvP15NWmMVaqWKt5+Wyjddcb5s 8W6syovCOYvygYGEgux3hJbLYfRqMzeAeWiaB8TgpoXualzXR/ljRSWrnn02h30wCXSS CBMtH3lZjaj+DmslJ6tHGYV8B1cCY906elnDkTAi4NIstgJBis22xiGOIQQ/UJp+YIni paBSefyreWhu6S78+3Ip+++Pzeb8gYSex/TGmzsOh8TI8XPsStvcBOgcWk4bmQGbcPgD QHwE+z6YW/HYjXy2f6kViUYM1q7I2+rTfoBoa16d7rDEQorQcqFndjinzfJOIcQOC/e2 NF6A== X-Gm-Message-State: AO0yUKXd1F4nGnhpYiCK71Ouf0IIjysB91DutWCEUXg+I/5niK+863Ir fr1pp26A+KA440mXxLFEVsKohQ== X-Google-Smtp-Source: AK7set+Tp6YAU+VuewoLRDk/J3IiEoVCKpv3GmkSgsu7IaZt4N4jGYkQc3wV37sh3+9U7WFried9GQ== X-Received: by 2002:a17:90b:4a85:b0:230:3af9:174 with SMTP id lp5-20020a17090b4a8500b002303af90174mr13622969pjb.5.1677136379844; Wed, 22 Feb 2023 23:12:59 -0800 (PST) Received: from PXLDJ45XCM.bytedance.net ([139.177.225.245]) by smtp.gmail.com with ESMTPSA id 13-20020a170902c24d00b0019ab6beea1esm2501639plg.87.2023.02.22.23.12.56 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 22 Feb 2023 23:12:59 -0800 (PST) From: Muchun Song To: mike.kravetz@oracle.com, akpm@linux-foundation.org, muchun.song@linux.dev Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Muchun Song Subject: [PATCH] mm: hugetlb_vmemmap: simplify hugetlb_vmemmap_init() a bit Date: Thu, 23 Feb 2023 14:59:47 +0800 Message-Id: <20230223065947.64134-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: d1gokapmqr4q5sb9yyze497kzntbago3 X-Rspam-User: X-Rspamd-Queue-Id: 4B87F180002 X-Rspamd-Server: rspam06 X-HE-Tag: 1677136381-426930 X-HE-Meta: U2FsdGVkX19ULNhVJKluKa9CnXjQG14+rmSS0GkZXONMCNFxy8hbn/YXOFLJnT8rmt5FGbBst3EKM/yz151Vp2pRNmPPm8NNN9W0vSEACrqxCwrEjKahInlW/tb6788GmNwBpwZ2I8fuA/+vR96KKdQ/3iAYRT+YXuakEvIgGmoHnGMFnuvx846mtEiYrSmpWFGqCgrCOKijg9WhZcIHME9dC9E2wPlc0bZ7ablc4/rMWK2iEmQElj6gEEBoqn9NAphw2fy0whjCi2bkUCpvizh1phY7yeB2JOODrf8aYaWpO33kiV3NZ7mHDj76dpkdgtbiFASAx3Tlm42D2XRGc/v3rrTAa/xDl9oBcmTDH8TlLNO19BmuIwYEerF2FiplwymUHoK6XwhnkIytwTnhJamTdL8ChYS48gGVlCd65akFIuz3bLO9uNKTiXMrxKQlMECkzEVDg4Swij1XofgwK11Hud5k9+cYZvbEFTf0MOBbHbF7wBN8rnbqqwBl8LLTUXucwkEZTD4+fFkGddxu4X0x8YrW5nXtzAxWqoZpVbOimA+IFlBABYLRJxu+BOMtoRI6B8a08QF1A4lQdcB/X/ebtqDuCNzMnLUb1VpeJZ8GusFDW7DoT7QR1lBBAEmCcCuTy9boeYdlp6QMT+Huk2ghNtvodm3I4hrU/c2hnPqZuo3MFZqMXpfExLWAV21WLIqTaBlL3biPYCEcNFE6PncWF0XlFAxjOH148zHEP49E6hxqvy+5Om5YOA4jlywgRvL9ZI1onGXl0quISN0J2LFWfl373hwQSiG7XzxxIWskRjPI3N3KvcMS7w+vVVi0IkjzISVFAIhX29wpOtX7TZyDS5drN4TdWvs2QDuAch2XJRi4e3tg6uSagUU4FCbwTOVgZE/k9N6nfOoWbvc1i9XaurTsSxIFgW3CVp9ZcuE3YPRLFWZXMVP29eiR6W/HBgDlfcQMFl2ClgWNRX5 967jsLh1 VXhIBB+EyPPtj70g59DW6zAj69XnWLsrY0tv2ddwvOzMhfft0ON3lpyzn6XPWVZxo58VIgBy7/DcC0Du7cOBWDagGPRncV5ilesTJkeoZNuBmeajdDpRxFm1xW4y+6CSJQ5DbkHJkQy/BKNVEKBt8d8rrnfV95Lx2a8f4TlmOK0xROht47AzCq581n2WsGUhN9w99lJMv7D+kDBgDqbk4VJ+w7pYyQuuwrvioo2BGZpIzjGecGipBsnxhUoN8eFr1Mt5FXfUiOXKw8OEJjj1woDfq18m6CFTCMfmnz9tKoC74V5IyK5oTBv+nOzLA0yieMkdplvrYX9L0kY/pFbLBWUHDHXWqZF70FHMM/n0haLkofe9RICp3mhTlhlJB+bbeQPRgYkb8KTCC5JtcdlrFQzaCuexBqdtJ+DpQfXyLyoFXcNKKufhKwogofKzYE2oVJXRKlPfbJR/1fnagkbSb+lUNjADTBw1NEM7tfl0UsRDc31S627gd/h8CwK9iX2EVEZ+SZXbcRuKSnGQE5TJNt1K6IA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The check of IS_ENABLED(CONFIG_PROC_SYSCTL) is unnecessary since register_sysctl_init() will be empty in this case. So, there is no warnings after removing the check. Signed-off-by: Muchun Song --- mm/hugetlb_vmemmap.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/mm/hugetlb_vmemmap.c b/mm/hugetlb_vmemmap.c index 45e93a545dd7..274b91d408c3 100644 --- a/mm/hugetlb_vmemmap.c +++ b/mm/hugetlb_vmemmap.c @@ -590,17 +590,15 @@ static struct ctl_table hugetlb_vmemmap_sysctls[] = { static int __init hugetlb_vmemmap_init(void) { + const struct hstate *h; + /* HUGETLB_VMEMMAP_RESERVE_SIZE should cover all used struct pages */ BUILD_BUG_ON(__NR_USED_SUBPAGE * sizeof(struct page) > HUGETLB_VMEMMAP_RESERVE_SIZE); - if (IS_ENABLED(CONFIG_PROC_SYSCTL)) { - const struct hstate *h; - - for_each_hstate(h) { - if (hugetlb_vmemmap_optimizable(h)) { - register_sysctl_init("vm", hugetlb_vmemmap_sysctls); - break; - } + for_each_hstate(h) { + if (hugetlb_vmemmap_optimizable(h)) { + register_sysctl_init("vm", hugetlb_vmemmap_sysctls); + break; } } return 0; -- 2.11.0