From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D34BC61DA4 for ; Wed, 22 Feb 2023 18:27:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D26F86B0074; Wed, 22 Feb 2023 13:27:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CD71F6B0075; Wed, 22 Feb 2023 13:27:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9E9C6B0078; Wed, 22 Feb 2023 13:27:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A96766B0074 for ; Wed, 22 Feb 2023 13:27:00 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 7BECAAB2D8 for ; Wed, 22 Feb 2023 18:27:00 +0000 (UTC) X-FDA: 80495759400.20.F52C4C7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id DC77C140015 for ; Wed, 22 Feb 2023 18:26:57 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gyy8EWcw; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677090418; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GnASALWcmQx9VakGnwgR1mxBal/Ve7GSPKBAGVW6jVc=; b=GI+mEoE1FjzQDJcIFKyIW+DGcaH/TCkzul+UTS1MjofjWRZ173By89qXvSdGnssa1l+Sh+ rycKO7yikLkA67ToRzSArlb9W5bsdGGfgybKGHuGGhL7skbUqoFRqstvGRDaAUK0M0HgR2 fmGEyAfFS7vii/U7XbHXwWk6BQxOurU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gyy8EWcw; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677090418; a=rsa-sha256; cv=none; b=HWQc3A8qYJ+3Uw+zzc8lwDysz8b7cW3Lkdppp589qmzdBcdUKeelQlGjMNg2xguo1oh5ql SAFi4rhkkSOEsUDpT4V0MNPzk4UKALHCwV0DD6pBLNJLntfrQRd2iSJqZheK+m6lJq190/ V5Q+jrHcgRxh5+t05uIVJU6bS5Wkes8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD17460C5B; Wed, 22 Feb 2023 18:26:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 424DBC433EF; Wed, 22 Feb 2023 18:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677090416; bh=xBFAtQy7H9IEzhN6tiCIgW4YKmQxOgfi228DV4+IAOU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=gyy8EWcwUoDh5Qjanib5yUoXbwdJ3E933glFTOrgDTICp8tQxuZZkdBWdCGE3GP5L IxTfwN+Fh1JdZsKTXuH3jKRJEB9zy2LO/NH1jbTZ7E/EOY4q1FNVRzyJjAoBxvmdDu MVV+eDn0AMPxdnL8Q0FRbrW2+coXXNG5QDtWh3vppgE5oVBaBvMuflomt+yJYgElsD MlPWYQGEs//RgjLSUiJywp5dwIEHNFErsiKFuvoqUa/G+n4gVnIs1G6MkBP917I6I1 Ekzw/9EtI+E+SdRK5UvkWyfFnnXBWppvc+L5Lm48S6NxOuPYko2N/twjqZwm5QpX26 VmfP0U9PyOClQ== From: SeongJae Park To: Cc: SeongJae Park , Andrew Morton , Matthias Brugger , AngeloGioacchino Del Regno , wsd_upstream@mediatek.com, casper.li@mediatek.com, "andrew . yang" , stable@vger.kernel.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3] mm/damon/paddr: fix missing folio_put() Date: Wed, 22 Feb 2023 18:26:53 +0000 Message-Id: <20230222182653.156921-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230222064223.6735-1-andrew.yang@mediatek.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: DC77C140015 X-Rspam-User: X-Stat-Signature: 84j3c4knpeyz3zrp8877xs3om1zkkz75 X-HE-Tag: 1677090417-133382 X-HE-Meta: U2FsdGVkX1+5NfP0IpLb/BJi1/ibBmNk2gTuBdT1NGuolVoEKs9gS+4cKUyo/RNJikKisejn2i3rZL1DCHUPooWwH4ZVFvFcyXizUYhFtoKY8SOai8YFi2OyGlApj8TbjJP0rJ7BYLHsgi9YTGJFk8m2crn6CImkxCEd5RMUU9HtJ158woSv4olUAyrXyB5bsf67RBmW07DjxvBG/nCYpbHFCgalh/qC4A6fXgq11tcwNRu0u/3DNX+LGlpqR+PeAaaW89tSTYeKP2MSn5eK5t5/4SJtq0NW7M6RWRsbq6jUDQdx3+kl1i27+6tTSclEkE42fsQxzboJZgQd6XjXK0Ueuuz5fI5XP6Ytl9deklX5QClTsdlbKdxDk6p+LliF2h96PFsBkNasePLdo/YHbMoAMZnZ8J9aaDVk1ZKYQsXowQ6NOhhbyAS+z6LdjzbbmMw6evotQqzAH7MLWPoNs7Nuk/w+3NqcG2bM7aYXLFolbAoR/qhuWvJC2n2KwgRzh/krT/gReTZtgfzRfRx3I4cpz2F58XTV4u0utssZ0JR83LsD/nvi/JOB186yGg6EwSDFLJDhV0Z89gT0xO545qAzLO+vQXjGOhLRX9U1Yg20dibH194jCRFwnP/gGu/ypB4+WACAHClsNVy6RmdRcMqSuau8KGfokq4tCHJhMufCuwBq0Facmh0Tok0yWeiy+kHqqKUEuxlnAzW6ZpbrJMZ9gi0vKvXgCTxQkp0khIqPfUOrJ6QfYIgSqnj6Fhg58kFxuL4knhZV6ebo2Mo9V+7v2MLYhdmGRzuJ59n7ghF0xaWi1Id7IKj1K9c8i+KfQniQbCe4rFoRg4tB9UAlKr1Ub3qzy9k/afSFZMaEBcJughwg7S/4/Au17v9UYzjW1zXuDseI9g3uH5wNI0n+PUlWJRGxjCPAnptyMjczUXbE83LTXiVMxN+9awyGdU2vYxJidse/urd2Gznr3Ut Z0u4MS/T RWUMQ1+RjS85kmklCTxySYLdQwbICjASbJSUu6cEg6IZq2YYqg+t2efQNDilRX9PERGALbgjt4GMe46ODHa5y58K5mypp9o8AwXzSsnjXxzeZz4C1yvXeqx7YiKJAKNgDoXgCTGnHxVu2nOSGhKeI0xN2hFB9XmsF733d9NGzPPc4Do88li+2/k6lMiBn2vRYD/0WMnj2yHsbNRk1b8HvUnVPzlf3X3rrA80xnMmDzpm2EulOtX6WhrNl8dg/zkg7s31Z39hHMKoLAu8vfwqh0ZwAx49rZrOtCtuo36db/atETpSF5YfAiOx1A+Iu3q8z+F9/HThRSlE/mIHpRIXp9+staAfMzfCMiQ8Q8XN030+ULVtFHU8FuG7mdI4dgy0y4xAasy2Q9XzVOr4/SXdrvfc30MK/SJy/XfnRygcbDEB8yMEJenoklHDe9RA6Rj62hVD9aHFxnTeV7rrlTASIp82PuW3xvR1kY8jlXnCOM605O5gnmDI4wJA4YwAYNlq3+Fl/3nCkY9sBytF3XT0mle+2AA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, Thank you for revising this patch! > From: "andrew.yang" > > damon_get_folio() would always increase folio _refcount and > folio_isolate_lru() would increase folio _refcount if the folio's lru > flag is set. > > If an unevictable folio isolated successfully, there will be two more > _refcount. The one from folio_isolate_lru() will be decreased in > folio_puback_lru(), but the other one from damon_get_folio() will be > left behind. This causes a pin page. > > Whatever the case, the _refcount from damon_get_folio() should be > decreased. > > Signed-off-by: andrew.yang > Fixes: 57223ac29584 ("mm/damon/paddr: support the pageout scheme") > Cc: # 5.16.x Reviewed-by: SeongJae Park This may not cleanly applicable on 6.1.y and 6.2.y. I would post backports once this is merged in the mainline, unless others do earlier than me. Thanks, SJ > --- > v3: > add fixes tag and cc stable > v2: > according to David's suggestion > 1. revise subject > according to SeongJae's suggestions > 1. rebase to mm-unstable tree > 2. remove braces for th single statements > --- > mm/damon/paddr.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index 607bb69e526c..6c655d9b5639 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -250,12 +250,11 @@ static unsigned long damon_pa_pageout(struct damon_region *r, struct damos *s) > folio_put(folio); > continue; > } > - if (folio_test_unevictable(folio)) { > + if (folio_test_unevictable(folio)) > folio_putback_lru(folio); > - } else { > + else > list_add(&folio->lru, &folio_list); > - folio_put(folio); > - } > + folio_put(folio); > } > applied = reclaim_pages(&folio_list); > cond_resched(); > -- > 2.18.0 > >