linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] swiotlb: mark swiotlb_memblock_alloc() as __init
@ 2023-02-22  7:04 Randy Dunlap
  2023-02-22 14:45 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2023-02-22  7:04 UTC (permalink / raw)
  To: linux-kernel
  Cc: Randy Dunlap, Alexey Kardashevskiy, Christoph Hellwig, iommu,
	Mike Rapoport, linux-mm

swiotlb_memblock_alloc() calls memblock_alloc(), which calls
(__init) memblock_alloc_try_nid(). However, swiotlb_membloc_alloc()
can be marked as __init since it is only called by swiotlb_init_remap(),
which is already marked as __init. This prevents a modpost build
warning/error:

WARNING: modpost: vmlinux.o: section mismatch in reference: swiotlb_memblock_alloc (section: .text) -> memblock_alloc_try_nid (section: .init.text)
WARNING: modpost: vmlinux.o: section mismatch in reference: swiotlb_memblock_alloc (section: .text) -> memblock_alloc_try_nid (section: .init.text)

This fixes the build warning/error seen on ARM64, PPC64, S390, i386,
and x86_64.

Fixes: 8d58aa484920 ("swiotlb: reduce the swiotlb buffer size on allocation failure")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Alexey Kardashevskiy <aik@amd.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: iommu@lists.linux.dev
Cc: Mike Rapoport <rppt@kernel.org>
Cc: linux-mm@kvack.org
---
 kernel/dma/swiotlb.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff -- a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c
--- a/kernel/dma/swiotlb.c
+++ b/kernel/dma/swiotlb.c
@@ -292,8 +292,9 @@ static void swiotlb_init_io_tlb_mem(stru
 	return;
 }
 
-static void *swiotlb_memblock_alloc(unsigned long nslabs, unsigned int flags,
-		int (*remap)(void *tlb, unsigned long nslabs))
+static void __init *swiotlb_memblock_alloc(unsigned long nslabs,
+			unsigned int flags,
+			int (*remap)(void *tlb, unsigned long nslabs))
 {
 	size_t bytes = PAGE_ALIGN(nslabs << IO_TLB_SHIFT);
 	void *tlb;


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] swiotlb: mark swiotlb_memblock_alloc() as __init
  2023-02-22  7:04 [PATCH] swiotlb: mark swiotlb_memblock_alloc() as __init Randy Dunlap
@ 2023-02-22 14:45 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2023-02-22 14:45 UTC (permalink / raw)
  To: Randy Dunlap
  Cc: linux-kernel, Alexey Kardashevskiy, Christoph Hellwig, iommu,
	Mike Rapoport, linux-mm

Thanks,

applied to the dma-mapping tree.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-02-22 14:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-22  7:04 [PATCH] swiotlb: mark swiotlb_memblock_alloc() as __init Randy Dunlap
2023-02-22 14:45 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox