From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BF78C64EC7 for ; Tue, 21 Feb 2023 18:35:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F86A6B0075; Tue, 21 Feb 2023 13:35:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A8DD6B007B; Tue, 21 Feb 2023 13:35:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 170556B007D; Tue, 21 Feb 2023 13:35:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 05C096B0075 for ; Tue, 21 Feb 2023 13:35:08 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id CBCBD1A08DA for ; Tue, 21 Feb 2023 18:35:07 +0000 (UTC) X-FDA: 80492151054.23.16FC524 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id DE7D24001A for ; Tue, 21 Feb 2023 18:35:05 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JaHaknMQ; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677004506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wEduu8lG576J1PT74GPwcOiZm9fPXyVi3oiEJ3RNdS8=; b=c6/yokaPgM7H8CfYZT8DHKivxbVynkHBp5UMuXc6V0i/NBHpfabrT8JgBBvQh2CfJRrstx W8KUw9FcEvg4IbgBRA9qiAmA1+gcnLYblukyeLUr2FX/BDd7grRkXRGxMr5qxZS6/jlGoV x/2O9cvt21hnghNhb005ZIGdqhGkQ3I= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=JaHaknMQ; spf=pass (imf11.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677004506; a=rsa-sha256; cv=none; b=WpHsGtMM/JTpQiMoxVokhue6/6VPtYIWNdOZX7/FWdptCR5/suUmh+ZikPLtA/kMYRQiUe oUup+AY1NGI2V4jakWc8Lo6KDnKZ2fvS4+MllnjJN0cYI4rujXR239YgfwTRw6hCGYyxZF RDf1Uf0rI3HVilaPKRpOfbzBbQI9EPY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CCDEB60FBC; Tue, 21 Feb 2023 18:35:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44575C433D2; Tue, 21 Feb 2023 18:35:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1677004504; bh=dgnjcSUG5w1/UXY20oy7pA67rk5DpCFG+LKqSztlm2U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JaHaknMQH94f0Ouz7x7+bJIIjbqP/1A+lf0z1r07/7u31jA6NOMhkjW7+NQyvj35e r/jQRM84dkmgFx+I10T1+lXThjNBjateNxycYIcs8ndkx+83AY7RtGGDH1RDlxKsfx F0ElKYH0Wx72EtvnPAl2tSazAPHRHXzUqgYigzELtugc3AHpiPANpZvByCujdPkOTF w0dPFwyDldQNFWCLQNnI2VnKaMG/a15VZoIU6XlPnNlL9JqQDQxANx9QltdGXZU71M Dl2ye6B6QBHGkFlvvHhMbYXijeMmxJYK1eg3IOhRUo8lxsPqfw5aljOdgLV50q/zFN Y/WQZlhgK3iOA== From: SeongJae Park To: Andrew Yang Cc: SeongJae Park , Andrew Morton , Matthias Brugger , AngeloGioacchino Del Regno , wsd_upstream@mediatek.com, casper.lin@mediatek.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/damon/paddr: fix pin page problem Date: Tue, 21 Feb 2023 18:35:01 +0000 Message-Id: <20230221183501.132024-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230221090313.15396-1-andrew.yang@mediatek.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: DE7D24001A X-Stat-Signature: fpe8m6bbf4a6fad4wns5n5gzgkrfc1ay X-Rspam-User: X-HE-Tag: 1677004505-548143 X-HE-Meta: U2FsdGVkX1/QMZwC7sqDDTOwBs2G8e6xqTLrPuAog3nGYOp6Ki01KLXXXj3Snf6EEdt8ZQJB9eINXzzEu0k3pTadcQ7MRkREa9FtMWqBEPkxPJWjM2GOqMJjnIZA4SQXYK92Xx7mSv9zzL/+MZVLY6p+ySEpDv882Vjg5MqT8qAf8he+xZap1CKgcjOk0ifdUWRWmxI2L1UYMVX/5dMXRamamgazPdVkp+fO5TsK2ZuPuCYBqsJ7n4i9+GW2yC0UOyyPKqlG/3Ndia6ifFBhcgmUYnRZHtDhDXq8QB3G9dMOCnLVJ6oyXK2edtXBdchPyH7voqM9mrOv+tV0uYuikcNF0cBsYXs/W33i0FB8z1LKMkTK5Tm2ibX5GAdvb/V179ovTc86HMm4ASGX9IkfJmvkSXeDMkIEDkIUx7bNHEpP2Ct5U8R2EfXjksooYOFymOaRnrstphjz4OVqWloADdJgdE7aBHUHocuke1PVldt/ZPesAIxHlPUaVqovmEQxK62UanSzLqC5IzVF0BRtSijylFs/VJCjDKiCpZJPD18JF7FDkPjqyyIQOS0NSKGlA/9yXBHXjUqnxEkyifpGXKkRICaycZLuwSZt9ElKHknwNNDeKWE64s1yJnFhPvJu3PwEs9TfznuZTvgVXxghCznvqcdgiE/AcCkRlWAns/wz/7vocVreLE87qtuY/T/j4/w6X5QbGCPzNb98J17MRCHff9i4WKuJke+n/YFc7qd9eEVh6Ngq4fURKLqBebM2JKG8vfYNEMl2rmZGd81bYnytHlT6FkOsfTZi+vk34g2KU6yj4KdsqSofMqQevTWcZZXHqbYIc/cd56VX83U1qBQM5KD9OyGesxWtlcXDmtuDWdFRW4cCqN9HNbePsu4M7aJjDPuo5TxwqN/hY5U7a6kAtOFI4GtqlDd/iMO9gPsCXLRFeIxuuts7tQccGtJPhg0N088eGo0LBDGcKc6 d10ByrsQ ysH4Vua2D9XMKLbbslpj/vBPF6NyOjopr7VDXDlbtfo9Ye/uFVFzFfx9uje521N6+H8nkSSa2zLjDtsSAE5/KYA01eE9UwkBA9X81ocQ7EgHcnzmz5CyMQtJbzC7Lmuu9jtUju9OUJr68C/UgEayw3AUVuqYFfogZWLIYjacvv0z9TROKJsH64FG7gwPAfIr/IyhcGinQdStXih7hHv4Gb83z9Oy0bvdz99zwvmf6SKvDoqC9aWwBqJ6KrSv+lI33zUS+Dk+gDmYSKkUyPIqiMcxNM+f70wGi/iMVGuSEmaGQY+MrtOfHGW+MpZsNZingWQ2co2e8UUkMx/mhtwkCYplOy0+OU0vKOSv7PsUxZ4Gd5VRRCc5LozwExYXUmNrvUbTtdqo1TKhez9en+JioDMB4/kiNSflXIGCmf+k51tb9pMJLmZtez5DzvgHdmv3j7XRG7oz+8Ic865R+SwLcfnmlsjsHv3GpItsw6I39YDNiVg9eUWr/13wD/QaqxYYWM29ZY3WqGjAaOtSEXf+g/JvqavIsr4oOETG+EJm+kiNRYdV/qs64Fy01VA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, On Tue, 21 Feb 2023 17:03:13 +0800 Andrew Yang wrote: > From: "andrew.yang" > > damon_get_page() would always increase page _refcount and > isolate_lru_page() would increase page _refcount if the page's lru > flag is set. > > If a unevictable page isolated successfully, there will be two more > _refcount. The one from isolate_lru_page() will be decreased in > putback_lru_page(), but the other one from damon_get_page() will be > left behind. This causes a pin page. > > Whatever the case, the _refcount from damon_get_page() should be > decreased. Thank you for finding this issue! I think the David suggested subject[1] is better, though. I think we could add below Fixes: and Cc: tags? Fixes: 57223ac29584 ("mm/damon/paddr: support the pageout scheme") Cc: # 5.16.x > > Signed-off-by: andrew.yang > --- > mm/damon/paddr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c > index e1a4315c4be6..56d8abd08fb1 100644 > --- a/mm/damon/paddr.c > +++ b/mm/damon/paddr.c > @@ -223,8 +223,8 @@ static unsigned long damon_pa_pageout(struct damon_region *r) > putback_lru_page(page); > } else { > list_add(&page->lru, &page_list); > - put_page(page); > } > + put_page(page); Seems your patch is not based on mm-unstable tree[2]. Could you please rebase on it? Also, let's remove the braces for the single statements[3]. [1] https://lore.kernel.org/damon/1b3e8e88-ed5c-7302-553f-4ddb3400d466@redhat.com/ [2] https://docs.kernel.org/next/mm/damon/maintainer-profile.html#scm-trees [3] https://docs.kernel.org/process/coding-style.html?highlight=coding+style#placing-braces-and-spaces Thanks, SJ > } > applied = reclaim_pages(&page_list); > cond_resched(); > -- > 2.18.0