From: SeongJae Park <sj@kernel.org>
To: Anders Roxell <anders.roxell@linaro.org>
Cc: sj@kernel.org, shuah@kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, damon@lists.linux.dev,
linux-mm@kvack.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH 2/2] selftests: damon: change scripts to be executable
Date: Tue, 21 Feb 2023 17:56:12 +0000 [thread overview]
Message-ID: <20230221175612.131555-1-sj@kernel.org> (raw)
In-Reply-To: <20230221070837.1502935-2-anders.roxell@linaro.org>
On Tue, 21 Feb 2023 08:08:37 +0100 Anders Roxell <anders.roxell@linaro.org> wrote:
> When running kselftest-damon The following issues shows up:
>
> '# Warning: file debugfs_attrs.sh is not executable'
>
> Changing the scripts so they are executable.
I tried to make similar changes before[1], but resulted in making a change in
kselftest following Greg's comment[2]. So it might make sense to remove the
warning message from kselftest instead of this change, though I think this
change also looks good. Could I ask others' opinions?
[1] https://lore.kernel.org/mm-commits/20210810112050.22225-1-sj38.park@gmail.com/
[2] https://lore.kernel.org/mm-commits/YRJisBs9AunccCD4@kroah.com/
Thanks,
SJ
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> ---
next prev parent reply other threads:[~2023-02-21 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 7:08 [PATCH 1/2] selftests: damon: add config file Anders Roxell
2023-02-21 7:08 ` [PATCH 2/2] selftests: damon: change scripts to be executable Anders Roxell
2023-02-21 17:56 ` SeongJae Park [this message]
2023-02-21 17:19 ` [PATCH 1/2] selftests: damon: add config file SeongJae Park
2023-02-21 20:10 ` Anders Roxell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221175612.131555-1-sj@kernel.org \
--to=sj@kernel.org \
--cc=anders.roxell@linaro.org \
--cc=damon@lists.linux.dev \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox