From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 725B5C6379F for ; Tue, 21 Feb 2023 09:24:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D57F86B0071; Tue, 21 Feb 2023 04:24:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D084E6B0072; Tue, 21 Feb 2023 04:24:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD0566B0073; Tue, 21 Feb 2023 04:24:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id AD64A6B0071 for ; Tue, 21 Feb 2023 04:24:10 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7BB8681151 for ; Tue, 21 Feb 2023 09:24:10 +0000 (UTC) X-FDA: 80490762660.28.9B0DB7B Received: from mailgw01.mediatek.com (mailgw01.mediatek.com [216.200.240.184]) by imf14.hostedemail.com (Postfix) with ESMTP id 76F0D100006 for ; Tue, 21 Feb 2023 09:24:06 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=mediatek.com header.s=dk header.b=Ke7xi24z; dmarc=pass (policy=quarantine) header.from=mediatek.com; spf=pass (imf14.hostedemail.com: domain of andrew.yang@mediatek.com designates 216.200.240.184 as permitted sender) smtp.mailfrom=andrew.yang@mediatek.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676971448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=DZiCKkXRKaBMEPM33tFzlW1XDIvB4CcSTT6creyaUOs=; b=uHl/t/Nbof/icC+LwHQM0AHpa+2C7mQ7r0uIVJYa0ZqGooDph+H+r15Uz8yL8aLeawzSpZ kZREBKMLFUUoaLmnbJnxZKyRpniwrs+8fTzKiqeBohfWVP2NpioEgYvFegkp6qnMiyqfcE X7GSBtRbuxtTEeXDDzOUz9NIC46u8ik= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=mediatek.com header.s=dk header.b=Ke7xi24z; dmarc=pass (policy=quarantine) header.from=mediatek.com; spf=pass (imf14.hostedemail.com: domain of andrew.yang@mediatek.com designates 216.200.240.184 as permitted sender) smtp.mailfrom=andrew.yang@mediatek.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676971448; a=rsa-sha256; cv=none; b=dLm4sik3IZAHEdI4IRsYdP91FDDMa8oaxnJO4VtKgjul2R6PPvC0XpeyQdWYZ9Pzx3kQ5c Cs3wN4UKfMb4YsAr/ct2FovMKkkQgS8MaGxlr3Fm02cdEGXtklwUl/kWXN6w5GSopbKro4 4TUoovJuGlGdL3lcArOyhz6NiDmoERs= X-UUID: 7901fbd8b1c911edbbe3f76fe852e059-20230221 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:Message-ID:Date:Subject:CC:To:From; bh=DZiCKkXRKaBMEPM33tFzlW1XDIvB4CcSTT6creyaUOs=; b=Ke7xi24zxJ4Fc0DrdI8y4+RFQ3//kqLq0/lcATVL19t65+Qz27ioUGdEr67dGpreLRVR9jCR9Y/iYD3yvWyzjbhnnkNyrqyzshw+izTCkqwzQl6afvc6QX50rxevcrI6MCTOgGOqsRacFbr4uPjWxFa+H1xuWLVAMVcZfQ9TMJs=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.20,REQID:9b412b9f-89fd-4935-985c-544fcc23d9f8,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:25b5999,CLOUDID:61441cb1-beed-4dfc-bd9c-e1b22fa6ccc4,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0 X-CID-BVR: 0 X-UUID: 7901fbd8b1c911edbbe3f76fe852e059-20230221 Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1663150472; Tue, 21 Feb 2023 02:23:59 -0700 Received: from mtkmbs13n2.mediatek.inc (172.21.101.194) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.3; Tue, 21 Feb 2023 17:03:24 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Tue, 21 Feb 2023 17:03:24 +0800 From: Andrew Yang To: SeongJae Park , Andrew Morton , Matthias Brugger , AngeloGioacchino Del Regno CC: , , andrew.yang , , , , , Subject: [PATCH] mm/damon/paddr: fix pin page problem Date: Tue, 21 Feb 2023 17:03:13 +0800 Message-ID: <20230221090313.15396-1-andrew.yang@mediatek.com> X-Mailer: git-send-email 2.18.0 MIME-Version: 1.0 Content-Type: text/plain X-MTK: N X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 76F0D100006 X-Stat-Signature: 798rwr5a51f5cou6ie3ehd5jqwxn37ds X-HE-Tag: 1676971446-389602 X-HE-Meta: U2FsdGVkX1+G6EMEO/qwrRkTrZS0o6lgmkxdUmCBVSdi0tisgZ6OrM7jSz60p9+phXguFg4LKDgRqQ2KWpY/i2yJolNmOZJ87t2l1rDPWF1CKMI2+HFo67H+5Az2Kk188VwZbyer03163aj33UNKkNC7UoTgQkJzUZW7jQdHVKKv0MQcor3GRKzKpc7X7VVHpB4z5jV5kGv37c32kX7+4VhOBaQyvi1bwaXRUYriNm3w9rsBxttxH+JT0061nWQzM9nsYy3p2AB0W2vGmU/vJYzEUdqpHqDH9VBEom1b3h17Nvw8zRtSM3mjSoDtXy7BB3/jjcZjN2zoMFxw93EIg43qmqER4YOHHy+tGIYIfOui0vgqyR8yFFnI/1ZBn+/KOFBC6vjF1+T0G8M865wXUe5fo2i25jTBpQCbhijRRaABI6YT/Fd+LK1IrdkhhTw5wLEjgh8VrjtFJbC9P/I/w7UqOlldHmYxP2itC1LUdwIjLpgIUNr57ht7BPBoCtA82/pDJE63LsNIsAvfQzmqKOAPeFLDweHlHEHfo+kdy3mVpgIK4P8K3GoS1mHASh8EKMHa2Cbd/v5P+A2Hs0bFWjCnBC1/Y+oTIa90Wlt/FtyMYTMa66QALVkWBSYwBbP7/aaj7WqkjnMJCLtvFpsc4sQvyD9SEN6F9HIe0lp/mr1oLiG/EBOMEYSYhAMX0egFkaNq2JT6kJQccByZF7DEa407yVUtPLoeRYC8PDa+Ql3tqT/py5Re6QtnXs0HS9ivhLrcdUIhsW1H2CGsVga1LqoXqH9Ke8+io+aWBj/Zsjnu2lZvYpWhHT7uwPc2P1j3ehOjIM0eXt7sFHiF0v8JCq/R7NEXgXfx7aRc7O96avjVD8jiVBhGJzM0IbX2WcvNPvqebfUdSLCm7yl90HhROlkVPD9GVs0C4jZFfmnzSjFwcxc2rlThPiAndfVARoP1OJ+/SGcrYZJ3MZiopNO s/KbvWTT aaBFrucFlYVBP+c4DNVLSzyvHWFe1NYnpEP7b4EIRuwXZAQ5s2iQTSccndrcVnc0PoN6F7DhpBB5v+UEG19lzY3cQEfZcrBC9Biho/4QxuYT8hkKAZqkjz3s/IFtimlic/vXiNIo+3ezZll7uHUVt7EDACcRqBkxwbLXGfT8WnGnn3UmNggOHzCFBY75T6+8b1onLO2jU4otzZP28FI4VH+vfrv6rEjsTlH5vnCK8nHTFVDTXV9ECWgNdE9zm/q3VS0zQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "andrew.yang" damon_get_page() would always increase page _refcount and isolate_lru_page() would increase page _refcount if the page's lru flag is set. If a unevictable page isolated successfully, there will be two more _refcount. The one from isolate_lru_page() will be decreased in putback_lru_page(), but the other one from damon_get_page() will be left behind. This causes a pin page. Whatever the case, the _refcount from damon_get_page() should be decreased. Signed-off-by: andrew.yang --- mm/damon/paddr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/damon/paddr.c b/mm/damon/paddr.c index e1a4315c4be6..56d8abd08fb1 100644 --- a/mm/damon/paddr.c +++ b/mm/damon/paddr.c @@ -223,8 +223,8 @@ static unsigned long damon_pa_pageout(struct damon_region *r) putback_lru_page(page); } else { list_add(&page->lru, &page_list); - put_page(page); } + put_page(page); } applied = reclaim_pages(&page_list); cond_resched(); -- 2.18.0