From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFAF2C636D6 for ; Mon, 20 Feb 2023 21:13:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F29036B0071; Mon, 20 Feb 2023 16:13:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id ED99C6B0072; Mon, 20 Feb 2023 16:13:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA0D66B0073; Mon, 20 Feb 2023 16:13:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CA78B6B0071 for ; Mon, 20 Feb 2023 16:13:08 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 995A7A556E for ; Mon, 20 Feb 2023 21:13:08 +0000 (UTC) X-FDA: 80488920456.24.42D0FC2 Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf16.hostedemail.com (Postfix) with ESMTP id A8891180019 for ; Mon, 20 Feb 2023 21:13:05 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KE1OVRc+; spf=pass (imf16.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676927585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TDIW4axl+hkN5j3NPMXP+ZPoJ29pdF3/fwwVKvtB5gk=; b=DvZJjpMYvgqY9/lBSIoRGHINHxrCpQXgooJoawYVYmDbv4CjUV58N70cj/aHhlnLXViGhu uAy/cUK9WN9FJsXNGTB5OvfogHYVL7gU5sIM5fmCCMxwTidsAxbFU9WKHvdNP2RYTk6MIJ fA8mdkT55AcTrrGUCmNtZvVSvGk8Dkc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=KE1OVRc+; spf=pass (imf16.hostedemail.com: domain of zhi.wang.linux@gmail.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=zhi.wang.linux@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676927585; a=rsa-sha256; cv=none; b=InlCn0yZOiDRZ8di3bijSQ0vhV6jCz1j7KjTY7OlcZKOQeDlPHBSoOveN3Q5olzoF3lBMu wU9S21sh0ZK40mDNlLtVm4/NzHR3Eqn8j4kpGbROlMbYCsGL2dCaKDgHotw7ROjyCr/FDr 4VeLnXwRt8GzGG/0iHpbiyQAH5yDojo= Received: by mail-lf1-f47.google.com with SMTP id s22so3094667lfi.9 for ; Mon, 20 Feb 2023 13:13:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1676927584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=TDIW4axl+hkN5j3NPMXP+ZPoJ29pdF3/fwwVKvtB5gk=; b=KE1OVRc+qlYS5auHFljuhewLrBtTVsN/HV2pvtiQwUrLF6eqwzmYRitRPsdm8PzCKP f94jSIuX7FTmGS11bxjT4AvvNxyrRqcYUiGEF4Ng3DhvV3zoLw5e9pxiCp4QQ8OrDhxX +IYExd0hsXsaDOmT+Huu4SvNvPABnALW1IS0k8plNRR4mfpDqb94BaZcW6HC6enQPONQ 1emTmsmu6j96DIDwBRU9vHZSilWZTAUV76IdLSvjlWCEwuOHk3swIZ9ku21QyrPbomhK StQA/UBsTxKBtZ+RXC4bCF9FuQXIXP0dNTDB6/L1AxVvsISpEQu6VSEPEOdLzBthSfmK X9Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1676927584; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TDIW4axl+hkN5j3NPMXP+ZPoJ29pdF3/fwwVKvtB5gk=; b=HF3SOmns6tgEFlIZg5Z5sIOi4zuTBvyk1tN1JJPhf945HPQmUi4FaQX+5a/IVYoz0d MWS54jtrtbW4dUnM/zQ17ACZqNz7godjeyujLnqGigv4ZazR1plDgegAsoIua2hVk3tm 8oSkKsA5tZW22rY9lGiw4Pc2CrkWQ/H2eKY8tK3JB+5wvKYayAP9077+Sai6DeyLFzqW GH9699eOeB45Jz1wnX4lCLVpZQhBozcGMoAfx0jyem62gIC9WJ2Fmorl3DXnejWwqslx TWvTMx+cFzgFLCXeUKdJqqKxMqwvuAiGhWdNSx4hi+V+z6Tp1MOLTj4hq/ee/4Ubmmuy 9PQQ== X-Gm-Message-State: AO0yUKWdlil4gpZLPUDY9O94X3iKUsVbDaeWLymqRzPzALEIupVuOaT6 c7w5ulkil9ubwNDbvs1hyX0= X-Google-Smtp-Source: AK7set+SFmQKGMJwRWrnol+bh+JAzBSaJAJIcs3b4nUG3o31URK0ZZcsUT7nvy2Smugv5Xzpba5R+g== X-Received: by 2002:a19:f00e:0:b0:4a4:68b9:26c with SMTP id p14-20020a19f00e000000b004a468b9026cmr795903lfc.6.1676927583594; Mon, 20 Feb 2023 13:13:03 -0800 (PST) Received: from localhost (88-115-161-74.elisa-laajakaista.fi. [88.115.161.74]) by smtp.gmail.com with ESMTPSA id u10-20020ac248aa000000b004dc4cb4f9c4sm1625853lfg.35.2023.02.20.13.13.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 13:13:03 -0800 (PST) Date: Mon, 20 Feb 2023 23:13:00 +0200 From: Zhi Wang To: Michael Roth Cc: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH RFC v8 19/56] x86/fault: Return pfn from dump_pagetable() for SEV-specific fault handling. Message-ID: <20230220231300.00004591@gmail.com> In-Reply-To: <20230220183847.59159-20-michael.roth@amd.com> References: <20230220183847.59159-1-michael.roth@amd.com> <20230220183847.59159-20-michael.roth@amd.com> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: A8891180019 X-Rspam-User: X-Stat-Signature: zy7fqcn3j7rasamyfmfwadhscfq7zge6 X-HE-Tag: 1676927585-305301 X-HE-Meta: U2FsdGVkX1+fDN43Fj5e0HY5noCqJb8sOO0k0swNHlK2Ql1yB1rP+mRJ1SpGAgisYRWzhXeaDv5Tgo6eOURqMbvNXvG+1nsfRqyqXOefukS97XYk0RMuFh44HtN2djRU2X/qGcGAjg+OsqJXmnN0KHeRYt4Ffziu4YKeQtauhzeJBWz7e7+QxOZM6lL0KgbHw738sVf6B67pB00iAsMGecjDD5NuWFWqcJ8pfdPQwKlxiQrBb7eq+9gONuVKCp8a7zWaTmGjOHAdi7KPGFn8dPv4/UIGy1GN9E8lfQzXmYiP3eFJT7aECzgqRS40v6maP3Qgr47sLhPH1PtsMbbJv5oja7MEcPHEkHGV2tL3UpFcqNHVvf37xIrkzEOnRLoYBnBc1ReNluCSF6eGRgGvtJew21e0F/ZbjIfM2hFWHgMNqG52RswO9LEoIRxwz2zcog+xV3nxG17zlSItwWRxtmSEuM6QIPIOJQFP6uZIKF/b8U5rPw0/9DporxrjkJFzYhPXh4AiTOh0InenCIFEl5KkPyku0mML/tDzA6RksLw3JAg3WZECJOnYTW0BsvhomwZu5OpbV5DiQE8D6zykEJHJH0ZLlLsNS0m14p7HhsupzGPaqMXfajvOnKOKmAkxghWlvOj4h0ihAK/Eq39q1LJwzOT91eORPYru4efmfHoc/EXKlprquJF+QekopcpEN3twLQUAssIBHsf+sYy271sd75zpEkXymwjVEMYmYuuyiGv5VQuhQX+lC5tbyTTI+AsrzNofebSJxgKyeejVp5v/Vg2D3ec/Dtljkp9ruiGAMJ/RmB2kKoKH9jO9D4zILZV5JXo45pK5281oYUEuE2yx66b3Al25foSiNELds34RTLBuEHsT+yyx141l1n4hISyP4TkCAAdDS8v+ZJ9/M/rCVdYfzQSPdx3qRlcRW5+CVRzf/gK3di0iQgf7aqejMk+Xh1kRIbu1OVgPZRm OjmIxqLM 2cdMzGNp24VS+was9HyaMEW/TUXxWQ0PSSU9TZrq58BaI+sOTLLPlZSUZkhREjINmtB0WJpuVA6SmDJ1htnZdHj++0fQzP+bBqy3iX8QJPFk0RJ0M4gDCCk8Q5jt34ItItHtpJV0nHYXEOFxmLn83AsQAWRddkoVOdDNm3RrnT5GOs/96VIB6hUotq02Az+hfc+D3A50Uuk9t39IJXLeMPNXv5TaYctSXsJ39ynWLsoH4w1TLL12NYr+NLTlpq5TlR32dbYqjBtwDnzZdlL2WrcV7K5oegNUJv9ChV/HILAvRX+yRHY2zhRnp2ve7l3Yf0u3ZHt2F1bf4jT4136UhyI6WTNyq/Z52M6AvdMNnwNNB4zBWLdM/Itv7BlQZWCO0RrWEUX2K45qhnpyLgbUzLT5kfKq/SzwUZ+HFuRxEUWWraDzw9HzHHw0k9H1A9mFJbz7X4kBAERwM63uufi5wwK9MJALLbSohn3kMSSpDyxKX02L7VE9piPFROqZ2QgBazK2FA+SsFkB5tr2jr3lYDatn78GTdKWe8MsvD4JLyc7MrXn9qMsY0ZGKMdrLq6PqaIB/fM6o3bpQxeMZravQP+AOag== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 20 Feb 2023 12:38:10 -0600 Michael Roth wrote: > From: Ashish Kalra > > Return pfn from dump_pagetable() to do SEV-specific > fault handling. Used for handling SNP RMP page fault. > It would be better to merge this patch with PATCH 13. > Signed-off-by: Ashish Kalra > Signed-off-by: Michael Roth > --- > arch/x86/mm/fault.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index afd4cde17001..f2b16dcfbd9a 100644 > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -311,7 +311,7 @@ static bool low_pfn(unsigned long pfn) > return pfn < max_low_pfn; > } > > -static void dump_pagetable(unsigned long address) > +static unsigned long dump_pagetable(unsigned long address) > { > pgd_t *base = __va(read_cr3_pa()); > pgd_t *pgd = &base[pgd_index(address)]; > @@ -345,8 +345,10 @@ static void dump_pagetable(unsigned long address) > > pte = pte_offset_kernel(pmd, address); > pr_cont("*pte = %0*Lx ", sizeof(*pte) * 2, (u64)pte_val(*pte)); > + return 0; > out: > pr_cont("\n"); > + return 0; > } > > #else /* CONFIG_X86_64: */ > @@ -367,10 +369,11 @@ static int bad_address(void *p) > return get_kernel_nofault(dummy, (unsigned long *)p); > } > > -static void dump_pagetable(unsigned long address) > +static unsigned long dump_pagetable(unsigned long address) > { > pgd_t *base = __va(read_cr3_pa()); > pgd_t *pgd = base + pgd_index(address); > + unsigned long pfn; > p4d_t *p4d; > pud_t *pud; > pmd_t *pmd; > @@ -388,6 +391,7 @@ static void dump_pagetable(unsigned long address) > if (bad_address(p4d)) > goto bad; > > + pfn = p4d_pfn(*p4d); > pr_cont("P4D %lx ", p4d_val(*p4d)); > if (!p4d_present(*p4d) || p4d_large(*p4d)) > goto out; > @@ -396,6 +400,7 @@ static void dump_pagetable(unsigned long address) > if (bad_address(pud)) > goto bad; > > + pfn = pud_pfn(*pud); > pr_cont("PUD %lx ", pud_val(*pud)); > if (!pud_present(*pud) || pud_large(*pud)) > goto out; > @@ -404,6 +409,7 @@ static void dump_pagetable(unsigned long address) > if (bad_address(pmd)) > goto bad; > > + pfn = pmd_pfn(*pmd); > pr_cont("PMD %lx ", pmd_val(*pmd)); > if (!pmd_present(*pmd) || pmd_large(*pmd)) > goto out; > @@ -412,13 +418,14 @@ static void dump_pagetable(unsigned long address) > if (bad_address(pte)) > goto bad; > > + pfn = pte_pfn(*pte); > pr_cont("PTE %lx", pte_val(*pte)); > out: > pr_cont("\n"); > - > - return; > + return pfn; > bad: > pr_info("BAD\n"); > + return -1; > } > > #endif /* CONFIG_X86_64 */