From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 815ABC636D6 for ; Mon, 20 Feb 2023 21:25:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13D586B0075; Mon, 20 Feb 2023 16:25:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0ED816B0078; Mon, 20 Feb 2023 16:25:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EF71F6B007B; Mon, 20 Feb 2023 16:25:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DF8CE6B0075 for ; Mon, 20 Feb 2023 16:25:14 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AA907160326 for ; Mon, 20 Feb 2023 21:25:14 +0000 (UTC) X-FDA: 80488950948.25.701C525 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf20.hostedemail.com (Postfix) with ESMTP id BA7031C000F for ; Mon, 20 Feb 2023 21:25:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=N5kDy3DC; dmarc=none; spf=none (imf20.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 209.85.214.177) smtp.mailfrom=david@fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676928311; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QESLl69yTFuw/UHokvPcBCupvaRLpWJFOxU9lYfGwWo=; b=Q3tjJqNdmoFwyVH3gyHRIGuF+RDARUMUfc4KxWRVT89YdIphrQvTkcLsJNyYi5RK11cIA6 tEjWGA3nqK75OqS6kuTKdC1+dWwCE/6oZDeuNm436C6NOKvCiDU7h1RVv2vVqmOL5S/asl wSNtcpIky0SO9bR0a2lhghNlbwfCKno= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=N5kDy3DC; dmarc=none; spf=none (imf20.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 209.85.214.177) smtp.mailfrom=david@fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676928311; a=rsa-sha256; cv=none; b=LSt6ij2KunzjoZRQpmQ4ggVRj11oQW8lmAV3cKeShQbchULI+CsHdhyLZZ+DF3j/4fUrkV MCZr4lBN9x7XwOF8D2sCxcO+tstw3Xcz6T9GCeynjIE5WCpto2atxWH6j7alLoQGISkOD2 vaxGBoKUpTn5D6RMOwaXmDNdmYNVfdA= Received: by mail-pl1-f177.google.com with SMTP id c1so3135154plg.4 for ; Mon, 20 Feb 2023 13:25:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=QESLl69yTFuw/UHokvPcBCupvaRLpWJFOxU9lYfGwWo=; b=N5kDy3DCypsUjNTIL6uKqPnIi4VuPmqW/5tC0XFeR4brBKCtKvN+UyuKUVGmY06M0r sqU4mlP5niEuq7PrXx4wZlFEqrMe/1cE7qvgAttb/jZOt6T6Egg+dd5TkiAeo1q3igMx woZqabfyycCzfKIe/OhmkQwObwKvDhvIXyYKUmG5xYEwZbx4LydK6tsL5DkHVdGaQPz+ UGFB1y7LLPxMky0ZXcdRcqO+b/sepsCmbJ53Ch2qjYGFnID2tPRxSkN3Zh/KKk/yL8wh vSrFRSU0KA0AVOYVMpFoth6W5HDuoBsUQ3CGaOipNmKzGGSydVezHT3ZivmEpURxhaKy Tkyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=QESLl69yTFuw/UHokvPcBCupvaRLpWJFOxU9lYfGwWo=; b=TeIDPYQcq1D0CwrWAhfYXjEVnLFMTYxvIZxebf0l4qJyZb9D5LT4NN6XQf/ID9cRYx bd1/cvxZjMpSBz4LzRX9AB0Kxa++iKSc8zDGX1LjGALfllNBC7DiDqbt2vQyRagUa4eu x2OSjxL4jgrHTwngjV3AnfRrJaUWyKIXicoomtDMNTDNmfaLwrgFM16iTEGFylNux6mi 42o958befvP/VEeK6qFOu6qnNP1sZs+YGEyvbP7dsA982HTxSVShi9wNQpEfX4H3ztSi 5dfpohhZtfe+xjYqfnQtn5MHUHkAr0JBBeUTFHkVN19yqyp5qgwtltQgOyf0Z83urQym HXVQ== X-Gm-Message-State: AO0yUKXy7I7vWewDjELvgSwhQHf6/oizwz49K+mWA8imHh+EO8wnrBRz E67vfL0P6kEsGmgvXMCuOvuh+A== X-Google-Smtp-Source: AK7set/7p/rU3G5m3+Tu0pQdEIVeL6cGQ6eHnMmFlnj9qkTBEkSagKYJEBYzfb8nFNFw6MFe34UtYQ== X-Received: by 2002:a17:903:234b:b0:196:595b:2580 with SMTP id c11-20020a170903234b00b00196595b2580mr2854902plh.0.1676928310567; Mon, 20 Feb 2023 13:25:10 -0800 (PST) Received: from dread.disaster.area (pa49-186-4-237.pa.vic.optusnet.com.au. [49.186.4.237]) by smtp.gmail.com with ESMTPSA id h8-20020a170902748800b0019a7c890c61sm8337880pll.252.2023.02.20.13.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 13:25:09 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pUDek-0007sH-Ij; Tue, 21 Feb 2023 08:25:06 +1100 Date: Tue, 21 Feb 2023 08:25:06 +1100 From: Dave Chinner To: Shiyang Ruan Cc: linux-xfs@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, djwong@kernel.org, dan.j.williams@intel.com, hch@infradead.org, jane.chu@oracle.com, akpm@linux-foundation.org, willy@infradead.org Subject: Re: [PATCH v10 2/3] fs: introduce super_drop_pagecache() Message-ID: <20230220212506.GS360264@dread.disaster.area> References: <1676645312-13-1-git-send-email-ruansy.fnst@fujitsu.com> <1676645312-13-3-git-send-email-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1676645312-13-3-git-send-email-ruansy.fnst@fujitsu.com> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: BA7031C000F X-Stat-Signature: 9it6xxbajuqitjo3ngdpy6nfdne9maig X-HE-Tag: 1676928311-716294 X-HE-Meta: U2FsdGVkX18dTZzqP6BGsQmlm1vQWV61EZoxq5P7CPyZItYyJXJmzeWL2q83jqhGA3+6PXRDOCAaMfDOf6FS15N1FLUjWoocMRG6y0/t6SqF4eVFWDdZO0pYko1yFzK95Id5C4FnDjclJeoiq9XGCddF44fjXj/z7a6mIJljCHe7/tD/ySt6eknyedx48Gpcds8xiHgATrO+FEa1Lv4M44EBSFsavcKOBPej5u9v5Ey4TAsV4CWnH40d0LHrgIlsbzCD2DRkoZH1wGJ9BYKNFI0S84QkoXgS54EPMBSH2fzW4vw+QSOyFyXj1ci5TZRllMX/zEhxfMKQLUPXwer+3t+8k9f2makktP4NLoIfhoqmdVfh8NQKjdX+cfsybTu3l30GFoNjlCxOFcGTprjQ5qBENpUCSfk4JY7y7UEp2MrRrFFhuu2f1u7z6rnqaOKJzK+TRK1ipxiaitoesbW2VtjhOGQv5bo3mu5xrdjKGIM7i8GOm+ZB+ZornFArK4tlx+KchSdQCNDjt/FQ2XghQDLm69FrDm+J2rFm4DuEobjeaqt97Y9gIi5g0iPhAV+TTv594/aYdMdjOMyyFYErYJWgX0dW067ULmLe+OjNlA/ETIQE4G33FboPpYsPgweIIwQN1hXUNh95hErDDWm/nbqhObPg7+Q9Z8TnEiE/1yJhUA9E0prssAuMa55DaRBf4p78WgXmJEVFxpnIlyTfNXFZT6kgz3mo0x+EC79MM1bX6fubIzKCaSn2YFxRA+GZ8xdETT8LkezuwqyIIqPVIwc7bGSxeyQwlcyE5x29EJkuQX0VhQrph7kCeDwwMY5vTebLE5gv/zvT61+0vlNvFe6zzi/BhTZNt+QgTbRQ100tQvS5ZCtqQTwRFeoibT5LO0F6dPvh2Jvf/JyusDSDaxWn0iLfnhg0/pP0hIo/exFFdjM729eaM4Yw3xt7HwtqrMbdsrN8nDVsJfQarJh IjdbbXPX AhUsGOL+W8YZfjSCz1a4vHq+7j8mgcYu5WQ1YLRjIhrlI2mhR5u3onOVWvf32OTFwQoEdp+zIT4UVnkiGiZ6uWDtqh3j/8KhDsk9uPePhLbVQ0il80innC6hMk1Yt3omoXOmzK4o/HH0GOD6KEvAu+oqpUWG/DnD8qNWGXipKRJ23gi4pZY0Fdv24GmrFmH6h0zqjdMVQrEdjNt/5Ak2ictuxEl+UH5x3SlYvZBXu8dCd0/vyIP8o4nr4F1gAtQnlStD41fuAaEX6LSONW48CaHb8usR9IXi3ZQw2Qc8c0z+a+iaykI3+VXYR57mECnmv/cmD96rhBQADIjdVf2FQXeBguNGbvQUnfky7En7YhPudOVUfNf8q0RXoHJFbaX8N7IDDFRehTHM5Bkwdq5FfFVRUCP+VW+sSpkPh6Knu9S/d3VxKwJkxD6tQZnDYy3nmJCJD7MXENr3KBmmwzEXaXAeVw15ky5HiRP7Ui3UNAZQach1GWXZRjpve2WYXvlIqnLB2hllxAT6zIWEl8j0KXcK1iTUWuZxw/uqNVyt35BiTBEM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.001842, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 17, 2023 at 02:48:31PM +0000, Shiyang Ruan wrote: > xfs_notify_failure.c requires a method to invalidate all dax mappings. > drop_pagecache_sb() can do this but it is a static function and only > build with CONFIG_SYSCTL. Now, move its implementation into super.c and > call it super_drop_pagecache(). Use its second argument as invalidator > so that we can choose which invalidate method to use. > > Signed-off-by: Shiyang Ruan I got no repsonse last time, so I'll just post a link to the concerns I stated about this: https://lore.kernel.org/linux-xfs/20230205215000.GT360264@dread.disaster.area/ -Dave. -- Dave Chinner david@fromorbit.com