From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E44AC05027 for ; Mon, 20 Feb 2023 13:22:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C2616B007B; Mon, 20 Feb 2023 08:22:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 871706B007D; Mon, 20 Feb 2023 08:22:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73B0E6B007E; Mon, 20 Feb 2023 08:22:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5DEFE6B007B for ; Mon, 20 Feb 2023 08:22:47 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 158771C580A for ; Mon, 20 Feb 2023 13:22:47 +0000 (UTC) X-FDA: 80487735174.24.5961DCA Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by imf05.hostedemail.com (Postfix) with ESMTP id 2D603100013 for ; Mon, 20 Feb 2023 13:22:45 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m4sHT58j; spf=pass (imf05.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676899365; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=su9AUGykhersjsst4vs9klhjt/8CsSP7xnYPDmfSl5c=; b=SYwhuR2B1Sqzur69wHsouXF4PqUxzveBsFKb6Xkhtdk0rgYazbwn6YIopSLHawThlZmBuC F8T+60GP6QisanHqDotp99w+JiOrHd94szPwdaDEwgnLF3GhiMTZrz5n9N8wao9/yGDmoB mE7l5tezva2FIgomS+kr83tdphUhL6k= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=m4sHT58j; spf=pass (imf05.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.216.44 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676899365; a=rsa-sha256; cv=none; b=yzLHOT7HxUKrkF7Ust+LlHqZZoWVxomhXMk3k56eVW6lEy5rU7mRzpUAGDZRqUw1vsv/O+ AgSWwiRm34W2Bcj2YLfTovGG9wAH70lLOmngdc4a+RxDeN78pcDCwnzKrTfE6MWPJxktjj /ghAmYaLwZeECszhvbfOguMIVWQ6u/0= Received: by mail-pj1-f44.google.com with SMTP id il18-20020a17090b165200b0023127b2d602so1442352pjb.2 for ; Mon, 20 Feb 2023 05:22:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=su9AUGykhersjsst4vs9klhjt/8CsSP7xnYPDmfSl5c=; b=m4sHT58jIbhWJ3czvzfGCWiobij/g12pgUp0L9wpWvw/6qPQYP53ZQY2sFTWX2cB0J e6oF33FtFps4j5tJIn9xs/UrxS/RCG+vXjThyqMGZKgCYLOSqYhzdpqjNdgO2a5YfpLh qGA+U9K94VcFByTssTsTcunOYV1zHyMvV2Blyl9lMPJqlR3oniDWl2nC6YO8Ovb03spc rxArW3B4DhtAPAbF47d/NSr32KgEsFwMBUEy5AHpQ0pGesmEkZAqdaZhiGnNBbPGZNpO xJ7x7IySYoBmkQnICgFLwy5YPaDJfFkOvDZWhE7zyoc0MPEiD2jebHXNKcVwSMgSjHcN BNjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=su9AUGykhersjsst4vs9klhjt/8CsSP7xnYPDmfSl5c=; b=XVDCu17zWw5VwgEUH9jZgzWX0ApQuFUajniH7qTUDRieSbZs13Tf0wZZcMcX0cn2+x Q9xVwBe5x2JVFAaTSDKLogZdr4YHxzEACe0xj+5V3WOfFPG3A1tpN3TwTfIdIIovD1xh QfT0aYJtzs8yLfowWvu4ZPWy2cvhQEpbZLyCPmYMz2hhjWe6Sn255OWJZDh409pgBZAL qHGrNRhTu1DavrVskjsWCyxNUA07BZzbIVUumKB2a20RJl7a89vRj09YYSIv0uLExUec quujqI6U8OE0rMKTUSB4BZOAkvN+99NnZL+0uFAnB93n38VqAjRR98iSTzGn/8SrbhRM 6hAQ== X-Gm-Message-State: AO0yUKUAsTPGj7zAZ+PE+oYVYaGsDQNbUuoo3c1LN24RvLJWb1kQ3zoR RAA6ks5PgMlGDIBKWULAyadoEDhnpk3axg== X-Google-Smtp-Source: AK7set/T1mg4U7o08moigSuVSJRAus8woDkV8CIDUm/5jwO3jQxCdTocbBTL70Gb+HBT+mFLqLesXg== X-Received: by 2002:a17:903:28c3:b0:199:219b:f81d with SMTP id kv3-20020a17090328c300b00199219bf81dmr1871000plb.47.1676899364633; Mon, 20 Feb 2023 05:22:44 -0800 (PST) Received: from test-ha.kr-central-1.c.kakaoi.io ([210.109.63.229]) by smtp.gmail.com with ESMTPSA id x2-20020a170902fe8200b0019c13d032d8sm6125436plm.253.2023.02.20.05.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 05:22:43 -0800 (PST) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Minchan Kim , Sergey Senozhatsky , Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [RFC PATCH 04/25] mm/zsmalloc: add alternatives of frequently used helper functions Date: Mon, 20 Feb 2023 13:21:57 +0000 Message-Id: <20230220132218.546369-5-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230220132218.546369-1-42.hyeyoo@gmail.com> References: <20230220132218.546369-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2D603100013 X-Stat-Signature: ju7apeaq94bxkwhgwb386eh3uxyekuks X-Rspam-User: X-HE-Tag: 1676899365-112830 X-HE-Meta: U2FsdGVkX1/ssaXtHqTvxAUpZmWDQsxSrZme3Wa7KESJ0BKIpS7OUQJYf6X1HcSKXIZfFl78Yxa3wPkRZipg/2TraFbTXdjk+TJ0CitEBWUUp3/aEuWr1waCjriCeqvuEAXGk8Zo0xKFZ9MiKShudsEPUwOTX65tcoR3RGHZAZ4HHvj9JwSKEc/dHulsZD3ImdyLAurzBGssXcrODg/6eEHB4/3sN77WYqcHEcpoJ38yauwVpzd9IXZI34QW2k1Ze7o3c0LlWRgb5YVl18fDiCsZiDFChJfL0xf2RBVZ8QxKblTfpREWlkUPFRScUfDQEUnA+b4ISbWPATtfMJvqTwroDS2dSOHZOF7KB0Pot4vcoVeldQjgsru2xNDwyilFdSznCmndjzIIqdAnBcLCkUMp+qrCMlfazTaT0RtVwaycuQwW65Fw0iyMhRx1c24TxUm6w4vlUOUOl4vGBcM6tCR58a/IKDma4UEOYQBPKc+xN3NcwubMlwj0s7sg0vcDSFWEdTsidQ+f5ogUohh+LV6qVrU1ZaniiMcF8EuTEpw6LL5Z1Lk+bxci1Hhhn0gSYLKIdCPJ8BdPN3eBFCEMrfU7eAx8yiurXep7lk0asFSg0r9OFRoYHxi5hXom+m+NWyQ/fkJ0h546bVYVE13e04wpm1W6QB9/rJnA/6ogMXEmasTsplhf3YaEXBdTqtxHptC1eA5J1qgpYOqVrzz9rYIFSYb4ynSqi4YFxGoP5kN738eUCYc3g3OvWuSqtP92KTVkf/pzWbS07En7c6yDrgk85I+0HrQVFHgDm+54Z9BpRg2staJ1coOx2+ciNKuvCzCQ1xnpgEdjkoqSMUK4bZGT4bs57FnKWuDhm74BH/cwzVIo1iFuWKEzqckcwE4C3x+V6MAqrK/00jHWnKqsP57E8MK4BrQp6CvINAv6KRSMTA6Sel+tWovbBsz2X82D9NlH2WiJzrLPdVHgppy vQQ5zJ9e ih0KQF+cxpLxB/xlzci3LGLGBLzJ0oUHFzHt/VGP9B0tdZh5E17KFmiJvf1XB/FPiwwZ6gv+sExV6O7OrsS088Nq1ZIcpwH7iGZ4ofKQoLVdEQyHB1mQ+qjsUGMLnyQP44T3jwW/7ll+Rc2maFHZ78T3Pp5DW3C2HNvdKm34SPWMSTHOwVwXeTbwIgiPdSF/YIGqT/Q3zgMVYDMjsNXXJQD287ANaWoQD/xLYbf/oeShab+GEPXhftnGkwgKTFePq3BZ52uVFtX2NJUMKOWV00Dh9qhoPFvSxExFeKwl30BKpKfa4rK1WQJwGf9eQ3BpTtUy/cidpUSg2b3OP9+GJiR6mWIRpHOGKGCRvBen7q7gDmC1kHYs9oeYhgYaGNdarAsu2gP+ijTiM3O2WdgWPE+g0ZZpJbRH8TxUFjFH1Bz7pqUt/1u+ng8KHZE09819HcZ188dg9PIicDXdcinF5nxmxwPdY2CoIaQQTTD4DG07h/9sd+Bq/OeVO/vHoOYnWeasODkxoE7172MBrjMhMXFmJVQmogNveMy2WSz37yDFfzGrWefIcAuxMRQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: get_first_page(), get_next_page(), is_first_page() are frequently used throughout zsmalloc code. As replacing them all at once would be hard to review, add alternative helpers and gradually replace its users to use new functions. Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/zsmalloc.c | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index f7b6b67e7b01..1ee9cfae282b 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -653,6 +653,11 @@ static __maybe_unused int is_first_page(struct page *page) return PagePrivate(page); } +static __maybe_unused int is_first_zsdesc(struct zsdesc *zsdesc) +{ + return PagePrivate(zsdesc_page(zsdesc)); +} + /* Protected by pool->lock */ static inline int get_zspage_inuse(struct zspage *zspage) { @@ -665,7 +670,7 @@ static inline void mod_zspage_inuse(struct zspage *zspage, int val) zspage->inuse += val; } -static inline struct page *get_first_page(struct zspage *zspage) +static __maybe_unused inline struct page *get_first_page(struct zspage *zspage) { struct page *first_page = zsdesc_page(zspage->first_zsdesc); @@ -673,6 +678,14 @@ static inline struct page *get_first_page(struct zspage *zspage) return first_page; } +static __maybe_unused struct zsdesc *get_first_zsdesc(struct zspage *zspage) +{ + struct zsdesc *first_zsdesc = zspage->first_zsdesc; + + VM_BUG_ON_PAGE(!is_first_zsdesc(first_zsdesc), zsdesc_page(first_zsdesc)); + return first_zsdesc; +} + static inline unsigned int get_first_obj_offset(struct page *page) { return page->page_type; @@ -973,7 +986,7 @@ static struct zspage *get_zspage(struct page *page) return zspage; } -static struct page *get_next_page(struct page *page) +static __maybe_unused struct page *get_next_page(struct page *page) { struct zspage *zspage = get_zspage(page); @@ -983,6 +996,16 @@ static struct page *get_next_page(struct page *page) return (struct page *)page->index; } +static __maybe_unused struct zsdesc *get_next_zsdesc(struct zsdesc *zsdesc) +{ + struct zspage *zspage = get_zspage(zsdesc_page(zsdesc)); + + if (unlikely(ZsHugePage(zspage))) + return NULL; + + return zsdesc->next; +} + /** * obj_to_location - get (, ) from encoded object value * @obj: the encoded object value -- 2.25.1