From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B93E4C05027 for ; Mon, 20 Feb 2023 13:23:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B4946B008C; Mon, 20 Feb 2023 08:23:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 566126B0099; Mon, 20 Feb 2023 08:23:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 42BF66B009A; Mon, 20 Feb 2023 08:23:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3094A6B008C for ; Mon, 20 Feb 2023 08:23:39 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 08E8F160509 for ; Mon, 20 Feb 2023 13:23:39 +0000 (UTC) X-FDA: 80487737358.28.D084CE7 Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf14.hostedemail.com (Postfix) with ESMTP id 35296100003 for ; Mon, 20 Feb 2023 13:23:37 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Th71S5AE; spf=pass (imf14.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676899417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rgoxeG6lbKxpgFkDDARmc06MAeDOGzJmDdevVLJlxU4=; b=IMIrdrQpaoxc8X8esN/JVye0HcSe9HJWmgMTtsz7PH/zMvHkXKGaKG2Lplq9rtsk04/3Xb B+iZo1bYMEGxfIFe08d8acT9IF/74x9CsSIx/f4juUsDv8YLgYg8cj4lKEnYtYVIboZeDp NZ6PdzDpR+XiQ3IBmYvLdD6+BmVFFeE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Th71S5AE; spf=pass (imf14.hostedemail.com: domain of 42.hyeyoo@gmail.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=42.hyeyoo@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676899417; a=rsa-sha256; cv=none; b=lQ+CiazVoSJVe0wFkZi/z8KUlMPjTVEkvYWo5g9tmJR//4O+OSAveX65DTOY8IC/RYsPYv LcDpoBS5nM2Ds4RoNZkgHve7turUIBaSsIMI4qPwCYRuIZ58dEipHmuxOg/qzfG9+uRJNx ESlrYK0tBCpLB5ZDRHwEfmmGG8vjAhk= Received: by mail-pl1-f172.google.com with SMTP id s5so1263395plg.0 for ; Mon, 20 Feb 2023 05:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rgoxeG6lbKxpgFkDDARmc06MAeDOGzJmDdevVLJlxU4=; b=Th71S5AE2gdWm8+Tbt1USoCL8IQYJ2sUaE/e6L7NqdnL8kXaSBI8kT9Cqy9SMr1up+ 4LaP2Y9KZ+ABMvqGIB4yQTsBoHOX6w/x1WL89pT2GfgHQdPnRvN6BXXfEUlNW85X3eTO pqdaox+K2PVVYCWimTHy2Z4eAVgIt8AKYnBX8mkaYJgsx/Q3KotCYFUZM3gLHiHbHxW9 KwKAjHSExLXuBodQnfl6g+BbJNzTWnkfAa1q4K18ef9cF+s/A4nVKlxBvVTOuFiUbtNb BQ2VWQ/SFIrTrjZnydOUkVwZcbZguNg2ZGDAueX60lgXD8po9iXEkcTrHfkVt1x5Gcnc MMJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rgoxeG6lbKxpgFkDDARmc06MAeDOGzJmDdevVLJlxU4=; b=mVV5vqaC6MEpSDFia9pZji2rh++PQRECm+KhcfxIS8RmaW5AR1b3t2J6MbMn5y31nC U+O5Z7kH6EJ2SYlQNxgpAPn/tKlhmV38DzLvlRQToF+B1TqRzJGslDPaPkYA9YUZNWc7 ix7I2u4gaIOsm0ckEEVbGW976X4yUAdKZpoe6FrzrvhBlDVRrMcIPQVhlR7uXaz/xE1D GImfp62tiistdGJ9Qz0PnBG7nJNTDaqDXcZhvmSKMeboKAa48cyEhBpFVMizSRAJAT+B GPxUIeuXDzEVGMp3nSSYbIYYfzGgRGT3Svys/0CmuGx4NQyqD+CEyEIi8PjzYsWANoxP vCDw== X-Gm-Message-State: AO0yUKWHeK8RcB2KJ8YLk0UDgYoVdvbUVCjZZhp6JsVJGDq/Fh0kWGVQ nzsp6/g8cVFd7OFiOqyvjvQ= X-Google-Smtp-Source: AK7set8Bp7kH68Es1zY0lt7bJEAC/NYqLArqXNafEN1maUbokgHKFk4Slhti3JriS2OJthqnv7r4Nw== X-Received: by 2002:a17:903:1c5:b0:19a:743e:b148 with SMTP id e5-20020a17090301c500b0019a743eb148mr1088684plh.66.1676899416188; Mon, 20 Feb 2023 05:23:36 -0800 (PST) Received: from test-ha.kr-central-1.c.kakaoi.io ([210.109.63.229]) by smtp.gmail.com with ESMTPSA id x2-20020a170902fe8200b0019c13d032d8sm6125436plm.253.2023.02.20.05.23.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Feb 2023 05:23:35 -0800 (PST) From: Hyeonggon Yoo <42.hyeyoo@gmail.com> To: Minchan Kim , Sergey Senozhatsky , Matthew Wilcox Cc: Andrew Morton , linux-mm@kvack.org, Hyeonggon Yoo <42.hyeyoo@gmail.com> Subject: [RFC PATCH 23/25] mm/zsmalloc: convert zs_reclaim_page() to use zsdesc Date: Mon, 20 Feb 2023 13:22:16 +0000 Message-Id: <20230220132218.546369-24-42.hyeyoo@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230220132218.546369-1-42.hyeyoo@gmail.com> References: <20230220132218.546369-1-42.hyeyoo@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Stat-Signature: natcy61zzyumk1fmqxtbj9zkk68rdhab X-Rspam-User: X-Rspamd-Queue-Id: 35296100003 X-Rspamd-Server: rspam06 X-HE-Tag: 1676899417-479593 X-HE-Meta: U2FsdGVkX1/ag/5TW+E7UojZuj1pv3YVoXtdvY/PnbJ8bwhg2rzjFWiaI2enHnisx8rWeZF3F+qnM3Rm5jxfuvZYa28ncRC4PDDJvY5BzuRQHMyanz4tbN3IupPSxe2zXggA6IEVgiMt5mHstWrGFojApb4ovIv2H9HXocCNB9/sgoshnMhfePmUlnZwBQbJ5KrdZgOqGCTeU5M4Qq8dbKbVBNQmxkC7exFrNQzidehMiQaYlIswwcIu3w+XcHzhGfo2qp0X2h+07Szu1aN9T04MSaDLALu6hJ0GWAEL7ZBVTC8QOom2AFpLbYDTzwU8x4zaYQwmmIcVH1fDPw+ZREdGo8WLIyL4yLyBuZpAIq8Q06C5r1c5cuqtPh8Inst5BP2Yt83aTE96AZGRIleOpKQoopivWgkroWCLYFmrPrOZ2fSvEtLCGPk3lcTTQ5DW5WObCHeSQXnV6d2IvOYFc9nt6tLMIV4xr26NAcSGcAWrlzg9f93tofqNldHwzEgfiBYADlRAMNi/6+auMB3dZC0+dqX1TL5TxbXn3jpWb9heONNjRGfeZgCVXopFIDtgFmSDNlh8LlW4yUtwqqv30luy8kj0oN6S5YXeNkm6vgtXNnhTtMx5SNNZuCUjDYcPv7st0fcAhip5j3IszLcMNO9yFUMLNLdNMsD29/sjNQXX6oMoZ7/3ATcWjJDJqswZjtybgtGz/ftCjnWxFqOocxj9A0o0/JWr+lCZCKPaaBh4D+U6rJj/SPF0vU9dKZRcIcHyDIHM2eujbiHr3AdEtVlrP+qLsF4+jD97g/vkR+1LfLnk7VnllfaJx+eyQcIc99VTnHMl2W3zcQXYG9je0VgLrKQVe+X6Pzn+71Pre+Hsjknu4ViWX1sjFYITKUugWdzRg8fdsXXYnfEPw293HUKQbXFMpo8RSfB6Xzk/uGurZorYY/Ydfdqj+eOPxYTmjuAVn/5/Nuqnk9MVJIE pdDHkZgr 3wVCwvzDbnWw+WJNY/I3LWxx+FGaVB6nAANvP3PPU1Sa0EcL+eXqtC388g/OYu8sC10k6erOjvM5WtHz6xnK6waZG5m7bilBj66Uf6yeUZS9zCIq0urWcrG5fXPQy0R9Up23vTPfPVGBcYhSxAJUk2sLkGGXfg+xEfm5j3LZVm6AZX0RjEIwD1gmscobt46YiL+xJivN5kKZV0+94vhmQ2Ox4xEvgNxRVtGFxu577l4kjnChxTiznJv/tPvDS/ympoFCT6B202UisTfvwQ7RYbNTkLvT8MRQCSWw3Qipgqo/kIZXzXmpMQTdLKqugx4t9R7oLEH4IMCVLLb+86blYw62qOVE8K91hJFAaz9qQppdUw6BClso+n7PLV8yJ/u9r45N8M6dpsIn593qiLcSFqpjclmD5oCfcEcm4vb4DfwUEwK8/ByZJ7y+5ObgbmGIu3NEWXvITOF1m7EP62t/LtX1eSfNIoZ/E6s+B0oOSjZWXSFdFoOtNhAqfllpnNDlgYIQj+6yUmaGsAErmrTLMszcB7xD3J7KVRD92RtW2BA0xRs2vQuYLhFgRv3V+8boQ4t8tqXqrpTb2tmdzpv3nf5LmkQw8GU0Qhq5LW/3t38wVsYQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Convert zs_reclaim_page() to use zsdesc and update its comments accordingly. Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- mm/zsmalloc.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c index b6ca93012c9a..7153688f5bca 100644 --- a/mm/zsmalloc.c +++ b/mm/zsmalloc.c @@ -2802,7 +2802,7 @@ static int zs_reclaim_page(struct zs_pool *pool, unsigned int retries) int i, obj_idx, ret = 0; unsigned long handle; struct zspage *zspage; - struct page *page; + struct zsdesc *zsdesc; enum fullness_group fullness; /* Lock LRU and fullness list */ @@ -2830,16 +2830,16 @@ static int zs_reclaim_page(struct zs_pool *pool, unsigned int retries) spin_unlock(&pool->lock); cond_resched(); - /* Lock backing pages into place */ + /* Lock backing zsdescs into place */ lock_zspage(zspage); obj_idx = 0; - page = get_first_page(zspage); + zsdesc = get_first_zsdesc(zspage); while (1) { - handle = find_alloced_obj(class, page_zsdesc(page), &obj_idx); + handle = find_alloced_obj(class, zsdesc, &obj_idx); if (!handle) { - page = get_next_page(page); - if (!page) + zsdesc = get_next_zsdesc(zsdesc); + if (!zsdesc) break; obj_idx = 0; continue; @@ -2870,7 +2870,7 @@ static int zs_reclaim_page(struct zs_pool *pool, unsigned int retries) if (!get_zspage_inuse(zspage)) { /* * Fullness went stale as zs_free() won't touch it - * while the page is removed from the pool. Fix it + * while the zsdesc is removed from the pool. Fix it * up for the check in __free_zspage(). */ zspage->fullness = ZS_EMPTY; -- 2.25.1