From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4EDC05027 for ; Fri, 17 Feb 2023 13:44:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B70966B0074; Fri, 17 Feb 2023 08:44:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD03F6B0075; Fri, 17 Feb 2023 08:44:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D54F6B0078; Fri, 17 Feb 2023 08:44:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7857F6B0074 for ; Fri, 17 Feb 2023 08:44:42 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2131016053F for ; Fri, 17 Feb 2023 13:44:42 +0000 (UTC) X-FDA: 80476904004.10.F65657E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id 1261114000E for ; Fri, 17 Feb 2023 13:44:39 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VgF1xCMR; spf=pass (imf23.hostedemail.com: domain of dakr@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676641480; a=rsa-sha256; cv=none; b=aK1/vHrONzbFf2CnlfCDuH8r7HgZBejWZsMw6PR5aYMRuDdoVD8Q6Zez4aGWM2XS0cOHSv RyUQulHWl/8DcoTHCD6KUuBOtCehX7cf1nbzXCUXHsh6kFLnaAvXOSIWmWbqJPcPuxaKef Kf0s7ZOcwIEzziGbYkjj3mq5HoYyNzk= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VgF1xCMR; spf=pass (imf23.hostedemail.com: domain of dakr@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=dakr@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676641480; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7uKZrgGFJpURUNNqYPRQvVp3RBdWsUReZR9Qa+W+o5s=; b=39sUeFPfza4hrozEuLNpxtOipqbHSDlUK6gEsLPQUa3PZMnByYBn2EEkmB8j2ypDTg+ALv nDKUz6XS5JN5nDc6zFVMOLwmbbiXcMGAcfZntbehAdQdLVCy6heOawueiY0NpFz4xQO0y9 w8eDUtOGOghbX9c1EyV+Mo4iKwuiDxA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676641479; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7uKZrgGFJpURUNNqYPRQvVp3RBdWsUReZR9Qa+W+o5s=; b=VgF1xCMRViNC5MoMXSeppypDYZslYo6iwTqkrAGW/CKURrRaWaH2oBB8ghQnQa96PFRRQt l8mndVHpU4WyuW4Tuntk2qgDBEn1uSvp/jC95zpheDdx7iUMCn6VmfWgDbQGyNp5d/QnTh jdV6Vd6DuDgjwm6fxcMe9ljdF7rNCfY= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-402-_ppvwkfHO0y03FlztoPngA-1; Fri, 17 Feb 2023 08:44:38 -0500 X-MC-Unique: _ppvwkfHO0y03FlztoPngA-1 Received: by mail-ed1-f70.google.com with SMTP id fd8-20020a056402388800b004ad793116d5so61967edb.23 for ; Fri, 17 Feb 2023 05:44:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7uKZrgGFJpURUNNqYPRQvVp3RBdWsUReZR9Qa+W+o5s=; b=S/UjoHni8dMx8/5VuoxxNSVITC8t7YKVbo3As2yPlIIRIGh7jqXNS+ld9qAYKtSvKH fh7trG/uR982pI/6xdUgiENfn1SHbMrKyQ7grX4BKVPvB97KkHKfB5U6fg08T3AGuDLo bAeoZPG36OLcVYguPZRLAYYZuoDUIo2nbN3xI6wIhjaPdu5nGVgu9Ts0xjmAYQv1dUEv fmUgxzrY8JO9P/0mGHpBAUqfm3gSW0drcRfU0UhminWDgIFueax0riKtaUtpPwaPKUJf KEWv/orfy2lT3VdONpFQqHAihBbtoYXfm42oxfiHueBR+tDdBZseXLdGHntLHgHOnsEj 57cA== X-Gm-Message-State: AO0yUKVZsXHI5ZtWtZHcrbgTSHH+W9vygpCfzxF7VOYLEVivqULVECjw KDfa02a1AmtKwafB95HOljCkahbLFisG0baSS0K6qROerTFRTP6JmvJ7Txv/8F/QNXD13vt3peJ E0Qxkdp8E2wU= X-Received: by 2002:aa7:c9c6:0:b0:4ae:e51e:9e3e with SMTP id i6-20020aa7c9c6000000b004aee51e9e3emr348790edt.24.1676641477312; Fri, 17 Feb 2023 05:44:37 -0800 (PST) X-Google-Smtp-Source: AK7set9IRUJksGLLW/RDiXSfuPpHSO6kl3p0Lri0OcDeobF/5J+q0ZakgTJZKlO0HFr6pr+zDCdPAg== X-Received: by 2002:aa7:c9c6:0:b0:4ae:e51e:9e3e with SMTP id i6-20020aa7c9c6000000b004aee51e9e3emr348775edt.24.1676641477173; Fri, 17 Feb 2023 05:44:37 -0800 (PST) Received: from cassiopeiae.. ([2a02:810d:4b3f:de78:642:1aff:fe31:a19f]) by smtp.gmail.com with ESMTPSA id u8-20020a509508000000b004ad61135698sm1948004eda.13.2023.02.17.05.44.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 05:44:36 -0800 (PST) From: Danilo Krummrich To: airlied@gmail.com, daniel@ffwll.ch, tzimmermann@suse.de, mripard@kernel.org, corbet@lwn.net, christian.koenig@amd.com, bskeggs@redhat.com, Liam.Howlett@oracle.com, matthew.brost@intel.com, boris.brezillon@collabora.com, alexdeucher@gmail.com, ogabbay@kernel.org, bagasdotme@gmail.com, willy@infradead.org, jason@jlekstrand.net Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Danilo Krummrich Subject: [PATCH drm-next v2 02/16] drm/exec: fix memory leak in drm_exec_prepare_obj() Date: Fri, 17 Feb 2023 14:44:08 +0100 Message-Id: <20230217134422.14116-3-dakr@redhat.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230217134422.14116-1-dakr@redhat.com> References: <20230217134422.14116-1-dakr@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Rspam-User: X-Rspamd-Queue-Id: 1261114000E X-Rspamd-Server: rspam01 X-Stat-Signature: uezkra74qanjxxokgffo6uwmqmbtgjyu X-HE-Tag: 1676641479-408617 X-HE-Meta: U2FsdGVkX1/3WjhJ1dSSl8PrWs5050bt6qDsB6ATiwG1dF6z37K5CXQUDnIRgrPVMrGM8D3+W+HLGwZpyaq7+GQed6vk/IXOtRUbuEhWFVeVq0J4XhMy5gvwawuK950wahd4D+iwdUgY94i5rZNaWFnFzSzkj1aq5DmwkDGlM76watjzUnTnTXrjnR8drgFU++H1o14/Bj4Xq/yjKCW6GG5ge7HM9+mPTLkctr3NEcLg1Vxb5Cz+mY1FKx0lJ+oQiXwjdT5A0hh8iiqNqYfLpC+oFSs3XbcOZe/HGkGeFHMm4VM5Wl08MufnIGjwf1aGHuJpKyfvJO2c7fHByu5bumd2P4AW0oi9IoBqb+EHWQrW0azq4n2kWepV7K7CdSNIoUISmRR3Urv0Erls/QSnigB2E5V3/szeMog/N7bHYAZ3bb/EsBI1k7JZo/Cj6N0xBRPRyQTkpPj/hNenYdepvliHEnIh+o/+bSFHHjBN1AeSk/fUiypGemofFsIYozyclKMSlYv/iMyWQTF8k3mJp2bOp1ElbjpbIeODzmGdfvxvN4jOm9NNEOTWXVI99xT4rlu7FAVudDtvC5mqg5SpQ8ktw/0GIrCdSnwXj+TUalDYNH0HhN6zOtqRPLazCWGBrV8Ma8Ydli+UzX1J1zZQyACc8JM7nCfycCVWkCi2GevoAPzyu3DRzc8ekBuo/Rb+cU7ZPKSvY4QaGD0dt0mkLEofdsZmH7cAlVgbuZuCJN7icSaJ6tLIo5VvTGZ20hNJL5VFFfENyVPm8JostqrgtrSQfJ1Iu1iT1GYTitbwsVDg9N2K7kZku8fGjG4QX3Za3uTj5zLGIhcbJZj72fS3lQzgps18Ma4m2rfFgUO2KGdS+waOiMnyzR94CP9v/AKV9mEa2zAg/Poux6a5w8ucBQ0gMBmg78lCVqPeDRjlQrJ1ingt5r4pLjx7bppn2RQr9HbYy6qcrkfEDvP5oMu dQZOOlLT twatz4gfZjOLHPX1bUtwdS3IFaRPJdhYJ714uwEDjVD1BKOvu+v+k6Rfb9mPAJ9ROjmbODxnOW2haumgJIVxgkqXrB0+gqxJwFtR5FR9QnTxW1Vsu0iPH5zbBEqO4tV/xAIco1z0EUjip7PnGG07WnGDKT0dfwzKzbcoyxDPi7bfDVehDQm6z7l3SfX4gVGT0fL6fzutmhf3EfxWdRJROjmJ4Ifh29vSm8gPdA/1vywsPlanKkuL953fARNKKf2wZzdKWsX9qK7abJ3OKrVZLhsVBaJ96lFYotuzSP0PCTbzTP2RiSLzZTWz7MI1pLsYK4zkbakOSzsbw2mgekBl1W0u2xwgVok8p/9kg2uJDKvShyMujlDY7LvCFVG/E/BBpP6RKojvrhEEvP0SOgnRemtMpKa3q/Ke8m4lgWkVE6BEUw1Y6ZgfxQIrE7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Don't call drm_gem_object_get() unconditionally. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/drm_exec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_exec.c b/drivers/gpu/drm/drm_exec.c index ed2106c22786..5713a589a6a3 100644 --- a/drivers/gpu/drm/drm_exec.c +++ b/drivers/gpu/drm/drm_exec.c @@ -282,7 +282,6 @@ int drm_exec_prepare_obj(struct drm_exec *exec, struct drm_gem_object *obj, goto error_unlock; } - drm_gem_object_get(obj); return 0; error_unlock: -- 2.39.1