From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C96EC61DA4 for ; Thu, 16 Feb 2023 22:47:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B20DE6B0072; Thu, 16 Feb 2023 17:47:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AD1346B0074; Thu, 16 Feb 2023 17:47:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 998706B0075; Thu, 16 Feb 2023 17:47:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8584D6B0072 for ; Thu, 16 Feb 2023 17:47:04 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 4B65CC1184 for ; Thu, 16 Feb 2023 22:47:04 +0000 (UTC) X-FDA: 80474641968.06.CEAC4A4 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf08.hostedemail.com (Postfix) with ESMTP id 6F3AD160005 for ; Thu, 16 Feb 2023 22:47:02 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XklABHGu; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676587622; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o4zdoJap/GrXqHxnn+y8KebQbINsndLZxz3f3V/pwKM=; b=FqYAfvniprvCk99d7k3EBVLhA+uzMel9G22EBvUpBTFt/FcBv0wUB5EjCoa/rafvf2OidB zhVdnNomp4fgloOvsAFafCkJZhNywTp5gMe79rcA+54370dK0Ie+bNuvAPSm0KNs6+BcSm rZuiroM3vJNoOEqwHZ0CxYCPKA1oH+M= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XklABHGu; spf=pass (imf08.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676587622; a=rsa-sha256; cv=none; b=UHwJmYwDENk66tCHAv8rHdmK+kZ9J3d4qGfi2OMwbZQSP3Wwx92JSVUOiVRnYD94qbQFl7 l4VfLuJfBU59pPyMQfhUtKwEHTSvvIWWKDr9qfjDwpSLToeyofAdrD8vFyOV5/fMNb4GU1 gTVKmri442fav4SHbNCmo0154tctyLo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C7808B829D4; Thu, 16 Feb 2023 22:47:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC6ACC433EF; Thu, 16 Feb 2023 22:46:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1676587619; bh=9oeCHSLszN1ZlteZIP+mKzpT4ngVcpBp4cDal0zXZL0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XklABHGuz67Jr6L6q/GiqwCZqRGFa+meW1H0YZ/7JApSIsmEX8CEMBZVPkJ8B+60O FlR0T0McnQ+zkZBfm7a39gFwYc8vtAuogsrnhflLLTuwcTv+vtD/qfquyn7FMcATsT 3jqW32IAcaubqFDEOIYbQmm1CSWaRBHcflvOu1P0= Date: Thu, 16 Feb 2023 14:46:58 -0800 From: Andrew Morton To: Matthew Wilcox Cc: Baolin Wang , torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, naoya.horiguchi@nec.com, linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de, mike.kravetz@oracle.com, damon@lists.linux.dev, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 4/4] mm: change to return bool for isolate_movable_page() Message-Id: <20230216144658.18add74d133be070f07cf1f5@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: xgnjxkjknm3f6soxo84n7jpmye7umc5z X-Rspamd-Queue-Id: 6F3AD160005 X-HE-Tag: 1676587622-927951 X-HE-Meta: U2FsdGVkX194IX9GdIWsQvQvvcHFyrbQ4FtSTaB+5J+OXlge+4wpCOsKI9gZC5rjnzZlEbFThobWig7iYK9xJ71kALdAsWKe3/mTWT4Hwu0lmKsVaq6AXjU2K6OAVjUIO5FEPI65JwVbNopp4EQEQOBYBgK4YVhHL9xBBhZBpOUHRv9DNRZ7asgtwyUi/hqnABSKIwuIjAu5a6ixtMTVvcH6Fcq0mplVO9MFAdUEvvUzwDWKHgV/VVwSH4jomokDqA64U0wlzJ66mStVGdn4BfiNUR64LdNH2o3x/a8/H3gNjNfN41ytXg6v77ehj6NVW+SupiRB7wQXsZzsGGiXjmSi1M+XNV/TgXFfCvy8OeFwwGrWqAo1HYTGrYsewwE/nBma1E1f1PJFtboudc/Yfu8kPrMt26m75H9KJEseVA7688Urx4FZpRxdS/BjZiISQWof8b2sTdmXDjW1pDjkFeV+wNxufnhjE+KSk13m8OZ2hVFX5n4rvCQhXt6BglcFYOx5APXMJ6ud8Hi5lkfsR7o4M64e2D2Wqvsan97Rcdj4qhAXUlGVuJFtEz1xPzwVjSrHJbnCGMiU0qDtW3sbbwCoS4vQkieB16Y4NugrdRAENckz15G8ijlEMdxftGNEFt+t+bKLSsPuPk4VFRffCEKzzFjbJNLdOOthRg6mOh+PvNxpohnGW2RnJRvpYKQGN371Jc8KwQFoXjMEX7R+Ina9GBkMokApFtsJ/u1xa9VmvIIMKCbOgq4/xpX6VMmAOpsJAvG753Nr8wywXThZIqOz9gS9zOjxFb2tG2ZNw44KnW/oI3Ql7NDA3DMp12aImpRr3KEtAwsVUuhNfWSjR5kwrDndxPQFKA4WOlq/25BKitXP52iILQggDpC5UsjcqYBtiwYlHDjyqfcQ+H5d2nfcJrRJMMYU2EEoxEen0qzdD7H/jLTaxglRcSF92MctlGw9pFFXTHRspthUUAH HKzP2TlB Hk3SVF5j/y9RpvNRszcp8ybG24czqwVxaYjNCbhJQWchG9aW/zyJ8vb+lshtRTJE4Ub+/tMQhNHhSOx/WhIXlmhDNIklstWAZAu14v3g4TN27ALpmItgnjr3Lu4udqHPVhTsT3bCw+J5B9YPJvgT4IpX02rgpnzwtrJUIfLXtEvM2tIUXOqZQ/7V3GGGo2piEt4daNf4QyeLuAQgxnvQGUUJQ4C7vIqrSb2g59lbihkIhPPP25dqAAUCaOC0NSR8Ca8oStQqp79C+0+LOZJGfZErYzxxgH0D7eayD4CE6RFqCwd0+nKAKhRBaWu5/7eAnsdh6b05pmSY5SZglLjwABi0ccHm3C+67uRlCZ+K77h+YrDqgEoYlrU4F5G7Z/SNCYeCf35ujucdgo8L03yPZVwk4g4a4TqQI7Oo+dx6Yxt5qWJ+N3cX3JIf6iEJSMI9x6ZNmMN+Jp7nt38s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 15 Feb 2023 15:44:22 +0000 Matthew Wilcox wrote: > > extern struct page *alloc_migration_target(struct page *page, unsigned long private); > > -extern int isolate_movable_page(struct page *page, isolate_mode_t mode); > > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode); > > You can drop the 'extern' here. There are a bunch of them, so a separate patch would be better. --- a/include/linux/migrate.h~a +++ a/include/linux/migrate.h @@ -62,16 +62,16 @@ extern const char *migrate_reason_names[ #ifdef CONFIG_MIGRATION -extern void putback_movable_pages(struct list_head *l); +void putback_movable_pages(struct list_head *l); int migrate_folio_extra(struct address_space *mapping, struct folio *dst, struct folio *src, enum migrate_mode mode, int extra_count); int migrate_folio(struct address_space *mapping, struct folio *dst, struct folio *src, enum migrate_mode mode); -extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free, - unsigned long private, enum migrate_mode mode, int reason, - unsigned int *ret_succeeded); -extern struct page *alloc_migration_target(struct page *page, unsigned long private); -extern bool isolate_movable_page(struct page *page, isolate_mode_t mode); +int migrate_pages(struct list_head *l, new_page_t new, free_page_t free, + unsigned long private, enum migrate_mode mode, int reason, + unsigned int *ret_succeeded); +struct page *alloc_migration_target(struct page *page, unsigned long private); +bool isolate_movable_page(struct page *page, isolate_mode_t mode); int migrate_huge_page_move_mapping(struct address_space *mapping, struct folio *dst, struct folio *src); @@ -142,8 +142,8 @@ const struct movable_operations *page_mo } #ifdef CONFIG_NUMA_BALANCING -extern int migrate_misplaced_page(struct page *page, - struct vm_area_struct *vma, int node); +int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, + int node); #else static inline int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, int node) _