From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Baolin Wang <baolin.wang@linux.alibaba.com>,
torvalds@linux-foundation.org, sj@kernel.org, hannes@cmpxchg.org,
mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com,
muchun.song@linux.dev, naoya.horiguchi@nec.com,
linmiaohe@huawei.com, david@redhat.com, osalvador@suse.de,
mike.kravetz@oracle.com, damon@lists.linux.dev,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 4/4] mm: change to return bool for isolate_movable_page()
Date: Thu, 16 Feb 2023 14:46:58 -0800 [thread overview]
Message-ID: <20230216144658.18add74d133be070f07cf1f5@linux-foundation.org> (raw)
In-Reply-To: <Y+z91pcxAuygc92J@casper.infradead.org>
On Wed, 15 Feb 2023 15:44:22 +0000 Matthew Wilcox <willy@infradead.org> wrote:
> > extern struct page *alloc_migration_target(struct page *page, unsigned long private);
> > -extern int isolate_movable_page(struct page *page, isolate_mode_t mode);
> > +extern bool isolate_movable_page(struct page *page, isolate_mode_t mode);
>
> You can drop the 'extern' here.
There are a bunch of them, so a separate patch would be better.
--- a/include/linux/migrate.h~a
+++ a/include/linux/migrate.h
@@ -62,16 +62,16 @@ extern const char *migrate_reason_names[
#ifdef CONFIG_MIGRATION
-extern void putback_movable_pages(struct list_head *l);
+void putback_movable_pages(struct list_head *l);
int migrate_folio_extra(struct address_space *mapping, struct folio *dst,
struct folio *src, enum migrate_mode mode, int extra_count);
int migrate_folio(struct address_space *mapping, struct folio *dst,
struct folio *src, enum migrate_mode mode);
-extern int migrate_pages(struct list_head *l, new_page_t new, free_page_t free,
- unsigned long private, enum migrate_mode mode, int reason,
- unsigned int *ret_succeeded);
-extern struct page *alloc_migration_target(struct page *page, unsigned long private);
-extern bool isolate_movable_page(struct page *page, isolate_mode_t mode);
+int migrate_pages(struct list_head *l, new_page_t new, free_page_t free,
+ unsigned long private, enum migrate_mode mode, int reason,
+ unsigned int *ret_succeeded);
+struct page *alloc_migration_target(struct page *page, unsigned long private);
+bool isolate_movable_page(struct page *page, isolate_mode_t mode);
int migrate_huge_page_move_mapping(struct address_space *mapping,
struct folio *dst, struct folio *src);
@@ -142,8 +142,8 @@ const struct movable_operations *page_mo
}
#ifdef CONFIG_NUMA_BALANCING
-extern int migrate_misplaced_page(struct page *page,
- struct vm_area_struct *vma, int node);
+int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma,
+ int node);
#else
static inline int migrate_misplaced_page(struct page *page,
struct vm_area_struct *vma, int node)
_
next prev parent reply other threads:[~2023-02-16 22:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 10:39 [PATCH v3 0/4] Change the return value for page isolation functions Baolin Wang
2023-02-15 10:39 ` [PATCH v3 1/4] mm: change to return bool for folio_isolate_lru() Baolin Wang
2023-02-15 15:35 ` Matthew Wilcox
2023-02-15 10:39 ` [PATCH v3 2/4] mm: change to return bool for isolate_lru_page() Baolin Wang
2023-02-15 15:39 ` Matthew Wilcox
2023-02-15 10:39 ` [PATCH v3 3/4] mm: hugetlb: change to return bool for isolate_hugetlb() Baolin Wang
2023-02-15 15:41 ` Matthew Wilcox
2023-02-15 19:22 ` Mike Kravetz
2023-02-15 20:25 ` SeongJae Park
2023-02-16 2:04 ` Baolin Wang
2023-02-15 10:39 ` [PATCH v3 4/4] mm: change to return bool for isolate_movable_page() Baolin Wang
2023-02-15 15:44 ` Matthew Wilcox
2023-02-16 2:07 ` Baolin Wang
2023-02-16 22:46 ` Andrew Morton [this message]
2023-02-15 20:14 ` [PATCH v3 0/4] Change the return value for page isolation functions Linus Torvalds
2023-02-15 20:26 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216144658.18add74d133be070f07cf1f5@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=cgroups@vger.kernel.org \
--cc=damon@lists.linux.dev \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=naoya.horiguchi@nec.com \
--cc=osalvador@suse.de \
--cc=roman.gushchin@linux.dev \
--cc=shakeelb@google.com \
--cc=sj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox