From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55AA1C6379F for ; Wed, 15 Feb 2023 05:00:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 668A56B0072; Wed, 15 Feb 2023 00:00:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6191D6B0073; Wed, 15 Feb 2023 00:00:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4E1266B0074; Wed, 15 Feb 2023 00:00:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3F8DA6B0072 for ; Wed, 15 Feb 2023 00:00:00 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EF714AB03A for ; Wed, 15 Feb 2023 04:59:59 +0000 (UTC) X-FDA: 80468324118.03.4B3FF2B Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf03.hostedemail.com (Postfix) with ESMTP id 10C4F20085 for ; Wed, 15 Feb 2023 04:59:56 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=rketxIr4; spf=none (imf03.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 209.85.216.42) smtp.mailfrom=david@fromorbit.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676437197; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CaZgKqOUe0VVRH5ftQYEOTV1BVr4Wv8d3kXjdyKziRI=; b=Fj7NT5chJUFi9QyzlGXzxgVR+rKbaNmkhXgw2mt9hYDdfa1uV4lW7zDGbCTakzUAQOJDRF EjmFoJXWs/m7E9C4AYDJHDE1vUFhYOlKMZ6g54XKqkIb/SZKsyFTUingbGEjxtZ56oFgpM uTWIbwsW4zZ6hQ3t0i+9B2t5wlIEDwk= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=fromorbit-com.20210112.gappssmtp.com header.s=20210112 header.b=rketxIr4; spf=none (imf03.hostedemail.com: domain of david@fromorbit.com has no SPF policy when checking 209.85.216.42) smtp.mailfrom=david@fromorbit.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676437197; a=rsa-sha256; cv=none; b=VNV3o+JsDJFUWLhOz3rTf7JCuGnqifhCiK2G3Z6q+qZELwwuv/fKuGUnrLc5Xyxo0BWjl9 GXvNd6kfxGDsxoilbe8vkDyaDCKK3gUruPgeiD/Fkl2fjhHhwU3LR/wUU1GSy7OGJPZ2Al pgRpwIEW1e3j7Mkm/10Qqr/J/xr/1S4= Received: by mail-pj1-f42.google.com with SMTP id kk7-20020a17090b4a0700b00234463de251so933375pjb.3 for ; Tue, 14 Feb 2023 20:59:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CaZgKqOUe0VVRH5ftQYEOTV1BVr4Wv8d3kXjdyKziRI=; b=rketxIr4gImJPorL4R5BRrbp+c0WJjOM6XhLDCzwXdV6Fj1IT4O0ZK8DFJCWACBnVd nQqxyMQoCbntnZoJztkq64u0znEbhYif7EjCaLuLvgcYkX3wlJnfr7QPAdnCDBpAsnK2 k3NzSt9lKQC4InHgH1A7iKw/ayUkNVETC+TSIQ23+DvbBC0iCSuWLgyv5+Ju45HThA1t FyXFYz8rHviPYEGVGqvBo3x2vs7XvZ5irj2NGf8AeEK31To10XgAbZaWPY+h8D5LhBq/ PjPpSBH8/eI5TO767b2bsmgSXYnTPhm5RHRDbBI8xY9wZHIFyHtYwGc3lkltkMvP3WcT It6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CaZgKqOUe0VVRH5ftQYEOTV1BVr4Wv8d3kXjdyKziRI=; b=dJui5gd0vGtawih7DzmB2xvPWlkj+ke5qupxh1WMIuxaOQjfXqgvGQuj/NCZVriaN1 bG7XuZHkdcUlJOJzbGfF4IwPfkB4O84JnVkFAOXtciosSmHhwk92uDipTekX3uYHA07H IFxUvWfWBvp1XDc5e1QItHy9SZ5cSoq3FUCT6nRxlyq7MKQDQINspOeNusg3cNFznPfg u1sWYsDoMJqG7kUuShDLxxv2phByAZ+sVKuuDu8vLytLPKqk6k5kfBdA50U/tafBD7K1 1TgcQyb93qnp8AEkJl6AIMS1lR/3YwFqoCUNEEZQQcQNMhOCwH411uKQDtXoRLB/lgy1 kd0w== X-Gm-Message-State: AO0yUKW2HeS5kGfYhrVs57yUVrobjMl7sh+dbl46qndmGLBSsYHu8D2K X6ird+p2Q6QaKaFB8YZFxjE/hQ== X-Google-Smtp-Source: AK7set+JG/B78Wq9ZBXSoUQJVRPwNoUSoonIc9EyVLGDRxv5C5xNQ3cyJaZxI/N31YGytS8k0cKOHQ== X-Received: by 2002:a17:903:2344:b0:19a:586c:2b81 with SMTP id c4-20020a170903234400b0019a586c2b81mr1271624plh.40.1676437195868; Tue, 14 Feb 2023 20:59:55 -0800 (PST) Received: from dread.disaster.area (pa49-181-4-128.pa.nsw.optusnet.com.au. [49.181.4.128]) by smtp.gmail.com with ESMTPSA id jm15-20020a17090304cf00b001994a0f3380sm11035857plb.265.2023.02.14.20.59.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 20:59:55 -0800 (PST) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1pS9tY-00FTp0-LH; Wed, 15 Feb 2023 15:59:52 +1100 Date: Wed, 15 Feb 2023 15:59:52 +1100 From: Dave Chinner To: Jan Kara Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-mm@kvack.org, John Hubbard , David Howells , David Hildenbrand Subject: Re: [PATCH 4/5] block: Add support for bouncing pinned pages Message-ID: <20230215045952.GF2825702@dread.disaster.area> References: <20230209121046.25360-1-jack@suse.cz> <20230209123206.3548-4-jack@suse.cz> <20230214135604.s5bygnthq7an5eoo@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230214135604.s5bygnthq7an5eoo@quack3> X-Rspamd-Queue-Id: 10C4F20085 X-Stat-Signature: mgr9sa56urtqa7x1k85pe1kikmwfu19y X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676437196-801612 X-HE-Meta: U2FsdGVkX18AxnjoDPGmCWGZRZWIXKX1xZhrUzmrKC+fpv72TXZZ1q3K3s11zIHmFbRt/valK0cE/DgKqfzzCHyWCU0Z0PlQqVArYQHLwwMjw+Vh1VGgWJeDsxv4zEzMtfAUktdCmEMb3IvpsxQ1hTuxatHyJiyC1wbHmWim8VspD3YpD9a1IH2Gp4YanKH4GLf6JHaXrvPyX1WCMr2bvZZBwtTVz+J8vTY+XY1IAVj8oXMHrQqh5EeYuktgDTf22wP+wCYbz0r96jO/4OzSLKdCM2P4Y7W0h0h3kfWT7jS4rKwrk8jt4J8pJNxo/PiYfXe6ILX9dfPw5LfTiT6MPzcn/wRy5eQ7S6PgQnIRkJVsy+YEAg1N4DYcB61c0Stn+L/AS4HCqRzf1+tIlzryEER+HZH6af+B5alGvPmgjURYU2p3InK1WrW8PCBIgRcVW1DgNfJQeJKeEkusRa7MopNcgPzXRFuaP7+btdBGVKoRD2ZFAHDNw0OL6Itt5lBAH+neGJ8eMsutwAmZvV+KdABXh+15DmF0leAuPBvCBvmsnkwr4YwEvblhYpTKib8ukIt/2tl5jtR8T7gNb8nQ3t+Yw/UoKnXnXYIyOkZwmoElycFZabYb2A5ekLFL4vJsZaR9Kbu9jz9YqgxKisM08xq4cpLEWsdRmLNIvXBg/Z2KBtOGk4/EMPXLSZA5Ox2ArWw+AMxOc63t6dT5ykbCvfuELD1PrR5/YPVd8R/85oDnIuTAiy2uZh1C26J1eOM72VqyG9j6avXIBxhbInA9N4f83CppS68peDMN6ky7+nIpWHpc3GYmcmNw+dGz3fQnmN43Nceln4sP3I7Kj6Fx5TIPEEcb4lEk8id4COuPyvyGMxRochTNJXqDCA7vJbf90CQt1L1uA45oNQ0XevkPPeN8C7qzCNF+SWQ+UCMr6CAnuoeqUANb2RbA6yVmUP/VC86w7TbpaHtlY2Cqn89 zwBYN12W IzKFUDqM3Rz6wjXI4G0Lu/05zSEdH+4FY3CQwldu7NTanvxV/H9umnZI1u9cfTcdQV+SdVRkBD1itR+SyVUFbcGTY32VbnzyAQ6PuSS3AED+BTiGmwPTqZX3oDphbPClReOMdrKj0kKHcu9ynBQdHMnfhUaalyOA768fBH+dEqzjiE61J0VRLqnXYmZ3etA+mPhJ3sWNiiD0F8xpsP26J9vFbE05b3J58dKDBrx9k4JyY69vGEJfqs5+U8wDdAEM1IpyOXEloogVU6gb/kNYmmILqZgt8lKOE0fFaGdABl+C8914lBnl1OzuzGlf9HmvuEC5zYAj/pzEH+5tNP/OUbNB5oaZQkhn9PrF9mGBdr+xtqFVZjpmGN9rLWpe5hyeGSm/0BFFg2hDDFD/AyN8mQtGqvhjm5k0t8mz+UkNA0oGOHkM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 14, 2023 at 02:56:04PM +0100, Jan Kara wrote: > On Mon 13-02-23 01:59:28, Christoph Hellwig wrote: > > Eww. The block bounc code really needs to go away, so a new user > > makes me very unhappy. > > > > But independent of that I don't think this is enough anyway. Just > > copying the data out into a new page in the block layer doesn't solve > > the problem that this page needs to be tracked as dirtied for fs > > accounting. e.g. every time we write this copy it needs space allocated > > for COW file systems. > > Right, I forgot about this in my RFC. My original plan was to not clear the > dirty bit in clear_page_dirty_for_io() even for WB_SYNC_ALL writeback when > we do writeback the page and perhaps indicate this in the return value of > clear_page_dirty_for_io() so that the COW filesystem can keep tracking this > page as dirty. I don't think this works, especially if the COW mechanism relies on delayed allocation to prevent ENOSPC during writeback. That is, we need a write() or page fault (to run ->page_mkwrite()) after every call to folio_clear_dirty_for_io() in the writeback path to ensure that new space is reserved for the allocation that will occur during a future writeback of that page. Hence we can't just leave the page dirty on COW filesystems - it has to go through a clean state so that the clean->dirty event can be gated on gaining the space reservation that allows it to be written back again. Cheers, Dave. -- Dave Chinner david@fromorbit.com