From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
Steve French <sfrench@samba.org>, Paulo Alcantara <pc@cjr.nz>,
Ronnie Sahlberg <lsahlber@redhat.com>,
Shyam Prasad N <sprasad@microsoft.com>,
Tom Talpey <tom@talpey.com>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
linux-mm@kvack.org, Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH 0/2] Revert boot-breaking changes in fs/
Date: Wed, 15 Feb 2023 13:00:37 +0100 [thread overview]
Message-ID: <20230215-topic-next-20230214-revert-v1-0-c58cd87b9086@linaro.org> (raw)
next-20230213 introduced commit d9722a475711 ("splice: Do splice read from
a buffered file without using ITER_PIPE") which broke booting on any
Qualcomm ARM64 device I grabbed, dereferencing a null pointer in
generic_filesplice_read+0xf8/x598. Revert it (and its dependency)
(or accept better solutions should anybody come up with such) to make
them bootable again.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (2):
Revert "iov_iter: Kill ITER_PIPE"
Revert "splice: Do splice read from a buffered file without using ITER_PIPE"
fs/cifs/file.c | 8 +-
fs/splice.c | 159 +++----------------
include/linux/uio.h | 14 ++
lib/iov_iter.c | 435 +++++++++++++++++++++++++++++++++++++++++++++++++++-
mm/filemap.c | 3 +-
5 files changed, 479 insertions(+), 140 deletions(-)
---
base-commit: 3ebb0ac55efaf1d0fb1b106f852c114e5021f7eb
change-id: 20230215-topic-next-20230214-revert-cce3cff17c45
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
next reply other threads:[~2023-02-15 12:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 12:00 Konrad Dybcio [this message]
2023-02-15 12:00 ` [PATCH 1/2] Revert "iov_iter: Kill ITER_PIPE" Konrad Dybcio
2023-02-15 12:00 ` [PATCH 2/2] Revert "splice: Do splice read from a buffered file without using ITER_PIPE" Konrad Dybcio
2023-02-15 13:01 ` David Howells
2023-02-16 9:10 ` Konrad Dybcio
2023-02-16 10:56 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230215-topic-next-20230214-revert-v1-0-c58cd87b9086@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lsahlber@redhat.com \
--cc=pc@cjr.nz \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=sprasad@microsoft.com \
--cc=tom@talpey.com \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox