From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C95AC64ED6 for ; Tue, 14 Feb 2023 13:23:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A68B96B0075; Tue, 14 Feb 2023 08:23:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A18BF6B0078; Tue, 14 Feb 2023 08:23:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 908856B007B; Tue, 14 Feb 2023 08:23:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 7E62B6B0075 for ; Tue, 14 Feb 2023 08:23:43 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2C8638077D for ; Tue, 14 Feb 2023 13:23:43 +0000 (UTC) X-FDA: 80465964726.12.4821DAF Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf22.hostedemail.com (Postfix) with ESMTP id 9142AC0015 for ; Tue, 14 Feb 2023 13:23:40 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676381021; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=elYQoE3zNoLwGUGdtf8ALmqj96+ZNNp9vgcdcl7X49I=; b=nwMUqAW9VPL0yj+neOgtSeko9BodS9Wd0VVKqySEFINyQdUPd3OVDow0aDaTd7Ist38RRc tKJqP/jEqs3Ud6Us9wAgzSRIgN9yLyh5Hvc9eKegfsF50cMaMCGF9bR4Mz8uoGbWYeNm2u TpD8ENSSkpb7afoz/I0326UzyBbOqM0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676381021; a=rsa-sha256; cv=none; b=vA3PWT68nh6Sl/cJWT/GmVvspW6ynGOQKo3r/Gdy/7LGUGM/M/fD3Z7bbX5mlqj+PRSycy LYu9wp+w6QXQaOrkG/e3gfJoJiMStuxEOZQwkglNjLEVlCNlrsNgDfd0RVqgBQ/xJx7XZX F9q7aSPFl3I6BexuUDiTZaXGc/dUxc8= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PGMHC09Mbz6J7f8; Tue, 14 Feb 2023 21:19:03 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Tue, 14 Feb 2023 13:23:37 +0000 Date: Tue, 14 Feb 2023 13:23:36 +0000 From: Jonathan Cameron To: Dan Williams CC: , Fan Ni , , , , Subject: Re: [PATCH v2 13/20] cxl/region: Add region autodiscovery Message-ID: <20230214132336.00005915@Huawei.com> In-Reply-To: <63e6b89581c3c_1db5d029467@dwillia2-xfh.jf.intel.com.notmuch> References: <167601992097.1924368.18291887895351917895.stgit@dwillia2-xfh.jf.intel.com> <167601999958.1924368.9366954455835735048.stgit@dwillia2-xfh.jf.intel.com> <20230210180958.00002e5a@Huawei.com> <63e6b89581c3c_1db5d029467@dwillia2-xfh.jf.intel.com.notmuch> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml100005.china.huawei.com (7.191.160.25) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 9142AC0015 X-Stat-Signature: nd9bx1yeem3fmjrh4mcf3hk4ixpxoocn X-HE-Tag: 1676381020-13176 X-HE-Meta: U2FsdGVkX1+qr7TogFs2U74ACbq8ZgyhJVLIlBaxgr/OH4A3PinJRgneQ8gLgWigOXHF+7/0CxU61QuJeFtkvBvMRmxO8jjQ80B5uiPgpZX4X4CmJ1SrjYQkbK1jDKWTHA0UV32CocpklCEdCkoImIXcEslnTp2lUhCGL99gCvvwvdCJEW49vD0fORTDq4/ryHtua4BEP8RYK+S2Ix91s9wFK6Y6c7QDo+EmdBaj/H/T7TNxC0KCk4BCJHKEae7QroUl6HkNkwm7YzBYTkwMEtV9TgerT63+8XdeQ247865sWTC5guH2lyt1iqjk6kcPa0h8cHD+XemJu6KAo8LM3hdlxCGhh4V0ZiKettIlg8kLUg6w3ndN3kEMqF5VS/EOJh/fRJzhwc4biVz/T/7J/O3GihxWMCOLutDRzT9IfWAiAgJygGr4BgRMTOg64/CcXJ8FRKMAxnxAzsZWvAPvj8pVg9fAejEtjuxZbFSQgOXR6E6hL6giDqbs4u+fP6qLsFLX9PPTXS/zBH+OvgOioGrEsv9xihW0vHkVS+NjQi6yrHimYTbx1mUcp4jSUU5hkg90w/R2XgpOj8LA0idFWfC2ZPw7nGUOFEqeMATfiK0pxvOBvuGeOAkzvythiZfG6haKzhnqX2LIDMLSqWvTHJOHQX7TbIYH4E0/gRJdTJuy08CkVlQHFNj2L1f/6WoXY1tXFxE0nVgzMwi/6AWk7ZTKDIbn3YZbdBvxLdynVwtOPAfWvRdmzGBdlftNeOzfrmL6+cmgVbw1ebPSHbUG4ptHVCS2XU5Ho7gl1tqpQgy1wec6Mxs4e/GaHEXPEkdFYQ6f/RZ2QLOHfI4l3q94/j6jbExKrB7IGK6fqNkKcifXcziglzv8SYH93NgBHtAvcK4I5I6/m3XuirBYVnmXkQEAeR2MUvwlwognfCuTCoMI0OpRiZHllBiKyIwx9KvngsHUtYWwvlBafjNXXen 2V6GrHdo AvMfu2GEDEOitCRbPql8IXgmL0H8eTCOzEiSkCcwc4GNot7UF63RVwHy8y2EdGjI7RW1HXzmuG/QCiBUwbovsoD8BRqJniyk4B8Zmo4UDjhKkL/++rIt8m7Wb4+zsJIvYhCdB9q6kuklbR1cANSb4/ghHYmyi7tMFI2NyKO7v5oVrUItjTdca+Pg/dc/2mLq8+pdrelKZ8kUQbTTjpwU6DczqaAIwXu1hnaob X-Bogosity: Ham, tests=bogofilter, spamicity=0.016704, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > > > /* > > * If device_attach() fails the range may still be active via > > * the platform-firmware memory map, otherwise the driver for > > * regions is local to this file, so driver matching can't fail > > + * and hence device_attach() cannot return 1. > > > > //very much not obvious otherwise to anyone who isn't far too familiar with device_attach() > > Hence the comment? Not sure what else can be said here about why > device_attach() < 0 is a sufficient check. I'd just add the bit I added above that calls out the condition you are describing is indicated by a return of 1.