linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "Jiazi.Li" <jqqlijiazi@gmail.com>
To: Christoph Lameter <cl@linux.com>,
	Pekka Enberg <penberg@kernel.org>,
	David Rientjes <rientjes@google.com>,
	Joonsoo Kim <iamjoonsoo.kim@lge.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	Roman Gushchin <roman.gushchin@linux.dev>,
	Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: "Jiazi.Li" <jiazi.li@transsion.com>, linux-mm@kvack.org
Subject: [PATCH] mm/slab: always use cache from obj
Date: Tue, 14 Feb 2023 18:19:49 +0800	[thread overview]
Message-ID: <20230214101949.7461-1-jiazi.li@transsion.com> (raw)

If free obj to a wrong cache, in addition random, different offset
and object_size will also cause problems:
1. The offset of a cache with a ctor is not zero, free an object from
this cache to cache with offset zero, will write next freepointer to
wrong location, resulting in confusion of freelist.
2. If wrong cache want init on free, and cache->object_size is large
than obj size, which may lead to overwrite issue.

Compared with adding a lot of if-else, it may be better to use obj's
cache directly.

Signed-off-by: Jiazi.Li <jiazi.li@transsion.com>
---
 mm/slab.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/mm/slab.h b/mm/slab.h
index 63fb4c00d529..ed39b2e4f27b 100644
--- a/mm/slab.h
+++ b/mm/slab.h
@@ -670,10 +670,6 @@ static inline struct kmem_cache *cache_from_obj(struct kmem_cache *s, void *x)
 {
 	struct kmem_cache *cachep;
 
-	if (!IS_ENABLED(CONFIG_SLAB_FREELIST_HARDENED) &&
-	    !kmem_cache_debug_flags(s, SLAB_CONSISTENCY_CHECKS))
-		return s;
-
 	cachep = virt_to_cache(x);
 	if (WARN(cachep && cachep != s,
 		  "%s: Wrong slab cache. %s but object is from %s\n",
-- 
2.17.1



             reply	other threads:[~2023-02-14 10:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-14 10:19 Jiazi.Li [this message]
2023-02-14 10:33 ` Vlastimil Babka
2023-02-15  5:49   ` lijiazi
2023-02-15  9:41     ` Vlastimil Babka
2023-02-15 10:03       ` lijiazi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230214101949.7461-1-jiazi.li@transsion.com \
    --to=jqqlijiazi@gmail.com \
    --cc=42.hyeyoo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=iamjoonsoo.kim@lge.com \
    --cc=jiazi.li@transsion.com \
    --cc=linux-mm@kvack.org \
    --cc=penberg@kernel.org \
    --cc=rientjes@google.com \
    --cc=roman.gushchin@linux.dev \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox