From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF669C636D4 for ; Mon, 13 Feb 2023 18:50:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5B0066B0072; Mon, 13 Feb 2023 13:50:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 538BC6B0074; Mon, 13 Feb 2023 13:50:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D9996B0075; Mon, 13 Feb 2023 13:50:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 294CC6B0072 for ; Mon, 13 Feb 2023 13:50:55 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B80AD80BCC for ; Mon, 13 Feb 2023 18:50:54 +0000 (UTC) X-FDA: 80463160428.17.E2E16AA Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id D0135140011 for ; Mon, 13 Feb 2023 18:50:51 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fKzWRcjY; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676314252; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HWNexQaEycebdBBQ5w4AvWVCvVvx2yrSpQjQ2YKje18=; b=8EBgvyIIHjVE5/WJTvHAR6Vlf6BwrZ+yK2UzHaFRFUBW0pgD0yPXGLlOLWDNvAtk2E7fKU ZUSR/FC8FSCO4JrsyAg/zlSpXhfSmD/YJmutOuQULfN6DaLPt0/PxCfOlidvAM1hSi1/9P rw3Bpmo7YAyESP4vKiegTG8aeUY+t8Q= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=fKzWRcjY; spf=pass (imf26.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676314252; a=rsa-sha256; cv=none; b=O2P+EohlCGCA9YGDaTmvsF8nNgOpuCpOklzVcNgpI21q7Raepx7BPoY5xsSkSGoDkOufDk ucB7yS/CbFK48GyP3xd7SBdNEGVoMfvZZD9s0zD2QPfGkuKCd6fd0vVmS1KMDVl62v2T2L a9abM1CIC8JAOSKAWp/3VNpUBIvoh7I= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B4F9A6123B; Mon, 13 Feb 2023 18:50:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0AADC433EF; Mon, 13 Feb 2023 18:50:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1676314250; bh=AE9Jo3WNCkiNWpAWO8ogGUm1wlArk2QW3e77TZzo/Rk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fKzWRcjYvzXt2VJKFufT77Vf0LMCAOMpLHHOFzdiFNqKvmMX+Zz89O8jhWHFp6QjB 4dnXZwFjlBUGiXWwvpHWDrtjd3z/5G8C/Mi6CGEueBjk+uE41JixL7TrAlka9ZymW3 ottmzkVu7WymXOdBusSQxRn7IeBMwN3Nkp0+/7xg= Date: Mon, 13 Feb 2023 10:50:49 -0800 From: Andrew Morton To: Yafang Shao Cc: linux-mm@kvack.org, Dennis Zhou , Tejun Heo , Christoph Lameter , Roman Gushchin , Vasily Averin Subject: Re: [PATCH -mm] mm: percpu: fix incorrect size in pcpu_obj_full_size() Message-Id: <20230213105049.a5354a4e20fdc4cdbec55b05@linux-foundation.org> In-Reply-To: References: <20230210154947.4460-1-laoar.shao@gmail.com> <20230210140508.cfafb571dd44cf4fe776750b@linux-foundation.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: fndqzig4s84pz7eemb35tedn1y3qpx99 X-Rspamd-Queue-Id: D0135140011 X-HE-Tag: 1676314251-233914 X-HE-Meta: U2FsdGVkX18KaN25sUntyMyOl7u/l0WP19LjsMRLMUACkpCDgGzsH4YrYhMSxW6/JYdOsA/Uu03gpmY2rlHoIODCplm9TNGR0+cUbp7TKE5LRmv+feUBgiWqfujN/tnLolU3FdENKWPp60k+P2N5ERrDJnw1e8NXzusZrlH7norypjl3x5Fm4szTu1aJHzfJZdLqqC06I1fGS8Y7XN43QQcatIrVCEgmxRaDtWGX3gXneQbIHCLcnYxgh3kPxsZdqzMf3k32bm6Objtu5xUlvjktRNT6LItPZ1MG9kf0WvhRJce5K0dmF8+hv1lN9QmxXI0eGFXMzssMI27fLaH+P63SI2WWvvUQ5drSCQFyGPgfwxiML/Yy8cscLowW64bFLUQKxf2lHsq2wNnXEtFeLUs1iHAZqyXuYvh6KF2hfJuSO+Lvnh+DWfFbpPpIpaqZsA8mJxE8YRJgl6LcbeLQ7C1rNxJTsDP0TTgsrcn26fvcByEqjXMYaT5rHU3/vvbk6GgbkU1j6oa/yEbGtWG6ER3M2D9LrZpoekLh+9A3VbUjIMT+l2Aq1+0wx5ecwGVH0rH2p4ixZ2g/qv9ob4IzsMLppBMZ73mm9wHqFLRBbwsiNdKvb/YeajIV1JxdG/E/pAbvsDm4BbrP78143lKzTZkxaMq1hUsPJcLyOxTMWhv14aE4Vr61vYO8/Op8Ub/KBZ0T0UiHpwP0AuJAQC5W85bNuDEfybD8vFjPKT3T4xLzHLoQ8vUfjA+ggXwJOJO1OHVwe/G+qtF2uPEPVVP8mdqUJWIvgYmlpq0qytHjR+EYTGQOa95btcINX4UQyIVwlXqAbV2JlpeMttafE5453aWvllCmpj7DwqMwMM3XQHY3ds4pwm94YdMlULY9K7MQR2iF4lmcZdaTeJbIjVWq8/6aelyYWhblqw1JZc3Ta3yHY4t245S549dxcqkEWWT3ViNfU5pzFGDXV6Zx4IO PeJOs581 I2Yus51OScegKiEeDlYqGWisW3YSjiUpm9nPgiqRfukaLSsCqEMWJT1AOmNxmc5okptl9sZdWOjfMvR+YaEobuN4pFQ8Re/U9C2ju/oZecJ4d++eUE4QIyySFRzrlT5rKG5jHF3pE4DoQOAx0BXDnAOf9VJfJS+fN+ZNmt3iitdx02C6N/P6gyWSz9DU/1n2Uta29Af71mpEEJep6VEe/lC/dmgYarTsg0G18K5dbPInKzOG5PHFujmZd84tWCYKKbu+7eWOgRcIp/Ed1i814jv8hMO+uJ1mosQOgtzig0ju+0GruiAAo+hNd0vwy66+IA5ylZ2aIgNkcg0/Tu9CkHv+PJItdeHzseyBw6Q1QzcovD5T463bR9rcDuL7Gn1qG8J7CVVrRbA4is31HRg3iEoUsGNNSVy4TW4EpXp8P+HsDKzFqRp7S8caauXvdBh3l3OdsrsNiC4GrgPKuEmAKrcFLAfIWskKNG4NNWQy5NOb4MbeaZrD4YHGO0j5kIb9g3ngdscuTYW+JEMLIzFGhuZLejYSWLd+IxRSE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 12 Feb 2023 22:05:42 +0800 Yafang Shao wrote: > On Sat, Feb 11, 2023 at 6:05 AM Andrew Morton wrote: > > > > On Fri, 10 Feb 2023 15:49:47 +0000 Yafang Shao wrote: > > > > > The extra space which is used to store the obj_cgroup membership is only > > > valid when kmemcg is enabled. The kmemcg can be disabled via the kernel > > > parameter "cgroup.memory=nokmem" at runtime. > > ... > > > > > What happens if we do a bunch of allocations with kmemcg enabled, then > > disable kmemcg then free those allocations, or some such thing. Does > > the accounting end up wrong? > > > > That won't happen, because we can only enable and disable kmemcg at boot time. Ah, I misread the changelog. I suggest that "disabled via the kernel parameter ... at runtime" be "... at boot time".