From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9CFDC636D7 for ; Sun, 12 Feb 2023 17:35:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4141C6B0074; Sun, 12 Feb 2023 12:35:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C3A26B0075; Sun, 12 Feb 2023 12:35:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 263AA6B0078; Sun, 12 Feb 2023 12:35:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 140946B0074 for ; Sun, 12 Feb 2023 12:35:19 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C73EE8077E for ; Sun, 12 Feb 2023 17:35:18 +0000 (UTC) X-FDA: 80459341116.08.6A2CA9B Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by imf07.hostedemail.com (Postfix) with ESMTP id DA9D640005 for ; Sun, 12 Feb 2023 17:35:16 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MHIS9yii; dmarc=none; spf=pass (imf07.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.43 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676223317; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AviV4NP8CNDKVbz9j5WTQQVcHZAFX3ps8TmNJsoE4Jc=; b=PfjNmQZYBs//e++uSwhoR6tlVPNHnbDUnd76Vdj5qoj6G2GvXqhJFIYobAHjSzoJJplJ9I LyOuiYFTHV4w82/He4K+q97uBrWmcET2S8KuqsyTwqCeojnmDKYK7nZXDDl71367784u7v frX/PY2PbksSqBckZMtEFvLhIdb4PhI= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=MHIS9yii; dmarc=none; spf=pass (imf07.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.43 as permitted sender) smtp.mailfrom=groeck7@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676223317; a=rsa-sha256; cv=none; b=MGfhJpJ0SXOjTiRxTP5x+7cKH6bzmkeZdIAyk1qljg6FmWtmFbj1W9VDUZRc3Pq3BQbwZ2 gzA8DSTb41BenXztSG9wGx6l/KUOvGFj0EgJUILlPXsqBr3PmMs8s/r8rLJjDSm0pCR9Uj oArmLixQt6ObMgq9g1aV0CFY1wizHlI= Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-169ba826189so12875263fac.2 for ; Sun, 12 Feb 2023 09:35:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=AviV4NP8CNDKVbz9j5WTQQVcHZAFX3ps8TmNJsoE4Jc=; b=MHIS9yiiSKowWCqVfdLqqCBXCJI87xi4ik1euT9MI5qsuF90euB0z5OyKuHA+cX91w YM7Wr6xuS7Jsgd7Y/u17CKVlvOwGsLCmOXhdEeanSjtI1beQ/D1NtEqo8E4P8eQmjrlC u7UFMNCSnuCP/T/T+tikXDIsSQMmHH2xGwg65Lv0VkoYlNQzShkSHlh6NsCvKZch8Vej m1HG5S97Md/HphSzvy3Z1aOcBibylidfKFslbj4nzbnKfNRe5nxJQMAlztxOYwkeDTKX lJ8sbGZbHDOmiA/KDUs9NhF4Uu6i1LxZhJTamcW/BCuJlw1+7dh4aeYpmNhWCcX+M886 twIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AviV4NP8CNDKVbz9j5WTQQVcHZAFX3ps8TmNJsoE4Jc=; b=31MbeBvveaNhxRDe0yKdEzMq+ZlPYDKWLxNZfjuwSXlgaGLd/Mfe9gPyi+F4HQVb27 NERGFyOaHqdV2X+j8q7c4EEWUAl1p+MkQ5lavKzB3CmDffguti3BzOliwBJFw7VQHH7b sHcbyfc8O9vu6zsM1KRdNiBGY1dlkv3VytKqDtfA93DdXQg6SJ4rLhuyu57uF76WQwe4 U22+o75ogaCh0Vjjk1uNpTLhRnDwLjItoJdTxiRH9a0UaV59tazhmw992KfhWZWfjtTT XGPhGPWjCveYEvNCpMOHbrBSa0c8JhRz5s+eQvFc8MyWwkpqVqv/HgCOqkeTni8xh8oO 2UWg== X-Gm-Message-State: AO0yUKXdwUEygu1CRieOO15OqhfpooTNz+ukfUaJe3dis7JhemlenjRo Y2k/yiwSjxPrhjXhewfv2LQ= X-Google-Smtp-Source: AK7set+HQUfu5iOqDoYfEGRzO6Asv+HJqu3wHpvaAM105ZXPUWPVLHg/VWo/CEfIvczS113vNKvB7Q== X-Received: by 2002:a05:6871:9d:b0:15f:32b:6e33 with SMTP id u29-20020a056871009d00b0015f032b6e33mr15518149oaa.39.1676223315946; Sun, 12 Feb 2023 09:35:15 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id i9-20020a4abc09000000b004a3527e8279sm4076452oop.0.2023.02.12.09.35.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Feb 2023 09:35:15 -0800 (PST) Date: Sun, 12 Feb 2023 09:35:13 -0800 From: Guenter Roeck To: Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , Brian Cain , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Greg Ungerer , Guo Ren , Helge Deller , Huacai Chen , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Rich Felker , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Vineet Gupta , WANG Xuerui , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v2 2/4] m68k: use asm-generic/memory_model.h for both MMU and !MMU Message-ID: <20230212173513.GA4052259@roeck-us.net> References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-3-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230129124235.209895-3-rppt@kernel.org> X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: DA9D640005 X-Stat-Signature: jidwxyhfm7xiaj78ek4onkzghw59sr19 X-HE-Tag: 1676223316-987207 X-HE-Meta: U2FsdGVkX1+26ElnFujOTg3fko/GqcfUoL0z0NWJDAuwv8hA1PhNCLtDR4wm9kzt4WfHjkPwW6YoOpPSkTHcgjsFdghZm31xGePXnDSkdfTPBc11aT0e0PlA1NdAPc3aL5Pq5/E0qA2sQAijysJ3d+FsoCBKxIpbUqYpTT68LsnPKtVIDQji2tC9kxAQUK2UF8IWkLRnwL3Cter8kDuGEXvdsDDFAOrcw3So7aGriw/8gy/HSOVpBeoYIVNoCaTALCO7ZRU1YVIF6jx0i6/QDaxSfCch1htL58URnDf2kBm7ZU7dt3hwzY08vd0nsCEigsg/oAMe+uc8qFqMmQu16rnOVH1VBjwVigNLcGFQm4VktnkhZTYwJH6yskHUv5SHNJcHew3QM+RVceRLVGwQsWltTwWSBnRcqTJoJZ4SKuGFKUliHaGlaFL+qw2e8tC6OZo3PrrLG7+fVTxip4qyS/vPllXqAwZJ8eyvGFDo4ib8J8wH5RUuTjQ1wo3N1OuXWM39iCODYskkOtdApKaGsG5u3I+ETxXQponXNZwPbTudNgYAal8U0xkcgxfRY7QYFcVytiU8AatenxrrpDCRP+wTHILB/PgbS7rl88kKBE7iQipw5sKwe2Qn74Oo7YsJ/L3OdaoBx7aE7LeNAA49dQr/bYAmhwi+uVEQfMpcZwPto3qOY66kkWXIaobV2WxOrCL7+U4r7GF9ohReb5LWWTk8swjEcIInIDbnfQFRJAJEYYiRQzAOLhn8fTxLznLac6jv6ocC6xFplzyi2oVLY9wZw0wDL+KVm58vqlpC05VBFAwP69TWDJQSnjXB5mTPGVw++A3Z88DlHwJ+5Mbf8Au2Py4jmRSZ9h8BIYoQxro85QkAMIDxh3vGPkWh106KwFUDxWKQlU3idHJyJ3qvmuYgYKmaj/wTWbnZALNHjy8/Bw+AnrD+7otoemlFDUPzzTH8uHA9jUWzSxSSAIE zX3tITH5 hpwwo+aLehJ0lD6voagrxv1HzwayuhDPfXOsYhXaoVTXoEdz++TuE2285sZLWaVP1JWg9epvX3/jueNmuIfyFHTn6scGxm5iFEoyDq+BUzEq/6M9QqsfQb8obmLqKE30U4t7++tfKKXEgduY3cKF/7DUxzOn2ko00FXf396n0ygPauVwYCqfIpKqfXkgN0qsVt4xRqqQCbS8iEtRf5jf7iPqzviBoyiHbpeNup34Af5E8g0JehrxVtcdMMJ5JQqXb4pWxFLFtcJNV8egR3N4Yp5emHPk1MJtFu6oEX7/GdmnII9NLCBYZvX8NFOnBOOJqqT8uGgdH4k7/uaLvjp4aZrIqZEtPSVIQsiIjRA+vsxEMPueZBjvKXYuABznsGvWWZ5+AhLFFtjk/f5WCWnobXSbK3ayaGSkAkkhxKvJy9Pxy46ZqtBukZfHvcR2fDYS2pvEI9/Ptu6w6g21sy/Qr0ORD151sHCIG/K8Q9vCKz2/yJtLPZBVqZFMqA2RUuCo2ZgesWF3S/51Y4f6v9yrY+5jbf+lD1E879ghjnzI1WkcHItMco7xjVbOpbfZHaMDmDVLIamR8weUUXlqyhdhudztykDF48nJ0w6Hk8aQ3y4l2D+cEdNofBzkhdebhhCHHc4q5H4xq7wSwgpLed50ryX7VsjvOIIOGYpTFBQHlmPx3Vp3THwvk04NwotmNKoqFQS4ssNZtKAJiNdIjIPhVh+GMnzxIdPTlrDeF X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi, On Sun, Jan 29, 2023 at 02:42:33PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > The MMU variant uses generic definitions of page_to_pfn() and > pfn_to_page(), but !MMU defines them in include/asm/page_no.h for no > good reason. > > Include asm-generic/memory_model.h in the common include/asm/page.h and > drop redundant definitions. > > Signed-off-by: Mike Rapoport (IBM) > Reviewed-by: Geert Uytterhoeven > Acked-by: Geert Uytterhoeven This patch results in a boot failure when trying to boot the mcf5208evb qemu emulation. Reverting it together with "mm, arch: add generic implementation of pfn_valid() for FLATMEM" fixes the problem. There is no error log - the emulation hangs silently until aborted. Guenter --- bisect log: # bad: [6ba8a227fd19d19779005fb66ad7562608e1df83] Add linux-next specific files for 20230210 # good: [4ec5183ec48656cec489c49f989c508b68b518e3] Linux 6.2-rc7 git bisect start 'HEAD' 'v6.2-rc7' # good: [94613f0efc69ed41f9229ef5c294db3ec37145da] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git git bisect good 94613f0efc69ed41f9229ef5c294db3ec37145da # good: [19e62c715fe70dae4582c2874ed3e66715d09af6] Merge branch 'rcu/next' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git git bisect good 19e62c715fe70dae4582c2874ed3e66715d09af6 # good: [5d8b7ecef7f4a681b6e5538db59ff26c389c0ab6] Merge branch 'for-next' of https://gitlab.com/peda-linux/mux.git git bisect good 5d8b7ecef7f4a681b6e5538db59ff26c389c0ab6 # good: [c349bf6ec83903b20fe570c5609b9a864a64e09c] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/krisman/unicode.git git bisect good c349bf6ec83903b20fe570c5609b9a864a64e09c # good: [5a06a9f17454df38f35672be522ff5eb9b4277d2] selftest: add testing unsharing and counting ksm zero page git bisect good 5a06a9f17454df38f35672be522ff5eb9b4277d2 # bad: [f5d115a7b06e5661ed5218ffa9a2644c4ff1c135] Merge branch 'mm-nonmm-unstable' into mm-everything git bisect bad f5d115a7b06e5661ed5218ffa9a2644c4ff1c135 # bad: [acb018d6ea0c055381fba7dddaef386ee28f8075] mm/vmalloc.c: allow vread() to read out vm_map_ram areas git bisect bad acb018d6ea0c055381fba7dddaef386ee28f8075 # good: [1a5d9782ac969dc6e61c6786500b5160603188ea] mm/mmap: remove __vma_adjust() git bisect good 1a5d9782ac969dc6e61c6786500b5160603188ea # good: [4b32363697de957dcc890b6245bec3f58903639a] arm: include asm-generic/memory_model.h from page.h rather than memory.h git bisect good 4b32363697de957dcc890b6245bec3f58903639a # bad: [328cf3fa6682ce6a4de6f8bb8009c833dc33f3c8] mm/migrate: convert isolate_movable_page() to use folios git bisect bad 328cf3fa6682ce6a4de6f8bb8009c833dc33f3c8 # bad: [b704c765b08cabe82adf76a4d1a74f3688eee410] mm/mempolicy: convert queue_pages_pmd() to queue_folios_pmd() git bisect bad b704c765b08cabe82adf76a4d1a74f3688eee410 # bad: [e5734c8b0edfd2a053a5c256189586a3b1e9f63d] mm, arch: add generic implementation of pfn_valid() for FLATMEM git bisect bad e5734c8b0edfd2a053a5c256189586a3b1e9f63d # bad: [ad8aecea034c591b9754bc5908da9719853aa7fa] mips: drop definition of pfn_valid() for DISCONTIGMEM git bisect bad ad8aecea034c591b9754bc5908da9719853aa7fa # bad: [1f6271a0dfdf952c2e3981f424784d48f243a2be] m68k: use asm-generic/memory_model.h for both MMU and !MMU git bisect bad 1f6271a0dfdf952c2e3981f424784d48f243a2be # first bad commit: [1f6271a0dfdf952c2e3981f424784d48f243a2be] m68k: use asm-generic/memory_model.h for both MMU and !MMU