From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0560C636D7 for ; Sun, 12 Feb 2023 16:13:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 523B16B0073; Sun, 12 Feb 2023 11:13:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D3D16B0074; Sun, 12 Feb 2023 11:13:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 375536B0075; Sun, 12 Feb 2023 11:13:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 27BDA6B0073 for ; Sun, 12 Feb 2023 11:13:25 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D34D31207E5 for ; Sun, 12 Feb 2023 16:13:24 +0000 (UTC) X-FDA: 80459134728.13.8C41563 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) by imf04.hostedemail.com (Postfix) with ESMTP id DDDD14001C for ; Sun, 12 Feb 2023 16:13:22 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RPfdfqoX; spf=pass (imf04.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.53 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676218403; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m9JNrWha4YKLX9rD9uaO4Le+Z0yMwIJejyvjLhFB0mM=; b=68b0z4DbBi4iRT2wsOc9WwkeOzTIHphl9G8i0z4Cfhc2JGt/DRQ1CCg3b7LTZhP2dTPism UaDZGZCCAgOmtBpuj+c6BD13ch7P5L/co4wDBPsG+liXxYuBOHppc1IePBYe1IEoM2CLba AL6YX8mtEGCAw7rXd2ZfIk34WfSIIE4= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RPfdfqoX; spf=pass (imf04.hostedemail.com: domain of groeck7@gmail.com designates 209.85.160.53 as permitted sender) smtp.mailfrom=groeck7@gmail.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676218403; a=rsa-sha256; cv=none; b=FFBbcsOoj3aG9bx8gEI1GB3tPDF4uHWbxcYmwiiHM5xh4H+aBxDEGwUygJJtLAKKiUXEaC cuREHuX5xDzvhl26kDWKy5leZzuiS2Hx9fibEcs1GqLx6VedY/j4Vm3AwLrs+BDNFU0RJw 2S2lLoCK3OxgNGht3CYpF8XzBikXwH4= Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-15ff0a1f735so12709968fac.5 for ; Sun, 12 Feb 2023 08:13:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=m9JNrWha4YKLX9rD9uaO4Le+Z0yMwIJejyvjLhFB0mM=; b=RPfdfqoXr1Cw8prltm7TREoupX5eaNpNd+CDIlDXf9L709PnPoKQLyqZ+zboWylzWR vxu85Zr3W8llfd+943ctWIFMuj/eUOowqYJKaVeMEAuOZh7DSd87i28bvDxNAQ6PoOwC wXW2mjy0Nv7rWdLT7K6lR96N0WQft3GWf2KAFrqyzdPjhTZH7LFIYRkc0u2koR60TrCD 1hpxf+WoKXg0JbOE+h0e0CkhGndeecaH5fbwJ/zhVif01anzu3CRcpBwMXBGR6L77UGt T0ZqZhaH9160JyrIQvfc6bBDGV0wnlmjvzDTuOmCpyHfThC29vCqk4lTBNsczBdn8qUd qBXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=m9JNrWha4YKLX9rD9uaO4Le+Z0yMwIJejyvjLhFB0mM=; b=fDlhSJU0HpW6lEItZBZ3rEl1+nJqc1rIagvPNMrTBczWYuLD0mIabOvyEi6ZkXA9o6 qKxeNhdx63oRz83WZT/9SVZENWcJ0I3DarUvFsSn91flCTZ61Axo4P1ouIhNKupmNyXO 9UeInwuykejRDuQ0HwsD2raTZvbG+/OvDweYKiD92+TSEFyxTjOC/I255ubkpoduIDiX kT92kGfrkwCL/YBAblO5TSBOp49t+cuT/uyC81L/9w4AT9NiSl7nFKoVa7Mt/ZbTxV+t Un3VVVXOtzwQSBnYpwoExcSA0EeIKiIjun8sIG3N5AZbaEq2/yK9ZmTnWFAPjDuaOsBs 1FBA== X-Gm-Message-State: AO0yUKVaX1j8Eb6ldIoEbFg8eYGDuWFT2KUovflVfhKzWxT+I8Wj1V+n 8LZW5RAjeXFf4GE8Kz5YO50= X-Google-Smtp-Source: AK7set9kfP8sfCh4EsN95J/ZdmLAzZQPNePNkWSy8sPECM/cP6PHARZOJXcrMxdY1LlBw1JK0pRDxg== X-Received: by 2002:a05:6870:b48d:b0:16d:ec6a:71ec with SMTP id y13-20020a056870b48d00b0016dec6a71ecmr2441541oap.27.1676218402068; Sun, 12 Feb 2023 08:13:22 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id n2-20020a056870844200b0010c727a3c79sm3225235oak.26.2023.02.12.08.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Feb 2023 08:13:21 -0800 (PST) Date: Sun, 12 Feb 2023 08:13:20 -0800 From: Guenter Roeck To: Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , Brian Cain , "David S. Miller" , Dinh Nguyen , Geert Uytterhoeven , Greg Ungerer , Guo Ren , Helge Deller , Huacai Chen , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Palmer Dabbelt , Rich Felker , Richard Weinberger , Russell King , Stafford Horne , Thomas Bogendoerfer , Vineet Gupta , WANG Xuerui , Yoshinori Sato , linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, openrisc@lists.librecores.org, sparclinux@vger.kernel.org, x86@kernel.org, Huacai Chen Subject: Re: [PATCH v2 4/4] mm, arch: add generic implementation of pfn_valid() for FLATMEM Message-ID: <20230212161320.GA3784076@roeck-us.net> References: <20230129124235.209895-1-rppt@kernel.org> <20230129124235.209895-5-rppt@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230129124235.209895-5-rppt@kernel.org> X-Rspamd-Queue-Id: DDDD14001C X-Stat-Signature: xpupb6n7x3wiwdajx56babynuyzy3xte X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676218402-974877 X-HE-Meta: U2FsdGVkX1946maARE4ZPw1RvuWRBQFCBe831uhGit5Y9md7wYuCt6orKoRkcw6GpdmKXokP0YoWByOxM8pdLpgwVj9NMaLecjSFOj7hvhvzCbnPoY+uehdanODnoEnm+/7miI1cKDIVM3t9n69C0haXAKIeE9TuA61l77xXBeZibpHirFCgXIvQe/mXft4RdHuPq8vUUO+FuhcyKN4mJImcUimJLYd35EUPr5EyhyKC8rkUBv+7hi/bWr0fpdZR7bWtJ2uBQ4cbRD3r9gTDtY+Gc4omuz5sAi8olhrj1445flMCf88S7mTxYCbt+GYrlVaWGopfODJ13pAvdirQyRuz9zao2jyCIrY+Ozb4G6+QPBuEnlmInRmuybRWK9g+A/iGVvgW2OvcpJX7Vnz7S8OU2X/SYjTRJ4aQ/AfNYA9Bhk1ElCq/KRs0fE8vZ/3Y0AreTIx8YkmOj3vvnkC/TSEkEHR5Ry9SPO8RAbCPvNg4Pc1iCDDTBh6b3RoEVhT0bztGgAJSu7bynUy2+hDvK0dLrfJLhjdG7CEaIq0kh409t1FGPsJlinIF6etM7kqGULOsP1w+sNA4WAui7gnQ/oHC74epsCsDrfMligM5AX8DkOvNUMM9DIf58Oqt2058LnHHO+7LprB+AnKmyZoIqHkliqIVQTn7T/czlEnfgrmStI4T4miAJyPNFpOK7pXMRyp4k2Yb2tgT/2M/wF34fh599Opyc7F59LTNmmMVvZfbDMmTydMFLaRFjoiVjbdaB5B1GFMJ4pwN+a9Xm4kWeR8hW7F7VDU62bN6pmk/tgS+02mCNEimxdzVVGt8Kell8Xol59wS3RSJnjkidsAHVBLTfiYjSPJbz1PAZQmQQkfiJSg6AlDLmj4s9UqAZRKIW1RQuMnrYt8evOgRH/d/AnmEy/lApBguWKvW1eeAxzrZVi6Cl2N6UAQdBWxYHjsI6Sw1nP7dUIyOrucU4ml l/iV8irx l7aLUn6VTR4HyO5KUYafjYjLDsQcXWe2M9vTKye4jGLyRhy/vtkdbrm3exPDFr8t5wXoZOg9uRjgPpirCYe8XOJhsCmUBCtZN++iSrayTJevMn69+1JUJSNqzVYGd0+dkMbc0rGllvVhjXgMgbg7oFY1vrLntdSNvfrWCZgUXvTuO12MWphe1Hgl1kyqLQvc9X/Cnf2ZDvsDGuyeQSnDenAAoGysy2QHnBJGpONQi8slVmIPHkn2W9ovrVdkUPr/vfLXAWgVX9x8NEVaTpaWKV+i0xDJWli6B2UpPmmx+jxIIRZM+/CLWu6buyJjlVzq/1vXPOSqm/QMhz8bZ1aBQugBvfvopFdjIFCUdsJ8tfo3JQ7Nr6SINEhKv+kM0BcqFhSekawFTa0sza1ViLwLE5HIzSqN6bsfdzFCk+MvFnozZ0bPXHQH56BrH80dV+Y782CRlAcRm6/pZgruJ9ZFxor8wsVE03eSQPigPbIvOU9c9tYPL+/TCC5ukIS+fAbuANccwaFYT5ln6B0UNuqEksXqrRBTbTMnbfaPW6EaGoKPsQms46/eWwPp34mFhfypQvWYOPeSOT2YbTfHeDVVl66ztQtQgcyFq2nutJmWLbdjf4/ap6jre8wk7uj0om1QphDW3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 29, 2023 at 02:42:35PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Every architecture that supports FLATMEM memory model defines its own > version of pfn_valid() that essentially compares a pfn to max_mapnr. > > Use mips/powerpc version implemented as static inline as a generic > implementation of pfn_valid() and drop its per-architecture definitions. > With this patch in the tree, sh4 and sh4eb qemu emulations no longer boot. Reverting this patch fixes the problem. Guenter --- # bad: [6ba8a227fd19d19779005fb66ad7562608e1df83] Add linux-next specific files for 20230210 # good: [4ec5183ec48656cec489c49f989c508b68b518e3] Linux 6.2-rc7 git bisect start 'HEAD' 'v6.2-rc7' # good: [94613f0efc69ed41f9229ef5c294db3ec37145da] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git git bisect good 94613f0efc69ed41f9229ef5c294db3ec37145da # good: [19e62c715fe70dae4582c2874ed3e66715d09af6] Merge branch 'rcu/next' of git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git git bisect good 19e62c715fe70dae4582c2874ed3e66715d09af6 # good: [5d8b7ecef7f4a681b6e5538db59ff26c389c0ab6] Merge branch 'for-next' of https://gitlab.com/peda-linux/mux.git git bisect good 5d8b7ecef7f4a681b6e5538db59ff26c389c0ab6 # good: [c349bf6ec83903b20fe570c5609b9a864a64e09c] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/krisman/unicode.git git bisect good c349bf6ec83903b20fe570c5609b9a864a64e09c # good: [5a06a9f17454df38f35672be522ff5eb9b4277d2] selftest: add testing unsharing and counting ksm zero page git bisect good 5a06a9f17454df38f35672be522ff5eb9b4277d2 # bad: [f5d115a7b06e5661ed5218ffa9a2644c4ff1c135] Merge branch 'mm-nonmm-unstable' into mm-everything git bisect bad f5d115a7b06e5661ed5218ffa9a2644c4ff1c135 # bad: [acb018d6ea0c055381fba7dddaef386ee28f8075] mm/vmalloc.c: allow vread() to read out vm_map_ram areas git bisect bad acb018d6ea0c055381fba7dddaef386ee28f8075 # good: [1a5d9782ac969dc6e61c6786500b5160603188ea] mm/mmap: remove __vma_adjust() git bisect good 1a5d9782ac969dc6e61c6786500b5160603188ea # good: [4b32363697de957dcc890b6245bec3f58903639a] arm: include asm-generic/memory_model.h from page.h rather than memory.h git bisect good 4b32363697de957dcc890b6245bec3f58903639a # bad: [328cf3fa6682ce6a4de6f8bb8009c833dc33f3c8] mm/migrate: convert isolate_movable_page() to use folios git bisect bad 328cf3fa6682ce6a4de6f8bb8009c833dc33f3c8 # bad: [b704c765b08cabe82adf76a4d1a74f3688eee410] mm/mempolicy: convert queue_pages_pmd() to queue_folios_pmd() git bisect bad b704c765b08cabe82adf76a4d1a74f3688eee410 # bad: [e5734c8b0edfd2a053a5c256189586a3b1e9f63d] mm, arch: add generic implementation of pfn_valid() for FLATMEM git bisect bad e5734c8b0edfd2a053a5c256189586a3b1e9f63d # good: [ad8aecea034c591b9754bc5908da9719853aa7fa] mips: drop definition of pfn_valid() for DISCONTIGMEM git bisect good ad8aecea034c591b9754bc5908da9719853aa7fa # first bad commit: [e5734c8b0edfd2a053a5c256189586a3b1e9f63d] mm, arch: add generic implementation of pfn_valid() for FLATMEM