From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6637EC05027 for ; Sun, 12 Feb 2023 03:45:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA8FC6B0075; Sat, 11 Feb 2023 22:45:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D58346B0078; Sat, 11 Feb 2023 22:45:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF87B6B007B; Sat, 11 Feb 2023 22:45:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id ACAB96B0075 for ; Sat, 11 Feb 2023 22:45:05 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7DA45A08CA for ; Sun, 12 Feb 2023 03:45:05 +0000 (UTC) X-FDA: 80457248970.11.8CEE928 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf30.hostedemail.com (Postfix) with ESMTP id AF7E08000A for ; Sun, 12 Feb 2023 03:45:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of "SRS0=19W6=6I=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=19W6=6I=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676173503; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9fCiYD1vQu/CyLq6q/3bPkNlnMFQCiEzwyqJUkFPYzg=; b=1WY0BvSVvCR3rQZsW0eukj0hWWYZThVeTeWvQ5XCNHm8tzwoVNAJdzMAmraeQ3jBKxn8Rh JGT/dtF1fgoF32gHd/UHTtxkTdLWbnhmqIyrtELlg2ZfM4IPxXdipGR+qlIJNDdgqdFaLH IMnMxREdYZOuIfd3xJs/MnOzBRwvSk4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of "SRS0=19W6=6I=goodmis.org=rostedt@kernel.org" designates 145.40.68.75 as permitted sender) smtp.mailfrom="SRS0=19W6=6I=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676173503; a=rsa-sha256; cv=none; b=1iheRunwXwyRjXxZqOYznOehftPgrQBK+51ZOqE3vJyXqPYthsRM+Rv+OkIQU+ungiDxGZ HeXIolqMifJ1De824VoBE/XnnY/BhsIVAx9O7JBkDpHGosBegOX57ds7PnUF+EDM7M4aON WcVqtQkqkyKb3cDWLqS95CT5ndPn1W8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 01F58B80B27; Sun, 12 Feb 2023 03:45:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5851C433EF; Sun, 12 Feb 2023 03:44:57 +0000 (UTC) Date: Sat, 11 Feb 2023 22:44:55 -0500 From: Steven Rostedt To: Yafang Shao Cc: John Stultz , Alexei Starovoitov , Andrew Morton , Network Development , bpf , "linux-perf-use." , Linux-Fsdevel , linux-mm , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko , David Hildenbrand , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek , Kajetan Puchalski , Lukasz Luba , Qais Yousef , Daniele Di Proietto , Linus Torvalds Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN Message-ID: <20230211224455.0a4b2914@gandalf.local.home> In-Reply-To: References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> <20230208212858.477cd05e@gandalf.local.home> <20230208213343.40ee15a5@gandalf.local.home> <20230211140011.4f15a633@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AF7E08000A X-Stat-Signature: d7xaq7qj4rzy91mxnb518gbdotu4uwie X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1676173503-700968 X-HE-Meta: U2FsdGVkX1+KQuYUJWRiiC8Jv2vPYIRUUzWq2rnPrZ8iPyrKTCh8VsA7XrZ2iUtnEz9W0dNknmr4XuPE1QxCZwiqBH9vUe4+0BjUFJgziKgKOzzTZHP5oRQ6hKiyIQLzZhMGGFLlr2Ctn+6ql53HzJz7JkKvVesROFxs1wZzbbvsVxwieg+NG2B63FEierUzThjyIOOYNuWGZidcJJANxsb7f6hGXW4mtzCc/OZrVAz6nZn0qjNtS9juXn+Zf6PlYw0TWsFENDvJwoqG+9V5jV1ZsRMqsk5D+cLSppqAKC+7wYz+f7vi/qOJ/4Eonj9pRJ2s/mZ0St1vSgoXRwUMJNgou5xBF+CZS+UGv1ikM7zsebkq29Nqc4FKtLa2WRNvp69fjd1id7IZoIGIU6yuyQoxcbEOqw7kfDx7cSM6YCagMLu95GuDwBiub7iY58bPoBLqdXyHB4riJYWUuGeSK+tVUUSGBlDIMwrsrpW7i6prC8/VI/uosZvjeQW1PmvsJykrL0EA8OnSclLKrCI0UdkbexGdqf6A4xpaG6BWr2PO3vZ6TFIVUjFpP4YUvMCfUph+qx8cyXDasA2CsVLEs8KdPlqbUVqYtkOWPCXx10PCbHFGSGJVHMF5xb/+JUzeOFty1bRiAzLFNqgn8QvKMMnETYDi0jJpDUxMkUcH9jkYpnOaMOjXFBcAh29yk7Oz00vC8/iduze7DGjKhzDenevPDR0PYD3Q0l/Ev7aFFQL4B4QT7eO/yJ5L+KaDhrXRJxTnlZb8z0IylegtbQV5W0uCusPIwSSIfbRgllIXQjdsAjBWiZiMBMZI17NY9Y4dO7i40kUOp6oYb7wT+faeyaKkrgOVWfbMUKbbIwfqmeNavZMjvkm1C3dZa3o1sSskJzRfQzpaywfVwS6IUUqeXLarjmxTUvWiS5/bSAwgyVU9nvspsY2oT0bG1kS74bLYyX7v1C8XyBeMIA38KGG vW1jZZ7D 5P4Cr34OYUOeIis+xLM1VNLAcYWJeezWcGgXHqznh7Q695KEW2pt9ILt9yXXTOvvYaVI/amPs86rpStucNeofPrfrgI5ldK54HMeWOY+VCzrMkPsDQ6yUpoW6qc3bXlDBjfwIEOwpxYlBy3fCOXg/UBpvZ6se3/9kXZf/Cp1ae7hDJp+5fmVDKKnnX9uLUuKWHm1eZ08U44KOoRmZ32bJPhAWVCnlZyD5MnETGeYj1bU4fACI4fdzCrv4DnvKnFbFsWhXDOxHzJGezCV0EX3MXeVrBeJ5mlkhGMASbSDXffRTUA6GA5xDxPO3B49oitT78BNexY2Q6+AgnjH57h24XH8gtFOBdGtTF/cSo33ooAcNbpszgDlSqtSSMDgI6ZAKN3DFSYAz0VhFBTOqBXFbAE0m5xiteAWFzZMzz/8GNqtIDiU2Q+p/5SvuEm9tazM6XXtqYqlNTJ1Oj/jx4PPNmEvdt5v43KONKRR/OmrWUyB/CwW8vtaiYCNLmfQkjvrpDDDj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 12 Feb 2023 11:38:52 +0800 Yafang Shao wrote: > > Actually, there are cases that this needs to be a number, as b3bc8547d3be6 > > ("tracing: Have TRACE_DEFINE_ENUM affect trace event types as well") made > > it update fields as well as the printk fmt. > > > > It seems that TRACE_DEFINE_ENUM(TASK_COMM_LEN) in the trace events > header files would be a better fix. NACK! I much prefer the proper fix that adds the length. -- Steve