From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0820DC636CC for ; Sat, 11 Feb 2023 16:51:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 13E896B0074; Sat, 11 Feb 2023 11:51:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0EDFD6B0075; Sat, 11 Feb 2023 11:51:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA98C6B0078; Sat, 11 Feb 2023 11:51:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D6FE06B0074 for ; Sat, 11 Feb 2023 11:51:25 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 92C67AABA7 for ; Sat, 11 Feb 2023 16:51:25 +0000 (UTC) X-FDA: 80455601730.17.0397582 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf16.hostedemail.com (Postfix) with ESMTP id 8561E18000F for ; Sat, 11 Feb 2023 16:51:23 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=layalina-io.20210112.gappssmtp.com header.s=20210112 header.b=ER9ivdRQ; spf=pass (imf16.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.41 as permitted sender) smtp.mailfrom=qyousef@layalina.io; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676134283; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V3dLOUyD2qLLZeL+RCBFqBDU+r6K7Onh/Gy2tm5yVZc=; b=htQYVIVheP1B+ovOp7/60q/p1Tn7xZlXPf7lFruK0jl5yohq8PLPNU4biy8DVPQwpU2PLx 3sgpAqnmzUDvmc3Oda5yZNfvfQGh2e7PDR8tKDYX3fpWnWPauEjTdaILZj0+LIPOgO2cx5 E9VL1g5mZq4RRnfHwd5HF9AbnYBXpkI= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=layalina-io.20210112.gappssmtp.com header.s=20210112 header.b=ER9ivdRQ; spf=pass (imf16.hostedemail.com: domain of qyousef@layalina.io designates 209.85.128.41 as permitted sender) smtp.mailfrom=qyousef@layalina.io; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676134283; a=rsa-sha256; cv=none; b=RZDDOhhr9Lx5rO5pZyZIQrlx0Ebh16RHNJ5fXcEs0N1FvXf0rBugl2u289V064PAXKgBmO T2VGhTnoFjxUw8KU3V3GbcUtItUX2jskrphFme4Tc3VCViWZXIMxBn89IY2PhokZ72vNfv /MhbcC7Fa5ZDO3pOlnT25pP20+4qOPE= Received: by mail-wm1-f41.google.com with SMTP id r18so5918099wmq.5 for ; Sat, 11 Feb 2023 08:51:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=layalina-io.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=V3dLOUyD2qLLZeL+RCBFqBDU+r6K7Onh/Gy2tm5yVZc=; b=ER9ivdRQA46j70AsRtLo3uCWnNMEK1js+A1odjy8Q0Z3FMBTW+wMfXjciKmV+z6gW1 k8VkV1E+uBYcsO8SvacDa6fyImvMFIzgtocB2MjOTLT0R0EaDu9jszSbGiTeXetIw81K yHCVKShSA2+RdAwVEqdQLXvrsVSYxRbps4YjQL3gFfW8Q12WxO1WoMpit3RYvCcLYLJw wd1I/Gd+PbRPUMBJ4svv5nAc4RiZRM74ZEd5KQyXsUAnhJ2KD1xN0Ya2j6VrIyGpXSy/ 9L/oFg6Smvz+NKUvzRDYsgn9WBqBhOUD2cfoTgFSfBopcysBA3dBAWTc77y6jTPjPvy4 HueA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=V3dLOUyD2qLLZeL+RCBFqBDU+r6K7Onh/Gy2tm5yVZc=; b=1Tw6Dyf13pwYkphv4KbXTAVV5MZrWRJ7PZN/AdOytgd+ntNsbtOtHHMzpG2oEfdCVT rGik5/uU9LgJBxfzALvkcPUDMYkeCtZZ+1nbbRpPzQFdjeyPCE6UxaQ8O3PYiHf/viFZ odQ4E4UyUDH1C18dsZKUDM7Oyo257Om6CD4trlKktRJiooFZB3RwYvwtJnTTVMTbjBX9 aRVKW+sUqwIRkA0Ixx2Ig21Nq33uclL8cuOhLAtz0qY0/KbbiFTHk9BEvcoPKCQjdZKL M+4kH4RuxnBrLib5Q+YFUdF4mGWb//qoHlzrNc50zBxLf5Z2cPvQ/bhBMD8zdXu9mUoS 6Pcw== X-Gm-Message-State: AO0yUKXgmQ5G6AN09ZACmUFPRw8W+uQg1KOg3rLLvlFnRp1jw5iliqh2 9LCLq9uobvH6y/p57l2mKqL75w== X-Google-Smtp-Source: AK7set/CFEhOT8NQgm8Y1FA7us6RejO5nTqrWa3aLjIDDJhY7POSdEi1Rr+Jp4XzmhMfDx7bAQd+FA== X-Received: by 2002:a05:600c:331c:b0:3df:ee43:860b with SMTP id q28-20020a05600c331c00b003dfee43860bmr15481946wmp.23.1676134282119; Sat, 11 Feb 2023 08:51:22 -0800 (PST) Received: from airbuntu (host86-163-35-10.range86-163.btcentralplus.com. [86.163.35.10]) by smtp.gmail.com with ESMTPSA id r18-20020a05600c459200b003db03725e86sm9729083wmo.8.2023.02.11.08.51.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Feb 2023 08:51:21 -0800 (PST) Date: Sat, 11 Feb 2023 16:51:20 +0000 From: Qais Yousef To: Yafang Shao Cc: Kajetan Puchalski , Mathieu Desnoyers , John Stultz , Alexei Starovoitov , Andrew Morton , Network Development , bpf , "linux-perf-use." , Linux-Fsdevel , linux-mm , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko , David Hildenbrand , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Steven Rostedt , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek , Lukasz Luba , Qais Yousef , Daniele Di Proietto Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN Message-ID: <20230211165120.byivmbfhwyegiyae@airbuntu> References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> <08e1c9d0-376f-d669-6fe8-559b2fbc2f2b@efficios.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 8561E18000F X-Rspam-User: X-Stat-Signature: x6mz7g1t6xoyde1gbhghorrqpfnrfuug X-HE-Tag: 1676134283-709591 X-HE-Meta: U2FsdGVkX18hIii0jmTgbRUubyru0KeQw8jN4ZlwqKA/zyZRxR3FfDxpU3irjzWM3g2Nr5QVUp4OojEuKAP2UML90QNpyG4nE0FsTVeyg8ajKiHOfRmVTWALb/vljFvfWE3m/njt5FBt9vwZp/POPviZw3FbGkIRAPHhY+3IHkLl+DARETI64MtQiTCsG+MZ53T0ytn0Ygza/9pZdvNeGaaFGHDfXpfZOGI1HEO30CNQtOthO4LpopvHEXowEfiy8F0GPf+CCj/qFSrV3s85iCEVqWvVqSV1GKoj4XK4KIDHkjG+52j8fYLguunKCN7C5zouDQJveJny+sNbZ/z4siQMjLYfloqi21OI1ns2lg6YoYoePdfS+sknfOv7ufArs5mw1E8gytkSQgteKQWjZ+q02gfhXp8Nouq7OzHDdfZV2eQoU85t6m2dKsH9qP9bitnU6gsrJOONv/e3q/SKiVj4Bli1gqBSlk7c/mRM17iXtBiWPK9ho388JH35Qz4Ivc68v5TrF7YNiZhAgCM3Lrmr0NhdxHHt9b5yvuqVlpKkpRYAsEv9mFNrOWKd6JkfmnvIi92ixh/xgpM6WAVnQOehqni4N/7nPxQ/KfKWDyyF5UFUzcVI9BrhvaU5now56e0WvO4pkakCJ9pJOgkkSCoysVZ3mk1aNBCFgkMsxVJSSHAIQet+JkjsoRdryQHLK1plkEwrfSOULGZou+af5Z/n+DTG++yT43G9NrUeCSdpJeN7m/PvaKFAeGlqLeP/IS+w2kvYlVFJGXNFUrKk2O4iqpSAfc8apaRrEkPo8sAPV7E1T9eRec0EOmSoDegOp2TQKmDMHLASy2GtLalptymj2JlqSogXqy4EdLm7igKhvluv8HSgP+4+4HjBC/cvTH1KXgHsjQqgqYlRUjI3EHbPz8kHR0JCy9aSCNVqqG7V1q1+mjkQyI2hTuxPfjx1OwEC/62FdJLWTtpskbx XRKiH72H uB7HrrRAc5WpzZo+6Np/KONewpZ+hPLoQU7PeAlJlwPb/Mrhf1/5lCmE9Yv9Vj6kcr120Vl6M4P8sSnjFvQ/UZHMF+8+UP5yzVB+HWGimabX1lubvzKFyTzauh9s7qX06aP2UMUAtv5kWmApmryxICkPcMZq578LoukadlKnhmL2kRVRTe+YL0/BEQYlztF+4SS8owntgxLPC/XagU50sMLHah7rFgPpnCJsok5OZEeiOBAPvv9cyQXfNlshH5BHj4bflsqJqWaSylVWAUFC9oCnAsvKlSZN30uFl3KMY55ZUOtup2gcOoCjNc9NyYIeGMgHdllycfBmYuEtQTlB8NzWN9mztnx8JTyt6AA2bb7YkE0uz/vpWNRP3JMWd51I7vN+K+eHd439Hw4Js2cnESLuvmA6nQtFuqpaey7fkYLqd8xGuBRG8Oq0DHA4mth+bOYmACtstllpz5IMM32AmoGId/P8YzxCfmKSUjmrTyJKfC0KOXZAnl7/fza6qxiO0Xrl4XZycLuNCovRByXQkH1jziIGjngQeN1cfAoE6hoMvAJDsrCS1j0RLcZUceuse4uT83MG7h28pGuqdXWqmnkkIXPd4rVkj7xSI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02/09/23 23:37, Yafang Shao wrote: > On Thu, Feb 9, 2023 at 10:28 PM Kajetan Puchalski > wrote: > > > > On Thu, Feb 09, 2023 at 02:20:36PM +0800, Yafang Shao wrote: > > > > [...] > > > > Hi Yafang, > > > > > Many thanks for the detailed analysis. Seems it can work. > > > > > > Hi John, > > > > > > Could you pls. try the attached fix ? I have verified it in my test env. > > > > I tested the patch on my environment where I found the issue with newer > > kernels + older Perfetto. The patch does improve things so that's nice. > > Thanks for the test. I don't have Perfetto in hand, so I haven't > verify Perfetto. FWIW, perfetto is not android specific and can run on normal linux distro setup (which I do but haven't noticed this breakage). It's easy to download the latest release (including for android though I never tried that) from github https://github.com/google/perfetto/releases Kajetan might try to see if he can pick the latest version which IIUC contains a workaround. If this simple patch can be tweaked to make it work again against older versions that'd be nice though. HTH. Cheers -- Qais Yousef