From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E6CC636D4 for ; Fri, 10 Feb 2023 18:26:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9281828000E; Fri, 10 Feb 2023 13:26:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8B13A280003; Fri, 10 Feb 2023 13:26:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 778AE28000E; Fri, 10 Feb 2023 13:26:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6475A280003 for ; Fri, 10 Feb 2023 13:26:07 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 15FCB41176 for ; Fri, 10 Feb 2023 18:26:07 +0000 (UTC) X-FDA: 80452211574.26.DDB26B7 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf29.hostedemail.com (Postfix) with ESMTP id 2856A120021 for ; Fri, 10 Feb 2023 18:26:03 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676053564; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R2Xbfvlt8nDFD/Iuv+Q+1tTssX5ZRsLqvNFCYlgRhUA=; b=KIrL8gX1R21AxuJRTPzzEccOtY0Lz7FGkQ7N7hlQAu8GbR8mZ3jZSyxdW4nj3U4SlcaztF Tyl7M3AN6YXSk9QCAiyrDFrEPg/iZ1NfmjHt8Isqu0KVk79N5Bzm6dkdSXUajMvp6t23Gc LEYrvyoFNSKsK+J13CscsfSRjVJ6yF8= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf29.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676053564; a=rsa-sha256; cv=none; b=Y9U2TnBXuwWmLSe2UxXtvCZwaUdi588up/s5FHbgLqDnhzp4es+Usq3yz2cCbTPYbjTr0i s7OtWeRcNXmciCnAgFk7A0FjazEVUIj/Mr8UM08bmz5BE/44z8cSbsYjeGaT7yfFg/GQaU qBJUV3WP5AoSt3HjC/0G3/b9f0tXmRo= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PD2BQ08fnz6J64s; Sat, 11 Feb 2023 02:21:50 +0800 (CST) Received: from localhost (10.81.210.211) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Fri, 10 Feb 2023 18:25:59 +0000 Date: Fri, 10 Feb 2023 18:25:58 +0000 From: Jonathan Cameron To: Dan Williams CC: , Fan Ni , , , , Subject: Re: [PATCH v2 18/20] dax/hmem: Move hmem device registration to dax_hmem.ko Message-ID: <20230210182558.00005853@Huawei.com> In-Reply-To: <167602002771.1924368.5653558226424530127.stgit@dwillia2-xfh.jf.intel.com> References: <167601992097.1924368.18291887895351917895.stgit@dwillia2-xfh.jf.intel.com> <167602002771.1924368.5653558226424530127.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.81.210.211] X-ClientProxiedBy: lhrpeml100004.china.huawei.com (7.191.162.219) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 2856A120021 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: a4zrxg8b3futoe64axa5idexghah6bcn X-HE-Tag: 1676053563-369867 X-HE-Meta: U2FsdGVkX1+SLViyNt8zhAkQ/jITMyutAKd+Y1E6bqE2P+HNXvdhWBwe72PWlTh5SeasHJivwHOxdWH9vsgoCqS9ewBh4E2z03nQ8LvSNvaEouWObQO7UGTSTu/Syq1w/4xWgZ0xXXWYO4Dd563WFIjix3DpP9oODSfxk1UBhuiepOJETR1rCYO9qM8pq5958ZSk3Afe9Z7nQ/hXkCf2qBrtw7uRY8t6V7+DJeq556RYKY0+lTR6g4y428rik8XCINbCmtapr4l0urExnK+Ts8F0F1n4wZvgC2GoDKX3ZuomgpPlKO/mYi4fU+6C2zoCxpeulx6bJu4JCzd4eALhzef6lF4Dd6y3gX6DVuMlkiX6tGK6eZkCe+K9Z0GsByUh3zAzRoyDFSuRwD5vEJHCsJXiZydHSByulmkBHlvykxvBdX5h4D+BUPHmbkaVjrZAtO2pFZtM072vspCvE2wU/34ue2rvlxxHKwYuadQjP44/cGu/W2W86DCkPEwOfuGg0PJeonWpusyI1mOViDkJmwtvnRgddjQiwe/ZZ9p9gJRi5MExQxbzvg/fyV/d1oCwHKEhGLVnc3LHlNo1RzlQOXaG/Nl8crBlxd9Yh8ajrmsoE3bStOCxVPXdnGtKKD8XF6o98dWg4XwsD2SMvUlpQdndFwBn8Jnhrq1fb37ZvRTMWZ++wvjp4jvvR592cfPx0ufEe7QYkixChDElWiNu0uKIEcrp0qchH2U0Xx8xXzTzeiJqFnX6SFlxyrTeFLBvWbWgkUpCTgqgDJ8VF1aMsPIWvRurwgKeTlrwKmmPbB+BZh8C++nXmb1aOXMv7T4pDEKoR0iIDYMJSuNnrROqPGwoTomUwv+8JvnwMqwnnuOYoDIX7gRz9vfggTL7UNkKpbDLVRX69f4cEDCnV4eh1TveFtGtlNIazfCrNVX1+IVkhOCfJxS6RR774PGL/aggMti2oDmuDpRDenhemhe CPfUFbbY ogYMeg87h2lumRFNQpTi+LYdi6Dr+p+pslJIFWYnBdWMS45W75PzNH1Tnv8iTPaybAfpo4O6QYvKMrm2j1do3+fNXzLBHVYVhii1Bp4eKqFRjPX/QEGcWeQ+Gp0MUgQ3IFwExQMAZCwFedNP/sOx13RBnRpk5GzAwiG4TiLCaNkRFtxDeyOMnyFgFkyvP0Z60HGg6J6sEz638wdH2eTNJXwsO7pXnRfpjFQOFFW7lVmx6Ggdk6E8a9v9zKw1sWPNohp0do5zz6gThBWB/teKqZyE4UUWSsfrV+DkwkMsrz1+ky7n1D+MKGZb97G/T+zEykBog3YP4nUkExyP8VHrOIjpHeGCUQ0boXUF47oTeTJ3ek8in6gtBmmKLigfzIKHN7thNv5ZXw3JvuwQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 10 Feb 2023 01:07:07 -0800 Dan Williams wrote: > In preparation for the CXL region driver to take over the responsibility > of registering device-dax instances for CXL regions, move the > registration of "hmem" devices to dax_hmem.ko. > > Previously the builtin component of this enabling > (drivers/dax/hmem/device.o) would register platform devices for each > address range and trigger the dax_hmem.ko module to load and attach > device-dax instances to those devices. Now, the ranges are collected > from the HMAT and EFI memory map walking, but the device creation is > deferred. A new "hmem_platform" device is created which triggers > dax_hmem.ko to load and register the platform devices. > > Tested-by: Fan Ni > Link: https://lore.kernel.org/r/167564543923.847146.9030380223622044744.stgit@dwillia2-xfh.jf.intel.com > Signed-off-by: Dan Williams I'm not particularly familiar with this code, but you changes indeed reflect what you describe above an appear correct to me. Reviewed-by: Jonathan Cameron