From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF34CC05027 for ; Fri, 10 Feb 2023 17:31:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 978506B0166; Fri, 10 Feb 2023 12:31:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 927C36B0167; Fri, 10 Feb 2023 12:31:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 817326B0168; Fri, 10 Feb 2023 12:31:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6F3196B0166 for ; Fri, 10 Feb 2023 12:31:38 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2E996141128 for ; Fri, 10 Feb 2023 17:31:38 +0000 (UTC) X-FDA: 80452074276.15.12255EF Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf15.hostedemail.com (Postfix) with ESMTP id 1B032A0019 for ; Fri, 10 Feb 2023 17:31:35 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676050296; a=rsa-sha256; cv=none; b=8SEiarQXF+FpkgNLi2Gcg/0UkiEvOdUgnC4FweOzfBb8f1lPX7QB5zWfA0UuXFwE91vlJ3 mKkwihKuz1i+cMPV3l8IKgJn8IjrCpDT5qA7FKBSxSKzfKcKb4DzZuB3n9GrMWbMSq18oX w3pucMLobljKZR5QUQfKfaqww2QiMwA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; spf=pass (imf15.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676050296; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V0pqV69yVsvVTR5wXSLPwSfyd/MBf8d67NZONJBayKA=; b=WS4DV+sLXaBl+yblqiEDh2tgx02tt+ijlImoep+q26yuLUuiSM6jWG1AXWlAxMaIVCl60s Xwc7gJDwrm34VS0Q2netOMY7l+3JtFwl61Sop7OWhEDdxcBhk2/hPbLZUo4fyqb4J1MjUv yJARO/WvHdl2FD6ShroJfJMUEejprDw= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PD12h5vcvz6J91l; Sat, 11 Feb 2023 01:30:04 +0800 (CST) Received: from localhost (10.81.210.211) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Fri, 10 Feb 2023 17:31:33 +0000 Date: Fri, 10 Feb 2023 17:31:32 +0000 From: Jonathan Cameron To: Dan Williams CC: , , , , Subject: Re: [PATCH v2 08/20] cxl/region: Cleanup target list on attach error Message-ID: <20230210173132.00003647@Huawei.com> In-Reply-To: <167601996980.1924368.390423634911157277.stgit@dwillia2-xfh.jf.intel.com> References: <167601992097.1924368.18291887895351917895.stgit@dwillia2-xfh.jf.intel.com> <167601996980.1924368.390423634911157277.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.81.210.211] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 1B032A0019 X-Rspamd-Server: rspam01 X-Stat-Signature: tp3j8os6stnqnr9rq9bc6pji57tcseue X-HE-Tag: 1676050295-725021 X-HE-Meta: U2FsdGVkX18UZ+BLBQPxr5skdLQA77/e+Ab7q9g6ofi0H5pzjihuesRnrot4Ls7HNCxGB99VgVpvRodItpxvvIs8CL4d6sQ/t7sWOdwqph1kpMxYFG3iNGM33WH8EpznqRsbxyTfhGHNWguIme/v5oBGYqgJl1LKffFq31hvAlBR9x4ssRFjQTHaJ8bB7ZXD5XrdT2EFmHCCfzsf/7PLIQBYuTxWerxwHEjbNkYIFc1EcmAYyu9zo2WMMTQ6Q2RvKkGvI8/Kto3b018jaoVX+eJc9mTCgXODqrEDoPPRHSALHdbepYa+1yH4hmvE4Dh2qXvnfcuI1DiC2oobzS37SrqdYdxb9i+s2GobEiVbO/38a+IPpOXUxXBLxhYmrHYNSSliJd1vV1gxLb/gfYVd32pep5Q8wrFaDxFd7jFKkBYFNOeV9FVLfmVW4hZ9hgYE03Ce/6tkBJ+8+hPqLPJwBd5yWL59KRf/A6OY+/xVtekUrrdgoH/Ooh5wtXnN26RpZAs/xSSbeSLMzy8WTjpqv1CIOA1cX2stTAfwgrhJqDUssIxu80+AknuZ6af10lU5ADtnXHYyyy5RFZEk6VLiVmvPCNWQe3FX6O9cWC8aK1fmzD04jT6mzJN6vLcSGRSlsdk7Ma//JoguX/iRB9ZNNvgcSH6IRyvIDpZAtzP74Jl0oUoJHiSza88segmdemmEhA4BosYIPeGpnoQ+rVS90aHRRBseamblmCm9+0khdIsrGQAU2huSNF17IRf49J2lCBBd6cU2nOuCUJefzoFEjH2g5P460kiuwvt/Oog0ZSrnRJ5jed0RNQLykYo8N7s56BuViV/AgdXHOJN0XtFqzRddA18Lz2H9tJdGCxicUljHfvIr9EXlo+qNRrb7VnP3iOnIt9KglIZ861h29gjxpRqZBdI6WJK2McfL7OuoSX1YqaRfNrvAzeZ/i1rEyKBRk56iOZ9AK7TUrsfZedg wC0tWFFj KJM4Li10I63jMS/fAZy9YdTWhDbWZYOb8Pi8F+sVoM7ILMyEWz7IsuF0+S69bjaw99Ohv1wb7idQ2Cdw8pbjWjO9lvQ80Fn7PSAfKs8X88mQ0FvlB8eYHPDX8R5HVBMVO2krcT9NrOOYCx1spcgNOYRt+fcm459tn33NkWhtFXoi22hwDPtc5lOrvJsEG3JUl374oRK1qntpIA9wEtzPc/Nin79IuEzBlvSAVDsrHQHwv058o5CE4zZ7fZ62STu0lKiN6vS9V9BsxVleruqkT23kGn/UGUs04GDTa78ZNDnvJ/avz+ZE/HzfLHYaALGMBqgeR0h7IKfmEcvk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 10 Feb 2023 01:06:09 -0800 Dan Williams wrote: > Jonathan noticed that the target list setup is not unwound completely > upon error. Undo all the setup in the 'err_decrement:' exit path. > > Fixes: 27b3f8d13830 ("cxl/region: Program target lists") > Reported-by: Jonathan Cameron > Link: http://lore.kernel.org/r/20230208123031.00006990@Huawei.com > Signed-off-by: Dan Williams Reviewed-by: Jonathan Cameron > --- > drivers/cxl/core/region.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index 040bbd39c81d..ae7d3adcd41a 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -1347,6 +1347,8 @@ static int cxl_region_attach(struct cxl_region *cxlr, > > err_decrement: > p->nr_targets--; > + cxled->pos = -1; > + p->targets[pos] = NULL; > err: > for (iter = ep_port; !is_cxl_root(iter); > iter = to_cxl_port(iter->dev.parent)) > >