From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A274C05027 for ; Fri, 10 Feb 2023 09:46:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A3BD06B013B; Fri, 10 Feb 2023 04:46:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9EC3D6B013C; Fri, 10 Feb 2023 04:46:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B2FC6B013D; Fri, 10 Feb 2023 04:46:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7A1846B013B for ; Fri, 10 Feb 2023 04:46:29 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0C8271A14B9 for ; Fri, 10 Feb 2023 09:46:29 +0000 (UTC) X-FDA: 80450902098.26.5E20765 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf24.hostedemail.com (Postfix) with ESMTP id 53E6A180015 for ; Fri, 10 Feb 2023 09:46:26 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=LWCJXAT7; spf=pass (imf24.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676022386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=ppfFWpSAcZ1aESEIi3DI7xxDUI8KrBz5/PkXTDog9ro=; b=2S3TobRBw3WAa8BsSAUoE/x2iMgQbV7aMPkbujdcHwzE3I3ijdOdbZ4tKoDzQDg2IxKG+P xvmTKEetB8Ezkc7/gYFqCozg4uLh6yRlOJMhOubKspJt176apl2svt8MGThpFzyA3pmHwJ 7WoZOxaDDKWjHWWq4lbEpKgGCZeWJQo= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=shopee.com header.s=shopee.com header.b=LWCJXAT7; spf=pass (imf24.hostedemail.com: domain of haifeng.xu@shopee.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=haifeng.xu@shopee.com; dmarc=pass (policy=reject) header.from=shopee.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676022386; a=rsa-sha256; cv=none; b=whNa4xdp4OoYxGumti+k/+dtAA9aoPS+WB7p5/ndCO/LhiXDYEC4A1MwufT97w9tALd0a7 NCDu/LGzO/KsJ7ST9jRp2YOJtAd5toAai61zK13KXoS/z6hxrWF5rV8ibl3PB1WXS0/jm3 WO7z5Ur8PP8/550ACQEzJZP8RLGZztk= Received: by mail-pj1-f49.google.com with SMTP id n20-20020a17090aab9400b00229ca6a4636so9258375pjq.0 for ; Fri, 10 Feb 2023 01:46:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shopee.com; s=shopee.com; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ppfFWpSAcZ1aESEIi3DI7xxDUI8KrBz5/PkXTDog9ro=; b=LWCJXAT7I+EECVCLtdt5TrDfY1jP64bH1PN4m10e5ID9k8mohRc90Id/D9P5YQ0zo8 tpNUNA/I+Y2qw21VFtzvbQq/iFU1JdeU5uWGqhcnZwqEX8DlWw+irAGC01fg4inhfNUj qfVuPkwbTvxBq/JFjbEKnDjL/vfK4QSLJHUBBrCzAQJAmSckmSmlND9nVCiYZS9FwxM7 +mUz9uyIMg8cibzSLzifH+bR9e0N1BIuhqHHXFjp60clgMKLA9obumlPzfdkCI9SomZS xSKsStJ8KUfMd4aBExGiaG0EOb+1TG/W36cWikejp1fQnLVQm6sVf36/6dWb00RBzrR7 nhUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ppfFWpSAcZ1aESEIi3DI7xxDUI8KrBz5/PkXTDog9ro=; b=m4EHIKJRddHbBFg5nfTv/sHfTzYbETs+BPU3M5yOB2vne+3FDVRjvGGzQKd7j2hxFT g4Pe/9JBCjocGnkct1ajAxBX4GPOUXUIVlZxsuJjEFE2gVDd7JEXDQWh/r+ZKg8HwtD0 HQQbEKwqts3qSBmhUav6AV+HDs6VEtISD6HQ0Gkkfv2KXPzLOMvZNNe+j/bc9d8Hqd16 WxAYxit2uQb/Z/UmoJCaTRHu0GINIoyHDIyehVz0bHSOE6Z6SR/15rYApBlkMi0asnG8 Q9YF13wlkqYNUFHXMXMJz9ZpL+MEBPlZL7XoYnKJeOBJg0MSMh/vVrJMpJtPu3BwH3kQ 0WPQ== X-Gm-Message-State: AO0yUKUw2kM/74An2Zg2BSGlQaFfz6lBIYyD6CCRvDC1wlRQGuwaXKHv Xm/e1MMDEEraLawv3Xm+xX0/9w== X-Google-Smtp-Source: AK7set+b58gL6zwZfMrrWNjgCByJacYZP1DVcOGb+Rp36X4U3HgVQgr2uQ/HX09SBRwBJkNHVKaQDA== X-Received: by 2002:a17:902:d48e:b0:199:472b:927f with SMTP id c14-20020a170902d48e00b00199472b927fmr10878196plg.51.1676022384998; Fri, 10 Feb 2023 01:46:24 -0800 (PST) Received: from ubuntu-haifeng.default.svc.cluster.local ([101.127.248.173]) by smtp.gmail.com with ESMTPSA id p11-20020a170902a40b00b0019460ac7c6asm2935186plq.283.2023.02.10.01.46.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Feb 2023 01:46:24 -0800 (PST) From: Haifeng Xu To: hannes@cmpxchg.org Cc: mhocko@kernel.org, shakeelb@google.com, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Haifeng Xu Subject: [PATCH] mm/memcg: Skip high limit check in root memcg Date: Fri, 10 Feb 2023 09:45:50 +0000 Message-Id: <20230210094550.5125-1-haifeng.xu@shopee.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 53E6A180015 X-Rspam-User: X-Stat-Signature: 6r3n37ho6qgyjek1e4o4augeqmkrkcfs X-HE-Tag: 1676022386-14853 X-HE-Meta: U2FsdGVkX1+6tqkmHWa6nywKTlK9Eb4dHrA1FwJSTlFlGCWmH0o5T2EqGn1tWQiE7rpcxICfpsniwAdRVvZNPVieW2UhSBtLfRFuYT9ao1FDpkEJYUZwrUJZUQrHH0e1qZrdlkt9FVFqxw7fJ8GtcOnkIZuXa9Cr1kbD+jaTp62NETaXJr776IKeMx5ROBkOoJlmKgYf5AZWnGPPjmAiwyk6xO9b9uuunhwPrBkyC7O94nrLCreSVzvch0rKAU9ISuijkBfOsLiz7Xgcsn8tTmQYlOiwSCFEQtm2F4kLnmcjiKah54pX+oCev0ClyNvhHPEiJNXw8hpgmmappdKofXXM4yKDClHjgnc6ZcvC8oEwvLcNCzMXfpzRgjEtsAbmksUhUTFJaoN8HrzHBB4xCmiK9qER6+kHOXl1h9D1MlIXj4YsvjOaxpgfbeohETfrO9VonsIncLILzeyBe8Be6nj9B4vbHxTrCcq5QuwzsLMgrMNh2tCc2pUi6UTdgcoOstdyhpDxoxBJYCVdp1mNVjMlWNtzg4fpWOXvkRYcYum8OKQuG1lV4ev/NlgIPKvC4NA8gJ+Il68f9JHoNq6lJDiyKn64DFpLv8xHYAXSnVUSG9kySzowzx2Ysfy/waXdUKAXf6NyAlZRFYZh8UO4eiXF0eQ7H8vApPTVHTD1HLkyEFwoGkvsXzMhzbSdvC37E8506YlZZT7zo99WihCb3RiSHV414RF7b3/UJhrDOPSaTKM1BUGB1WDoT+le7oMH0qTVGcp1r/lpP8JmnpBz624b4UPgr5FgWlL5xobc9+k/Hu3Ts3AcACAaoXMvzLB1WFVvhjwo7UA3zceaX0xd/dTtdeclkwq1epuQI2dByG/hdjn+7HLgFuL3uoTJ7Ey1KPMC2uYUuzvD1QjjJ+CJ+dlkFBGVNLA9G/+pRL2MPj/Ht7ZP4JVlxE+pCP/am1ZY833kfTubdA4/N1R34uK gahrDMva RPAKPji/DIgvU/SvoPMHfJ9VrO8nHXUYRKS1/22Hy4l62J31ZrWQBh6WCV8YnMf4fmlwvKonqNSvZFm9ZaTkOi66IkV5JSXfLNSFi1/iOPHpNohWq0LI2OjSQJFPbTqBoQLxWPlRLXdKQ7B1o/QsyqSkIjY2JqS4xjFDBz9Ioewwj1B6QVMLZf09LeSjc5Qvy0x/OFHoZ4FrpFAiyBpJx5qhLOFaWu7HLGv7lAOwX1MboQoLNLmGFe5htZt+VyzHwciyYqeEJsU1QfmLJP0tv813Q681NDOF5WQK369eU68J9fA6dYk4peMyYvj/962XjuqFYXTWB0XwWxwcrDB7XlAMmeLu6r50vVpHmxM0L+M++JcDGx3w3+1Lje84DD2krgaPCP87fIfRCqnqRS9syeCWNzJaG2PhGO4c+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The high limit checks the memory usage from given memcg to root memcg. However, there is no limit in root memcg. So this check makes no sense and we can ignore it. Signed-off-by: Haifeng Xu --- mm/memcontrol.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index 73afff8062f9..a31a56598f29 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -2780,6 +2780,10 @@ static int try_charge_memcg(struct mem_cgroup *memcg, gfp_t gfp_mask, do { bool mem_high, swap_high; + /* There is no need for root memcg to check high limit */ + if (mem_cgroup_is_root(memcg)) + break; + mem_high = page_counter_read(&memcg->memory) > READ_ONCE(memcg->memory.high); swap_high = page_counter_read(&memcg->swap) > -- 2.25.1